Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1612678/?format=api
{ "id": 1612678, "url": "http://patchwork.ozlabs.org/api/patches/1612678/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20220402221701.18498-3-pali@kernel.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20220402221701.18498-3-pali@kernel.org>", "list_archive_url": null, "date": "2022-04-02T22:17:00", "name": "[2/3] mmc: fsl_esdhc_spl: pre-PBL: fix determining U-Boot size", "commit_ref": "a91998d8affc0405bafeade583204f66db81e252", "pull_url": null, "state": "accepted", "archived": false, "hash": "e0419a9bc8f30bf9e3321f70e600b825ab05bfe0", "submitter": { "id": 78810, "url": "http://patchwork.ozlabs.org/api/people/78810/?format=api", "name": "Pali Rohár", "email": "pali@kernel.org" }, "delegate": { "id": 87636, "url": "http://patchwork.ozlabs.org/api/users/87636/?format=api", "username": "priyankajain", "first_name": "Priyanka", "last_name": "Jain", "email": "priyanka.jain@nxp.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20220402221701.18498-3-pali@kernel.org/mbox/", "series": [ { "id": 293276, "url": "http://patchwork.ozlabs.org/api/series/293276/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=293276", "date": "2022-04-02T22:16:59", "name": "mmc: fsl_esdhc_spl: Fix booting P2020 from SD card", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/293276/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1612678/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1612678/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=u31DLAmm;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.b=\"u31DLAmm\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org", "phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4KWBHr38zhz9sFv\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 3 Apr 2022 08:18:00 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 9DE0F839BE;\n\tSun, 3 Apr 2022 00:17:32 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id 408D3839AA; Sun, 3 Apr 2022 00:17:27 +0200 (CEST)", "from dfw.source.kernel.org (dfw.source.kernel.org\n [IPv6:2604:1380:4641:c500::1])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id E0FF383970\n for <u-boot@lists.denx.de>; Sun, 3 Apr 2022 00:17:19 +0200 (CEST)", "from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by dfw.source.kernel.org (Postfix) with ESMTPS id 94E1660F2F;\n Sat, 2 Apr 2022 22:17:18 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id D763CC340F3;\n Sat, 2 Apr 2022 22:17:17 +0000 (UTC)", "by pali.im (Postfix)\n id 0B7661640; Sun, 3 Apr 2022 00:17:15 +0200 (CEST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no\n version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1648937838;\n bh=o/PECdKpOIc4D9vmgxgJbqdC9AVOxYkVeij1Aa6Fy48=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=u31DLAmmLRHmTTwcwJoSyuIFi1Bwzfg7zy1aTQoYXJ6I/JmV1Ixyk2Za2isEtqUta\n uhFsWc94Jl509snHDXyK1jWePtCjvL/+K5+lQJdaoDfvzkfxGvpPmMNwArg/objdvr\n f5tSXGHIB/MB38JvQE3uKmbLEGg8quYeuxQucBPfA5XIfaYPmg7qfeu1qtAp72I9sr\n NdbITNofsvnz2miM7i0rnYbqKMlfxsMWyv5kt1s4CDFw0Fvm9Cfrswf17LNq9nsFpC\n eC2mL/wZDOVgr9YrKco3ipg9LytI4woM6wrNl6NRVAW/nALoFqaRc0QL4ZLoF2R9cg\n pR/TUr3SCMsrg==", "From": "=?utf-8?q?Pali_Roh=C3=A1r?= <pali@kernel.org>", "To": "Priyanka Jain <priyanka.jain@nxp.com>, Peng Fan <peng.fan@nxp.com>,\n Jaehoon Chung <jh80.chung@samsung.com>", "Cc": "u-boot@lists.denx.de", "Subject": "[PATCH 2/3] mmc: fsl_esdhc_spl: pre-PBL: fix determining U-Boot size", "Date": "Sun, 3 Apr 2022 00:17:00 +0200", "Message-Id": "<20220402221701.18498-3-pali@kernel.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20220402221701.18498-1-pali@kernel.org>", "References": "<20220402221701.18498-1-pali@kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.5 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "In pre-PBL header is stored size of code which BootROM copies from SD card\nto L2/SRAM. This size has upper limit of L2 cache size. In most cases this\nis size of U-Boot SPL or size of L2 cache.\n\nTherefore this size in pre-PBL header cannot be used for determining size\nof proper U-Boot.\n\nSo always use CONFIG_SYS_MMC_U_BOOT_SIZE for determining size of proper\nU-Boot which stored on SD card.\n\nSigned-off-by: Pali Rohár <pali@kernel.org>\n---\n drivers/mmc/fsl_esdhc_spl.c | 12 ++----------\n 1 file changed, 2 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/mmc/fsl_esdhc_spl.c b/drivers/mmc/fsl_esdhc_spl.c\nindex 109f558dcad3..b87597a88e1d 100644\n--- a/drivers/mmc/fsl_esdhc_spl.c\n+++ b/drivers/mmc/fsl_esdhc_spl.c\n@@ -79,7 +79,6 @@ void __noreturn mmc_boot(void)\n \n #ifdef CONFIG_FSL_CORENET\n \toffset = CONFIG_SYS_MMC_U_BOOT_OFFS;\n-\tcode_len = CONFIG_SYS_MMC_U_BOOT_SIZE;\n #else\n \tblklen = mmc->read_bl_len;\n \ttmp_buf = malloc(blklen);\n@@ -135,18 +134,11 @@ void __noreturn mmc_boot(void)\n \t\toffset = (offset << 8) + val;\n \t}\n \toffset += CONFIG_SYS_MMC_U_BOOT_OFFS;\n-\t/* Get the code size from offset 0x48 */\n-\tbyte_num = 4;\n-\tcode_len = 0;\n-\tfor (i = 0; i < byte_num; i++) {\n-\t\tval = *(tmp_buf + ESDHC_BOOT_IMAGE_SIZE + i);\n-\t\tcode_len = (code_len << 8) + val;\n-\t}\n-\tcode_len -= CONFIG_SYS_MMC_U_BOOT_OFFS;\n+#endif\n \t/*\n \t* Load U-Boot image from mmc into RAM\n \t*/\n-#endif\n+\tcode_len = CONFIG_SYS_MMC_U_BOOT_SIZE;\n \tblk_start = ALIGN(offset, mmc->read_bl_len) / mmc->read_bl_len;\n \tblk_cnt = ALIGN(code_len, mmc->read_bl_len) / mmc->read_bl_len;\n \terr = mmc->block_dev.block_read(&mmc->block_dev, blk_start, blk_cnt,\n", "prefixes": [ "2/3" ] }