Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1612672/?format=api
{ "id": 1612672, "url": "http://patchwork.ozlabs.org/api/patches/1612672/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20220402220510.17879-2-pali@kernel.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20220402220510.17879-2-pali@kernel.org>", "list_archive_url": null, "date": "2022-04-02T22:05:08", "name": "[1/3] powerpc: mpc85xx: Drop _start symbol", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "df4371b400e2ead61b0d0284ba7318a35a4dfb80", "submitter": { "id": 78810, "url": "http://patchwork.ozlabs.org/api/people/78810/?format=api", "name": "Pali Rohár", "email": "pali@kernel.org" }, "delegate": { "id": 87636, "url": "http://patchwork.ozlabs.org/api/users/87636/?format=api", "username": "priyankajain", "first_name": "Priyanka", "last_name": "Jain", "email": "priyanka.jain@nxp.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20220402220510.17879-2-pali@kernel.org/mbox/", "series": [ { "id": 293275, "url": "http://patchwork.ozlabs.org/api/series/293275/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=293275", "date": "2022-04-02T22:05:08", "name": "powerpc: mpc85xx: Cleanup code", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/293275/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1612672/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1612672/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=OdU/qrUd;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.b=\"OdU/qrUd\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kernel.org", "phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4KWB1g4bTXz9sFv\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 3 Apr 2022 08:05:41 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 3E54083988;\n\tSun, 3 Apr 2022 00:05:24 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id B20ED83988; Sun, 3 Apr 2022 00:05:21 +0200 (CEST)", "from ams.source.kernel.org (ams.source.kernel.org\n [IPv6:2604:1380:4601:e00::1])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 26F1F8395F\n for <u-boot@lists.denx.de>; Sun, 3 Apr 2022 00:05:19 +0200 (CEST)", "from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by ams.source.kernel.org (Postfix) with ESMTPS id CF5E2B80AC2;\n Sat, 2 Apr 2022 22:05:18 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id 74C1EC340F2;\n Sat, 2 Apr 2022 22:05:17 +0000 (UTC)", "by pali.im (Postfix)\n id EDFC4FE8; Sun, 3 Apr 2022 00:05:14 +0200 (CEST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no\n version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1648937117;\n bh=YNp/QP1ZZoAIYcIJgxBwZpeIr6+wlYksfT5m6PLoGG4=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=OdU/qrUdxtsRKMgisPY1xHYJwyNJbuHgmNYjawCySM/18yZGOnxASWCuFKbXljrM/\n ULu5WWcs/ibLtTPp/XfuN7GM5mARV316I/cvKwNypBiysfrYmzkECms3ANoFgj0Omj\n 38WhIUvV+wZznT02xailP5MO34OdnrG3lk2rX5Nq8KdwZ35k7pZvSMXAkDH6sPeYaP\n R8OJMHZZ60sp9TVi2N6JiC0YnwqieFgCnztKraCUS/di7AUD2+6lETUB9nMw7TQ0qc\n 5BHRBao2cSYGEbH/EnBdNIPa0dYkukYBQoAhha4SOal2GKX3SmFwyftsSYZ6z8CVE+\n GVfp8qEMeK1SA==", "From": "=?utf-8?q?Pali_Roh=C3=A1r?= <pali@kernel.org>", "To": "Priyanka Jain <priyanka.jain@nxp.com>,\n\tWolfgang Denk <wd@denx.de>", "Cc": "u-boot@lists.denx.de", "Subject": "[PATCH 1/3] powerpc: mpc85xx: Drop _start symbol", "Date": "Sun, 3 Apr 2022 00:05:08 +0200", "Message-Id": "<20220402220510.17879-2-pali@kernel.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20220402220510.17879-1-pali@kernel.org>", "References": "<20220402220510.17879-1-pali@kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.5 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "_start symbol contains only 32-bit data number 0x27051956 despite it is\nmarked as text section. This magic number is IH_MAGIC which is used for\nmarking uboot image header.\n\nmpc85xx start.S code does not define valid uboot image header, so IH_MAGIC\nnumber in _start symbol is useless there.\n\nMoreover this _start symbol is not used at all. Entry point is at symbol\n_start_e500.\n\nSo because this _start symbol is not used for anything, completely remove\nit with IH_MAGIC number. After _start symbol was _start_cont symbol, so\nreplace all relative address calculations by _start_cont.\n\nSigned-off-by: Pali Rohár <pali@kernel.org>\n---\n arch/powerpc/cpu/mpc85xx/start.S | 9 ++-------\n 1 file changed, 2 insertions(+), 7 deletions(-)", "diff": "diff --git a/arch/powerpc/cpu/mpc85xx/start.S b/arch/powerpc/cpu/mpc85xx/start.S\nindex 656cc6ec8024..71b04b9f7286 100644\n--- a/arch/powerpc/cpu/mpc85xx/start.S\n+++ b/arch/powerpc/cpu/mpc85xx/start.S\n@@ -46,7 +46,6 @@\n \tGOT_ENTRY(_FIXUP_TABLE_)\n \n #ifndef MINIMAL_SPL\n-\tGOT_ENTRY(_start)\n \tGOT_ENTRY(_start_of_vectors)\n \tGOT_ENTRY(_end_of_vectors)\n \tGOT_ENTRY(transfer_to_handler)\n@@ -1128,16 +1127,12 @@ switch_as:\n \t/*--------------------------------------------------------------*/\n \tlis\tr3,CONFIG_SYS_MONITOR_BASE@h\n \tori\tr3,r3,CONFIG_SYS_MONITOR_BASE@l\n-\taddi\tr3,r3,_start_cont - _start\n+\taddi\tr3,r3,_start_cont - _start_cont\n \tmtlr\tr3\n \tblr\n #endif\n \n \t.text\n-\t.globl\t_start\n-_start:\n-\t.long\t0x27051956\t\t/* U-BOOT Magic Number */\n-\n \t.globl\t_start_cont\n _start_cont:\n \t/* Setup the stack in initial RAM,could be L2-as-SRAM or L1 dcache*/\n@@ -1604,7 +1599,7 @@ relocate_code:\n * initialization, now running from RAM.\n */\n \n-\taddi\tr0,r10,in_ram - _start\n+\taddi\tr0,r10,in_ram - _start_cont\n \n \t/*\n \t * As IVPR is going to point RAM address,\n", "prefixes": [ "1/3" ] }