Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1609029/?format=api
{ "id": 1609029, "url": "http://patchwork.ozlabs.org/api/patches/1609029/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20220324131915.13929-1-mateusz.palczewski@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20220324131915.13929-1-mateusz.palczewski@intel.com>", "list_archive_url": null, "date": "2022-03-24T13:19:15", "name": "[net,v1] Revert \"iavf: Fix deadlock occurrence during resetting VF interface\"", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "633a09b739cca02d5d29719c52a430022d88db09", "submitter": { "id": 79992, "url": "http://patchwork.ozlabs.org/api/people/79992/?format=api", "name": "Mateusz Palczewski", "email": "mateusz.palczewski@intel.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20220324131915.13929-1-mateusz.palczewski@intel.com/mbox/", "series": [ { "id": 291839, "url": "http://patchwork.ozlabs.org/api/series/291839/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=291839", "date": "2022-03-24T13:19:15", "name": "[net,v1] Revert \"iavf: Fix deadlock occurrence during resetting VF interface\"", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/291839/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1609029/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1609029/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=X4YcmxDr;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=<UNKNOWN>)", "smtp4.osuosl.org (amavisd-new);\n dkim=pass (2048-bit key) header.d=intel.com" ], "Received": [ "from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4KPQqD4LHwz9s0B\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 25 Mar 2022 00:21:44 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 899A08417A;\n\tThu, 24 Mar 2022 13:21:42 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n\tby localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id x9kmQU6ft3pK; Thu, 24 Mar 2022 13:21:41 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id A34A6843DB;\n\tThu, 24 Mar 2022 13:21:41 +0000 (UTC)", "from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by ash.osuosl.org (Postfix) with ESMTP id 99ECB1C115D\n for <intel-wired-lan@lists.osuosl.org>; Thu, 24 Mar 2022 13:21:39 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 86BBE41C41\n for <intel-wired-lan@lists.osuosl.org>; Thu, 24 Mar 2022 13:21:39 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id DVaJsMs2UUTX for <intel-wired-lan@lists.osuosl.org>;\n Thu, 24 Mar 2022 13:21:39 +0000 (UTC)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n by smtp4.osuosl.org (Postfix) with ESMTPS id D668841C27\n for <intel-wired-lan@lists.osuosl.org>; Thu, 24 Mar 2022 13:21:38 +0000 (UTC)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 24 Mar 2022 06:21:38 -0700", "from amlin-018-068.igk.intel.com (HELO localhost.igk.intel.com)\n ([10.102.18.68])\n by fmsmga007.fm.intel.com with ESMTP; 24 Mar 2022 06:21:37 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.8.0", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1648128098; x=1679664098;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=wU8HC+QDbMpJZJxmk9tjVn95spPbw+MQcktVeC5TBOc=;\n b=X4YcmxDrs4bJXmcliiCJcllAM3Uu4CBQTmINqCl9jHSdsxmVoy/crfzz\n xrKWYwBxn3wYsLn58nytn8BODfal50hHo+xyTGe45zPK5Noa7tHwTxIJ0\n GQcat5dcvriKJhG5CV8D114yN0a3REPM5FUQBY7cpMoymFB4zgtCbCqpg\n 1vW6fXa9fuJycgwqFXEFaoXe3IZqDAjE1QXvSlZl0QwI0g8pWeJiWp9ze\n EWPeTXbTDquW8Dfz0Y6y48KezWVCas0+lhaFebaTdq/Ke0rG+IgahCCpE\n 5ahaBhhom0hBR1HN/j2aCGZC6z6S9zIe3Attt1RFNoICGRcWFQI3knM7n w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10295\"; a=\"238316472\"", "E=Sophos;i=\"5.90,207,1643702400\"; d=\"scan'208\";a=\"238316472\"", "E=Sophos;i=\"5.90,207,1643702400\"; d=\"scan'208\";a=\"552862851\"" ], "X-ExtLoop1": "1", "From": "Mateusz Palczewski <mateusz.palczewski@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 24 Mar 2022 14:19:15 +0100", "Message-Id": "<20220324131915.13929-1-mateusz.palczewski@intel.com>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH net v1] Revert \"iavf: Fix deadlock\n occurrence during resetting VF interface\"", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Mateusz Palczewski <mateusz.palczewski@intel.com>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "This change caused a regression with resetting while changing network\nnamespaces. By clearing the IFF_UP flag, the kernel now thinks it has\nfully closed the device.\n\nThis reverts commit 0cc318d2e8408bc0ffb4662a0c3e5e57005ac6ff.\n\nSigned-off-by: Mateusz Palczewski <mateusz.palczewski@intel.com>\n---\n drivers/net/ethernet/intel/iavf/iavf_main.c | 7 ++-----\n 1 file changed, 2 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c\nindex 0e178a0a..310fd57 100644\n--- a/drivers/net/ethernet/intel/iavf/iavf_main.c\n+++ b/drivers/net/ethernet/intel/iavf/iavf_main.c\n@@ -2706,7 +2706,6 @@ static void iavf_reset_task(struct work_struct *work)\n \trunning = adapter->state == __IAVF_RUNNING;\n \n \tif (running) {\n-\t\tnetdev->flags &= ~IFF_UP;\n \t\tnetif_carrier_off(netdev);\n \t\tnetif_tx_stop_all_queues(netdev);\n \t\tadapter->link_up = false;\n@@ -2821,7 +2820,7 @@ static void iavf_reset_task(struct work_struct *work)\n \t\t * to __IAVF_RUNNING\n \t\t */\n \t\tiavf_up_complete(adapter);\n-\t\tnetdev->flags |= IFF_UP;\n+\n \t\tiavf_irq_enable(adapter, true);\n \t} else {\n \t\tiavf_change_state(adapter, __IAVF_DOWN);\n@@ -2837,10 +2836,8 @@ static void iavf_reset_task(struct work_struct *work)\n reset_err:\n \tmutex_unlock(&adapter->client_lock);\n \tmutex_unlock(&adapter->crit_lock);\n-\tif (running) {\n+\tif (running)\n \t\tiavf_change_state(adapter, __IAVF_RUNNING);\n-\t\tnetdev->flags |= IFF_UP;\n-\t}\n \tdev_err(&adapter->pdev->dev, \"failed to allocate resources during reinit\\n\");\n \tiavf_close(netdev);\n }\n", "prefixes": [ "net", "v1" ] }