Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1600612/?format=api
{ "id": 1600612, "url": "http://patchwork.ozlabs.org/api/patches/1600612/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20220303204400.2787389-13-sean.anderson@seco.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20220303204400.2787389-13-sean.anderson@seco.com>", "list_archive_url": null, "date": "2022-03-03T20:43:55", "name": "[12/17] cmd: fdt: Use start/size for chosen instead of start/end", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "c6d2600103a919729a737c549f71848b0a6162f6", "submitter": { "id": 80860, "url": "http://patchwork.ozlabs.org/api/people/80860/?format=api", "name": "Sean Anderson", "email": "sean.anderson@seco.com" }, "delegate": { "id": 3651, "url": "http://patchwork.ozlabs.org/api/users/3651/?format=api", "username": "trini", "first_name": "Tom", "last_name": "Rini", "email": "trini@ti.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20220303204400.2787389-13-sean.anderson@seco.com/mbox/", "series": [ { "id": 288836, "url": "http://patchwork.ozlabs.org/api/series/288836/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=288836", "date": "2022-03-03T20:43:44", "name": "arm: semihosting: Cleanups and new features", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/288836/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1600612/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1600612/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=seco.com header.i=@seco.com header.a=rsa-sha256\n header.s=selector1 header.b=jcufYCy5;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)", "phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=seco.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=seco.com header.i=@seco.com header.b=\"jcufYCy5\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=seco.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=sean.anderson@seco.com", "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=seco.com;" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4K8jhn3Bz0z9sG1\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 4 Mar 2022 07:47:05 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 0062683D4D;\n\tThu, 3 Mar 2022 21:45:21 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id 02CD183CD6; Thu, 3 Mar 2022 21:44:49 +0100 (CET)", "from EUR03-AM5-obe.outbound.protection.outlook.com\n (mail-am5eur03on0604.outbound.protection.outlook.com\n [IPv6:2a01:111:f400:fe08::604])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 8A55483CA4\n for <u-boot@lists.denx.de>; Thu, 3 Mar 2022 21:44:33 +0100 (CET)", "from DB7PR03MB4523.eurprd03.prod.outlook.com (2603:10a6:10:19::27)\n by VI1PR03MB4893.eurprd03.prod.outlook.com (2603:10a6:803:ba::33) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Thu, 3 Mar\n 2022 20:44:32 +0000", "from DB7PR03MB4523.eurprd03.prod.outlook.com\n ([fe80::9130:93ae:6e27:e9a]) by DB7PR03MB4523.eurprd03.prod.outlook.com\n ([fe80::9130:93ae:6e27:e9a%4]) with mapi id 15.20.5038.014; Thu, 3 Mar 2022\n 20:44:32 +0000" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,\n T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2", "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=NvEeUL7/Fi7efRiHDV1DLC5KFWmsakGad56346knn3rnn8Pgna0gD37AFHLPJ3YltTvvMmpIqm/jyh4rv6+PaVqBOQJ8p9600PngajhVW4fq4tOd8RMKk3heOKh8gJJeRIvdBnv9NUaXdkVctUuHX7HhSNiXv/aE8Pz3v7EgIvaK/Rv12JIWEhrrDrU002hvR0/ji2P5wNnggT8OcImm2dsU9ygzBXHOwqnKDU8/ds1Z3ZAFzIGXEqQjHXCj3lPwJO6NV0JUE6+2Giq1WBQCGBd9jfN6/a272g3+mYKT1DgOkzG1yPzrqp1qUlB1P3BZqhkCBuDhxQH8QgsJ0W1CtQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=c29mlZisbGkl7bsWJbU/fqQTwEOfXHfnuOuy8ql8NYs=;\n b=L6JzoOxc1dh5rXvT9FnAIR0LOu+OOOoU6zws+tAD9Dw2ry6VBzcBrATpgNqyQV42RKGgm9uaWObsvAseCMEcMd2BCBW7MRYbs3Qltf/59FPvKE2iV90mY8Xmhgcr2A1vVWLmzlOeB06qJS0RgCZMwwXlMr9JwaXaUZnASVUDs+3C1vSRNkNJRCYsGjE3vir1q06ydQYJkFwaSFzFjj36b8Zjeu2Zja89ielDDa6wvNKHRl9ePbVwfA/FxCLr5kp5oUnFypVT1vWM+MjjT0Dhj5n5BdWaKZgOM4Rj2MmqnYnypR2meRFdLDR0HmVxY8r8Cgh2LZMDp+Z8uPhUN6sETg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=seco.com; dmarc=pass action=none header.from=seco.com;\n dkim=pass header.d=seco.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=seco.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=c29mlZisbGkl7bsWJbU/fqQTwEOfXHfnuOuy8ql8NYs=;\n b=jcufYCy5ysMhzBcc0VKz3OgHIvZGi7NX+ryPpMgNAU33xTHZemaIzjON3vkXtoSC7ie5ixlgCu1vXF34aaJvIDaLE7E8ONR6cBHPMQpS+x7WFDnGZN4wiufCCBz7EBwrG+4L/ELZ43bGaBt0VfYVjwr3eeGu/7S4xo4s5x2Vr3MDc22ddK6el1zXrSBPwblx4+FnT5CAD1rlTXXSZ63QWx+slQIDfIfDlpJSbZjEsdqHu0S8e7VF89bRrQtlYzgu2pemXSa7mWB+EN+H0scbIsgdfROvHUaglSJAtctUkf585/CCgaMAHqR6e3vELrZf+vcoee3wCyFBL5QQVhFi6g==", "From": "Sean Anderson <sean.anderson@seco.com>", "To": "Simon Glass <sjg@chromium.org>", "Cc": "Linus Walleij <linus.walleij@linaro.org>, Tom Rini <trini@konsulko.com>,\n u-boot@lists.denx.de, Sean Anderson <sean.anderson@seco.com>", "Subject": "[PATCH 12/17] cmd: fdt: Use start/size for chosen instead of\n start/end", "Date": "Thu, 3 Mar 2022 15:43:55 -0500", "Message-Id": "<20220303204400.2787389-13-sean.anderson@seco.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220303204400.2787389-1-sean.anderson@seco.com>", "References": "<20220303204400.2787389-1-sean.anderson@seco.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "MN2PR16CA0013.namprd16.prod.outlook.com\n (2603:10b6:208:134::26) To DB7PR03MB4523.eurprd03.prod.outlook.com\n (2603:10a6:10:19::27)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "73245ac8-da0d-4349-e5db-08d9fd569ebb", "X-MS-TrafficTypeDiagnostic": "VI1PR03MB4893:EE_", "X-Microsoft-Antispam-PRVS": "\n <VI1PR03MB48939FB97FA63192A05877BB96049@VI1PR03MB4893.eurprd03.prod.outlook.com>", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n BmNh+HHzrU49rZ2WqhGJC9BmzDy85d5ZamKbVt10RWEQDtcvR5XOcIRJW9l4/P72m/gZXeUN54kXp1G95uRJkRoq4gcaGb3fL81WBnRKUgipTzrc7INcgOvwiV8zAzRTQsp/JSK5ib1BV3Xavlrb0BQK4OdeheAWioU1a8uEXg6athQfu2rsR+cpyBAGViTDYfQIaX9cLJx8/cYK/5aleWYzbRI9zLfFxtayztwCYyYFCM9YzeS16cu6DN8gzIpcb2qS3RgytNPj+frLtgZSldjdcZA2t7gAcU8avjxid5o5R9vyvNuSxfRg0jywfh+HXRNBzPUfimQGscf2i3oOrWFRSvVQ8OnSxJdoZvH7G2tbIc6kgU1UyttoaGRd+qdoHu3pBeenuwVaRoANmi5YttjSjghox1foDoQH3YzT0xavQLxHtVzCq8TDRxzbrbdyTW+c5CvXmZN4TurJHlXzUGhv0JSJ43w40UzK31zFDv71YDodTQK3X777WBw8IdShV4XRXn4AD/cQTB6TaukFJuL8Og5WLTDa5IPkyaUULBlZNOvM9baGbaseWEKZ/TvDwXgVj10/Wn5KVl0sAT5JjjNcv+f4L1fqNh3sFh/AgaEi2NFVqAxpO4G0a/uX+pBPI+Rbqp99atgcFZVqL+aM3Eh9yhH2Mm9Yac9K1S6ofaHtVjaPZpXq1/w5wgdHKme/tk5wCZMgn2E+dOKzFnHsNQ==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:DB7PR03MB4523.eurprd03.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230001)(366004)(38350700002)(38100700002)(44832011)(36756003)(2906002)(186003)(8936002)(26005)(5660300002)(508600001)(2616005)(8676002)(4326008)(107886003)(1076003)(83380400001)(52116002)(66946007)(66556008)(86362001)(66476007)(316002)(54906003)(6916009)(6506007)(6512007)(6666004)(6486002);\n DIR:OUT; SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n xTAJsTRz/DXL0AwCYZVrCaAgJ5NUndWf9kwzbp3JwOi/eQ7eMlmdefUv8uqRQRxnxE/XY9JnJ0QdEh/jUesVM8Eh3E70rW+UieDJ43JCUi/8rcQ7+kjDCMyrcX57o56Mopdxb5+/flgtadoauD/e0zpNz71olL3+ePw9URps+Pvw8QTxA56FR6ZMIuTvFTyz1pOn/bBQ1sDM3bahDtjkM4XIyM2WKkZeqhP3nYOKPR/M4joEleDawYwzcJPYOgAxOyp4rlVUw/akVerZY+0iOaxXEAKp2SnW1p6V0+qSzCaGe7yXeWI3jIqzYhKp/+xAemCJbrGH6ggBaxM43Hkj+NVl4GzZekjcomniAW+fQGeDPhhXnY+VxTyQFY7PkgYmhgORG6ksE0Q5OK+5w+3U+YtJcXSjMaY+IFyW3dIwiC+/9d8qbvaLTwL1PkZbqYQpnW1O0QJuMijKFdm6wQTflERmzgpyXN8Mhw771MyROxz70wEZTMYgae2dkqej0DH/fzqTRYZbi6iJZeKKU4SiRqH+VS79OO4u49SQNalxpu2czSz40OELDoJCl237dQoVboq2VFhwuFqoM6dEcRgrv1hE7o9uZTL2zq6IFcOcalpW3pqRTh75mCYLSVcnRKaPEX5Ih+GgPlXEumBFhHummPpnDrmntEGdXC+wKUGUsxjg/9oN9q6U4N7FpPaZqWT6VggI6pkbr1frQiCkSknKkOBu1OMOW1p4IuMS4gaWeqjZNOSqON4ekFbvLyGEUldNuPOomOIGehR6qBOFWj6sMIZ70E4OxK7IvfRTdUrsEginOlN4kwehUXXzCP9cUEnOTx/kez2Rqxlu2AMUZQaJ+FKjfc4sWa1eIzPVRpl1AzYAIGfDudtMRK3ww4+JyuolggUSuQcbpgOYJFZdPxapH5ci9T8OTJITpPt6Q32R6dayXE13eoZU76kIbBI8lAcxe6h5bAI4t4i5p3UZgB4Ni5wdvkAoRoStjZpiXZL0WNdyn6mzzIWheYuRB29la6kowV+IxaQCerzq79y43XexGlhMjvOxlJHYjCU3H1/G5K7UnA5fOmpwXKJg3FWjnKFEZjwlabRzXft9DzRQjVNI6LSEBXI+2wD9547xfKt5WfKiE2+FGmiHgYMmg5DVflSOoQkSrSJc+4B1ASLBqYNcQQiqN3209zKvMEooiuMkB2cid2cIo3qveky49/tb9yobM/Rkx8PN/L2MdkfO6xCQeSu2bIb6U+mJfALpoaP5mLEpVJMAvuVAhXWi43cb6aB5HHXbSgO/nmUz6NgDbN6OS6NocadxvvFHe0/DIgHHc3PuuP49gg5WbgdkXmV3Ysu7ujJDf8v4Fc+6YTkQDhRauxwF7toFzXnMTAPBabqvTEHCo71AFxi1bQq/YSFXFgs3imF8UzzbglOxFNbUSHOgJc2SegO9B4h3bQnsUX7pRNQ/5lVjxTFRJRcb2ST0COk9N66NOxY5s8WhMGxOQin6sBZVavt2VFXCKFTpeiSdGOUm6zY40fXJ8i2WUdB10JlbKyg2lk4KXRexh1Gm2HlpgnZONzwRVEJ0g5Mj1hk66yVwmLyGKy1yTwKDwkq4LY7lPhvhS3GjGf0pFQsQmSy7+mDby96K2gq2TfUPmxkCSYA=", "X-OriginatorOrg": "seco.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 73245ac8-da0d-4349-e5db-08d9fd569ebb", "X-MS-Exchange-CrossTenant-AuthSource": "DB7PR03MB4523.eurprd03.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "03 Mar 2022 20:44:32.3014 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "bebe97c3-6438-442e-ade3-ff17aa50e733", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n QR/nVuRsVvsvhlVVhAommM1IqDikqENaPcvKwR7s65wgc08N1VDOom8qCX2mrBVBY2yCewI++LtP6g5J29AqcQ==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "VI1PR03MB4893", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.5 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "Most U-Boot command deal with start/size instead of start/end. Convert\nthe \"fdt chosen\" command to use these semantics as well. The only user\nof this subcommand is vexpress, so convert the smhload command to use\nthis as well. We don't bother renaming the variable in vexpress64's\nbootcommand, since it will be rewritten in the next commit.\n\nSigned-off-by: Sean Anderson <sean.anderson@seco.com>\n---\n\n arch/arm/lib/semihosting.c | 16 ++++++++--------\n cmd/fdt.c | 6 +++---\n 2 files changed, 11 insertions(+), 11 deletions(-)", "diff": "diff --git a/arch/arm/lib/semihosting.c b/arch/arm/lib/semihosting.c\nindex d08003cef1..45cd566cfc 100644\n--- a/arch/arm/lib/semihosting.c\n+++ b/arch/arm/lib/semihosting.c\n@@ -171,7 +171,7 @@ long smh_seek(long fd, long pos)\n }\n \n static int smh_load_file(const char * const name, ulong load_addr,\n-\t\t\t ulong *end_addr)\n+\t\t\t ulong *size)\n {\n \tlong fd;\n \tlong len;\n@@ -191,11 +191,11 @@ static int smh_load_file(const char * const name, ulong load_addr,\n \tsmh_close(fd);\n \n \tif (ret == len) {\n-\t\t*end_addr = load_addr + len - 1;\n+\t\t*size = len;\n \t\tprintf(\"loaded file %s from %08lX to %08lX, %08lX bytes\\n\",\n \t\t name,\n \t\t load_addr,\n-\t\t *end_addr,\n+\t\t load_addr + len - 1,\n \t\t len);\n \t} else if (ret >= 0) {\n \t\tret = -EAGAIN;\n@@ -214,22 +214,22 @@ static int do_smhload(struct cmd_tbl *cmdtp, int flag, int argc,\n {\n \tif (argc == 3 || argc == 4) {\n \t\tulong load_addr;\n-\t\tulong end_addr = 0;\n+\t\tulong size = 0;\n \t\tint ret;\n-\t\tchar end_str[64];\n+\t\tchar size_str[64];\n \n \t\tload_addr = hextoul(argv[2], NULL);\n \t\tif (!load_addr)\n \t\t\treturn -1;\n \n-\t\tret = smh_load_file(argv[1], load_addr, &end_addr);\n+\t\tret = smh_load_file(argv[1], load_addr, &size);\n \t\tif (ret < 0)\n \t\t\treturn CMD_RET_FAILURE;\n \n \t\t/* Optionally save returned end to the environment */\n \t\tif (argc == 4) {\n-\t\t\tsprintf(end_str, \"0x%08lx\", end_addr);\n-\t\t\tenv_set(argv[3], end_str);\n+\t\t\tsprintf(size_str, \"0x%08lx\", size);\n+\t\t\tenv_set(argv[3], size_str);\n \t\t}\n \t} else {\n \t\treturn CMD_RET_USAGE;\ndiff --git a/cmd/fdt.c b/cmd/fdt.c\nindex 2a207bf2b5..7d7cae88a2 100644\n--- a/cmd/fdt.c\n+++ b/cmd/fdt.c\n@@ -638,7 +638,7 @@ static int do_fdt(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])\n \n \t\tif (argc == 4) {\n \t\t\tinitrd_start = hextoul(argv[2], NULL);\n-\t\t\tinitrd_end = hextoul(argv[3], NULL);\n+\t\t\tinitrd_end = initrd_start + hextoul(argv[3], NULL) - 1;\n \t\t}\n \n \t\tfdt_chosen(working_fdt);\n@@ -1083,8 +1083,8 @@ static char fdt_help_text[] =\n \t\"fdt rsvmem print - Show current mem reserves\\n\"\n \t\"fdt rsvmem add <addr> <size> - Add a mem reserve\\n\"\n \t\"fdt rsvmem delete <index> - Delete a mem reserves\\n\"\n-\t\"fdt chosen [<start> <end>] - Add/update the /chosen branch in the tree\\n\"\n-\t\" <start>/<end> - initrd start/end addr\\n\"\n+\t\"fdt chosen [<start> <size>] - Add/update the /chosen branch in the tree\\n\"\n+\t\" <start>/<size> - initrd start addr/size\\n\"\n #if defined(CONFIG_FIT_SIGNATURE)\n \t\"fdt checksign [<addr>] - check FIT signature\\n\"\n \t\" <start> - addr of key blob\\n\"\n", "prefixes": [ "12/17" ] }