Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1600606/?format=api
{ "id": 1600606, "url": "http://patchwork.ozlabs.org/api/patches/1600606/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20220303204400.2787389-7-sean.anderson@seco.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20220303204400.2787389-7-sean.anderson@seco.com>", "list_archive_url": null, "date": "2022-03-03T20:43:49", "name": "[06/17] arm: smh: Use numeric modes for smh_open", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b62e6b60b5f1922f132f85abe722f7766795052b", "submitter": { "id": 80860, "url": "http://patchwork.ozlabs.org/api/people/80860/?format=api", "name": "Sean Anderson", "email": "sean.anderson@seco.com" }, "delegate": { "id": 3651, "url": "http://patchwork.ozlabs.org/api/users/3651/?format=api", "username": "trini", "first_name": "Tom", "last_name": "Rini", "email": "trini@ti.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20220303204400.2787389-7-sean.anderson@seco.com/mbox/", "series": [ { "id": 288836, "url": "http://patchwork.ozlabs.org/api/series/288836/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=288836", "date": "2022-03-03T20:43:44", "name": "arm: semihosting: Cleanups and new features", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/288836/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1600606/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1600606/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=seco.com header.i=@seco.com header.a=rsa-sha256\n header.s=selector1 header.b=VT62NAtD;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)", "phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=seco.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=seco.com header.i=@seco.com header.b=\"VT62NAtD\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=seco.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=sean.anderson@seco.com", "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=seco.com;" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4K8jgQ632Lz9sG1\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 4 Mar 2022 07:45:54 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 87D7783C88;\n\tThu, 3 Mar 2022 21:44:48 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id E314083C70; Thu, 3 Mar 2022 21:44:35 +0100 (CET)", "from EUR02-VE1-obe.outbound.protection.outlook.com\n (mail-ve1eur02on0604.outbound.protection.outlook.com\n [IPv6:2a01:111:f400:fe06::604])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id B202483CAE\n for <u-boot@lists.denx.de>; Thu, 3 Mar 2022 21:44:26 +0100 (CET)", "from DB7PR03MB4523.eurprd03.prod.outlook.com (2603:10a6:10:19::27)\n by AM6PR03MB3573.eurprd03.prod.outlook.com (2603:10a6:209:2f::10) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26; Thu, 3 Mar\n 2022 20:44:25 +0000", "from DB7PR03MB4523.eurprd03.prod.outlook.com\n ([fe80::9130:93ae:6e27:e9a]) by DB7PR03MB4523.eurprd03.prod.outlook.com\n ([fe80::9130:93ae:6e27:e9a%4]) with mapi id 15.20.5038.014; Thu, 3 Mar 2022\n 20:44:25 +0000" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,\n T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2", "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=gjiaXPCr3K+Aq0dX8QHgdbX5a/qDX3fpSrqIENghaP73e4wXOdYAdhFBwiy1XKA1GUCAGHXV1g6aG0TerAGz+nngo+dq2gr+HWZI3l+X8cKzYQxHqob1JPOv0Gkk61uFvtENSAcP1+7aMvqLOMEzEKpJ2CxQDluNPlTLJnoCDzKKNO2fH9yTWqvCR+CFim53lR1t8GstH/l+9HEy3InQv3nN54RWmvLlWCDnfBQPu3QB+6MwsDAlT5iNgkeB+/CcquH2y3OWPOelaoFxi8QVB/freADHAbQDso0iwJLBKiAQoqjyrJ/uS0UxLOfDn/Y9/JtgL1B8Z2ZZB0HfsWbymQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=bgLdaa5/Tdidz5BQhE9qnBkaChvxQHlHK2W36tiadHw=;\n b=YFQqp6sg8TNuNsdJofXMtqwFtWVgeE91eEHeqiTb8B+0X6f5jzMksNiPHsGaC5oa0wv0gH4jbyGtyuCPG+JJ9Gqi6tGN3F+QLi0lMHMkdzpwgZ9oVQoZrps94SyDoBmLAliKDDP7MAEESXQLfGePg1WIhx4qan6bHkO+OAIlyGCaFZTIMFV707uEWd9OSMVojae/0A+wYxp3HesxNS71hIN3ELqN3w4UDrgT2ZE/rYvxQIhPyHaKBP764uJp8BICmWoOf4ykaWvMX21pbAf/2VioSgLmRaNzzNlt4pTO86AIUpw+nPZq+ebQGqhExZkOGY9t/pth5b6Y77gRlpAUlA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=seco.com; dmarc=pass action=none header.from=seco.com;\n dkim=pass header.d=seco.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=seco.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=bgLdaa5/Tdidz5BQhE9qnBkaChvxQHlHK2W36tiadHw=;\n b=VT62NAtDHLQy+cYY/zflXs0oSoPLCSOpf27NdLMJbFQ95kHWzupV+dOI17QUnI4Hgk8VheIjWbojWwTb9HYQSSHz0TnyeziGpmZ0rW3Hz1SY615vgJ1MKET60yFFFqgLb/dENHALGuRvU7u3HMaTetiQNSh1KKGsoBTuYz7I8vkP381lhcQfFpg6QT6GLnRcYQYOaV0o8n6thjQXEfMtpu+Xd1EaYO5vdm9ymlIZ1pTTjUmpXKfEjxeHmP4rNIBv6gdnkfzUUhzKbjGxin4D5yIveUT1SDrJJs0y1QtB0CGUtGG6Hed3e/1B9LCbm27sk5c53V2RRR7M4L7c36F8qg==", "From": "Sean Anderson <sean.anderson@seco.com>", "To": "Simon Glass <sjg@chromium.org>", "Cc": "Linus Walleij <linus.walleij@linaro.org>, Tom Rini <trini@konsulko.com>,\n u-boot@lists.denx.de, Sean Anderson <sean.anderson@seco.com>", "Subject": "[PATCH 06/17] arm: smh: Use numeric modes for smh_open", "Date": "Thu, 3 Mar 2022 15:43:49 -0500", "Message-Id": "<20220303204400.2787389-7-sean.anderson@seco.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220303204400.2787389-1-sean.anderson@seco.com>", "References": "<20220303204400.2787389-1-sean.anderson@seco.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "MN2PR16CA0013.namprd16.prod.outlook.com\n (2603:10b6:208:134::26) To DB7PR03MB4523.eurprd03.prod.outlook.com\n (2603:10a6:10:19::27)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "dc8b142a-9334-40b0-02d1-08d9fd569a78", "X-MS-TrafficTypeDiagnostic": "AM6PR03MB3573:EE_", "X-Microsoft-Antispam-PRVS": "\n <AM6PR03MB35732BF83C05B50AD2C7334D96049@AM6PR03MB3573.eurprd03.prod.outlook.com>", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n 3sJBViHPo090QR5MqBYqctkqBBOGOGrJBXeX9doHAocVkt8sLVABvSy2R2bTtZnxE1pH4eg/hXsI8Xykmw45xNaKcAHyyIXI3/rVoHG9BgBoKjNggydcePMv4TKMcFq8UMLaMSVdBv+vBGPi6+E0LP1vvswZMN0p3HMJpCbDOvqFHwzDEJocqFoPMOxHzzB4bgvO4xyey31IWrL+Vg6k8UKxv9PKkSwjZUNPdi7cq/PYUcmHtjPH/pQ1C3Yn1ddZ/Ij5AwlnYSMhw6u/jYurZ9rn+ClPn6ZhNuN0WHSa1R2nt4d/vV8h8m+GXLxGDqHnXUi2D558Rx42Zb2QGcNXqN5inbm4dO4uZr9Z+TJUQvxzSQ438dbbNQ79uPtXlYwPXglWTW/CzIExETNZy35qn6qOxNl8S1e7frQzdw7f7QpD5+J2eIwB7tiot+tDKAX0REX1HcJ9yoxr21uFWYtho0Vv02SxqsRj4Z/QjrBYNtmIBzEY69b2ejKXpIZSyz0GffzSReTK3AzucHx5o+qSm2BHNKLi7y9NhDD4ISJC/ZouD8LTpQB5BLTrDT+66weHnyF9Rrb5oQT3x3Gy5JPx+bz6M1WDtbZbgquYkSGFs6YJLEjZ3yuPpWqRrHrpnuC62tjg/d8oRLTfAsxv9ozdeA8dx4jpiBymB/nOi/z3JaoAccfHvjOC7Srl1wq98tuqx71kZI7N5JVUKt2flkyukA==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:DB7PR03MB4523.eurprd03.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230001)(366004)(6916009)(36756003)(54906003)(1076003)(2616005)(83380400001)(316002)(38100700002)(38350700002)(186003)(26005)(107886003)(4326008)(6506007)(6666004)(508600001)(6512007)(2906002)(52116002)(86362001)(5660300002)(6486002)(8676002)(44832011)(66476007)(66946007)(66556008)(8936002);\n DIR:OUT; SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n f+7t3xHllFStzfvIASMJ7B9A8o+KYB7/4yOnwqZGvvwYKmMqk3nD3zfqoiUYdHPw3dXQVM9KAMBG1Ncqx/8u9zR/VW0r6NnfcSqxX4G1U8PUP9lGcYCiepryBpDZVim5tXRvOVGIx9vDzJrMODiPhy1a8M2sGp6bs/bBl6Ciu0g8UPERKuocP0TokY4HB465KSTsPoPDyI/QyT7wrqhIi7VN8qlW0PuWjPRBo+qWFAfT8riZ19QPkma6/e9/4HSdeQq8WQuepDjnnxbvtaHrlbgRVrvdnDGQUEM8i7U2/v8HdncWtyKofXw/69clg7+uMPFq7il+vFRBQzQ/FJR2U2HYNQ3IDUeTQwIKTlyTqoNsFQvQV8fxiEhyEgmTaDMrCBVu23wl7r4Ozgp1khopwdm9TXT5LNKWysyn3Z+kOgbElGYcBxZ+CwA+H8wRUq6eg9HUmwsn5dkSJR/lTMzWpo3FlJx95fOxll68wV3bDvjcN1wTHHoniio/VkjuvWX/57N3Zw+oEMIvCSfQVMQ1SRmi5jOij+37o1r+4aLc5Lu/Zox50K3sdYKdqvoLB4vG4sjOyvvzy2lbPBG78/8zOkM9kCAEpqG3iUfANBXRmVD6QdDLnSNIS+GRyL9KaUR0icD1g6lFXOoD12k1rDX8pa6gdQzBbbs9rF8q6z2LwoxtICK5HXC85eIef4pno0XaoF3A/cLH8jQ+DyD02eA4S87NQqRgsiLJymNthNnl0UrlMrGYoG3022dxSdFh18wY8qAhU/rFoymNraqZO2iGCn3AlTYg4qM3yQ8LYd3g5Vr2WW2emeu6lpBv0TntQCtU2na2zgWWi2wF3UESCzE9/LRnWYVAlB/W9peTwNRUFBYF0dFSlgiO3aYUVwE+V/w/SK0dLe/J96AWT6JjVYRDoB8QvsBnX6gsbQtEvZq/4Png52HMk+ARdra/wbhTr/A9uO6brXAqKptJ9jmVpJDGBGbSQR7YqVGdcsi1cF13SoUYsovkV+Zvj0ry69ycDuX5ZCCNLUgEc0EtNexwkh7YBLDdNY6EPxoh1hCwusbmGxU8a4ezlKpAQbScHEuxQgbW98yR3n3Icph4OHWKztB75whxQ6PnsVrn7Pwa9/LlutWKPDWq42GvmB4MhWi89iRogHC/vC8JeaxMzbf5epbDLB6Ib1ySG7VyNw1zMD9AbqocNlOZwyCoTWaO4l2Tn/cEV/2obRd88o2XwZd3OfoF+0DOeIBv1jRjIzyWf5GP2DR9LRaupagPZHNJoep9WXclmSVwYp8BB2c4hgXorgEHzza88+DfgaBvrjumeOJnsYELaflOqb1i8+JPkzwtd074D8IiJF8LmIERPwdbVQi8VjfJ8uJt9wf0EVEsttwSmXeYzasjPdLzUZyyeECGXQVtfx1uiT6XYY9mX/FpqrM85e6Co/8gid9rRQriaCiD9CM6vLjT7p+asrGwYUN1a+pj89t+Pn/WwXAahEDAHpcWJ1JrPme6nD8YGSMXuW/lb7ewDa64y0Pv4yyqk65PIHLcHdMvaVstZ3sG7h6BxE+TJ8Himl+W6C78W/FKBW5xgjCigLCv3AxrUUEKuzm3K6oj+GIPj0b3mKL81q2anBn8Wv0H0EE88Bn340XvGJxb7qM=", "X-OriginatorOrg": "seco.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n dc8b142a-9334-40b0-02d1-08d9fd569a78", "X-MS-Exchange-CrossTenant-AuthSource": "DB7PR03MB4523.eurprd03.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "03 Mar 2022 20:44:25.1300 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "bebe97c3-6438-442e-ade3-ff17aa50e733", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n OhTRG3NoHFMQ3qu2yWFcr6ygqskCFRPfzE124wFAYg4MGL4+a8kAmsnXxt6R11HkycwXhCnorjjxKlLDGf06Yw==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM6PR03MB3573", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.5 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "There's no point in using string constants for smh_open if we are just\ngoing to have to parse them. Instead, use numeric modes. The user needs\nto be a bit careful with these, since they are much closer semantically\nto string modes used by fopen(3) than the numeric modes used with\nopen(2).\n\nSigned-off-by: Sean Anderson <sean.anderson@seco.com>\n---\n\n arch/arm/lib/semihosting.c | 21 +++------------------\n include/semihosting.h | 25 ++++++++++++++++++++++++-\n 2 files changed, 27 insertions(+), 19 deletions(-)", "diff": "diff --git a/arch/arm/lib/semihosting.c b/arch/arm/lib/semihosting.c\nindex c38892fdd8..b983cc3935 100644\n--- a/arch/arm/lib/semihosting.c\n+++ b/arch/arm/lib/semihosting.c\n@@ -22,9 +22,6 @@\n #define SYSREAD\t\t0x06\n #define SYSFLEN\t\t0x0C\n \n-#define MODE_READ\t0x0\n-#define MODE_READBIN\t0x1\n-\n /*\n * Call the handler\n */\n@@ -46,28 +43,16 @@ static noinline long smh_trap(unsigned int sysnum, void *addr)\n * Open a file on the host. Mode is \"r\" or \"rb\" currently. Returns a file\n * descriptor or -1 on error.\n */\n-long smh_open(const char *fname, char *modestr)\n+long smh_open(const char *fname, enum smh_open_mode mode)\n {\n \tlong fd;\n-\tunsigned long mode;\n \tstruct smh_open_s {\n \t\tconst char *fname;\n \t\tunsigned long mode;\n \t\tsize_t len;\n \t} open;\n \n-\tdebug(\"%s: file \\'%s\\', mode \\'%s\\'\\n\", __func__, fname, modestr);\n-\n-\t/* Check the file mode */\n-\tif (!(strcmp(modestr, \"r\"))) {\n-\t\tmode = MODE_READ;\n-\t} else if (!(strcmp(modestr, \"rb\"))) {\n-\t\tmode = MODE_READBIN;\n-\t} else {\n-\t\tprintf(\"%s: ERROR mode \\'%s\\' not supported\\n\", __func__,\n-\t\t modestr);\n-\t\treturn -1;\n-\t}\n+\tdebug(\"%s: file \\'%s\\', mode \\'%u\\'\\n\", __func__, fname, mode);\n \n \topen.fname = fname;\n \topen.len = strlen(fname);\n@@ -155,7 +140,7 @@ static int smh_load_file(const char * const name, ulong load_addr,\n \tlong len;\n \tlong ret;\n \n-\tfd = smh_open(name, \"rb\");\n+\tfd = smh_open(name, MODE_READ | MODE_BINARY);\n \tif (fd == -1)\n \t\treturn -1;\n \ndiff --git a/include/semihosting.h b/include/semihosting.h\nindex 3843863046..cf54819192 100644\n--- a/include/semihosting.h\n+++ b/include/semihosting.h\n@@ -6,7 +6,30 @@\n #ifndef _SEMIHOSTING_H\n #define _SEMIHOSTING_H\n \n-long smh_open(const char *fname, char *modestr);\n+/**\n+ * enum smh_open_mode - Numeric file modes for use with smh_open()\n+ * MODE_READ: 'r'\n+ * MODE_BINARY: 'b'\n+ * MODE_PLUS: '+'\n+ * MODE_WRITE: 'w'\n+ * MODE_APPEND: 'a'\n+ *\n+ * These modes represent the mode string used by fopen(3) in a form which can\n+ * be passed to smh_open(). These do NOT correspond directly to %O_RDONLY,\n+ * %O_CREAT, etc; see fopen(3) for details. In particular, @MODE_PLUS\n+ * effectively results in adding %O_RDWR, and @MODE_WRITE will add %O_TRUNC.\n+ * For compatibility, @MODE_BINARY should be added when opening non-text files\n+ * (such as images).\n+ */\n+enum smh_open_mode {\n+\tMODE_READ\t= 0x0,\n+\tMODE_BINARY\t= 0x1,\n+\tMODE_PLUS\t= 0x2,\n+\tMODE_WRITE\t= 0x4,\n+\tMODE_APPEND\t= 0x8,\n+};\n+\n+long smh_open(const char *fname, enum smh_open_mode mode);\n long smh_read(long fd, void *memp, size_t len);\n long smh_close(long fd);\n long smh_flen(long fd);\n", "prefixes": [ "06/17" ] }