Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1600605/?format=api
{ "id": 1600605, "url": "http://patchwork.ozlabs.org/api/patches/1600605/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20220303204400.2787389-8-sean.anderson@seco.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20220303204400.2787389-8-sean.anderson@seco.com>", "list_archive_url": null, "date": "2022-03-03T20:43:50", "name": "[07/17] arm: smh: Return errno on error", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "534fb65e99f92a4f7d081f36c07032a70d87c9fa", "submitter": { "id": 80860, "url": "http://patchwork.ozlabs.org/api/people/80860/?format=api", "name": "Sean Anderson", "email": "sean.anderson@seco.com" }, "delegate": { "id": 3651, "url": "http://patchwork.ozlabs.org/api/users/3651/?format=api", "username": "trini", "first_name": "Tom", "last_name": "Rini", "email": "trini@ti.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20220303204400.2787389-8-sean.anderson@seco.com/mbox/", "series": [ { "id": 288836, "url": "http://patchwork.ozlabs.org/api/series/288836/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=288836", "date": "2022-03-03T20:43:44", "name": "arm: semihosting: Cleanups and new features", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/288836/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1600605/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1600605/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=seco.com header.i=@seco.com header.a=rsa-sha256\n header.s=selector1 header.b=wZtru4HF;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)", "phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=seco.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=seco.com header.i=@seco.com header.b=\"wZtru4HF\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=seco.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=sean.anderson@seco.com", "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=seco.com;" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4K8jgD2Y1Kz9sG1\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 4 Mar 2022 07:45:44 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id A267D83CBF;\n\tThu, 3 Mar 2022 21:44:45 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id 8D8F883D14; Thu, 3 Mar 2022 21:44:36 +0100 (CET)", "from EUR02-VE1-obe.outbound.protection.outlook.com\n (mail-ve1eur02on0604.outbound.protection.outlook.com\n [IPv6:2a01:111:f400:fe06::604])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 48D0783CA0\n for <u-boot@lists.denx.de>; Thu, 3 Mar 2022 21:44:27 +0100 (CET)", "from DB7PR03MB4523.eurprd03.prod.outlook.com (2603:10a6:10:19::27)\n by AM6PR03MB3573.eurprd03.prod.outlook.com (2603:10a6:209:2f::10) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26; Thu, 3 Mar\n 2022 20:44:26 +0000", "from DB7PR03MB4523.eurprd03.prod.outlook.com\n ([fe80::9130:93ae:6e27:e9a]) by DB7PR03MB4523.eurprd03.prod.outlook.com\n ([fe80::9130:93ae:6e27:e9a%4]) with mapi id 15.20.5038.014; Thu, 3 Mar 2022\n 20:44:26 +0000" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,\n T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2", "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=GT4tltBIUi8LmRfHdRwl2Pu7jzsz6+SgenuhWUsAc6w7seim/nnPb+qjDZM82XwLWeMiUYurgDxHE1rHLKiFlbSIPjDwd0GpvcxVmHw13q0JSfwxKQmFbOOHTbyPhWV2wOeiUzrwc4FhPHtqNeuckeRMkFlaqtzfmryNroboTUp9dqQDMQtgTQ+oPlPmpr9oEelGIJpDrnFWiJKoS+vunLLO9jz0u90NMRgwUw9E1o4V5km0J08g8nGjT6+sEYtaVm0yNWq+zeTAQ4AbJkclMcF3GXrUWmcXl7HkjSlxNZOPmr7f9rGfJahXVC8dLx4jhYOqcPXcu8K8YDyoxv658w==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=5HmgAC6aKFBuE3M0b0oc33rdL8JhYDCXNuvAY/tp7y8=;\n b=f+icYRIK83LMZQ690UECxnk+NKc8RfrqQAtkmlyZaGf6ynaxd5a3pseSVxMg/tXMFWKYqPFF9KiqWcC5NxxHQzJSb4u96vEzKgKxBWoSVfU07YXhJcgN46vn+el0lseR8nvAJtdZ6biqzJu+JtaynVxm3hDQ0l9E82KbpbXPTGQ8KsIWj6X+d/lHCoIiylqEXMBd1RIZrIa8xIEGUaAc4Fvq6u3y2wqykHybKynxB6KXJO2JbY6+Ld96V6YaNiSjsAaDVEg+W5EEr9HEWrJqmSz1GqO7mnH5CqeY3Fbf3xOeXbQiR5HlTcCL7j47p+s792YFKEvFxNnBNcc9ENPMEw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=seco.com; dmarc=pass action=none header.from=seco.com;\n dkim=pass header.d=seco.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=seco.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=5HmgAC6aKFBuE3M0b0oc33rdL8JhYDCXNuvAY/tp7y8=;\n b=wZtru4HF3wEXN+udetaKpJSlVLsvnCIICjA6/nU0gP6k8ff2oyAiB6Cu6ZEmEOuJ9DKuu4fNsP9hEQx5LC+dCsyCjTNqwq8q54zpfbPB6gvJIxqQWDqmF+4d1o5vM6oO8R8C7KCt+zhA73qniNy3iuMG9S1yYoUsmVnvFcEQQdMEsgX813MvXUMlaQPLuBkqxLVFlahjZwqRBbflvvYE0uc0JYxMiIE1ZV8WXrVxIdbwcmK+2jqKzl2ss3TVEicQmNcrrd5agJX9tcAv65UPzOfrhC/wFY5B4l/jt5yUCJ5a2AA8DEe8D7rqDteBkEZv47UpI9VhUhuguU0z6K6ykw==", "From": "Sean Anderson <sean.anderson@seco.com>", "To": "Simon Glass <sjg@chromium.org>", "Cc": "Linus Walleij <linus.walleij@linaro.org>, Tom Rini <trini@konsulko.com>,\n u-boot@lists.denx.de, Sean Anderson <sean.anderson@seco.com>", "Subject": "[PATCH 07/17] arm: smh: Return errno on error", "Date": "Thu, 3 Mar 2022 15:43:50 -0500", "Message-Id": "<20220303204400.2787389-8-sean.anderson@seco.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220303204400.2787389-1-sean.anderson@seco.com>", "References": "<20220303204400.2787389-1-sean.anderson@seco.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "MN2PR16CA0013.namprd16.prod.outlook.com\n (2603:10b6:208:134::26) To DB7PR03MB4523.eurprd03.prod.outlook.com\n (2603:10a6:10:19::27)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "677446d4-9e02-4036-6de2-08d9fd569b28", "X-MS-TrafficTypeDiagnostic": "AM6PR03MB3573:EE_", "X-Microsoft-Antispam-PRVS": "\n <AM6PR03MB3573C5095184E226898357DA96049@AM6PR03MB3573.eurprd03.prod.outlook.com>", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n 81X6VSzTxtgxgMQDNWjk7weTgyhoGwFnu0OAlajqg9Nx8f5bKM/rtUxteGYM8En4/qq/HknKbARew4EJ+N7igLF6xsJNnr/g3hUUbMBDYaPDyiGxwQ4FwgCwCOBk05LYKwGR/yWG46YR1EQWUq6S6r/AgRG8B3VigyVjo8V6jvhUZop2I6sUw8dd+5JoHKDoYsXxe10YM7xD+6o2BEFNgfAAmRwXqztE66e2Ga3sQlltAww9QCw6Hx/38r+4jmYeXRd8XVUOftH8eWi4sy4AQac1w1ppRkNBCbvt58Q/sFVyG9e0Ym/9O0Vr+Zu8m8H6j3ul9JQy6b0yvla91eLqWr4+i0wLHsvPVWOxvHpb36SLVdW0SHbXYJOorwTafvDZtF7063xxHckFfYrGYhNrVAyu91QQ/NpN8KgHHKqdUQzqdEBxVGiSeWi07k1YYoaGZZlCy7GZzXcnnGCzoWXXaXXLjwfdM19soqOc2z9J0v6KFJCrv9UqkvhUYnGGuAdRWnDOFJqKVJawcdx2FpWMx03AxyiL6wmCQUPvr3NlVL0EPslfAo/fR4TUwaD12BK3tF56j+1F1qcO+WRtS0TegmTkHpUM65wle7coMr27AvEQc5+AeHhRdVYVbs+4shWiD67YqCp5oV6yjzuG9r08z0lmiDq/aji0h2NimYvcC+wjD6pUo9ptBw9WumtJoLVX6B0h44GFLh1RxwjvpJfTeA==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:DB7PR03MB4523.eurprd03.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230001)(366004)(6916009)(36756003)(54906003)(1076003)(2616005)(83380400001)(316002)(38100700002)(38350700002)(186003)(26005)(107886003)(4326008)(6506007)(6666004)(508600001)(6512007)(2906002)(52116002)(86362001)(5660300002)(6486002)(8676002)(44832011)(66476007)(66946007)(66556008)(8936002);\n DIR:OUT; SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n UT2E3tioc8ltXJ5zzLts4t7v2zXB0AlBB7ipAKCmq9bVZSRyEyl6dIJZp4rrboBwVk1/n58ADzFjwViXlvKwnime6mzqw3/spA85wZoZhdllb5UhSmBdwTm4Vh7thOtALOR8BPj6LMSlSb/jUdftDLtDoeAHlB6WVf+3RbWo7jBbrUJtcM+Wgi85teaoDES2bt9nGyjO5eZYYTUcOsSEe0xlnGT6LFA81G3DKwNmtGrbBPJ6CiC+Rh4T2lohynH8ZfqvtRV+mbwRQgEDvjhrw1YK2yutJdefmy0KkWGcsOxH5aXQibtOvtoOu8yNeT7qITYBuUsbNUmyKPDL/eNSBnspjuKTaOQ2gYe9vrYHzSDFhsEpgmT/ZRM7mJhaaNfV4yXQzzTjbdTayR1LxrXgah7WbU9ctk1WbpbsrpMXNtd3aWji3Yrt0LkPsKEyAZqm8WEUyqJkCFQpM8o1535O46Te6Zr7G4YMv0tgilTeSaI3uFdXDxjXTnsQOfnLmfB0xifcZE/Kfcq3UJpNWu05etcGFNbAXcgKZ7UZBZNVammrTuEC8TpZn+jQprDb/p2bYc9Xxx7a0GWO4GSD5HrN4g7jVjCZ6eV6kAz37Ozjw+lhsrtlVQCcP2CZ62yPB7AKj/XtMSQJvNPdJuyFzZz7KE1g1PccUsXmJDIV6KB8Fy0aBcv01PVuV25byFhSfpWD4ybX+Klhl2kEdYNvVmSy5qK3HieqcLjPfEt4W88sTlUfSedp6wzpebQKs//FUbHTwSglsuO+KSGIy9tScVBLHz4ZWyh7jaAWMp6NkptY5wrl4BpRVmueluBzLxluTScrOw4oL0pSsbjYsmMaOX+1pWITZflRPUgrChUP0t1Lg57Yv9JpNpFjnaPB6rnra00EkOLmUmyvu42Vxe0OVOBcDO5cEigmYXm0R3f0YKJg/e4mRRbCVxdhZXgv4TjilvX9b2k2oFOSBSzHFIIKIT7wd9Ahvp40o8iaDHrxEkDGxJ4GfBw9j+17cJgpYHgsNUb2B9J9EfD9ydVhj22I+4lqyuroo7isR/LXukQ2jL3GK93t1CCYz46hXerxv1/zBrrv/81d1gOjPq4hyZRmmo/x6F9U/oC5ckXYSreGvqX56/WXlvCBHBbjcXQcTynNGUdPKqIB/nWApaN5vSXNPou7MqZFzY+PbdDi9ZU6ElKYRORFFgJgkcjR4Wbpg4rHyr2QHYy3kmW9HROdNrB+QCf7MpMY5L2KxQdeSsMFPNsnymMMhLGYrMdiJqZUXNCGV5YnIWowBPbpy8WeYUz2TIrRcif22DwubXrVd6PBZzhocNSmFGZ8K0mIG4MycjQYTd158YA9ye930XLFYCsIueWSVjBL0rfIj4P33z0WCSs5EASTcto3fQc7DEjRBBDC0fQrxgwSfECcl752wD+VvfNxEGfFRbqMBEIRgmUbc3XZivjIQDVH0jEk1QkRxyDuJGr1rvUdi1MZVv9mO2vxPyQ/D08jTiAZq+7fSL64OUa4uf3vCQAd2oCLJJDCKZvHQG6GDjQN8sfG11p8+Jhe46BcADdQ4ZvHOsNEUUqeuhvdunefWj/VYPUkF1JYzFepOutrxFVJOsEDPevSLgAQEKa3qlbtCXYhUaBTdp9UUDTpoBs=", "X-OriginatorOrg": "seco.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 677446d4-9e02-4036-6de2-08d9fd569b28", "X-MS-Exchange-CrossTenant-AuthSource": "DB7PR03MB4523.eurprd03.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "03 Mar 2022 20:44:26.2862 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "bebe97c3-6438-442e-ade3-ff17aa50e733", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n maO95DxqylRNjeKD9n3TKFNBCrYDEAv3gYjwoPPZC91gXOX/6rEOpDEq2RUPSPOe1LpyybGux8386APC5Io55A==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM6PR03MB3573", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.5 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "Instead of printing in what are now library functions, try to return a\nnumeric error code. This also adjust some functions (such as read) to\nbehave more similarly to read(2). For example, we now return the number\nof bytes read instead of failing immediately on a short read.\n\nSigned-off-by: Sean Anderson <sean.anderson@seco.com>\n---\n\n arch/arm/lib/semihosting.c | 67 ++++++++++++++++++++------------------\n 1 file changed, 36 insertions(+), 31 deletions(-)", "diff": "diff --git a/arch/arm/lib/semihosting.c b/arch/arm/lib/semihosting.c\nindex b983cc3935..1686457685 100644\n--- a/arch/arm/lib/semihosting.c\n+++ b/arch/arm/lib/semihosting.c\n@@ -21,6 +21,7 @@\n #define SYSCLOSE\t0x02\n #define SYSREAD\t\t0x06\n #define SYSFLEN\t\t0x0C\n+#define SYSERRNO\t0x13\n \n /*\n * Call the handler\n@@ -39,10 +40,24 @@ static noinline long smh_trap(unsigned int sysnum, void *addr)\n \treturn result;\n }\n \n-/*\n- * Open a file on the host. Mode is \"r\" or \"rb\" currently. Returns a file\n- * descriptor or -1 on error.\n+/**\n+ * smh_errno() - Read the host's errno\n+ *\n+ * This gets the value of the host's errno and negates it. The host's errno may\n+ * or may not be set, so only call this function if a previous semihosting call\n+ * has failed.\n+ *\n+ * Return: a negative error value\n */\n+static int smh_errno(void)\n+{\n+\tlong ret = smh_trap(SYSERRNO, NULL);\n+\n+\tif (ret > 0 && ret < INT_MAX)\n+\t\treturn -ret;\n+\treturn -EIO;\n+}\n+\n long smh_open(const char *fname, enum smh_open_mode mode)\n {\n \tlong fd;\n@@ -61,9 +76,7 @@ long smh_open(const char *fname, enum smh_open_mode mode)\n \t/* Open the file on the host */\n \tfd = smh_trap(SYSOPEN, &open);\n \tif (fd == -1)\n-\t\tprintf(\"%s: ERROR fd %ld for file \\'%s\\'\\n\", __func__, fd,\n-\t\t fname);\n-\n+\t\treturn smh_errno();\n \treturn fd;\n }\n \n@@ -86,19 +99,9 @@ long smh_read(long fd, void *memp, size_t len)\n \tread.len = len;\n \n \tret = smh_trap(SYSREAD, &read);\n-\tif (ret < 0) {\n-\t\t/*\n-\t\t * The ARM handler allows for returning partial lengths,\n-\t\t * but in practice this never happens so rather than create\n-\t\t * hard to maintain partial read loops and such, just fail\n-\t\t * with an error message.\n-\t\t */\n-\t\tprintf(\"%s: ERROR ret %ld, fd %ld, len %zu memp %p\\n\",\n-\t\t __func__, ret, fd, len, memp);\n-\t\treturn -1;\n-\t}\n-\n-\treturn 0;\n+\tif (ret < 0)\n+\t\treturn smh_errno();\n+\treturn len - ret;\n }\n \n /*\n@@ -112,9 +115,8 @@ long smh_close(long fd)\n \n \tret = smh_trap(SYSCLOSE, &fd);\n \tif (ret == -1)\n-\t\tprintf(\"%s: ERROR fd %ld\\n\", __func__, fd);\n-\n-\treturn ret;\n+\t\treturn smh_errno();\n+\treturn 0;\n }\n \n /*\n@@ -128,8 +130,7 @@ long smh_flen(long fd)\n \n \tret = smh_trap(SYSFLEN, &fd);\n \tif (ret == -1)\n-\t\tprintf(\"%s: ERROR ret %ld, fd %ld\\n\", __func__, ret, fd);\n-\n+\t\treturn smh_errno();\n \treturn ret;\n }\n \n@@ -141,28 +142,32 @@ static int smh_load_file(const char * const name, ulong load_addr,\n \tlong ret;\n \n \tfd = smh_open(name, MODE_READ | MODE_BINARY);\n-\tif (fd == -1)\n-\t\treturn -1;\n+\tif (fd < 0)\n+\t\treturn fd;\n \n \tlen = smh_flen(fd);\n \tif (len < 0) {\n \t\tsmh_close(fd);\n-\t\treturn -1;\n+\t\treturn len;\n \t}\n \n \tret = smh_read(fd, (void *)load_addr, len);\n \tsmh_close(fd);\n \n-\tif (ret == 0) {\n+\tif (ret == len) {\n \t\t*end_addr = load_addr + len - 1;\n \t\tprintf(\"loaded file %s from %08lX to %08lX, %08lX bytes\\n\",\n \t\t name,\n \t\t load_addr,\n \t\t *end_addr,\n \t\t len);\n-\t} else {\n-\t\tprintf(\"read failed\\n\");\n-\t\treturn 0;\n+\t} else if (ret >= 0) {\n+\t\tret = -EAGAIN;\n+\t}\n+\n+\tif (ret < 0) {\n+\t\tprintf(\"read failed: %ld\\n\", ret);\n+\t\treturn ret;\n \t}\n \n \treturn 0;\n", "prefixes": [ "07/17" ] }