Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1585800/?format=api
{ "id": 1585800, "url": "http://patchwork.ozlabs.org/api/patches/1585800/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20220128153009.2467560-4-peter.maydell@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20220128153009.2467560-4-peter.maydell@linaro.org>", "list_archive_url": null, "date": "2022-01-28T15:29:40", "name": "[PULL,03/32] hw/char/exynos4210_uart: Fix crash on trying to load VM state", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "b4b7a1b3fd4d84a420e4cde15515b62f25849937", "submitter": { "id": 5111, "url": "http://patchwork.ozlabs.org/api/people/5111/?format=api", "name": "Peter Maydell", "email": "peter.maydell@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20220128153009.2467560-4-peter.maydell@linaro.org/mbox/", "series": [ { "id": 283405, "url": "http://patchwork.ozlabs.org/api/series/283405/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=283405", "date": "2022-01-28T15:29:53", "name": "[PULL,01/32] Update copyright dates to 2022", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/283405/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1585800/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1585800/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=pyRNfOpn;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=<UNKNOWN>)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4Jljsb1bqBz9t3b\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 29 Jan 2022 03:41:54 +1100 (AEDT)", "from localhost ([::1]:42970 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1nDUJs-0002cO-PI\n\tfor incoming@patchwork.ozlabs.org; Fri, 28 Jan 2022 11:41:52 -0500", "from eggs.gnu.org ([209.51.188.92]:58106)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>)\n id 1nDTDO-0002HC-Kz\n for qemu-devel@nongnu.org; Fri, 28 Jan 2022 10:31:06 -0500", "from [2a00:1450:4864:20::32d] (port=43868\n helo=mail-wm1-x32d.google.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>)\n id 1nDTDK-0006Jd-SS\n for qemu-devel@nongnu.org; Fri, 28 Jan 2022 10:31:06 -0500", "by mail-wm1-x32d.google.com with SMTP id\n k6-20020a05600c1c8600b003524656034cso1250680wms.2\n for <qemu-devel@nongnu.org>; Fri, 28 Jan 2022 07:30:18 -0800 (PST)", "from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2])\n by smtp.gmail.com with ESMTPSA id j3sm4749485wrb.57.2022.01.28.07.30.16\n for <qemu-devel@nongnu.org>\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 28 Jan 2022 07:30:16 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n h=from:to:subject:date:message-id:in-reply-to:references:mime-version\n :content-transfer-encoding;\n bh=tC3w9/x0OfjkAjjFI9nzbpgiKr47Rct6S90BOp4oX6s=;\n b=pyRNfOpnmQ7Mn2DA7Gj+8aumZCHhp56HTY/wqBqfPaiCEAtHyQv7wZnHxlUaexIY/y\n Ga8N8twpRDGOhvP/O88hKsgLcuS0sfG1/rEe0bIF7VJ6OdX0FQ6yDzjpStt2G46FW/ti\n rvVrDeZ1tX7/QxFfn3NoIVW4sZTjfvizr0Kng/j7ze3UtSM3VxVb547DiuxOzqxFjUmO\n HMGwVrByVJxvRK+dgFl3iDQ6o5bQwo9COU/Wu0tP/S9O5bot8IQT5ESi0bpFWXQthDbP\n MhCTuvJDMM4uPlZwoJymcL/o58DobMc0lAoxGIhOSkHAlslbIQ2wB/4tEc4M4LX5b7BS\n 8k2g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=tC3w9/x0OfjkAjjFI9nzbpgiKr47Rct6S90BOp4oX6s=;\n b=5NBVh9itkTHaRqOCP0oLXoDPfgavzXPTrt+kEfbKXY4AHKqByPnFS/QIYPBfWQen1V\n 8SMIUwtMvXVt5kvSqXBWZhavlR7V4PtJ9R+5wC7PJs08rJSQciIongZHWCAfxCbx7FDH\n rtIbq2JPWErEosIGYTv1xfRHigkhD9qMkh9ND5+YmjA5fZi1cKfHPBQ0G/+bT4XOkGIb\n ssWX2DD9/dVTG2937CLPMcLdmPWRBaAMtXuMKOjIoPrmNctOtXrw5nbMDf+Lm/UXg9cU\n zLlXNvz6DDLNMSEyWBVfcuXXAOUw3eTX8B2z721LmNY/pqNClbM/RNmaLakpotnb1FLK\n 20Bw==", "X-Gm-Message-State": "AOAM532fQov0RZ9zhydod5l+BAibuVjU8EO5BhehKNpXMRsAIKR6xRsD\n ZdHvECtS95/xQ28mQNvSDqjcmhevdPIG7Q==", "X-Google-Smtp-Source": "\n ABdhPJzT8QS3MniWHucPJi9NGXccrNHLb8za9DV68ms5//YXsyFm/inD6+cB3h/uFWk9h5nHA3llIA==", "X-Received": "by 2002:a1c:f203:: with SMTP id s3mr2424296wmc.112.1643383817022;\n Fri, 28 Jan 2022 07:30:17 -0800 (PST)", "From": "Peter Maydell <peter.maydell@linaro.org>", "To": "qemu-devel@nongnu.org", "Subject": "[PULL 03/32] hw/char/exynos4210_uart: Fix crash on trying to load VM\n state", "Date": "Fri, 28 Jan 2022 15:29:40 +0000", "Message-Id": "<20220128153009.2467560-4-peter.maydell@linaro.org>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220128153009.2467560-1-peter.maydell@linaro.org>", "References": "<20220128153009.2467560-1-peter.maydell@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Host-Lookup-Failed": "Reverse DNS lookup failed for 2a00:1450:4864:20::32d\n (failed)", "Received-SPF": "pass client-ip=2a00:1450:4864:20::32d;\n envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x32d.google.com", "X-Spam_score_int": "-12", "X-Spam_score": "-1.3", "X-Spam_bar": "-", "X-Spam_report": "(-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001,\n T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "The exynos4210_uart_post_load() function assumes that it is passed\nthe Exynos4210UartState, but it has been attached to the\nVMStateDescription for the Exynos4210UartFIFO type. The result is a\nSIGSEGV when attempting to load VM state for any machine type\nincluding this device.\n\nFix the bug by attaching the post-load function to the VMSD for the\nExynos4210UartState. This is the logical place for it, because the\nactions it does relate to the entire UART state, not just the FIFO.\n\nThanks to the bug reporter @TrungNguyen1909 for the clear bug\ndescription and the suggested fix.\n\nFixes: c9d3396d80fe7ece9b\n (\"hw/char/exynos4210_uart: Implement post_load function\")\nResolves: https://gitlab.com/qemu-project/qemu/-/issues/638\nSigned-off-by: Peter Maydell <peter.maydell@linaro.org>\nReviewed-by: Guenter Roeck <linux@roeck-us.net>\nReviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>\nMessage-id: 20220120151648.433736-1-peter.maydell@linaro.org\n---\n hw/char/exynos4210_uart.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/hw/char/exynos4210_uart.c b/hw/char/exynos4210_uart.c\nindex 80d401a3795..addcd59b028 100644\n--- a/hw/char/exynos4210_uart.c\n+++ b/hw/char/exynos4210_uart.c\n@@ -628,7 +628,6 @@ static const VMStateDescription vmstate_exynos4210_uart_fifo = {\n .name = \"exynos4210.uart.fifo\",\n .version_id = 1,\n .minimum_version_id = 1,\n- .post_load = exynos4210_uart_post_load,\n .fields = (VMStateField[]) {\n VMSTATE_UINT32(sp, Exynos4210UartFIFO),\n VMSTATE_UINT32(rp, Exynos4210UartFIFO),\n@@ -641,6 +640,7 @@ static const VMStateDescription vmstate_exynos4210_uart = {\n .name = \"exynos4210.uart\",\n .version_id = 1,\n .minimum_version_id = 1,\n+ .post_load = exynos4210_uart_post_load,\n .fields = (VMStateField[]) {\n VMSTATE_STRUCT(rx, Exynos4210UartState, 1,\n vmstate_exynos4210_uart_fifo, Exynos4210UartFIFO),\n", "prefixes": [ "PULL", "03/32" ] }