Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1585796/?format=api
{ "id": 1585796, "url": "http://patchwork.ozlabs.org/api/patches/1585796/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20220128153009.2467560-27-peter.maydell@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20220128153009.2467560-27-peter.maydell@linaro.org>", "list_archive_url": null, "date": "2022-01-28T15:30:03", "name": "[PULL,26/32] hw/intc/arm_gicv3_its: Provide read accessor for translation_ops", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "c0b12853f0c8c0cfd6af80f5fb09f86326e1a37c", "submitter": { "id": 5111, "url": "http://patchwork.ozlabs.org/api/people/5111/?format=api", "name": "Peter Maydell", "email": "peter.maydell@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20220128153009.2467560-27-peter.maydell@linaro.org/mbox/", "series": [ { "id": 283405, "url": "http://patchwork.ozlabs.org/api/series/283405/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=283405", "date": "2022-01-28T15:29:53", "name": "[PULL,01/32] Update copyright dates to 2022", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/283405/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1585796/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1585796/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=ETbcbFbD;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=<UNKNOWN>)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4Jljk14S9Pz9t3b\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 29 Jan 2022 03:35:20 +1100 (AEDT)", "from localhost ([::1]:34404 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1nDUDU-0004sc-UA\n\tfor incoming@patchwork.ozlabs.org; Fri, 28 Jan 2022 11:35:16 -0500", "from eggs.gnu.org ([209.51.188.92]:58036)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>)\n id 1nDTDM-0002Fn-Op\n for qemu-devel@nongnu.org; Fri, 28 Jan 2022 10:31:06 -0500", "from [2a00:1450:4864:20::42e] (port=45766\n helo=mail-wr1-x42e.google.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>)\n id 1nDTDK-0006Qh-4C\n for qemu-devel@nongnu.org; Fri, 28 Jan 2022 10:31:04 -0500", "by mail-wr1-x42e.google.com with SMTP id m14so11326515wrg.12\n for <qemu-devel@nongnu.org>; Fri, 28 Jan 2022 07:30:39 -0800 (PST)", "from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2])\n by smtp.gmail.com with ESMTPSA id j3sm4749485wrb.57.2022.01.28.07.30.38\n for <qemu-devel@nongnu.org>\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 28 Jan 2022 07:30:38 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n h=from:to:subject:date:message-id:in-reply-to:references:mime-version\n :content-transfer-encoding;\n bh=CQsAv8YABOqsexB08r7aY1gbvaVxjjzw44jl1Mp+yhE=;\n b=ETbcbFbDVduTUsqI3F+WtAj5h/E6ARRhYYa9oRVA41FiiNHGsG9/NPOpy5OqeY0R1S\n YfGqxzN8CZekYO6EUlecIocb0ZZIZU6qCh0iS+9ho/ppSNX43a/yXtsCkPtnXnKwo40O\n YGAjKRmrlzhh4aPXtY7/bPUdANNmBZs9WyHiz1VmQGXEkuXcIim4JFSfYNTpFmYp85JO\n m8rfGEuAHtGbdHowBIPsbWKKvWHBPnB9s0Yzys6qEgPPnKhRzxk4Ma4wXkR/JqCK7T/I\n AsP/ak5gB+06jRalQAXaOp5ppxaSblJWqqtcMTR14Qa6Z5+loNZrnARaW0puBGwQVZZU\n IQ6Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=CQsAv8YABOqsexB08r7aY1gbvaVxjjzw44jl1Mp+yhE=;\n b=gXI69fwU5sexdhhbTRrl9GBVzn3zkXc6SvUGN/e6vVZUj1bAZWqzIDgUNtArVuEqK8\n nttPpehmmLeAdfWDZCrXOwMArg3tddP42CNGQ8OWkGL5lzqSvc+mmdgwq4ip1OJrT8oH\n a1OAJ1P9r5KGkeKnKvLbNeNpQ8HJ0tK3oojFCgjDJL8PPjYrNXo3C7B/YW94yfnihYCe\n LQFSxXMNRX96TtOFtjXW7TMlZjzNqILwz7Uewt9ARuFJ8ECDm9V5G3Jod7FvUqn449YR\n WCoCChnA+ec02jkBzcHOQUrEQcUelDYKx8An+Rmw8K9VTTIdKK+SDc8mdmlu9MK+sl3s\n e8VA==", "X-Gm-Message-State": "AOAM531XmOMvWsH3/U7MvZ6s6/8gPit8E8RfJT+8N0SZnl+dj9wqLZnZ\n T6BTPwGVZfTUZnm7oiMfY3tcpz9OmiOADA==", "X-Google-Smtp-Source": "\n ABdhPJyrK9CF0Jwavho+ahcX55hps7/3ZIzquLk1j74wCy/MaK44e+j7gVkp4wyS8Ki++grQR6pSOg==", "X-Received": "by 2002:adf:e54e:: with SMTP id z14mr7624061wrm.490.1643383838803;\n Fri, 28 Jan 2022 07:30:38 -0800 (PST)", "From": "Peter Maydell <peter.maydell@linaro.org>", "To": "qemu-devel@nongnu.org", "Subject": "[PULL 26/32] hw/intc/arm_gicv3_its: Provide read accessor for\n translation_ops", "Date": "Fri, 28 Jan 2022 15:30:03 +0000", "Message-Id": "<20220128153009.2467560-27-peter.maydell@linaro.org>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220128153009.2467560-1-peter.maydell@linaro.org>", "References": "<20220128153009.2467560-1-peter.maydell@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Host-Lookup-Failed": "Reverse DNS lookup failed for 2a00:1450:4864:20::42e\n (failed)", "Received-SPF": "pass client-ip=2a00:1450:4864:20::42e;\n envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42e.google.com", "X-Spam_score_int": "-12", "X-Spam_score": "-1.3", "X-Spam_bar": "-", "X-Spam_report": "(-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001,\n T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "The MemoryRegionOps gicv3_its_translation_ops currently provides only\na .write_with_attrs function, because the only register in this\nregion is the write-only GITS_TRANSLATER. However, if you don't\nprovide a read function and the guest tries reading from this memory\nregion, QEMU will crash because\nmemory_region_read_with_attrs_accessor() calls a NULL pointer.\n\nAdd a read function which always returns 0, to cover both bogus\nattempts to read GITS_TRANSLATER and also reads from the rest of the\nregion, which is documented to be reserved, RES0.\n\nSigned-off-by: Peter Maydell <peter.maydell@linaro.org>\nReviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>\nReviewed-by: Richard Henderson <richard.henderson@linaro.org>\nMessage-id: 20220122182444.724087-11-peter.maydell@linaro.org\n---\n hw/intc/arm_gicv3_its.c | 13 +++++++++++++\n 1 file changed, 13 insertions(+)", "diff": "diff --git a/hw/intc/arm_gicv3_its.c b/hw/intc/arm_gicv3_its.c\nindex d9ff7b88492..b17f2631269 100644\n--- a/hw/intc/arm_gicv3_its.c\n+++ b/hw/intc/arm_gicv3_its.c\n@@ -813,6 +813,18 @@ static void extract_cmdq_params(GICv3ITSState *s)\n }\n }\n \n+static MemTxResult gicv3_its_translation_read(void *opaque, hwaddr offset,\n+ uint64_t *data, unsigned size,\n+ MemTxAttrs attrs)\n+{\n+ /*\n+ * GITS_TRANSLATER is write-only, and all other addresses\n+ * in the interrupt translation space frame are RES0.\n+ */\n+ *data = 0;\n+ return MEMTX_OK;\n+}\n+\n static MemTxResult gicv3_its_translation_write(void *opaque, hwaddr offset,\n uint64_t data, unsigned size,\n MemTxAttrs attrs)\n@@ -1168,6 +1180,7 @@ static const MemoryRegionOps gicv3_its_control_ops = {\n };\n \n static const MemoryRegionOps gicv3_its_translation_ops = {\n+ .read_with_attrs = gicv3_its_translation_read,\n .write_with_attrs = gicv3_its_translation_write,\n .valid.min_access_size = 2,\n .valid.max_access_size = 4,\n", "prefixes": [ "PULL", "26/32" ] }