Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1585740/?format=api
{ "id": 1585740, "url": "http://patchwork.ozlabs.org/api/patches/1585740/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20220128153009.2467560-33-peter.maydell@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20220128153009.2467560-33-peter.maydell@linaro.org>", "list_archive_url": null, "date": "2022-01-28T15:30:09", "name": "[PULL,32/32] target/arm: Use correct entrypoint for SVC taken from Hyp to Hyp", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "f0cec754f5d80254a3bb7ee626e48ddbb276970e", "submitter": { "id": 5111, "url": "http://patchwork.ozlabs.org/api/people/5111/?format=api", "name": "Peter Maydell", "email": "peter.maydell@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20220128153009.2467560-33-peter.maydell@linaro.org/mbox/", "series": [ { "id": 283405, "url": "http://patchwork.ozlabs.org/api/series/283405/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=283405", "date": "2022-01-28T15:29:53", "name": "[PULL,01/32] Update copyright dates to 2022", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/283405/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1585740/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1585740/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=NadRFUSH;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=<UNKNOWN>)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4JlhlD3GJbz9t56\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 29 Jan 2022 02:51:20 +1100 (AEDT)", "from localhost ([::1]:59350 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1nDTWw-0004dG-8F\n\tfor incoming@patchwork.ozlabs.org; Fri, 28 Jan 2022 10:51:18 -0500", "from eggs.gnu.org ([209.51.188.92]:57886)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>)\n id 1nDTDG-0002BC-TO\n for qemu-devel@nongnu.org; Fri, 28 Jan 2022 10:30:59 -0500", "from [2a00:1450:4864:20::330] (port=56155\n helo=mail-wm1-x330.google.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>)\n id 1nDTD9-0006RS-Vs\n for qemu-devel@nongnu.org; Fri, 28 Jan 2022 10:30:57 -0500", "by mail-wm1-x330.google.com with SMTP id r7so4663927wmq.5\n for <qemu-devel@nongnu.org>; Fri, 28 Jan 2022 07:30:44 -0800 (PST)", "from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2])\n by smtp.gmail.com with ESMTPSA id j3sm4749485wrb.57.2022.01.28.07.30.42\n for <qemu-devel@nongnu.org>\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 28 Jan 2022 07:30:42 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n h=from:to:subject:date:message-id:in-reply-to:references:mime-version\n :content-transfer-encoding;\n bh=fRHZFbTPE9xEcVHdaUtARyBl4Hsz+piH6aYCgikS9YI=;\n b=NadRFUSHS9fifjj64sye69XI+DZW2TGDfqWiAYi0IQzxsTjGzRH+nJGfwXulHNbb6F\n MXKIyIxzXuOJ5lNI8P59dGC4gqb8rwSklkFpJ54zq0Ep6ZCpB3bJoVFtPBvOKKWlcAV3\n 3yN6Q7G11NemsnALedRkzQ7nSLO3qXSWka0TQNYZonQsrpnD8XA4Vdlv5t2HmTdOfr+d\n 121qa1+muJfQSHVtT6z5+sFW01GXA3TLFhUhDhcyP15rB3r1m1thzn/pTzhUxXZf4CiH\n o47KF8dDtjWjpgx3M5/0YXT2m8C2y8bZtIbMZlYORLCrIuRR0AAmfBBpF5vQ1k7bXEsp\n hmuA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=fRHZFbTPE9xEcVHdaUtARyBl4Hsz+piH6aYCgikS9YI=;\n b=M0Y01emNT8TwKbjN5dw3Xq1p1qeHR2BkshQD91LtIGeKxHjWcyB+XnlTURS2xjuO0i\n GfHnMMp2IIQMnzA4nDHs246EIeDwoN5YqOvY36oBtWXtVHsnu5YYsumTWmdTtQcuWDqj\n JOizHx4nc6ZwURE9kAlBuZqXpMyfLo/rL5pDeHHUq1o5op2L6GWsQuZtX9XPXoNvdrl9\n a+TY1AGWX+plNS9dMAPL+Gd5hgEUjADlEkntQWHbjRAHiQkMLAQfj9jzeweGehZnQe4N\n 1jtfgq12nGbCRbschxI/SyqVEniS2wBuSpYmkfdwSwqqZMtakVL/WxByaO2PDADNh7L1\n /WNg==", "X-Gm-Message-State": "AOAM531qd+luzGxh9kT59hm8bi+IqriMnVWZkdVktnZ1D9bDoP3gEikc\n cjqZS3TXA9NISZZYF5ztReviQBpya5jHYQ==", "X-Google-Smtp-Source": "\n ABdhPJzlxIauCod12p1N5E86ZX5h7XwCiZW4gRpXhOFt1KmdRqjFW6Ddd3u412M7H4RXchott28uuw==", "X-Received": "by 2002:a1c:6a14:: with SMTP id\n f20mr16268887wmc.177.1643383843101;\n Fri, 28 Jan 2022 07:30:43 -0800 (PST)", "From": "Peter Maydell <peter.maydell@linaro.org>", "To": "qemu-devel@nongnu.org", "Subject": "[PULL 32/32] target/arm: Use correct entrypoint for SVC taken from\n Hyp to Hyp", "Date": "Fri, 28 Jan 2022 15:30:09 +0000", "Message-Id": "<20220128153009.2467560-33-peter.maydell@linaro.org>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220128153009.2467560-1-peter.maydell@linaro.org>", "References": "<20220128153009.2467560-1-peter.maydell@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Host-Lookup-Failed": "Reverse DNS lookup failed for 2a00:1450:4864:20::330\n (failed)", "Received-SPF": "pass client-ip=2a00:1450:4864:20::330;\n envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x330.google.com", "X-Spam_score_int": "-12", "X-Spam_score": "-1.3", "X-Spam_bar": "-", "X-Spam_report": "(-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001,\n T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "The exception caused by an SVC instruction may be taken to AArch32\nHyp mode for two reasons:\n * HCR.TGE indicates that exceptions from EL0 should trap to EL2\n * we were already in Hyp mode\n\nThe entrypoint in the vector table to be used differs in these two\ncases: for an exception routed to Hyp mode from EL0, we enter at the\ncommon 0x14 \"hyp trap\" entrypoint. For SVC from Hyp mode to Hyp\nmode, we enter at the 0x08 (svc/hvc trap) entrypoint.\nIn the v8A Arm ARM pseudocode this is done in AArch32.TakeSVCException.\n\nQEMU incorrectly routed both of these exceptions to the 0x14\nentrypoint. Correct the entrypoint for SVC from Hyp to Hyp by making\nuse of the existing logic which handles \"normal entrypoint for\nHyp-to-Hyp, otherwise 0x14\" for traps like UNDEF and data/prefetch\naborts (reproduced here since it's outside the visible context\nin the diff for this commit):\n\n if (arm_current_el(env) != 2 && addr < 0x14) {\n addr = 0x14;\n }\n\nSigned-off-by: Peter Maydell <peter.maydell@linaro.org>\nReviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>\nReviewed-by: Richard Henderson <richard.henderson@linaro.org>\nMessage-id: 20220117131953.3936137-1-peter.maydell@linaro.org\n---\n target/arm/helper.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/target/arm/helper.c b/target/arm/helper.c\nindex 4df12394021..6dd241fbef3 100644\n--- a/target/arm/helper.c\n+++ b/target/arm/helper.c\n@@ -9658,7 +9658,7 @@ static void arm_cpu_do_interrupt_aarch32_hyp(CPUState *cs)\n * separately here.\n *\n * The vector table entry used is always the 0x14 Hyp mode entry point,\n- * unless this is an UNDEF/HVC/abort taken from Hyp to Hyp.\n+ * unless this is an UNDEF/SVC/HVC/abort taken from Hyp to Hyp.\n * The offset applied to the preferred return address is always zero\n * (see DDI0487C.a section G1.12.3).\n * PSTATE A/I/F masks are set based only on the SCR.EA/IRQ/FIQ values.\n@@ -9672,7 +9672,7 @@ static void arm_cpu_do_interrupt_aarch32_hyp(CPUState *cs)\n addr = 0x04;\n break;\n case EXCP_SWI:\n- addr = 0x14;\n+ addr = 0x08;\n break;\n case EXCP_BKPT:\n /* Fall through to prefetch abort. */\n", "prefixes": [ "PULL", "32/32" ] }