Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1561699/?format=api
{ "id": 1561699, "url": "http://patchwork.ozlabs.org/api/patches/1561699/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/patch/20211130150013.6610-1-david.marchand@redhat.com/", "project": { "id": 47, "url": "http://patchwork.ozlabs.org/api/projects/47/?format=api", "name": "Open vSwitch", "link_name": "openvswitch", "list_id": "ovs-dev.openvswitch.org", "list_email": "ovs-dev@openvswitch.org", "web_url": "http://openvswitch.org/", "scm_url": "git@github.com:openvswitch/ovs.git", "webscm_url": "https://github.com/openvswitch/ovs", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20211130150013.6610-1-david.marchand@redhat.com>", "list_archive_url": null, "date": "2021-11-30T15:00:10", "name": "[ovs-dev,v3,1/4] system-dpdk: Refactor common logs matching.", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "19b85b3d4c7218dadb7b24b6ba79a00a033e7c9a", "submitter": { "id": 75396, "url": "http://patchwork.ozlabs.org/api/people/75396/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/openvswitch/patch/20211130150013.6610-1-david.marchand@redhat.com/mbox/", "series": [ { "id": 274454, "url": "http://patchwork.ozlabs.org/api/series/274454/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/list/?series=274454", "date": "2021-11-30T15:00:10", "name": "[ovs-dev,v3,1/4] system-dpdk: Refactor common logs matching.", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/274454/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1561699/comments/", "check": "success", "checks": "http://patchwork.ozlabs.org/api/patches/1561699/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<ovs-dev-bounces@openvswitch.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "dev@openvswitch.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "ovs-dev@lists.linuxfoundation.org" ], "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=JxtVz4GO;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=2605:bc80:3010::133; helo=smtp2.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=<UNKNOWN>)", "smtp3.osuosl.org (amavisd-new);\n dkim=pass (1024-bit key) header.d=redhat.com", "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com" ], "Received": [ "from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4J3QR96d8Qz9sRK\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 1 Dec 2021 02:01:41 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp2.osuosl.org (Postfix) with ESMTP id 4B4AC401C4;\n\tTue, 30 Nov 2021 15:01:39 +0000 (UTC)", "from smtp2.osuosl.org ([127.0.0.1])\n\tby localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id OL8wjeukUZBp; Tue, 30 Nov 2021 15:01:37 +0000 (UTC)", "from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56])\n\tby smtp2.osuosl.org (Postfix) with ESMTPS id E504440282;\n\tTue, 30 Nov 2021 15:01:36 +0000 (UTC)", "from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id BAAAEC0012;\n\tTue, 30 Nov 2021 15:01:36 +0000 (UTC)", "from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n by lists.linuxfoundation.org (Postfix) with ESMTP id DD57FC0012\n for <dev@openvswitch.org>; Tue, 30 Nov 2021 15:01:34 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id DA06E60A40\n for <dev@openvswitch.org>; Tue, 30 Nov 2021 15:01:34 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id WeE-mJezLyds for <dev@openvswitch.org>;\n Tue, 30 Nov 2021 15:01:33 +0000 (UTC)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by smtp3.osuosl.org (Postfix) with ESMTPS id A54AC60A3A\n for <dev@openvswitch.org>; Tue, 30 Nov 2021 15:01:33 +0000 (UTC)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-340-4z9pcLIaMte00fuN4PtrNA-1; Tue, 30 Nov 2021 10:01:28 -0500", "from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com\n [10.5.11.23])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 96EA91006AA0;\n Tue, 30 Nov 2021 15:01:27 +0000 (UTC)", "from dmarchan.remote.csb (unknown [10.39.195.207])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 29C7E196E2;\n Tue, 30 Nov 2021 15:00:33 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.8.0", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1638284492;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=eR8u4I5Op5/t4973Kqtj4ligZVC6H7dJQFV238hJQkc=;\n b=JxtVz4GOEYnTsL2A1x0jw5MR7QgA34GqyMqAQmMnwbgAgNOvuvFXrGINefsY6SnQeJO9Kw\n vYBngTHqT6KEPLtQKLZmSJLsU8ElH+Ya3BtCHhMwtXWeEjk26daZLeK5hgBX5I0IFrnnMI\n ITWHQ4vAUlIxmEQQiUeU/ZbIGjo75K4=", "X-MC-Unique": "4z9pcLIaMte00fuN4PtrNA-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@openvswitch.org", "Date": "Tue, 30 Nov 2021 16:00:10 +0100", "Message-Id": "<20211130150013.6610-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.84 on 10.5.11.23", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Cc": "i.maximets@ovn.org, fbl@sysclose.org, maxime.coquelin@redhat.com,\n kumar.amber@intel.com", "Subject": "[ovs-dev] [PATCH v3 1/4] system-dpdk: Refactor common logs matching.", "X-BeenThere": "ovs-dev@openvswitch.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "<ovs-dev.openvswitch.org>", "List-Unsubscribe": "<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>", "List-Archive": "<http://mail.openvswitch.org/pipermail/ovs-dev/>", "List-Post": "<mailto:ovs-dev@openvswitch.org>", "List-Help": "<mailto:ovs-dev-request@openvswitch.org?subject=help>", "List-Subscribe": "<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "ovs-dev-bounces@openvswitch.org", "Sender": "\"dev\" <ovs-dev-bounces@openvswitch.org>" }, "content": "Move EAL logs and commonly ignored logs to a common macro.\nRemove obsolete ones (like i40e [1] and timer [2] logs).\nSet log level for DPDK drivers to error only: the rationale is that we are\nnot testing DPDK drivers in system-dpdk.\nExtend regex on hugepage logs since a check on hugepages availability is\nalready present on OVS side, and as a consequence, we don't care about\nthe warnings on availability for certain hugepage size.\nAdd logs checks for MFEX tests that were missing them.\n\n1: https://git.dpdk.org/dpdk/commit/?id=a075ce2b3e8c\n2: https://git.dpdk.org/dpdk/commit/?id=c1077933d45b\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\nChanges since v2:\n- configured dpdk drivers log level to error,\n- added OVS flow control warning to common list,\n\n---\n tests/system-dpdk-macros.at | 3 ++\n tests/system-dpdk.at | 56 ++++++++++++++++++-------------------\n 2 files changed, 31 insertions(+), 28 deletions(-)", "diff": "diff --git a/tests/system-dpdk-macros.at b/tests/system-dpdk-macros.at\nindex c6708caaf0..ef0e84e939 100644\n--- a/tests/system-dpdk-macros.at\n+++ b/tests/system-dpdk-macros.at\n@@ -58,6 +58,9 @@ m4_define([OVS_DPDK_START],\n dnl Enable DPDK functionality\n AT_CHECK([ovs-vsctl --no-wait set Open_vSwitch . other_config:dpdk-init=true])\n \n+ dnl Change DPDK drivers log levels so that tests only catch errors\n+ AT_CHECK([ovs-vsctl --no-wait set Open_vSwitch . other_config:dpdk-extra=--log-level=pmd.*:error])\n+\n dnl Start ovs-vswitchd.\n AT_CHECK([ovs-vswitchd --detach --no-chdir --pidfile --log-file -vvconn -vofproto_dpif -vunixctl], [0], [stdout], [stderr])\n AT_CAPTURE_FILE([ovs-vswitchd.log])\ndiff --git a/tests/system-dpdk.at b/tests/system-dpdk.at\nindex e0e750fde5..9c8f4bb15a 100644\n--- a/tests/system-dpdk.at\n+++ b/tests/system-dpdk.at\n@@ -3,6 +3,13 @@ m4_define([CONFIGURE_VETH_OFFLOADS],\n \n AT_BANNER([OVS-DPDK unit tests])\n \n+m4_define([SYSTEM_DPDK_ALLOWED_LOGS],[\n+\\@does not exist. The Open vSwitch kernel module is probably not loaded.@d\n+\\@EAL: Invalid NUMA socket, default to 0@d\n+\\@EAL: No \\(available\\|free\\) hugepages reported in hugepages-@d\n+\\@Failed to enable flow control@d\n+])\n+\n dnl --------------------------------------------------------------------------\n dnl Check if EAL init is successful\n AT_SETUP([OVS-DPDK - EAL init])\n@@ -12,10 +19,7 @@ OVS_DPDK_START()\n AT_CHECK([grep \"DPDK Enabled - initializing...\" ovs-vswitchd.log], [], [stdout])\n AT_CHECK([grep \"EAL\" ovs-vswitchd.log], [], [stdout])\n AT_CHECK([grep \"DPDK Enabled - initialized\" ovs-vswitchd.log], [], [stdout])\n-OVS_VSWITCHD_STOP([\"/Global register is changed during/d\n-/EAL: Invalid NUMA socket, default to 0/d\n-/EAL: WARNING: cpu flags constant_tsc=yes nonstop_tsc=no -> using unreliable clock cycles !/d\n-/EAL: No free hugepages reported in hugepages-1048576kB/d\"])\n+OVS_VSWITCHD_STOP(\"[SYSTEM_DPDK_ALLOWED_LOGS]\")\n AT_CLEANUP\n dnl --------------------------------------------------------------------------\n \n@@ -37,12 +41,7 @@ sleep 2\n \n dnl Clean up\n AT_CHECK([ovs-vsctl del-port br10 phy0], [], [stdout], [stderr])\n-OVS_VSWITCHD_STOP(\"/does not exist. The Open vSwitch kernel module is probably not loaded./d\n-/Failed to enable flow control/d\n-/Global register is changed during/d\n-/EAL: WARNING: cpu flags constant_tsc=yes nonstop_tsc=no -> using unreliable clock cycles !/d\n-/EAL: No free hugepages reported in hugepages-1048576kB/d\n-\")\n+OVS_VSWITCHD_STOP(\"[SYSTEM_DPDK_ALLOWED_LOGS]\")\n AT_CLEANUP\n dnl --------------------------------------------------------------------------\n \n@@ -68,13 +67,9 @@ AT_CHECK([grep \"VHOST_CONFIG: $OVS_RUNDIR/dpdkvhostclient0: reconnecting...\" ovs\n \n dnl Clean up\n AT_CHECK([ovs-vsctl del-port br10 dpdkvhostuserclient0], [], [stdout], [stderr])\n-OVS_VSWITCHD_STOP([\"\\@does not exist. The Open vSwitch kernel module is probably not loaded.@d\n-\\@Failed to enable flow control@d\n+OVS_VSWITCHD_STOP(\"m4_join([], [SYSTEM_DPDK_ALLOWED_LOGS], [\n \\@VHOST_CONFIG: failed to connect to $OVS_RUNDIR/dpdkvhostclient0: No such file or directory@d\n-\\@Global register is changed during@d\n-\\@EAL: Invalid NUMA socket, default to 0@d\n-\\@EAL: WARNING: cpu flags constant_tsc=yes nonstop_tsc=no -> using unreliable clock cycles !@d\n-\\@EAL: No free hugepages reported in hugepages-1048576kB@d\"])\n+])\")\n AT_CLEANUP\n dnl --------------------------------------------------------------------------\n \n@@ -144,16 +139,12 @@ pkill -f -x -9 'tail -f /dev/null'\n \n dnl Clean up\n AT_CHECK([ovs-vsctl del-port br10 dpdkvhostuser0], [], [stdout], [stderr])\n-OVS_VSWITCHD_STOP([\"\\@does not exist. The Open vSwitch kernel module is probably not loaded.@d\n-\\@Failed to enable flow control@d\n+OVS_VSWITCHD_STOP(\"m4_join([], [SYSTEM_DPDK_ALLOWED_LOGS], [\n \\@VHOST_CONFIG: recvmsg failed@d\n \\@VHOST_CONFIG: failed to connect to $OVS_RUNDIR/dpdkvhostuser0: No such file or directory@d\n-\\@Global register is changed during@d\n \\@dpdkvhostuser ports are considered deprecated; please migrate to dpdkvhostuserclient ports.@d\n \\@failed to enumerate system datapaths: No such file or directory@d\n-\\@EAL: Invalid NUMA socket, default to 0@d\n-\\@EAL: WARNING: cpu flags constant_tsc=yes nonstop_tsc=no -> using unreliable clock cycles !@d\n-\\@EAL: No free hugepages reported in hugepages-1048576kB@d\"])\n+])\")\n AT_CLEANUP\n dnl --------------------------------------------------------------------------\n \n@@ -220,16 +211,12 @@ pkill -f -x -9 'tail -f /dev/null'\n \n dnl Clean up\n AT_CHECK([ovs-vsctl del-port br10 dpdkvhostuserclient0], [], [stdout], [stderr])\n-OVS_VSWITCHD_STOP([\"\\@does not exist. The Open vSwitch kernel module is probably not loaded.@d\n-\\@Failed to enable flow control@d\n+OVS_VSWITCHD_STOP(\"m4_join([], [SYSTEM_DPDK_ALLOWED_LOGS], [\n \\@VHOST_CONFIG: recvmsg failed@d\n \\@VHOST_CONFIG: failed to connect to $OVS_RUNDIR/dpdkvhostclient0: No such file or directory@d\n-\\@Global register is changed during@d\n \\@dpdkvhostuser ports are considered deprecated; please migrate to dpdkvhostuserclient ports.@d\n \\@failed to enumerate system datapaths: No such file or directory@d\n-\\@EAL: Invalid NUMA socket, default to 0@d\n-\\@EAL: WARNING: cpu flags constant_tsc=yes nonstop_tsc=no -> using unreliable clock cycles !@d\n-\\@EAL: No free hugepages reported in hugepages-1048576kB@d\"])\n+])\")\n AT_CLEANUP\n dnl --------------------------------------------------------------------------\n \n@@ -256,6 +243,7 @@ OVS_WAIT_UNTIL([test `ovs-vsctl get interface p1 statistics | grep -oP 'rx_packe\n \n dnl Clean up\n AT_CHECK([ovs-vsctl del-port br0 p1], [], [stdout], [stderr])\n+OVS_VSWITCHD_STOP(\"[SYSTEM_DPDK_ALLOWED_LOGS]\")\n AT_CLEANUP\n dnl --------------------------------------------------------------------------\n \n@@ -283,6 +271,7 @@ OVS_WAIT_UNTIL([test `ovs-vsctl get interface p1 statistics | grep -oP 'rx_packe\n \n dnl Clean up\n AT_CHECK([ovs-vsctl del-port br0 p1], [], [stdout], [stderr])\n+OVS_VSWITCHD_STOP(\"[SYSTEM_DPDK_ALLOWED_LOGS]\")\n AT_CLEANUP\n dnl --------------------------------------------------------------------------\n \n@@ -390,5 +379,16 @@ ovs-appctl: ovs-vswitchd: server returned an error\n \n dnl Clean up\n AT_CHECK([ovs-vsctl del-port br0 p1], [], [stdout], [stderr])\n+OVS_VSWITCHD_STOP(\"m4_join([], [SYSTEM_DPDK_ALLOWED_LOGS], [\n+\\@Error: unknown argument 1.@d\n+\\@Error: invalid study_pkt_cnt value: xyz.@d\n+\\@Error: unknown argument abcd.@d\n+\\@Error: -pmd option requires a thread id argument.@d\n+\\@Error: invalid study_pkt_cnt value: abcd.@d\n+\\@Error: miniflow extract parser not changed, PMD thread passed is not valid: 'zero'. Pass a valid pmd thread ID.@d\n+\\@Error: no miniflow extract name provided. Output of miniflow-parser-get shows implementation list.@d\n+\\@Error: unknown miniflow extract implementation superstudy.@d\n+\\@Error: invalid study_pkt_cnt value: -pmd.@d\n+])\")\n AT_CLEANUP dnl\n dnl --------------------------------------------------------------------------\n", "prefixes": [ "ovs-dev", "v3", "1/4" ] }