Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1558730/?format=api
{ "id": 1558730, "url": "http://patchwork.ozlabs.org/api/patches/1558730/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20211123180354.615946-16-sjg@chromium.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20211123180354.615946-16-sjg@chromium.org>", "list_archive_url": null, "date": "2021-11-23T18:03:52", "name": "[15/17] binman: cbfs: Refactor the init process", "commit_ref": "3fc20fd8055f59137293e487244d8b3d885bbbe5", "pull_url": null, "state": "accepted", "archived": false, "hash": "9b4320624bb542e257951a55de91d4c46460e31a", "submitter": { "id": 6170, "url": "http://patchwork.ozlabs.org/api/people/6170/?format=api", "name": "Simon Glass", "email": "sjg@chromium.org" }, "delegate": { "id": 3184, "url": "http://patchwork.ozlabs.org/api/users/3184/?format=api", "username": "sjg", "first_name": "Simon", "last_name": "Glass", "email": "sjg@chromium.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20211123180354.615946-16-sjg@chromium.org/mbox/", "series": [ { "id": 273476, "url": "http://patchwork.ozlabs.org/api/series/273476/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=273476", "date": "2021-11-23T18:03:37", "name": "binman: Various tidy-ups and refactors", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/273476/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1558730/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1558730/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=G6F2umTl;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"G6F2umTl\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4HzBtp2hhyz9s1l\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 24 Nov 2021 05:07:30 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 716378378D;\n\tTue, 23 Nov 2021 19:06:21 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id 6C4C98372E; Tue, 23 Nov 2021 19:04:46 +0100 (CET)", "from mail-ot1-x333.google.com (mail-ot1-x333.google.com\n [IPv6:2607:f8b0:4864:20::333])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id ACBD683738\n for <u-boot@lists.denx.de>; Tue, 23 Nov 2021 19:04:31 +0100 (CET)", "by mail-ot1-x333.google.com with SMTP id\n 47-20020a9d0332000000b005798ac20d72so97996otv.9\n for <u-boot@lists.denx.de>; Tue, 23 Nov 2021 10:04:31 -0800 (PST)", "from kiwi.bld.corp.google.com (c-67-190-101-114.hsd1.co.comcast.net.\n [67.190.101.114])\n by smtp.gmail.com with ESMTPSA id c8sm2357514otk.40.2021.11.23.10.04.29\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 23 Nov 2021 10:04:29 -0800 (PST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n SPF_PASS autolearn=ham autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=Y9VzYE0pnuSDx31Rp0mYOLJorMo+5IBVN/bSNB5Y6Cw=;\n b=G6F2umTl9KltJycQqRzK+ahi1AbEFcKg6NCd3IZADV87SG/DVSWXXwtelLhQVVqt3n\n lCkHsziq3a9mVPjqhO8q2/PP2OgWO047BmyYtfKBcIlB3Rz8JpzRxUe8c9ZvF4kr0Drk\n Ku8MJiIA3u+/6EshIUTmDmuACUdo54ej80+ew=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=Y9VzYE0pnuSDx31Rp0mYOLJorMo+5IBVN/bSNB5Y6Cw=;\n b=JQvcJbAosoy1lqSTf+k+x5cF7jZxe3BQ57NI+jYpePyvSntXyzGBZiGAUrIsDHKtlJ\n /AukWUBuxqBOEm8BK/RAsiueNwPDQGgks3A9lXH9nt5wYCzWQFwW7WFC7xKYJA4t2LbG\n VEARb7u6J2VwiKYjrW5/JvF1agtv5Hi+0lTHskf/+yEGTG8rvSdpOhGyaY6FJvEFlxQe\n SWmkjcgfh4OvGEHrw9agjL57KKo0TGFb2sc/OUeB6SnAAvHJOEW+0xdmKBHDELVBGxh2\n zHGlhqGq1ji54Q7VVb4xIDVlOJpyo9/+fu1LuFDJ9qAfEP2AsZwNcUEIn7TJc8jKhY6J\n FtKw==", "X-Gm-Message-State": "AOAM531waqhQRLsfhGfbTw5M9iGHvDmkoyrVJN9ShYqM+URGp5OQrfjq\n NCbSuVvmdL/h7+kvzI1Ncidgq8GSFKf1XA==", "X-Google-Smtp-Source": "\n ABdhPJwiRWan4///iZRvKmLWwiQFz6O7kZfzrqHtUjCanRZKSZ6USivjDyxm/840N/qCryCq5Av20g==", "X-Received": "by 2002:a9d:2608:: with SMTP id a8mr6170972otb.265.1637690669774;\n Tue, 23 Nov 2021 10:04:29 -0800 (PST)", "From": "Simon Glass <sjg@chromium.org>", "To": "U-Boot Mailing List <u-boot@lists.denx.de>", "Cc": "Tom Rini <trini@konsulko.com>, Simon Glass <sjg@chromium.org>,\n Stefan Reinauer <reinauer@chromium.org>", "Subject": "[PATCH 15/17] binman: cbfs: Refactor the init process", "Date": "Tue, 23 Nov 2021 11:03:52 -0700", "Message-Id": "<20211123180354.615946-16-sjg@chromium.org>", "X-Mailer": "git-send-email 2.34.0.rc2.393.gf8c9666880-goog", "In-Reply-To": "<20211123180354.615946-1-sjg@chromium.org>", "References": "<20211123180354.615946-1-sjg@chromium.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.37", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.2 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "Update the constructor to work in the recommended way, where the node\nproperties are read in a separate function. This makes it more similar to\nentry_Section.\n\nSigned-off-by: Simon Glass <sjg@chromium.org>\n---\n\n tools/binman/etype/cbfs.py | 8 ++++++--\n 1 file changed, 6 insertions(+), 2 deletions(-)", "diff": "diff --git a/tools/binman/etype/cbfs.py b/tools/binman/etype/cbfs.py\nindex 873b199a91d..a5120127059 100644\n--- a/tools/binman/etype/cbfs.py\n+++ b/tools/binman/etype/cbfs.py\n@@ -168,12 +168,16 @@ class Entry_cbfs(Entry):\n from binman import state\n \n super().__init__(section, etype, node)\n- self._cbfs_arg = fdt_util.GetString(node, 'cbfs-arch', 'x86')\n self.align_default = None\n self._entries = OrderedDict()\n- self.ReadEntries()\n self.reader = None\n \n+ def ReadNode(self):\n+ \"\"\"Read properties from the atf-fip node\"\"\"\n+ super().ReadNode()\n+ self._cbfs_arg = fdt_util.GetString(self._node, 'cbfs-arch', 'x86')\n+ self.ReadEntries()\n+\n def ReadEntries(self):\n \"\"\"Read the subnodes to find out what should go in this CBFS\"\"\"\n for node in self._node.subnodes:\n", "prefixes": [ "15/17" ] }