Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1558728/?format=api
{ "id": 1558728, "url": "http://patchwork.ozlabs.org/api/patches/1558728/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20211123180354.615946-15-sjg@chromium.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20211123180354.615946-15-sjg@chromium.org>", "list_archive_url": null, "date": "2021-11-23T18:03:51", "name": "[14/17] binman: Use normal entries in cbfs", "commit_ref": "080f859cf180e860ec5f3c8b7940820c5a32b02a", "pull_url": null, "state": "accepted", "archived": false, "hash": "286f2057212f0a6fc2dc77f0adbf44c5a6b90652", "submitter": { "id": 6170, "url": "http://patchwork.ozlabs.org/api/people/6170/?format=api", "name": "Simon Glass", "email": "sjg@chromium.org" }, "delegate": { "id": 3184, "url": "http://patchwork.ozlabs.org/api/users/3184/?format=api", "username": "sjg", "first_name": "Simon", "last_name": "Glass", "email": "sjg@chromium.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20211123180354.615946-15-sjg@chromium.org/mbox/", "series": [ { "id": 273476, "url": "http://patchwork.ozlabs.org/api/series/273476/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=273476", "date": "2021-11-23T18:03:37", "name": "binman: Various tidy-ups and refactors", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/273476/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1558728/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1558728/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=QJE75su7;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"QJE75su7\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4HzBtc5hK1z9s1l\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 24 Nov 2021 05:07:20 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 11CB083788;\n\tTue, 23 Nov 2021 19:06:18 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id 63E6283711; Tue, 23 Nov 2021 19:04:45 +0100 (CET)", "from mail-ot1-x32e.google.com (mail-ot1-x32e.google.com\n [IPv6:2607:f8b0:4864:20::32e])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 9C5C783737\n for <u-boot@lists.denx.de>; Tue, 23 Nov 2021 19:04:30 +0100 (CET)", "by mail-ot1-x32e.google.com with SMTP id\n h16-20020a9d7990000000b0055c7ae44dd2so93155otm.10\n for <u-boot@lists.denx.de>; Tue, 23 Nov 2021 10:04:30 -0800 (PST)", "from kiwi.bld.corp.google.com (c-67-190-101-114.hsd1.co.comcast.net.\n [67.190.101.114])\n by smtp.gmail.com with ESMTPSA id c8sm2357514otk.40.2021.11.23.10.04.27\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 23 Nov 2021 10:04:28 -0800 (PST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n SPF_PASS autolearn=ham autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=0xSQAnZyR9pED84GEF6OtRK8r4KC1u780/gaaOyEqvY=;\n b=QJE75su7mCFAl0aNZMOLe7jhQ8UPm0jQQ5guC4qs+5vDIrTyS2icIA9zGiMNLhf8xW\n eDdjGN3Da0NDotRSElvrJI1w6TLluyZGaLO24YInJvIu+MagG+guqggpubqM6quQ9tm9\n 7MlDNIHoGvxIIr8rLMAGFQ5ZOvI24SGz4xJm4=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=0xSQAnZyR9pED84GEF6OtRK8r4KC1u780/gaaOyEqvY=;\n b=YZqBN9QaEGxSCEVIZdhxHPwZuxx0zgLuYIZrjREnEivej49uSamfAkuSX6CecysDWv\n gI7vBqa2DEjKc/cFxQLjVu2ckehinvk5KRaPmPOAQ3LFG+6n4EznS7B606DuDPfU0BkG\n PCfr2lWpjCMsAw4RhB6pXNW0vvzkVxS+EXA1ITZvtya1dbr/j33uf/RN5w+3N+INXbaQ\n K6gvcnQdzJPBAcjf7ibfkj5rIl5LCixc2Z1gydI3YN9ObRdoMYnWiAIGzm3AbmJKlzQh\n HtKmAzY1RneD6CPrI6seb6D7BtqNLfGQxSHSbjfRCiFLk8lrRzVz/VtGTaL8AUWQOFgl\n MtPA==", "X-Gm-Message-State": "AOAM532sJqsv6SSFXgRcvNX8COqeOTQ4uuv7eMIQQgIzj+M2NMYWFsHh\n kLjrV0A1Tgq77eASJKRsr00AuSmP8ZjCSA==", "X-Google-Smtp-Source": "\n ABdhPJxk68+RrKoWpG7HfZZlUNUS8irvGolZgo7sEeIv5GAwbms8vBX6+VWlTx3crn3HG5lTC0xSvg==", "X-Received": "by 2002:a9d:2949:: with SMTP id d67mr6207481otb.347.1637690668802;\n Tue, 23 Nov 2021 10:04:28 -0800 (PST)", "From": "Simon Glass <sjg@chromium.org>", "To": "U-Boot Mailing List <u-boot@lists.denx.de>", "Cc": "Tom Rini <trini@konsulko.com>,\n\tSimon Glass <sjg@chromium.org>", "Subject": "[PATCH 14/17] binman: Use normal entries in cbfs", "Date": "Tue, 23 Nov 2021 11:03:51 -0700", "Message-Id": "<20211123180354.615946-15-sjg@chromium.org>", "X-Mailer": "git-send-email 2.34.0.rc2.393.gf8c9666880-goog", "In-Reply-To": "<20211123180354.615946-1-sjg@chromium.org>", "References": "<20211123180354.615946-1-sjg@chromium.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.37", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.2 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "This currently uses _cbfs_entries[] to store entries. Since the entries\nare in fact valid etypes, we may as well use the same name as\nentry_Section uses, which is _entries. This allows reusing more of the\ncode there (in a future patch).\n\nSigned-off-by: Simon Glass <sjg@chromium.org>\n---\n\n tools/binman/etype/cbfs.py | 16 ++++++++--------\n 1 file changed, 8 insertions(+), 8 deletions(-)", "diff": "diff --git a/tools/binman/etype/cbfs.py b/tools/binman/etype/cbfs.py\nindex 9e04897d71e..873b199a91d 100644\n--- a/tools/binman/etype/cbfs.py\n+++ b/tools/binman/etype/cbfs.py\n@@ -170,7 +170,7 @@ class Entry_cbfs(Entry):\n super().__init__(section, etype, node)\n self._cbfs_arg = fdt_util.GetString(node, 'cbfs-arch', 'x86')\n self.align_default = None\n- self._cbfs_entries = OrderedDict()\n+ self._entries = OrderedDict()\n self.ReadEntries()\n self.reader = None\n \n@@ -187,7 +187,7 @@ class Entry_cbfs(Entry):\n if entry._cbfs_compress is None:\n self.Raise(\"Invalid compression in '%s': '%s'\" %\n (node.name, compress))\n- self._cbfs_entries[entry._cbfs_name] = entry\n+ self._entries[entry._cbfs_name] = entry\n \n def ObtainContents(self, skip=None):\n arch = cbfs_util.find_arch(self._cbfs_arg)\n@@ -196,7 +196,7 @@ class Entry_cbfs(Entry):\n if self.size is None:\n self.Raise(\"'cbfs' entry must have a size property\")\n cbfs = CbfsWriter(self.size, arch)\n- for entry in self._cbfs_entries.values():\n+ for entry in self._entries.values():\n # First get the input data and put it in a file. If not available,\n # try later.\n if entry != skip and not entry.ObtainContents():\n@@ -230,7 +230,7 @@ class Entry_cbfs(Entry):\n super().SetImagePos(image_pos)\n \n # Now update the entries with info from the CBFS entries\n- for entry in self._cbfs_entries.values():\n+ for entry in self._entries.values():\n cfile = entry._cbfs_file\n entry.size = cfile.data_len\n entry.offset = cfile.calced_cbfs_offset\n@@ -240,7 +240,7 @@ class Entry_cbfs(Entry):\n \n def AddMissingProperties(self, have_image_pos):\n super().AddMissingProperties(have_image_pos)\n- for entry in self._cbfs_entries.values():\n+ for entry in self._entries.values():\n entry.AddMissingProperties(have_image_pos)\n if entry._cbfs_compress:\n state.AddZeroProp(entry._node, 'uncomp-size')\n@@ -252,7 +252,7 @@ class Entry_cbfs(Entry):\n def SetCalculatedProperties(self):\n \"\"\"Set the value of device-tree properties calculated by binman\"\"\"\n super().SetCalculatedProperties()\n- for entry in self._cbfs_entries.values():\n+ for entry in self._entries.values():\n state.SetInt(entry._node, 'offset', entry.offset)\n state.SetInt(entry._node, 'size', entry.size)\n state.SetInt(entry._node, 'image-pos', entry.image_pos)\n@@ -262,11 +262,11 @@ class Entry_cbfs(Entry):\n def ListEntries(self, entries, indent):\n \"\"\"Override this method to list all files in the section\"\"\"\n super().ListEntries(entries, indent)\n- for entry in self._cbfs_entries.values():\n+ for entry in self._entries.values():\n entry.ListEntries(entries, indent + 1)\n \n def GetEntries(self):\n- return self._cbfs_entries\n+ return self._entries\n \n def ReadData(self, decomp=True):\n data = super().ReadData(True)\n", "prefixes": [ "14/17" ] }