Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1558726/?format=api
{ "id": 1558726, "url": "http://patchwork.ozlabs.org/api/patches/1558726/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20211123180354.615946-14-sjg@chromium.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20211123180354.615946-14-sjg@chromium.org>", "list_archive_url": null, "date": "2021-11-23T18:03:50", "name": "[13/17] binman: Move cbfs.ObtainContents() down a bit", "commit_ref": "8cb069ab7467cd4b0a1a4f3fa18ed358c9179557", "pull_url": null, "state": "accepted", "archived": false, "hash": "923da0022b716aafee692ac87bb81fe9a02333a5", "submitter": { "id": 6170, "url": "http://patchwork.ozlabs.org/api/people/6170/?format=api", "name": "Simon Glass", "email": "sjg@chromium.org" }, "delegate": { "id": 3184, "url": "http://patchwork.ozlabs.org/api/users/3184/?format=api", "username": "sjg", "first_name": "Simon", "last_name": "Glass", "email": "sjg@chromium.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20211123180354.615946-14-sjg@chromium.org/mbox/", "series": [ { "id": 273476, "url": "http://patchwork.ozlabs.org/api/series/273476/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=273476", "date": "2021-11-23T18:03:37", "name": "binman: Various tidy-ups and refactors", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/273476/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1558726/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1558726/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=l6rWbMzR;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"l6rWbMzR\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4HzBtP5CZYz9s1l\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 24 Nov 2021 05:07:09 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id C35D683782;\n\tTue, 23 Nov 2021 19:06:11 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id 0A56982F73; Tue, 23 Nov 2021 19:04:43 +0100 (CET)", "from mail-ot1-x32d.google.com (mail-ot1-x32d.google.com\n [IPv6:2607:f8b0:4864:20::32d])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 5992283731\n for <u-boot@lists.denx.de>; Tue, 23 Nov 2021 19:04:29 +0100 (CET)", "by mail-ot1-x32d.google.com with SMTP id\n n104-20020a9d2071000000b005799790cf0bso128185ota.5\n for <u-boot@lists.denx.de>; Tue, 23 Nov 2021 10:04:29 -0800 (PST)", "from kiwi.bld.corp.google.com (c-67-190-101-114.hsd1.co.comcast.net.\n [67.190.101.114])\n by smtp.gmail.com with ESMTPSA id c8sm2357514otk.40.2021.11.23.10.04.27\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 23 Nov 2021 10:04:27 -0800 (PST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n SPF_PASS autolearn=ham autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=eR7/j2h3rTiidpNf8239ku132VsZWXVHnqro9B7CXXc=;\n b=l6rWbMzRyGHwFzhHqSQZflPFEI/aJOEV9tN/WR+zERSWV1NqR2j8kzi3LT+hzqjBhd\n q8gytRhoI5+vujwszt6oUsUaZLhSaIHzfC730gTRkvuPI6SE0Xl8xEwXKUKUmmKP0wAm\n IlGOIrOFy4+glZewywMHLUu7IutFgsRbO3suw=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=eR7/j2h3rTiidpNf8239ku132VsZWXVHnqro9B7CXXc=;\n b=uKkrCteBNHrL+65hZdg2E2XzHPd2kynK0rOkSU2PcrbMwZlErUC+O+hchmJzaChuEx\n mWE6O2D61j+zLEq3rS85/11RIeBUpuptzFExVBg3BkMrkfbfOdtxFxscHUHQHdAPHBPe\n eP5R/8EJ8SQuFVtA6Xkzn4vNFBanYpEZUmCLAZuXHzwLQ0NcnZ2hekGDb10xXWfKb+zG\n BVFc8t80rEOJVvrdzU1fB1sZzyY1Qg5CsOS//vGS7T7mn2ii1phpzAdHIibJuOrohwZx\n rlyRUORHJR00VNW80UOiIjgGD6pN1nl8PuZReNNHpp1Ul4A6HkumPFmKYeUkhTzdmG7y\n ElYQ==", "X-Gm-Message-State": "AOAM5312DzM/uz5IoyM5Xl1YAcvMFjq56hNbxD1/tO4DaTZgGxIfUBBi\n 52+Wo60ypA4u5X9EOX8eodqqMZtANkVUfw==", "X-Google-Smtp-Source": "\n ABdhPJzH3US2JV/0bwu0GS+HQnKYp1btDVlt+gHt9bv5nrHeZfjFS+mxhI3w5rr01h2C/i2SPAfLBQ==", "X-Received": "by 2002:a9d:2d81:: with SMTP id g1mr6362436otb.25.1637690667755;\n Tue, 23 Nov 2021 10:04:27 -0800 (PST)", "From": "Simon Glass <sjg@chromium.org>", "To": "U-Boot Mailing List <u-boot@lists.denx.de>", "Cc": "Tom Rini <trini@konsulko.com>,\n\tSimon Glass <sjg@chromium.org>", "Subject": "[PATCH 13/17] binman: Move cbfs.ObtainContents() down a bit", "Date": "Tue, 23 Nov 2021 11:03:50 -0700", "Message-Id": "<20211123180354.615946-14-sjg@chromium.org>", "X-Mailer": "git-send-email 2.34.0.rc2.393.gf8c9666880-goog", "In-Reply-To": "<20211123180354.615946-1-sjg@chromium.org>", "References": "<20211123180354.615946-1-sjg@chromium.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.37", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.2 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "It is easier to understand this file if reading the entries comes before\nobtaining the contents, since that is the order in which Binman proceeds.\nMove the function down a bit.\n\nSigned-off-by: Simon Glass <sjg@chromium.org>\n---\n\n tools/binman/etype/cbfs.py | 30 +++++++++++++++---------------\n 1 file changed, 15 insertions(+), 15 deletions(-)", "diff": "diff --git a/tools/binman/etype/cbfs.py b/tools/binman/etype/cbfs.py\nindex 0a858b8b849..9e04897d71e 100644\n--- a/tools/binman/etype/cbfs.py\n+++ b/tools/binman/etype/cbfs.py\n@@ -174,6 +174,21 @@ class Entry_cbfs(Entry):\n self.ReadEntries()\n self.reader = None\n \n+ def ReadEntries(self):\n+ \"\"\"Read the subnodes to find out what should go in this CBFS\"\"\"\n+ for node in self._node.subnodes:\n+ entry = Entry.Create(self, node)\n+ entry.ReadNode()\n+ entry._cbfs_name = fdt_util.GetString(node, 'cbfs-name', entry.name)\n+ entry._type = fdt_util.GetString(node, 'cbfs-type')\n+ compress = fdt_util.GetString(node, 'cbfs-compress', 'none')\n+ entry._cbfs_offset = fdt_util.GetInt(node, 'cbfs-offset')\n+ entry._cbfs_compress = cbfs_util.find_compress(compress)\n+ if entry._cbfs_compress is None:\n+ self.Raise(\"Invalid compression in '%s': '%s'\" %\n+ (node.name, compress))\n+ self._cbfs_entries[entry._cbfs_name] = entry\n+\n def ObtainContents(self, skip=None):\n arch = cbfs_util.find_arch(self._cbfs_arg)\n if arch is None:\n@@ -204,21 +219,6 @@ class Entry_cbfs(Entry):\n self.SetContents(data)\n return True\n \n- def ReadEntries(self):\n- \"\"\"Read the subnodes to find out what should go in this CBFS\"\"\"\n- for node in self._node.subnodes:\n- entry = Entry.Create(self, node)\n- entry.ReadNode()\n- entry._cbfs_name = fdt_util.GetString(node, 'cbfs-name', entry.name)\n- entry._type = fdt_util.GetString(node, 'cbfs-type')\n- compress = fdt_util.GetString(node, 'cbfs-compress', 'none')\n- entry._cbfs_offset = fdt_util.GetInt(node, 'cbfs-offset')\n- entry._cbfs_compress = cbfs_util.find_compress(compress)\n- if entry._cbfs_compress is None:\n- self.Raise(\"Invalid compression in '%s': '%s'\" %\n- (node.name, compress))\n- self._cbfs_entries[entry._cbfs_name] = entry\n-\n def SetImagePos(self, image_pos):\n \"\"\"Override this function to set all the entry properties from CBFS\n \n", "prefixes": [ "13/17" ] }