Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1558716/?format=api
{ "id": 1558716, "url": "http://patchwork.ozlabs.org/api/patches/1558716/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20211123180354.615946-10-sjg@chromium.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20211123180354.615946-10-sjg@chromium.org>", "list_archive_url": null, "date": "2021-11-23T18:03:46", "name": "[09/17] binman: Drop the filename property in entry_Section", "commit_ref": "b6caf0ebcabd20499f3171e12bcbee01a0b3d724", "pull_url": null, "state": "accepted", "archived": false, "hash": "630ca945cd4433ae989638f18c09103977a0e10e", "submitter": { "id": 6170, "url": "http://patchwork.ozlabs.org/api/people/6170/?format=api", "name": "Simon Glass", "email": "sjg@chromium.org" }, "delegate": { "id": 3184, "url": "http://patchwork.ozlabs.org/api/users/3184/?format=api", "username": "sjg", "first_name": "Simon", "last_name": "Glass", "email": "sjg@chromium.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20211123180354.615946-10-sjg@chromium.org/mbox/", "series": [ { "id": 273476, "url": "http://patchwork.ozlabs.org/api/series/273476/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=273476", "date": "2021-11-23T18:03:37", "name": "binman: Various tidy-ups and refactors", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/273476/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1558716/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1558716/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=PND5vTf9;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"PND5vTf9\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4HzBs63ZdQz9ssD\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 24 Nov 2021 05:06:02 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id F0CA183723;\n\tTue, 23 Nov 2021 19:05:04 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id 8E65D83753; Tue, 23 Nov 2021 19:04:35 +0100 (CET)", "from mail-oi1-x230.google.com (mail-oi1-x230.google.com\n [IPv6:2607:f8b0:4864:20::230])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 8357883711\n for <u-boot@lists.denx.de>; Tue, 23 Nov 2021 19:04:22 +0100 (CET)", "by mail-oi1-x230.google.com with SMTP id 7so46040751oip.12\n for <u-boot@lists.denx.de>; Tue, 23 Nov 2021 10:04:22 -0800 (PST)", "from kiwi.bld.corp.google.com (c-67-190-101-114.hsd1.co.comcast.net.\n [67.190.101.114])\n by smtp.gmail.com with ESMTPSA id c8sm2357514otk.40.2021.11.23.10.04.20\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 23 Nov 2021 10:04:20 -0800 (PST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n SPF_PASS autolearn=ham autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=ifL+Yhtgy/TxtQD08GJGaXJwHdkZpOtmNj3Kuuwxww8=;\n b=PND5vTf9UqoETnRe4rXygLUx1ESRXfn8qEpSrooZ8kNsOz7lxHNO9zycqewxbFjJbW\n yCEVQe6D77MCg+tkCefWyIAbaCnroZQN8YVInc4+aBkHa1XuKvAIEKBRimmxeFLkbVmc\n 0TvuUpnlHbLS2wr5GVvbMJwGCiJpGN5cvyh/E=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=ifL+Yhtgy/TxtQD08GJGaXJwHdkZpOtmNj3Kuuwxww8=;\n b=ofKEJyxfXU1JN0gIo2tQuwcyUIymKW3i20eKpDWmun/r5zHxYgFER3XtTS/v8uhhuO\n DRB0qiVRMbRkfx1Nx4ynBz3rwBSDIwmZ8nbMTGtq7gw6kP2qLktaEtzWh7xbp80BIOkn\n GM0pokBg20yqmvuu2Y+BgyfiNyWV8sBfMIO+LB+KBuCgOwj66pWJ1RccvUGh2avu0SSa\n X78eMxiX0+2vllXr1irIdxa2hMrmJtkD6YRD0rhT91IFMLtNNkgwsxesz/EH3h5XH5Qw\n V9RGEIjGSuMxyTOlNjUkzprIdXTDi58NPzXVkh4A/huoFdIb5rOcefdtRzJ6TmWxN8uh\n SPbA==", "X-Gm-Message-State": "AOAM531hQaTRMOdDvw87X4+5IM11NtYwEeHiMDxiRPHdwTnNOU5uF8wP\n 9X525nlktmFPtyFJGP6dT7rQECVcMaafBw==", "X-Google-Smtp-Source": "\n ABdhPJzO/0RVKf/rc8P1oF0x1xBee2omvsq1Kw8PNG+MXeBO0k6tINADCxPUVjEjpTNrFpXk4bsbdg==", "X-Received": "by 2002:a05:6808:11c1:: with SMTP id\n p1mr4508054oiv.113.1637690660888;\n Tue, 23 Nov 2021 10:04:20 -0800 (PST)", "From": "Simon Glass <sjg@chromium.org>", "To": "U-Boot Mailing List <u-boot@lists.denx.de>", "Cc": "Tom Rini <trini@konsulko.com>,\n\tSimon Glass <sjg@chromium.org>", "Subject": "[PATCH 09/17] binman: Drop the filename property in entry_Section", "Date": "Tue, 23 Nov 2021 11:03:46 -0700", "Message-Id": "<20211123180354.615946-10-sjg@chromium.org>", "X-Mailer": "git-send-email 2.34.0.rc2.393.gf8c9666880-goog", "In-Reply-To": "<20211123180354.615946-1-sjg@chromium.org>", "References": "<20211123180354.615946-1-sjg@chromium.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.37", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.2 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "This is not used and does nothing. Drop it.\n\nAdd a tweak to avoid reducing the pylint score.\n\nSigned-off-by: Simon Glass <sjg@chromium.org>\n---\n\n tools/binman/etype/section.py | 5 +----\n 1 file changed, 1 insertion(+), 4 deletions(-)", "diff": "diff --git a/tools/binman/etype/section.py b/tools/binman/etype/section.py\nindex 281a228cd0e..952c01de186 100644\n--- a/tools/binman/etype/section.py\n+++ b/tools/binman/etype/section.py\n@@ -81,9 +81,6 @@ class Entry_section(Entry):\n self._skip_at_start = 0\n self._name_prefix = fdt_util.GetString(self._node, 'name-prefix')\n self.align_default = fdt_util.GetInt(self._node, 'align-default', 0)\n- filename = fdt_util.GetString(self._node, 'filename')\n- if filename:\n- self._filename = filename\n \n self.ReadEntries()\n \n@@ -661,7 +658,7 @@ class Entry_section(Entry):\n return data\n \n def ReadChildData(self, child, decomp=True):\n- tout.Debug(\"ReadChildData for child '%s'\" % child.GetPath())\n+ tout.Debug(f\"ReadChildData for child '{child.GetPath()}'\")\n parent_data = self.ReadData(True)\n offset = child.offset - self._skip_at_start\n tout.Debug(\"Extract for child '%s': offset %#x, skip_at_start %#x, result %#x\" %\n", "prefixes": [ "09/17" ] }