Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1558715/?format=api
{ "id": 1558715, "url": "http://patchwork.ozlabs.org/api/patches/1558715/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20211123180354.615946-9-sjg@chromium.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20211123180354.615946-9-sjg@chromium.org>", "list_archive_url": null, "date": "2021-11-23T18:03:45", "name": "[08/17] binman: Drop the underscore in _ReadEntries()", "commit_ref": "1e99bc2923afa9c7a0e17895eec2d152c9187a80", "pull_url": null, "state": "accepted", "archived": false, "hash": "e11624d8faab3bf71554f71a017de1c740ab1cbc", "submitter": { "id": 6170, "url": "http://patchwork.ozlabs.org/api/people/6170/?format=api", "name": "Simon Glass", "email": "sjg@chromium.org" }, "delegate": { "id": 3184, "url": "http://patchwork.ozlabs.org/api/users/3184/?format=api", "username": "sjg", "first_name": "Simon", "last_name": "Glass", "email": "sjg@chromium.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20211123180354.615946-9-sjg@chromium.org/mbox/", "series": [ { "id": 273476, "url": "http://patchwork.ozlabs.org/api/series/273476/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=273476", "date": "2021-11-23T18:03:37", "name": "binman: Various tidy-ups and refactors", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/273476/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1558715/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1558715/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=gf/u5L9S;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"gf/u5L9S\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4HzBrt31zXz9ssD\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 24 Nov 2021 05:05:50 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id CB77C83754;\n\tTue, 23 Nov 2021 19:04:58 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id 8A933836C9; Tue, 23 Nov 2021 19:04:33 +0100 (CET)", "from mail-oi1-x22f.google.com (mail-oi1-x22f.google.com\n [IPv6:2607:f8b0:4864:20::22f])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 9139B83605\n for <u-boot@lists.denx.de>; Tue, 23 Nov 2021 19:04:21 +0100 (CET)", "by mail-oi1-x22f.google.com with SMTP id bf8so46172262oib.6\n for <u-boot@lists.denx.de>; Tue, 23 Nov 2021 10:04:21 -0800 (PST)", "from kiwi.bld.corp.google.com (c-67-190-101-114.hsd1.co.comcast.net.\n [67.190.101.114])\n by smtp.gmail.com with ESMTPSA id c8sm2357514otk.40.2021.11.23.10.04.19\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 23 Nov 2021 10:04:19 -0800 (PST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n SPF_PASS autolearn=ham autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=UYT8hrOx5gasgui7QUs1vfLnUbpcqmUSNEW/QTcj8uU=;\n b=gf/u5L9SljdiiVqI7uXdO9Xif2jBemjbMqKa+lptGCHIrDMD30Xou864/54+fsPwA+\n qz9mZ2jkZwc+19r1zcpAMLiUsUtBaeh0chtBl7VJcJZKtglVjDly+48qmqSmptKV+rdi\n 0xcH+kX/7zMj8LLbVGo9A5ZzfZF4fEHdiQ034=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=UYT8hrOx5gasgui7QUs1vfLnUbpcqmUSNEW/QTcj8uU=;\n b=WO6+7K0rt+GqVp6Im+/wleXgFP7e3aYBiS2dLHRv3CSchC2OTe+YxtWu9LsEdcZHtW\n aqtht4074ppDwUH7bzFTTVZt/4Gwcw+0wInvD+/dPPA3EYsHfPP7jOcAkXfJeyganuce\n B0eMFx2AIz76Jxd6BjrmwNCRoMEfYvCHNOD/yaj/LFE4j2Vj/o0ScN2RDQsd2Y/ls4Mo\n X8qkl0GNfJRDH6lWg6khXZ3gDDLk4MAqblShRZSnMH+63RTXdNAcVyit1SGyEadOzN8x\n GImrWLd3h1ziRIYGAwt1MxZEvPRi9L89m6+O2meFMPu3Z4evBR7Hu5e1UEThXMiOU6B0\n EcqQ==", "X-Gm-Message-State": "AOAM5329sTzzCDSzE9RMpAU//CQPDURCkEBPgZdz8rWkQ8f+EhdrQkJ8\n p/d/vbvqbG7pKZ3Qm7mwPcgMm9oDdKMwWQ==", "X-Google-Smtp-Source": "\n ABdhPJwcVYEcN1RKd9X9wZtQ32PAQHsOBsBBDc15arJ6dMsJi0Mi8/rQjouImtDl3p31jjjuk75r3g==", "X-Received": "by 2002:aca:a88f:: with SMTP id r137mr4216061oie.85.1637690659988;\n Tue, 23 Nov 2021 10:04:19 -0800 (PST)", "From": "Simon Glass <sjg@chromium.org>", "To": "U-Boot Mailing List <u-boot@lists.denx.de>", "Cc": "Tom Rini <trini@konsulko.com>,\n\tSimon Glass <sjg@chromium.org>", "Subject": "[PATCH 08/17] binman: Drop the underscore in _ReadEntries()", "Date": "Tue, 23 Nov 2021 11:03:45 -0700", "Message-Id": "<20211123180354.615946-9-sjg@chromium.org>", "X-Mailer": "git-send-email 2.34.0.rc2.393.gf8c9666880-goog", "In-Reply-To": "<20211123180354.615946-1-sjg@chromium.org>", "References": "<20211123180354.615946-1-sjg@chromium.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.37", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.2 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "This function can be overridden so should not have an underscore. Drop it.\n\nSigned-off-by: Simon Glass <sjg@chromium.org>\n---\n\n tools/binman/etype/blob_phase.py | 2 +-\n tools/binman/etype/cbfs.py | 4 ++--\n tools/binman/etype/files.py | 2 +-\n tools/binman/etype/section.py | 8 ++++----\n 4 files changed, 8 insertions(+), 8 deletions(-)", "diff": "diff --git a/tools/binman/etype/blob_phase.py b/tools/binman/etype/blob_phase.py\nindex 54ca54c50c1..ed25e467a13 100644\n--- a/tools/binman/etype/blob_phase.py\n+++ b/tools/binman/etype/blob_phase.py\n@@ -48,4 +48,4 @@ class Entry_blob_phase(Entry_section):\n subnode = state.AddSubnode(self._node, name)\n \n # Read entries again, now that we have some\n- self._ReadEntries()\n+ self.ReadEntries()\ndiff --git a/tools/binman/etype/cbfs.py b/tools/binman/etype/cbfs.py\nindex 44db7b9bb20..0a858b8b849 100644\n--- a/tools/binman/etype/cbfs.py\n+++ b/tools/binman/etype/cbfs.py\n@@ -171,7 +171,7 @@ class Entry_cbfs(Entry):\n self._cbfs_arg = fdt_util.GetString(node, 'cbfs-arch', 'x86')\n self.align_default = None\n self._cbfs_entries = OrderedDict()\n- self._ReadSubnodes()\n+ self.ReadEntries()\n self.reader = None\n \n def ObtainContents(self, skip=None):\n@@ -204,7 +204,7 @@ class Entry_cbfs(Entry):\n self.SetContents(data)\n return True\n \n- def _ReadSubnodes(self):\n+ def ReadEntries(self):\n \"\"\"Read the subnodes to find out what should go in this CBFS\"\"\"\n for node in self._node.subnodes:\n entry = Entry.Create(self, node)\ndiff --git a/tools/binman/etype/files.py b/tools/binman/etype/files.py\nindex 9b04a496a85..927d0f071df 100644\n--- a/tools/binman/etype/files.py\n+++ b/tools/binman/etype/files.py\n@@ -64,4 +64,4 @@ class Entry_files(Entry_section):\n state.AddInt(subnode, 'align', self._files_align)\n \n # Read entries again, now that we have some\n- self._ReadEntries()\n+ self.ReadEntries()\ndiff --git a/tools/binman/etype/section.py b/tools/binman/etype/section.py\nindex e2949fc9163..281a228cd0e 100644\n--- a/tools/binman/etype/section.py\n+++ b/tools/binman/etype/section.py\n@@ -85,9 +85,9 @@ class Entry_section(Entry):\n if filename:\n self._filename = filename\n \n- self._ReadEntries()\n+ self.ReadEntries()\n \n- def _ReadEntries(self):\n+ def ReadEntries(self):\n for node in self._node.subnodes:\n if node.name.startswith('hash') or node.name.startswith('signature'):\n continue\n@@ -741,5 +741,5 @@ class Entry_section(Entry):\n missing: List of missing properties / entry args, each a string\n \"\"\"\n if not self._ignore_missing:\n- entry.Raise('Missing required properties/entry args: %s' %\n- (', '.join(missing)))\n+ missing = ', '.join(missing)\n+ entry.Raise(f'Missing required properties/entry args: {missing}')\n", "prefixes": [ "08/17" ] }