Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1558713/?format=api
{ "id": 1558713, "url": "http://patchwork.ozlabs.org/api/patches/1558713/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20211123180354.615946-5-sjg@chromium.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20211123180354.615946-5-sjg@chromium.org>", "list_archive_url": null, "date": "2021-11-23T18:03:41", "name": "[04/17] binman: Tidy up style in cmdline", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "0526282d97212bcc24ae1b7270502eeb04904893", "submitter": { "id": 6170, "url": "http://patchwork.ozlabs.org/api/people/6170/?format=api", "name": "Simon Glass", "email": "sjg@chromium.org" }, "delegate": { "id": 3184, "url": "http://patchwork.ozlabs.org/api/users/3184/?format=api", "username": "sjg", "first_name": "Simon", "last_name": "Glass", "email": "sjg@chromium.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20211123180354.615946-5-sjg@chromium.org/mbox/", "series": [ { "id": 273476, "url": "http://patchwork.ozlabs.org/api/series/273476/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=273476", "date": "2021-11-23T18:03:37", "name": "binman: Various tidy-ups and refactors", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/273476/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1558713/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1558713/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=FhiLKrI7;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"FhiLKrI7\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4HzBrh0xMzz9ssD\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 24 Nov 2021 05:05:40 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id C1AF38370D;\n\tTue, 23 Nov 2021 19:04:55 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id 9A476836C9; Tue, 23 Nov 2021 19:04:29 +0100 (CET)", "from mail-oo1-xc2c.google.com (mail-oo1-xc2c.google.com\n [IPv6:2607:f8b0:4864:20::c2c])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id CD361836AC\n for <u-boot@lists.denx.de>; Tue, 23 Nov 2021 19:04:17 +0100 (CET)", "by mail-oo1-xc2c.google.com with SMTP id\n x1-20020a4aea01000000b002c296d82604so20936ood.9\n for <u-boot@lists.denx.de>; Tue, 23 Nov 2021 10:04:17 -0800 (PST)", "from kiwi.bld.corp.google.com (c-67-190-101-114.hsd1.co.comcast.net.\n [67.190.101.114])\n by smtp.gmail.com with ESMTPSA id c8sm2357514otk.40.2021.11.23.10.04.15\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 23 Nov 2021 10:04:15 -0800 (PST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n SPF_PASS autolearn=ham autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=+qQrtmT0Oh4dloSu1kpUNs/bpigTI1ukY2Hwd/fu8wg=;\n b=FhiLKrI7NYt3mSxvId0yOhIgkRlN0HVRc/7rxLO0panoR1TZb3XWCKjUj7KUTQJ3ak\n AcwnurDjsCVRE8iQIKMu0LrQnIL2Z7YC2kM5K3iO7S1CMq47Ms8v8+mGqsgigZYBqaG2\n 1aBXlF3DJT3Jcni6Cwjx/hnwTkTFW6/ihLKko=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=+qQrtmT0Oh4dloSu1kpUNs/bpigTI1ukY2Hwd/fu8wg=;\n b=1t3AROY7/VR/DyGsFCE8KHdu3307VgeUZYpTCsCLjAdJkxV4HL+lSjCqwDk+35Ezte\n nWPivOYvoVT18cukNtx7fkfhnXFY+a689//xnk3aMJWj5sKfaJw6YUSMNnG9zYH85kwv\n gZOgmqj5uImzNXGe3xgssf0Fw68Bh8sNoUPrJJ8DzBcxVpAQ4SECDmFnou8kpPQHXFaN\n /VcF84hSO5yUgpvnwFG1x93dYKYT/NvKy0ZiyNvG/QdDsZQ/Xi4Xr3O32Q7DTjMGHu6U\n +N1U7Nisy2CiLnjPi+UpXZ4aPOku9mwwwQpKS8trDJQASbkaDS8XQzLCRPhMl+2SB2Kc\n WL5w==", "X-Gm-Message-State": "AOAM530qdDwDERwUwVoTYfVZxlR8DBfBSDaF8L+JujsaV5hloFvzq1ZB\n vUWCe0dqsPB6Jr5nm01Ae6+p7hygjP5Ntg==", "X-Google-Smtp-Source": "\n ABdhPJz6rqf0X3L7cVkto60dUOeKs0WqGelKArZsNlMlzRI3TzAC+AbL7gSUNvgYTLK7CBiqqClRyg==", "X-Received": "by 2002:a4a:dec8:: with SMTP id w8mr4397345oou.24.1637690656215;\n Tue, 23 Nov 2021 10:04:16 -0800 (PST)", "From": "Simon Glass <sjg@chromium.org>", "To": "U-Boot Mailing List <u-boot@lists.denx.de>", "Cc": "Tom Rini <trini@konsulko.com>,\n\tSimon Glass <sjg@chromium.org>", "Subject": "[PATCH 04/17] binman: Tidy up style in cmdline", "Date": "Tue, 23 Nov 2021 11:03:41 -0700", "Message-Id": "<20211123180354.615946-5-sjg@chromium.org>", "X-Mailer": "git-send-email 2.34.0.rc2.393.gf8c9666880-goog", "In-Reply-To": "<20211123180354.615946-1-sjg@chromium.org>", "References": "<20211123180354.615946-1-sjg@chromium.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.37", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.2 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "Update this file to improve the pylint score a little. The remaining item\nis:\n\n Function name \"ParseArgs\" doesn't conform to snake_case naming style\n\nwhich needs some binman-wide renaming.\n\nSigned-off-by: Simon Glass <sjg@chromium.org>\n---\n\n scripts/pylint.base | 2 +-\n tools/binman/cmdline.py | 45 ++++++++++++++++++++++++-----------------\n 2 files changed, 28 insertions(+), 19 deletions(-)", "diff": "diff --git a/scripts/pylint.base b/scripts/pylint.base\nindex f4f226799c1..4e82dd4a616 100644\n--- a/scripts/pylint.base\n+++ b/scripts/pylint.base\n@@ -2,7 +2,7 @@ _testing 0.83\n atf_bl31 -6.00\n binman.cbfs_util 7.70\n binman.cbfs_util_test 9.19\n-binman.cmdline 8.87\n+binman.cmdline 9.06\n binman.control 4.39\n binman.elf 6.42\n binman.elf_test 5.41\ndiff --git a/tools/binman/cmdline.py b/tools/binman/cmdline.py\nindex e73ff780956..14ec95c25be 100644\n--- a/tools/binman/cmdline.py\n+++ b/tools/binman/cmdline.py\n@@ -2,18 +2,38 @@\n # Copyright (c) 2016 Google, Inc\n # Written by Simon Glass <sjg@chromium.org>\n #\n-# Command-line parser for binman\n-#\n+\n+\"\"\"Command-line parser for binman\"\"\"\n \n from argparse import ArgumentParser\n \n+def make_extract_parser(subparsers):\n+ \"\"\"make_extract_parser: Make a subparser for the 'extract' command\n+\n+ Args:\n+ subparsers (ArgumentParser): parser to add this one to\n+ \"\"\"\n+ extract_parser = subparsers.add_parser('extract',\n+ help='Extract files from an image')\n+ extract_parser.add_argument('-i', '--image', type=str, required=True,\n+ help='Image filename to extract')\n+ extract_parser.add_argument('-f', '--filename', type=str,\n+ help='Output filename to write to')\n+ extract_parser.add_argument('-O', '--outdir', type=str, default='',\n+ help='Path to directory to use for output files')\n+ extract_parser.add_argument('paths', type=str, nargs='*',\n+ help='Paths within file to extract (wildcard)')\n+ extract_parser.add_argument('-U', '--uncompressed', action='store_true',\n+ help='Output raw uncompressed data for compressed entries')\n+\n def ParseArgs(argv):\n \"\"\"Parse the binman command-line arguments\n \n Args:\n- argv: List of string arguments\n+ argv (list of str): List of string arguments\n+\n Returns:\n- Tuple (options, args) with the command-line options and arugments.\n+ tuple: (options, args) with the command-line options and arugments.\n options provides access to the options (e.g. option.debug)\n args is a list of string arguments\n \"\"\"\n@@ -74,8 +94,8 @@ controlled by a description in the board device tree.'''\n build_parser.add_argument('--update-fdt-in-elf', type=str,\n help='Update an ELF file with the output dtb: infile,outfile,begin_sym,end_sym')\n \n- entry_parser = subparsers.add_parser('entry-docs',\n- help='Write out entry documentation (see entries.rst)')\n+ subparsers.add_parser(\n+ 'entry-docs', help='Write out entry documentation (see entries.rst)')\n \n list_parser = subparsers.add_parser('ls', help='List files in an image')\n list_parser.add_argument('-i', '--image', type=str, required=True,\n@@ -83,18 +103,7 @@ controlled by a description in the board device tree.'''\n list_parser.add_argument('paths', type=str, nargs='*',\n help='Paths within file to list (wildcard)')\n \n- extract_parser = subparsers.add_parser('extract',\n- help='Extract files from an image')\n- extract_parser.add_argument('-i', '--image', type=str, required=True,\n- help='Image filename to extract')\n- extract_parser.add_argument('-f', '--filename', type=str,\n- help='Output filename to write to')\n- extract_parser.add_argument('-O', '--outdir', type=str, default='',\n- help='Path to directory to use for output files')\n- extract_parser.add_argument('paths', type=str, nargs='*',\n- help='Paths within file to extract (wildcard)')\n- extract_parser.add_argument('-U', '--uncompressed', action='store_true',\n- help='Output raw uncompressed data for compressed entries')\n+ make_extract_parser(subparsers)\n \n replace_parser = subparsers.add_parser('replace',\n help='Replace entries in an image')\n", "prefixes": [ "04/17" ] }