Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1558709/?format=api
{ "id": 1558709, "url": "http://patchwork.ozlabs.org/api/patches/1558709/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20211123180354.615946-8-sjg@chromium.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20211123180354.615946-8-sjg@chromium.org>", "list_archive_url": null, "date": "2021-11-23T18:03:44", "name": "[07/17] binman: Correct comments for ReadChildData()", "commit_ref": "557693ef7edaf66c43e709b33e7c98d7371c083c", "pull_url": null, "state": "accepted", "archived": false, "hash": "d90835ac2a36dfa11455f2898b40d4a6571e2fa3", "submitter": { "id": 6170, "url": "http://patchwork.ozlabs.org/api/people/6170/?format=api", "name": "Simon Glass", "email": "sjg@chromium.org" }, "delegate": { "id": 3184, "url": "http://patchwork.ozlabs.org/api/users/3184/?format=api", "username": "sjg", "first_name": "Simon", "last_name": "Glass", "email": "sjg@chromium.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20211123180354.615946-8-sjg@chromium.org/mbox/", "series": [ { "id": 273476, "url": "http://patchwork.ozlabs.org/api/series/273476/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=273476", "date": "2021-11-23T18:03:37", "name": "binman: Various tidy-ups and refactors", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/273476/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1558709/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1558709/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=BDL6lMCz;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"BDL6lMCz\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4HzBqq44NMz9ssD\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 24 Nov 2021 05:04:55 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id C349183681;\n\tTue, 23 Nov 2021 19:04:38 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id F2B0B83731; Tue, 23 Nov 2021 19:04:25 +0100 (CET)", "from mail-oi1-x229.google.com (mail-oi1-x229.google.com\n [IPv6:2607:f8b0:4864:20::229])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id B65C58370D\n for <u-boot@lists.denx.de>; Tue, 23 Nov 2021 19:04:20 +0100 (CET)", "by mail-oi1-x229.google.com with SMTP id bj13so46209679oib.4\n for <u-boot@lists.denx.de>; Tue, 23 Nov 2021 10:04:20 -0800 (PST)", "from kiwi.bld.corp.google.com (c-67-190-101-114.hsd1.co.comcast.net.\n [67.190.101.114])\n by smtp.gmail.com with ESMTPSA id c8sm2357514otk.40.2021.11.23.10.04.18\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 23 Nov 2021 10:04:18 -0800 (PST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n SPF_PASS autolearn=ham autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=RQYyGpHM9OuMrjF7hJUbxGvCkyYJYsek9D2zNg/1D18=;\n b=BDL6lMCzu/KPFOEIbJx44Wsw4IrPLR/l6cD4MuYWSko2lqkwaU1cg28udx9NvrlcRN\n GLEI9Rbw7p2PdiFbOTHtmatdaDN4PBm+fQA0jZ+ToldahVtf1hLRvtX1B64A0ziwJ7NW\n OZJdL6xoO97VpDyx8H+xkl4R6OfhUAZAVGiRc=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=RQYyGpHM9OuMrjF7hJUbxGvCkyYJYsek9D2zNg/1D18=;\n b=254azQER11e5MecqzNy9m/ewhlZ60RfCO8hZx2WmVZLO3yC8xTublDES+Oe6RPOqI9\n r18P0k/qGg2d9RMKzMypEKqwF09Gzw07uL/3tZbnY1xwn2mZqW4Gads552Al4mUEVTDc\n BNdhtAjpUZ/GLpTXAQ5OEbaNvC2IQLQZSP5T2T77hmUxDHh4NXgSiXT4TxR5G4EO7Jf4\n lfFsSSVJvc5Xf/d2EG56dZ0yXPVy0tTUr8iLWGAp/hHxGcMLzZ8TYvY2Hr9Fci06StW2\n XDZyjX2WXCpEYkfIFmJFG+GsSPjp5eQm1JGJcZt4zLatjt6hToGagQTdFMLrguap/BIA\n P2jg==", "X-Gm-Message-State": "AOAM530ZTHLytUaWrWKIGddsj4zQDlQdDVvuimonpo4LHdfSlidVStoZ\n 52ZILQi0lq3RM0QAlL8mf1vpK3NLHsVPIg==", "X-Google-Smtp-Source": "\n ABdhPJyQmmSraKuokYYytpUThDHL3WPVK/ayKTeuyjD8Eo/mSFqylJYoZwjXy7qet2zmwGvf+sfp3w==", "X-Received": "by 2002:a05:6808:171b:: with SMTP id\n bc27mr4278866oib.21.1637690659038;\n Tue, 23 Nov 2021 10:04:19 -0800 (PST)", "From": "Simon Glass <sjg@chromium.org>", "To": "U-Boot Mailing List <u-boot@lists.denx.de>", "Cc": "Tom Rini <trini@konsulko.com>,\n\tSimon Glass <sjg@chromium.org>", "Subject": "[PATCH 07/17] binman: Correct comments for ReadChildData()", "Date": "Tue, 23 Nov 2021 11:03:44 -0700", "Message-Id": "<20211123180354.615946-8-sjg@chromium.org>", "X-Mailer": "git-send-email 2.34.0.rc2.393.gf8c9666880-goog", "In-Reply-To": "<20211123180354.615946-1-sjg@chromium.org>", "References": "<20211123180354.615946-1-sjg@chromium.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.37", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.2 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "The comment here is incomplete. Fix it.\n\nSigned-off-by: Simon Glass <sjg@chromium.org>\n---\n\n tools/binman/entry.py | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/tools/binman/entry.py b/tools/binman/entry.py\nindex 5e66aa4fa54..2205bc8d923 100644\n--- a/tools/binman/entry.py\n+++ b/tools/binman/entry.py\n@@ -860,7 +860,8 @@ features to produce new behaviours.\n \"\"\"Handle writing the data in a child entry\n \n This should be called on the child's parent section after the child's\n- data has been updated. It\n+ data has been updated. It should update any data structures needed to\n+ validate that the update is successful.\n \n This base-class implementation does nothing, since the base Entry object\n does not have any children.\n@@ -870,7 +871,7 @@ features to produce new behaviours.\n \n Returns:\n True if the section could be updated successfully, False if the\n- data is such that the section could not updat\n+ data is such that the section could not update\n \"\"\"\n return True\n \n", "prefixes": [ "07/17" ] }