Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1558707/?format=api
{ "id": 1558707, "url": "http://patchwork.ozlabs.org/api/patches/1558707/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20211123180354.615946-3-sjg@chromium.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20211123180354.615946-3-sjg@chromium.org>", "list_archive_url": null, "date": "2021-11-23T18:03:39", "name": "[02/17] dtoc: Add support for reading 64-bit ints", "commit_ref": "d866e6291739de3da9550f2280574e1c44474dc3", "pull_url": null, "state": "accepted", "archived": false, "hash": "f367210a9bd57cc9a178c8d9b68a3efeca1f43c2", "submitter": { "id": 6170, "url": "http://patchwork.ozlabs.org/api/people/6170/?format=api", "name": "Simon Glass", "email": "sjg@chromium.org" }, "delegate": { "id": 3184, "url": "http://patchwork.ozlabs.org/api/users/3184/?format=api", "username": "sjg", "first_name": "Simon", "last_name": "Glass", "email": "sjg@chromium.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20211123180354.615946-3-sjg@chromium.org/mbox/", "series": [ { "id": 273476, "url": "http://patchwork.ozlabs.org/api/series/273476/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=273476", "date": "2021-11-23T18:03:37", "name": "binman: Various tidy-ups and refactors", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/273476/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1558707/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1558707/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=KD5cILhH;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"KD5cILhH\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4HzBqM3zTQz9ssD\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 24 Nov 2021 05:04:31 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id D8EC983720;\n\tTue, 23 Nov 2021 19:04:24 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id 4F0448020E; Tue, 23 Nov 2021 19:04:21 +0100 (CET)", "from mail-ot1-x32b.google.com (mail-ot1-x32b.google.com\n [IPv6:2607:f8b0:4864:20::32b])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 14E0C83605\n for <u-boot@lists.denx.de>; Tue, 23 Nov 2021 19:04:16 +0100 (CET)", "by mail-ot1-x32b.google.com with SMTP id\n v15-20020a9d604f000000b0056cdb373b82so115298otj.7\n for <u-boot@lists.denx.de>; Tue, 23 Nov 2021 10:04:15 -0800 (PST)", "from kiwi.bld.corp.google.com (c-67-190-101-114.hsd1.co.comcast.net.\n [67.190.101.114])\n by smtp.gmail.com with ESMTPSA id c8sm2357514otk.40.2021.11.23.10.04.13\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 23 Nov 2021 10:04:13 -0800 (PST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,\n SPF_PASS autolearn=ham autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=JJpHmQQxdf7M7VUwtWnm25bOgY6E06ZKKZufQyzAyIQ=;\n b=KD5cILhHhMuL6Xsrq5Zq1gemteqHta008UlMBZCr3QJUySB9aAs8hO8nT3Ccbkef8i\n CLSO9dpCYGTjFGp6Qxe38MzmE6woqA0Tlozr4zLyGeQZfm2LQ4MK+nNTdX3QkionhPUB\n G2xX5jjVTrhgJ7rdQRM60R5Og9GIUMUNeP5yM=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=JJpHmQQxdf7M7VUwtWnm25bOgY6E06ZKKZufQyzAyIQ=;\n b=BEIl1c3CC8EVBYyztSBwO54O+O22PDdUy9oVb4FqVCPawW0gppSaAkWL3tIg72jcjF\n GSPCTVPy19WNZZ3HPddFdNwJJqkt3tY5Ujz8ueuXa5w1SZSLXCwShuRURXRdqWACD95x\n nQGCi0TSenAhai3g4qfttuqe4fF5LLwWg9+fh6xdAhF4bTNzQ4krnaySizLnFZgNudnY\n 52KivD+0/MMDzyVl7Uz4DLIk5DDLznFJJsJP1725bPBIedvGNfo5Xi57ynLNGANn2m+g\n KKOO+ScxSktKkvREECLFy1kbKdaRBXtnImQp059H6HeUWD6jjf2HP+9g8EdcyKZHgra/\n rgUA==", "X-Gm-Message-State": "AOAM533nAN+B86M8R/yrSg/S5XoCAc+taKeH0du1+HN0WJSdVhHqmhxz\n QVkfRul4aosHnmO50/IFVcG2iejh8gKpsQ==", "X-Google-Smtp-Source": "\n ABdhPJzVyEPtjFYT2C0fjX/VUGhAY3YTPNucDJFFJLzrycf99yDGnyyl29lEdmVa83FuQDmdXX2atQ==", "X-Received": "by 2002:a9d:6482:: with SMTP id g2mr4080318otl.57.1637690654218;\n Tue, 23 Nov 2021 10:04:14 -0800 (PST)", "From": "Simon Glass <sjg@chromium.org>", "To": "U-Boot Mailing List <u-boot@lists.denx.de>", "Cc": "Tom Rini <trini@konsulko.com>, Simon Glass <sjg@chromium.org>,\n Walter Lozano <walter.lozano@collabora.com>", "Subject": "[PATCH 02/17] dtoc: Add support for reading 64-bit ints", "Date": "Tue, 23 Nov 2021 11:03:39 -0700", "Message-Id": "<20211123180354.615946-3-sjg@chromium.org>", "X-Mailer": "git-send-email 2.34.0.rc2.393.gf8c9666880-goog", "In-Reply-To": "<20211123180354.615946-1-sjg@chromium.org>", "References": "<20211123180354.615946-1-sjg@chromium.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.37", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.2 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "Add functions to read a 64-bit integer property from the devicetree.\n\nSigned-off-by: Simon Glass <sjg@chromium.org>\n---\n\n tools/dtoc/fdt_util.py | 35 ++++++++++++++++++++++++++++\n tools/dtoc/test/dtoc_test_simple.dts | 1 +\n tools/dtoc/test_dtoc.py | 2 ++\n tools/dtoc/test_fdt.py | 21 ++++++++++++++---\n 4 files changed, 56 insertions(+), 3 deletions(-)", "diff": "diff --git a/tools/dtoc/fdt_util.py b/tools/dtoc/fdt_util.py\nindex 37e96b98642..51d0eb52423 100644\n--- a/tools/dtoc/fdt_util.py\n+++ b/tools/dtoc/fdt_util.py\n@@ -27,6 +27,18 @@ def fdt32_to_cpu(val):\n \"\"\"\n return struct.unpack('>I', val)[0]\n \n+def fdt64_to_cpu(val):\n+ \"\"\"Convert a device tree cell to an integer\n+\n+ Args:\n+ val (list): Value to convert (list of 2 4-character strings representing\n+ the cell value)\n+\n+ Return:\n+ int: A native-endian integer value\n+ \"\"\"\n+ return fdt32_to_cpu(val[0]) << 32 | fdt32_to_cpu(val[1])\n+\n def fdt_cells_to_cpu(val, cells):\n \"\"\"Convert one or two cells to a long integer\n \n@@ -108,6 +120,29 @@ def GetInt(node, propname, default=None):\n value = fdt32_to_cpu(prop.value)\n return value\n \n+def GetInt64(node, propname, default=None):\n+ \"\"\"Get a 64-bit integer from a property\n+\n+ Args:\n+ node (Node): Node object to read from\n+ propname (str): property name to read\n+ default (int): Default value to use if the node/property do not exist\n+\n+ Returns:\n+ int: value read, or default if none\n+\n+ Raises:\n+ ValueError: Property is not of the correct size\n+ \"\"\"\n+ prop = node.props.get(propname)\n+ if not prop:\n+ return default\n+ if not isinstance(prop.value, list) or len(prop.value) != 2:\n+ raise ValueError(\"Node '%s' property '%s' should be a list with 2 items for 64-bit values\" %\n+ (node.name, propname))\n+ value = fdt64_to_cpu(prop.value)\n+ return value\n+\n def GetString(node, propname, default=None):\n \"\"\"Get a string from a property\n \ndiff --git a/tools/dtoc/test/dtoc_test_simple.dts b/tools/dtoc/test/dtoc_test_simple.dts\nindex 5a6fa88d5cc..4c2c70af222 100644\n--- a/tools/dtoc/test/dtoc_test_simple.dts\n+++ b/tools/dtoc/test/dtoc_test_simple.dts\n@@ -16,6 +16,7 @@\n \t\tboolval;\n \t\tmaybe-empty-int = <>;\n \t\tintval = <1>;\n+\t\tint64val = /bits/ 64 <0x123456789abcdef0>;\n \t\tintarray = <2 3 4>;\n \t\tbyteval = [05];\n \t\tbytearray = [06];\ndiff --git a/tools/dtoc/test_dtoc.py b/tools/dtoc/test_dtoc.py\nindex 752061f27a4..ee17b8daf9a 100755\n--- a/tools/dtoc/test_dtoc.py\n+++ b/tools/dtoc/test_dtoc.py\n@@ -296,6 +296,7 @@ struct dtd_sandbox_spl_test {\n \\tbool\\t\\tboolval;\n \\tunsigned char\\tbytearray[3];\n \\tunsigned char\\tbyteval;\n+\\tfdt32_t\\t\\tint64val[2];\n \\tfdt32_t\\t\\tintarray[3];\n \\tfdt32_t\\t\\tintval;\n \\tunsigned char\\tlongbytearray[9];\n@@ -355,6 +356,7 @@ static struct dtd_sandbox_spl_test dtv_spl_test = {\n \\t.boolval\\t\\t= true,\n \\t.bytearray\\t\\t= {0x6, 0x0, 0x0},\n \\t.byteval\\t\\t= 0x5,\n+\\t.int64val\\t\\t= {0x12345678, 0x9abcdef0},\n \\t.intarray\\t\\t= {0x2, 0x3, 0x4},\n \\t.intval\\t\\t\\t= 0x1,\n \\t.longbytearray\\t\\t= {0x9, 0xa, 0xb, 0xc, 0xd, 0xe, 0xf, 0x10,\ndiff --git a/tools/dtoc/test_fdt.py b/tools/dtoc/test_fdt.py\nindex d86fc86187e..21a9a7ca063 100755\n--- a/tools/dtoc/test_fdt.py\n+++ b/tools/dtoc/test_fdt.py\n@@ -24,7 +24,7 @@ sys.path.insert(2, os.path.join(our_path,\n \n from dtoc import fdt\n from dtoc import fdt_util\n-from dtoc.fdt_util import fdt32_to_cpu\n+from dtoc.fdt_util import fdt32_to_cpu, fdt64_to_cpu\n from fdt import Type, BytesToValue\n import libfdt\n from patman import command\n@@ -128,7 +128,7 @@ class TestFdt(unittest.TestCase):\n node = self.dtb.GetNode('/spl-test')\n props = self.dtb.GetProps(node)\n self.assertEqual(['boolval', 'bytearray', 'byteval', 'compatible',\n- 'intarray', 'intval', 'longbytearray',\n+ 'int64val', 'intarray', 'intval', 'longbytearray',\n 'maybe-empty-int', 'notstring', 'stringarray',\n 'stringval', 'u-boot,dm-pre-reloc'],\n sorted(props.keys()))\n@@ -335,6 +335,10 @@ class TestProp(unittest.TestCase):\n self.assertEqual(Type.INT, prop.type)\n self.assertEqual(1, fdt32_to_cpu(prop.value))\n \n+ prop = self._ConvertProp('int64val')\n+ self.assertEqual(Type.INT, prop.type)\n+ self.assertEqual(0x123456789abcdef0, fdt64_to_cpu(prop.value))\n+\n prop = self._ConvertProp('intarray')\n self.assertEqual(Type.INT, prop.type)\n val = [fdt32_to_cpu(val) for val in prop.value]\n@@ -586,10 +590,21 @@ class TestFdtUtil(unittest.TestCase):\n self.assertEqual(3, fdt_util.GetInt(self.node, 'missing', 3))\n \n with self.assertRaises(ValueError) as e:\n- self.assertEqual(3, fdt_util.GetInt(self.node, 'intarray'))\n+ fdt_util.GetInt(self.node, 'intarray')\n self.assertIn(\"property 'intarray' has list value: expecting a single \"\n 'integer', str(e.exception))\n \n+ def testGetInt64(self):\n+ self.assertEqual(0x123456789abcdef0,\n+ fdt_util.GetInt64(self.node, 'int64val'))\n+ self.assertEqual(3, fdt_util.GetInt64(self.node, 'missing', 3))\n+\n+ with self.assertRaises(ValueError) as e:\n+ fdt_util.GetInt64(self.node, 'intarray')\n+ self.assertIn(\n+ \"property 'intarray' should be a list with 2 items for 64-bit values\",\n+ str(e.exception))\n+\n def testGetString(self):\n self.assertEqual('message', fdt_util.GetString(self.node, 'stringval'))\n self.assertEqual('test', fdt_util.GetString(self.node, 'missing',\n", "prefixes": [ "02/17" ] }