Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1558035/?format=api
{ "id": 1558035, "url": "http://patchwork.ozlabs.org/api/patches/1558035/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/patch/20211122112256.2011194-19-amorenoz@redhat.com/", "project": { "id": 47, "url": "http://patchwork.ozlabs.org/api/projects/47/?format=api", "name": "Open vSwitch", "link_name": "openvswitch", "list_id": "ovs-dev.openvswitch.org", "list_email": "ovs-dev@openvswitch.org", "web_url": "http://openvswitch.org/", "scm_url": "git@github.com:openvswitch/ovs.git", "webscm_url": "https://github.com/openvswitch/ovs", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20211122112256.2011194-19-amorenoz@redhat.com>", "list_archive_url": null, "date": "2021-11-22T11:22:56", "name": "[ovs-dev,v1,18/18] python: add unit tests for filtering engine", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "db0ae58904147f345ef3c9fb6179b6c0514b6414", "submitter": { "id": 77477, "url": "http://patchwork.ozlabs.org/api/people/77477/?format=api", "name": "Adrian Moreno", "email": "amorenoz@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/openvswitch/patch/20211122112256.2011194-19-amorenoz@redhat.com/mbox/", "series": [ { "id": 273222, "url": "http://patchwork.ozlabs.org/api/series/273222/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/list/?series=273222", "date": "2021-11-22T11:22:39", "name": "python: add flow parsing library", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/273222/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1558035/comments/", "check": "fail", "checks": "http://patchwork.ozlabs.org/api/patches/1558035/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<ovs-dev-bounces@openvswitch.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "dev@openvswitch.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "ovs-dev@lists.linuxfoundation.org" ], "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Fshkq5YS;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=<UNKNOWN>)", "smtp2.osuosl.org (amavisd-new);\n dkim=pass (1024-bit key) header.d=redhat.com", "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=amorenoz@redhat.com" ], "Received": [ "from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4HyQ0y5k5zz9sX3\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 22 Nov 2021 22:25:06 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 5CB2482DE6;\n\tMon, 22 Nov 2021 11:25:04 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n\tby localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id CTWMAgatjQqE; Mon, 22 Nov 2021 11:25:02 +0000 (UTC)", "from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56])\n\tby smtp1.osuosl.org (Postfix) with ESMTPS id 81EA281CC3;\n\tMon, 22 Nov 2021 11:24:55 +0000 (UTC)", "from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id 75AB9C0043;\n\tMon, 22 Nov 2021 11:24:53 +0000 (UTC)", "from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by lists.linuxfoundation.org (Postfix) with ESMTP id 1F361C003C\n for <dev@openvswitch.org>; Mon, 22 Nov 2021 11:24:52 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id AFAD740402\n for <dev@openvswitch.org>; Mon, 22 Nov 2021 11:23:52 +0000 (UTC)", "from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id 2nxUDOzN4u4B for <dev@openvswitch.org>;\n Mon, 22 Nov 2021 11:23:51 +0000 (UTC)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [216.205.24.124])\n by smtp2.osuosl.org (Postfix) with ESMTPS id 986C0403F0\n for <dev@openvswitch.org>; Mon, 22 Nov 2021 11:23:51 +0000 (UTC)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-517-8pGhYrLgOvKjNkIV9FH7lg-1; Mon, 22 Nov 2021 06:23:49 -0500", "from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com\n [10.5.11.13])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 378D11006AA1\n for <dev@openvswitch.org>; Mon, 22 Nov 2021 11:23:48 +0000 (UTC)", "from amorenoz.users.ipa.redhat.com (unknown [10.2.16.196])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 3D11A60862;\n Mon, 22 Nov 2021 11:23:47 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.8.0", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1637580230;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=bBzwMu/Yqo27weO5wQH/5QZ6kBjQajManOeEhcLkDLI=;\n b=Fshkq5YSCFVd90pKnAHYkJWCFmeVMsyPiu/sUcfUMc4TayPtNNvRhOUb7dcOCS7jqQEzt6\n AzcckcjddthCY2uMBZ6eRsj4/yEoRUelSzJJkqx3/MAFaD/1Im6cojTEyI5REs25W4ZWvH\n Rwqot8E9RCqtppSQHWHuRzffY2IjHYU=", "X-MC-Unique": "8pGhYrLgOvKjNkIV9FH7lg-1", "From": "Adrian Moreno <amorenoz@redhat.com>", "To": "dev@openvswitch.org", "Date": "Mon, 22 Nov 2021 12:22:56 +0100", "Message-Id": "<20211122112256.2011194-19-amorenoz@redhat.com>", "In-Reply-To": "<20211122112256.2011194-1-amorenoz@redhat.com>", "References": "<20211122112256.2011194-1-amorenoz@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.13", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Subject": "[ovs-dev] [PATCH v1 18/18] python: add unit tests for filtering\n\tengine", "X-BeenThere": "ovs-dev@openvswitch.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "<ovs-dev.openvswitch.org>", "List-Unsubscribe": "<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>", "List-Archive": "<http://mail.openvswitch.org/pipermail/ovs-dev/>", "List-Post": "<mailto:ovs-dev@openvswitch.org>", "List-Help": "<mailto:ovs-dev-request@openvswitch.org?subject=help>", "List-Subscribe": "<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "ovs-dev-bounces@openvswitch.org", "Sender": "\"dev\" <ovs-dev-bounces@openvswitch.org>" }, "content": "Signed-off-by: Adrian Moreno <amorenoz@redhat.com>\n---\n python/automake.mk | 3 +-\n python/ovs/tests/test_filter.py | 225 ++++++++++++++++++++++++++++++++\n 2 files changed, 227 insertions(+), 1 deletion(-)\n create mode 100644 python/ovs/tests/test_filter.py", "diff": "diff --git a/python/automake.mk b/python/automake.mk\nindex cb8697b12..56cd9b7dc 100644\n--- a/python/automake.mk\n+++ b/python/automake.mk\n@@ -57,7 +57,8 @@ ovs_tests = \\\n \tpython/ovs/tests/test_kv.py \\\n \tpython/ovs/tests/test_list.py \\\n \tpython/ovs/tests/test_ofp.py \\\n-\tpython/ovs/tests/test_odp.py\n+\tpython/ovs/tests/test_odp.py \\\n+\tpython/ovs/tests/test_filter.py\n \n \n # These python files are used at build time but not runtime,\ndiff --git a/python/ovs/tests/test_filter.py b/python/ovs/tests/test_filter.py\nnew file mode 100644\nindex 000000000..e2aed9d77\n--- /dev/null\n+++ b/python/ovs/tests/test_filter.py\n@@ -0,0 +1,225 @@\n+import pytest\n+\n+from ovs.flows.filter import OFFilter\n+from ovs.flows.ofp import OFPFlowFactory\n+from ovs.flows.odp import ODPFlowFactory\n+\n+\n+ofp_factory = OFPFlowFactory()\n+odp_factory = ODPFlowFactory()\n+\n+\n+@pytest.mark.parametrize(\n+ \"expr,flow,expected,match\",\n+ [\n+ (\n+ \"nw_src=192.168.1.1 && tcp_dst=80\",\n+ ofp_factory.from_string(\n+ \"nw_src=192.168.1.1,tcp_dst=80 actions=drop\"\n+ ),\n+ True,\n+ [\"nw_src\", \"tcp_dst\"],\n+ ),\n+ (\n+ \"nw_src=192.168.1.2 || tcp_dst=80\",\n+ ofp_factory.from_string(\n+ \"nw_src=192.168.1.1,tcp_dst=80 actions=drop\"\n+ ),\n+ True,\n+ [\"nw_src\", \"tcp_dst\"],\n+ ),\n+ (\n+ \"nw_src=192.168.1.1 || tcp_dst=90\",\n+ ofp_factory.from_string(\n+ \"nw_src=192.168.1.1,tcp_dst=80 actions=drop\"\n+ ),\n+ True,\n+ [\"nw_src\", \"tcp_dst\"],\n+ ),\n+ (\n+ \"nw_src=192.168.1.2 && tcp_dst=90\",\n+ ofp_factory.from_string(\n+ \"nw_src=192.168.1.1,tcp_dst=80 actions=drop\"\n+ ),\n+ False,\n+ [\"nw_src\", \"tcp_dst\"],\n+ ),\n+ (\n+ \"nw_src=192.168.1.1\",\n+ ofp_factory.from_string(\n+ \"nw_src=192.168.1.0/24,tcp_dst=80 actions=drop\"\n+ ),\n+ False,\n+ [\"nw_src\"],\n+ ),\n+ (\n+ \"nw_src~=192.168.1.1\",\n+ ofp_factory.from_string(\n+ \"nw_src=192.168.1.0/24,tcp_dst=80 actions=drop\"\n+ ),\n+ True,\n+ [\"nw_src\"],\n+ ),\n+ (\n+ \"nw_src~=192.168.1.1/30\",\n+ ofp_factory.from_string(\n+ \"nw_src=192.168.1.0/24,tcp_dst=80 actions=drop\"\n+ ),\n+ True,\n+ [\"nw_src\"],\n+ ),\n+ (\n+ \"nw_src~=192.168.1.0/16\",\n+ ofp_factory.from_string(\n+ \"nw_src=192.168.1.0/24,tcp_dst=80 actions=drop\"\n+ ),\n+ False,\n+ [\"nw_src\"],\n+ ),\n+ (\n+ \"nw_src~=192.168.1.0/16\",\n+ ofp_factory.from_string(\n+ \"nw_src=192.168.1.0/24,tcp_dst=80 actions=drop\"\n+ ),\n+ False,\n+ [\"nw_src\"],\n+ ),\n+ (\n+ \"n_bytes=100\",\n+ ofp_factory.from_string(\n+ \"n_bytes=100 priority=100,nw_src=192.168.1.0/24,tcp_dst=80 actions=drop\" # noqa: E501\n+ ),\n+ True,\n+ [\"n_bytes\"],\n+ ),\n+ (\n+ \"n_bytes>10\",\n+ ofp_factory.from_string(\n+ \"n_bytes=100 priority=100,nw_src=192.168.1.0/24,tcp_dst=80 actions=drop\" # noqa: E501\n+ ),\n+ True,\n+ [\"n_bytes\"],\n+ ),\n+ (\n+ \"n_bytes>100\",\n+ ofp_factory.from_string(\n+ \"n_bytes=100 priority=100,nw_src=192.168.1.0/24,tcp_dst=80 actions=drop\" # noqa: E501\n+ ),\n+ False,\n+ [\"n_bytes\"],\n+ ),\n+ (\n+ \"n_bytes<100\",\n+ ofp_factory.from_string(\n+ \"n_bytes=100 priority=100,nw_src=192.168.1.0/24,tcp_dst=80 actions=drop\" # noqa: E501\n+ ),\n+ False,\n+ [\"n_bytes\"],\n+ ),\n+ (\n+ \"n_bytes<1000\",\n+ ofp_factory.from_string(\n+ \"n_bytes=100 priority=100,nw_src=192.168.1.0/24,tcp_dst=80 actions=drop\" # noqa: E501\n+ ),\n+ True,\n+ [\"n_bytes\"],\n+ ),\n+ (\n+ \"n_bytes>0 && drop=true\",\n+ ofp_factory.from_string(\n+ \"n_bytes=100 priority=100,nw_src=192.168.1.0/24,tcp_dst=80 actions=drop\" # noqa: E501\n+ ),\n+ True,\n+ [\"n_bytes\", \"drop\"],\n+ ),\n+ (\n+ \"n_bytes>0 && drop=true\",\n+ ofp_factory.from_string(\n+ \"n_bytes=100 priority=100,nw_src=192.168.1.0/24,tcp_dst=80 actions=2\" # noqa: E501\n+ ),\n+ False,\n+ [\"n_bytes\"],\n+ ),\n+ (\n+ \"n_bytes>10 && !output.port=3\",\n+ ofp_factory.from_string(\n+ \"n_bytes=100 priority=100,nw_src=192.168.1.0/24,tcp_dst=80 actions=2\" # noqa: E501\n+ ),\n+ True,\n+ [\"n_bytes\", \"output\"],\n+ ),\n+ (\n+ \"dl_src=00:11:22:33:44:55\",\n+ ofp_factory.from_string(\n+ \"n_bytes=100 priority=100,dl_src=00:11:22:33:44:55,nw_src=192.168.1.0/24,tcp_dst=80 actions=2\" # noqa: E501\n+ ),\n+ True,\n+ [\"dl_src\"],\n+ ),\n+ (\n+ \"dl_src~=00:11:22:33:44:55\",\n+ ofp_factory.from_string(\n+ \"n_bytes=100 priority=100,dl_src=00:11:22:33:44:55/ff:ff:ff:ff:ff:00,nw_src=192.168.1.0/24,tcp_dst=80 actions=2\" # noqa: E501\n+ ),\n+ True,\n+ [\"dl_src\"],\n+ ),\n+ (\n+ \"dl_src~=00:11:22:33:44:66\",\n+ ofp_factory.from_string(\n+ \"n_bytes=100 priority=100,dl_src=00:11:22:33:44:55/ff:ff:ff:ff:ff:00,nw_src=192.168.1.0/24,tcp_dst=80 actions=2\" # noqa: E501\n+ ),\n+ True,\n+ [\"dl_src\"],\n+ ),\n+ (\n+ \"dl_src~=00:11:22:33:44:66 && tp_dst=1000\",\n+ ofp_factory.from_string(\n+ \"n_bytes=100 priority=100,dl_src=00:11:22:33:44:55/ff:ff:ff:ff:ff:00,nw_src=192.168.1.0/24,tp_dst=0x03e8/0xfff8 actions=2\" # noqa: E501\n+ ),\n+ False,\n+ [\"dl_src\", \"tp_dst\"],\n+ ),\n+ (\n+ \"dl_src~=00:11:22:33:44:66 && tp_dst~=1000\",\n+ ofp_factory.from_string(\n+ \"n_bytes=100 priority=100,dl_src=00:11:22:33:44:55/ff:ff:ff:ff:ff:00,nw_src=192.168.1.0/24,tp_dst=0x03e8/0xfff8 actions=2\" # noqa: E501\n+ ),\n+ True,\n+ [\"dl_src\", \"tp_dst\"],\n+ ),\n+ (\n+ \"encap\",\n+ odp_factory.from_string(\n+ \"encap(eth_type(0x0800),ipv4(src=10.76.23.240/255.255.255.248,dst=10.76.23.106,proto=17,tos=0/0,ttl=64,frag=no)) actions:drop\" # noqa: E501\n+ ),\n+ True,\n+ [\"encap\"],\n+ ),\n+ (\n+ \"encap.ipv4.src=10.76.23.240\",\n+ odp_factory.from_string(\n+ \"encap(eth_type(0x0800),ipv4(src=10.76.23.240/255.255.255.248,dst=10.76.23.106,proto=17,tos=0/0,ttl=64,frag=no)) actions:drop\" # noqa: E501\n+ ),\n+ False,\n+ [\"encap\"],\n+ ),\n+ (\n+ \"encap.ipv4.src~=10.76.23.240\",\n+ odp_factory.from_string(\n+ \"encap(eth_type(0x0800),ipv4(src=10.76.23.240/255.255.255.248,dst=10.76.23.106,proto=17,tos=0/0,ttl=64,frag=no)) actions:drop\" # noqa: E501\n+ ),\n+ True,\n+ [\"encap\"],\n+ ),\n+ ],\n+)\n+def test_filter(expr, flow, expected, match):\n+ ffilter = OFFilter(expr)\n+ result = ffilter.evaluate(flow)\n+ if expected:\n+ assert result\n+ else:\n+ assert not result\n+\n+ assert [kv.key for kv in result.kv] == match\n", "prefixes": [ "ovs-dev", "v1", "18/18" ] }