Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1558031/?format=api
{ "id": 1558031, "url": "http://patchwork.ozlabs.org/api/patches/1558031/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/patch/20211122112256.2011194-13-amorenoz@redhat.com/", "project": { "id": 47, "url": "http://patchwork.ozlabs.org/api/projects/47/?format=api", "name": "Open vSwitch", "link_name": "openvswitch", "list_id": "ovs-dev.openvswitch.org", "list_email": "ovs-dev@openvswitch.org", "web_url": "http://openvswitch.org/", "scm_url": "git@github.com:openvswitch/ovs.git", "webscm_url": "https://github.com/openvswitch/ovs", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20211122112256.2011194-13-amorenoz@redhat.com>", "list_archive_url": null, "date": "2021-11-22T11:22:50", "name": "[ovs-dev,v1,12/18] tests: Wrap test-odp to also run python parsers", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "08e0a949d86da4d2e8e7d7ee14c74737bb65d6cb", "submitter": { "id": 77477, "url": "http://patchwork.ozlabs.org/api/people/77477/?format=api", "name": "Adrian Moreno", "email": "amorenoz@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/openvswitch/patch/20211122112256.2011194-13-amorenoz@redhat.com/mbox/", "series": [ { "id": 273222, "url": "http://patchwork.ozlabs.org/api/series/273222/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/list/?series=273222", "date": "2021-11-22T11:22:39", "name": "python: add flow parsing library", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/273222/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1558031/comments/", "check": "fail", "checks": "http://patchwork.ozlabs.org/api/patches/1558031/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<ovs-dev-bounces@openvswitch.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "dev@openvswitch.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "ovs-dev@lists.linuxfoundation.org" ], "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=QpO2L8oD;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=140.211.166.136; helo=smtp3.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=<UNKNOWN>)", "smtp1.osuosl.org (amavisd-new);\n dkim=pass (1024-bit key) header.d=redhat.com", "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=amorenoz@redhat.com" ], "Received": [ "from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4HyQ0c33Ckz9sRR\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 22 Nov 2021 22:24:48 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 7EA4561C93;\n\tMon, 22 Nov 2021 11:24:45 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n\tby localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 3QuSMbqps9kW; Mon, 22 Nov 2021 11:24:41 +0000 (UTC)", "from lists.linuxfoundation.org (lf-lists.osuosl.org\n [IPv6:2605:bc80:3010:104::8cd3:938])\n\tby smtp3.osuosl.org (Postfix) with ESMTPS id 3D49561C72;\n\tMon, 22 Nov 2021 11:24:37 +0000 (UTC)", "from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id C5EBEC001E;\n\tMon, 22 Nov 2021 11:24:35 +0000 (UTC)", "from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by lists.linuxfoundation.org (Postfix) with ESMTP id 07633C003F\n for <dev@openvswitch.org>; Mon, 22 Nov 2021 11:24:34 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 337A081763\n for <dev@openvswitch.org>; Mon, 22 Nov 2021 11:23:50 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id h-4GsaokP9lR for <dev@openvswitch.org>;\n Mon, 22 Nov 2021 11:23:49 +0000 (UTC)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by smtp1.osuosl.org (Postfix) with ESMTPS id D95A480F1E\n for <dev@openvswitch.org>; Mon, 22 Nov 2021 11:23:48 +0000 (UTC)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-421-sYzwQtBSPDuCl7bv4N0m-w-1; Mon, 22 Nov 2021 06:23:39 -0500", "from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com\n [10.5.11.13])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8498410060F2\n for <dev@openvswitch.org>; Mon, 22 Nov 2021 11:23:38 +0000 (UTC)", "from amorenoz.users.ipa.redhat.com (unknown [10.2.16.196])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 0D33E60862;\n Mon, 22 Nov 2021 11:23:35 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.8.0", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1637580227;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=3/1pQ8sm48qk4qgDuRMff41C8c9Vh0o0CLGlcSe3y90=;\n b=QpO2L8oDiAOj2JjDqHwdEbOujfoIgcGcHvMVDTOdapaIdFNhJza4/Mvvjf8em6MfoeWoDZ\n QZ70+Lduv3qwPCVDGo6Tkj1O5aToZ7x6m2KgXk7UJ/oKThs6omlsPeLsAzr++NvLeriNsu\n W/mVqpfOhsCCzROY/2BzOfmHQOZ3V04=", "X-MC-Unique": "sYzwQtBSPDuCl7bv4N0m-w-1", "From": "Adrian Moreno <amorenoz@redhat.com>", "To": "dev@openvswitch.org", "Date": "Mon, 22 Nov 2021 12:22:50 +0100", "Message-Id": "<20211122112256.2011194-13-amorenoz@redhat.com>", "In-Reply-To": "<20211122112256.2011194-1-amorenoz@redhat.com>", "References": "<20211122112256.2011194-1-amorenoz@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.13", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Subject": "[ovs-dev] [PATCH v1 12/18] tests: Wrap test-odp to also run python\n\tparsers", "X-BeenThere": "ovs-dev@openvswitch.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "<ovs-dev.openvswitch.org>", "List-Unsubscribe": "<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>", "List-Archive": "<http://mail.openvswitch.org/pipermail/ovs-dev/>", "List-Post": "<mailto:ovs-dev@openvswitch.org>", "List-Help": "<mailto:ovs-dev-request@openvswitch.org?subject=help>", "List-Subscribe": "<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "ovs-dev-bounces@openvswitch.org", "Sender": "\"dev\" <ovs-dev-bounces@openvswitch.org>" }, "content": "test-odp is used to parse datapath flow actions and matches within the\nodp tests. Wrap calls to this tool in a python script that also parses\nthem using the python flow parsing library.\n\nSigned-off-by: Adrian Moreno <amorenoz@redhat.com>\n---\n tests/automake.mk | 3 +-\n tests/odp.at | 36 ++++++++---------\n tests/ovs-test-dpparse.py | 83 +++++++++++++++++++++++++++++++++++++++\n 3 files changed, 103 insertions(+), 19 deletions(-)\n create mode 100755 tests/ovs-test-dpparse.py", "diff": "diff --git a/tests/automake.mk b/tests/automake.mk\nindex 5dc805ef4..be69f3d16 100644\n--- a/tests/automake.mk\n+++ b/tests/automake.mk\n@@ -21,7 +21,8 @@ EXTRA_DIST += \\\n \t$(srcdir)/package.m4 \\\n \t$(srcdir)/tests/testsuite \\\n \t$(srcdir)/tests/testsuite.patch \\\n-\t$(srcdir)/tests/ovs-test-ofparse.py\n+\t$(srcdir)/tests/ovs-test-ofparse.py \\\n+\t$(srcdir)/tests/ovs-test-dpparse.py\n \n \n COMMON_MACROS_AT = \\\ndiff --git a/tests/odp.at b/tests/odp.at\nindex 07a5cfe39..69e86c5c1 100644\n--- a/tests/odp.at\n+++ b/tests/odp.at\n@@ -105,7 +105,7 @@ sed -i'back' 's/\\(skb_mark(0)\\),\\(ct\\)/\\1,ct_state(0),ct_zone(0),\\2/' odp-out.tx\n sed -i'back' 's/\\(skb_mark([[^)]]*)\\),\\(recirc\\)/\\1,ct_state(0),ct_zone(0),ct_mark(0),ct_label(0),\\2/' odp-out.txt\n sed -i'back' 's/\\(in_port(1)\\),\\(eth\\)/\\1,packet_type(ns=0,id=0),\\2/' odp-out.txt\n \n-AT_CHECK_UNQUOTED([ovstest test-odp parse-keys < odp-in.txt], [0], [`cat odp-out.txt`\n+AT_CHECK_UNQUOTED([ovs-test-dpparse.py ovstest test-odp parse-keys < odp-in.txt], [0], [`cat odp-out.txt`\n ])\n AT_CLEANUP\n \n@@ -192,7 +192,7 @@ sed -n 's/,frag=no),.*/,frag=later)/p' odp-base.txt\n sed 's/^/skb_priority(0),tunnel(tun_id=0xfedcba9876543210,src=10.0.0.1,dst=10.0.0.2,ttl=128,erspan(ver=2,dir=1,hwid=0x7/0xf),flags(df|key)),skb_mark(0),recirc_id(0),dp_hash(0),/' odp-base.txt\n ) > odp.txt\n AT_CAPTURE_FILE([odp.txt])\n-AT_CHECK_UNQUOTED([ovstest test-odp parse-wc-keys < odp.txt], [0], [`cat odp.txt`\n+AT_CHECK_UNQUOTED([ovs-test-dpparse.py ovstest test-odp parse-wc-keys < odp.txt], [0], [`cat odp.txt`\n ])\n AT_CLEANUP\n \n@@ -239,25 +239,25 @@ AT_DATA([odp-tcp6.txt], [dnl\n in_port(1),eth(src=00:01:02:03:04:05,dst=10:11:12:13:14:15),eth_type(0x86dd),ipv6(src=::1/::255,dst=::2/::255,label=0/0xf0,proto=10/0xf0,tclass=0x70/0xf0,hlimit=128/0xf0,frag=no)\n in_port(1),eth(src=00:01:02:03:04:05,dst=10:11:12:13:14:15),eth_type(0x86dd),ipv6(src=::1,dst=::2,label=0,proto=6,tclass=0,hlimit=128,frag=no),tcp(src=80/0xff00,dst=8080/0xff)\n ])\n-AT_CHECK_UNQUOTED([ovstest test-odp parse-filter filter='dl_type=0x1235' < odp-base.txt], [0], [`cat odp-eth-type.txt`\n+AT_CHECK_UNQUOTED([ovs-test-dpparse.py ovstest test-odp parse-filter filter='dl_type=0x1235' < odp-base.txt], [0], [`cat odp-eth-type.txt`\n ])\n-AT_CHECK_UNQUOTED([ovstest test-odp parse-filter filter='dl_vlan=99' < odp-vlan-base.txt], [0], [`cat odp-vlan.txt`\n+AT_CHECK_UNQUOTED([ovs-test-dpparse.py ovstest test-odp parse-filter filter='dl_vlan=99' < odp-vlan-base.txt], [0], [`cat odp-vlan.txt`\n ])\n-AT_CHECK_UNQUOTED([ovstest test-odp parse-filter filter='dl_vlan=99,ip' < odp-vlan-base.txt], [0], [`cat odp-vlan.txt`\n+AT_CHECK_UNQUOTED([ovs-test-dpparse.py ovstest test-odp parse-filter filter='dl_vlan=99,ip' < odp-vlan-base.txt], [0], [`cat odp-vlan.txt`\n ])\n-AT_CHECK_UNQUOTED([ovstest test-odp parse-filter filter='ip,nw_src=35.8.2.199' < odp-base.txt], [0], [`cat odp-ipv4.txt`\n+AT_CHECK_UNQUOTED([ovs-test-dpparse.py ovstest test-odp parse-filter filter='ip,nw_src=35.8.2.199' < odp-base.txt], [0], [`cat odp-ipv4.txt`\n ])\n-AT_CHECK_UNQUOTED([ovstest test-odp parse-filter filter='ip,nw_dst=172.16.0.199' < odp-base.txt], [0], [`cat odp-ipv4.txt`\n+AT_CHECK_UNQUOTED([ovs-test-dpparse.py ovstest test-odp parse-filter filter='ip,nw_dst=172.16.0.199' < odp-base.txt], [0], [`cat odp-ipv4.txt`\n ])\n-AT_CHECK_UNQUOTED([ovstest test-odp parse-filter filter='dl_type=0x0800,nw_src=35.8.2.199,nw_dst=172.16.0.199' < odp-base.txt], [0], [`cat odp-ipv4.txt`\n+AT_CHECK_UNQUOTED([ovs-test-dpparse.py ovstest test-odp parse-filter filter='dl_type=0x0800,nw_src=35.8.2.199,nw_dst=172.16.0.199' < odp-base.txt], [0], [`cat odp-ipv4.txt`\n ])\n-AT_CHECK_UNQUOTED([ovstest test-odp parse-filter filter='icmp,nw_src=35.8.2.199' < odp-base.txt], [0], [`cat odp-icmp.txt`\n+AT_CHECK_UNQUOTED([ovs-test-dpparse.py ovstest test-odp parse-filter filter='icmp,nw_src=35.8.2.199' < odp-base.txt], [0], [`cat odp-icmp.txt`\n ])\n-AT_CHECK_UNQUOTED([ovstest test-odp parse-filter filter='arp,arp_spa=1.2.3.5' < odp-base.txt], [0], [`cat odp-arp.txt`\n+AT_CHECK_UNQUOTED([ovs-test-dpparse.py ovstest test-odp parse-filter filter='arp,arp_spa=1.2.3.5' < odp-base.txt], [0], [`cat odp-arp.txt`\n ])\n-AT_CHECK_UNQUOTED([ovstest test-odp parse-filter filter='tcp,tp_src=90' < odp-base.txt], [0], [`cat odp-tcp.txt`\n+AT_CHECK_UNQUOTED([ovs-test-dpparse.py ovstest test-odp parse-filter filter='tcp,tp_src=90' < odp-base.txt], [0], [`cat odp-tcp.txt`\n ])\n-AT_CHECK_UNQUOTED([ovstest test-odp parse-filter filter='tcp6,tp_src=90' < odp-base.txt], [0], [`cat odp-tcp6.txt`\n+AT_CHECK_UNQUOTED([ovs-test-dpparse.py ovstest test-odp parse-filter filter='tcp6,tp_src=90' < odp-base.txt], [0], [`cat odp-tcp6.txt`\n ])\n AT_CLEANUP\n \n@@ -385,14 +385,14 @@ check_pkt_len(size=200,gt(ct(nat)),le(drop))\n check_pkt_len(size=200,gt(set(eth(src=00:01:02:03:04:05,dst=10:11:12:13:14:15))),le(set(eth(src=00:01:02:03:04:06,dst=10:11:12:13:14:16))))\n lb_output(1)\n ])\n-AT_CHECK_UNQUOTED([ovstest test-odp parse-actions < actions.txt], [0],\n+AT_CHECK_UNQUOTED([ovs-test-dpparse.py ovstest test-odp parse-actions < actions.txt], [0],\n [`cat actions.txt`\n ])\n AT_CLEANUP\n \n AT_SETUP([OVS datapath actions parsing and formatting - invalid forms])\n dnl This caused a hang in older versions.\n-AT_CHECK([echo 'encap_nsh@:{@' | ovstest test-odp parse-actions\n+AT_CHECK([echo 'encap_nsh@:{@' | ovs-test-dpparse.py ovstest test-odp parse-actions\n ], [0], [dnl\n odp_actions_from_string: error\n ])\n@@ -427,7 +427,7 @@ data_invalid=$(printf '%*s' 131018 | tr ' ' \"a\")\n echo \"userspace(pid=1234567,userdata(${data_valid}),tunnel_out_port=10)\" >> actions.txt\n echo \"userspace(pid=1234567,userdata(${data_invalid}),tunnel_out_port=10)\" >> actions.txt\n \n-AT_CHECK_UNQUOTED([ovstest test-odp parse-actions < actions.txt], [0], [dnl\n+AT_CHECK_UNQUOTED([ovs-test-dpparse.py ovstest test-odp parse-actions < actions.txt], [0], [dnl\n `cat actions.txt | head -1`\n odp_actions_from_string: error\n `cat actions.txt | head -3 | tail -1`\n@@ -443,7 +443,7 @@ actions=$(printf 'set(encap()),%.0s' $(seq 8190))\n echo \"${actions}set(encap())\" > actions.txt\n echo \"${actions}set(encap()),set(encap())\" >> actions.txt\n \n-AT_CHECK_UNQUOTED([ovstest test-odp parse-actions < actions.txt], [0], [dnl\n+AT_CHECK_UNQUOTED([ovs-test-dpparse.py ovstest test-odp parse-actions < actions.txt], [0], [dnl\n `cat actions.txt | head -1`\n odp_actions_from_string: error\n ])\n@@ -457,7 +457,7 @@ dnl sequence of keys. 'syntax error' indicates oversized list of keys.\n keys=$(printf 'encap(),%.0s' $(seq 16382))\n echo \"${keys}encap()\" > keys.txt\n echo \"${keys}encap(),encap()\" >> keys.txt\n-AT_CHECK([ovstest test-odp parse-keys < keys.txt | sed 's/encap(),//g'], [0], [dnl\n+AT_CHECK([ovs-test-dpparse.py ovstest test-odp parse-keys < keys.txt | sed 's/encap(),//g'], [0], [dnl\n odp_flow_key_to_flow: error (duplicate encap attribute in flow key; the flow key in error is: encap())\n odp_flow_from_string: error (syntax error at encap())\n ])\n@@ -467,7 +467,7 @@ AT_SETUP([OVS datapath keys parsing and formatting - 33 nested encap ])\n AT_DATA([odp-in.txt], [dnl\n encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap()))))))))))))))))))))))))))))))))\n ])\n-AT_CHECK_UNQUOTED([ovstest test-odp parse-keys < odp-in.txt], [0], [dnl\n+AT_CHECK_UNQUOTED([ovs-test-dpparse.py ovstest test-odp parse-keys < odp-in.txt], [0], [dnl\n odp_flow_from_string: error (syntax error at encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap(encap())))))))))))))))))))))))))))))))))\n ])\n AT_CLEANUP\ndiff --git a/tests/ovs-test-dpparse.py b/tests/ovs-test-dpparse.py\nnew file mode 100755\nindex 000000000..455b6ea22\n--- /dev/null\n+++ b/tests/ovs-test-dpparse.py\n@@ -0,0 +1,83 @@\n+#!/usr/bin/env python3\n+# Copyright (c) 2021 Red Hat, Inc.\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at:\n+#\n+# http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing, software\n+# distributed under the License is distributed on an \"AS IS\" BASIS,\n+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+# See the License for the specific language governing permissions and\n+# limitations under the License.\n+\n+# Breaks lines read from stdin into groups using blank lines as\n+# group separators, then sorts lines within the groups for\n+# reproducibility.\n+\n+\n+# ovs-test-ofparse is just a wrapper around ovs-ofctl\n+# that also runs the python flow parsing utility to check that flows are\n+# parseable\n+\n+import subprocess\n+import sys\n+import re\n+\n+from ovs.flows.odp import ODPFlowFactory\n+\n+diff_regexp = re.compile(r\"\\d{2}: (\\d{2}|\\(none\\)) -> (\\d{2}|\\(none\\))$\")\n+\n+\n+def run(input_data):\n+ p = subprocess.Popen(\n+ sys.argv[1:],\n+ stdin=subprocess.PIPE,\n+ stdout=subprocess.PIPE,\n+ stderr=subprocess.PIPE,\n+ )\n+ out, err = p.communicate(input_data.encode(\"utf-8\"))\n+\n+ print(out.decode(\"utf-8\"), file=sys.stdout, end=\"\")\n+ print(err.decode(\"utf-8\"), file=sys.stderr, end=\"\")\n+ return p.returncode, out, err\n+\n+\n+def main():\n+ return_code = 0\n+ input_data = sys.stdin.read()\n+ return_code, out, err = run(input_data)\n+\n+ if return_code == 0:\n+ flows = list()\n+ for line in input_data.split(\"\\n\"):\n+ if not (\n+ \"error\" in line # skip errors\n+ or line.strip() == \"\" # skip empty lines\n+ or line.strip()[0] == \"#\" # skip comments\n+ ):\n+ flows.append(line)\n+\n+ factory = ODPFlowFactory()\n+ for flow in flows:\n+ if any(\n+ c in sys.argv\n+ for c in [\"parse-keys\", \"parse-wc-keys\", \"parse-filter\"]\n+ ):\n+ # Add actions=drop so that the flow is properly formatted\n+ flow += \" actions:drop\"\n+ elif \"parse-actions\" in sys.argv:\n+ flow = \"actions:\" + flow\n+ try:\n+ _ = factory.from_string(flow)\n+ except Exception as e:\n+ print(e)\n+ return 1\n+\n+ return return_code\n+\n+\n+if __name__ == \"__main__\":\n+ sys.exit(main())\n", "prefixes": [ "ovs-dev", "v1", "12/18" ] }