Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1558022/?format=api
{ "id": 1558022, "url": "http://patchwork.ozlabs.org/api/patches/1558022/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/patch/20211122112256.2011194-6-amorenoz@redhat.com/", "project": { "id": 47, "url": "http://patchwork.ozlabs.org/api/projects/47/?format=api", "name": "Open vSwitch", "link_name": "openvswitch", "list_id": "ovs-dev.openvswitch.org", "list_email": "ovs-dev@openvswitch.org", "web_url": "http://openvswitch.org/", "scm_url": "git@github.com:openvswitch/ovs.git", "webscm_url": "https://github.com/openvswitch/ovs", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20211122112256.2011194-6-amorenoz@redhat.com>", "list_archive_url": null, "date": "2021-11-22T11:22:43", "name": "[ovs-dev,v1,05/18] build-aux: generate ofp field decoders", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "01807579a9b9bb9b8c112293b05a6ce9707ff5e4", "submitter": { "id": 77477, "url": "http://patchwork.ozlabs.org/api/people/77477/?format=api", "name": "Adrian Moreno", "email": "amorenoz@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/openvswitch/patch/20211122112256.2011194-6-amorenoz@redhat.com/mbox/", "series": [ { "id": 273222, "url": "http://patchwork.ozlabs.org/api/series/273222/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/list/?series=273222", "date": "2021-11-22T11:22:39", "name": "python: add flow parsing library", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/273222/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1558022/comments/", "check": "fail", "checks": "http://patchwork.ozlabs.org/api/patches/1558022/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<ovs-dev-bounces@openvswitch.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "dev@openvswitch.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "ovs-dev@lists.linuxfoundation.org" ], "Authentication-Results": [ "bilbo.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=i/Y6MDix;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=140.211.166.138; helo=smtp1.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=<UNKNOWN>)", "smtp2.osuosl.org (amavisd-new);\n dkim=pass (1024-bit key) header.d=redhat.com", "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=amorenoz@redhat.com" ], "Received": [ "from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 4HyPzl0GvXz9sRR\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 22 Nov 2021 22:24:03 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 50A3081831;\n\tMon, 22 Nov 2021 11:24:00 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n\tby localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id hY39PtXSBAkf; Mon, 22 Nov 2021 11:23:59 +0000 (UTC)", "from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56])\n\tby smtp1.osuosl.org (Postfix) with ESMTPS id 955FE817A9;\n\tMon, 22 Nov 2021 11:23:58 +0000 (UTC)", "from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id 7912CC001E;\n\tMon, 22 Nov 2021 11:23:58 +0000 (UTC)", "from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by lists.linuxfoundation.org (Postfix) with ESMTP id A8633C002F\n for <dev@openvswitch.org>; Mon, 22 Nov 2021 11:23:56 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id 3AE41401C5\n for <dev@openvswitch.org>; Mon, 22 Nov 2021 11:23:35 +0000 (UTC)", "from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id F7CVdMO0EudM for <dev@openvswitch.org>;\n Mon, 22 Nov 2021 11:23:32 +0000 (UTC)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [216.205.24.124])\n by smtp2.osuosl.org (Postfix) with ESMTPS id B59734023B\n for <dev@openvswitch.org>; Mon, 22 Nov 2021 11:23:30 +0000 (UTC)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-97-J3hPEHvkMo65EaCQ2xeBgQ-1; Mon, 22 Nov 2021 06:23:28 -0500", "from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com\n [10.5.11.13])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 279AC10168C4\n for <dev@openvswitch.org>; Mon, 22 Nov 2021 11:23:27 +0000 (UTC)", "from amorenoz.users.ipa.redhat.com (unknown [10.2.16.196])\n by smtp.corp.redhat.com (Postfix) with ESMTP id D41C260862;\n Mon, 22 Nov 2021 11:23:13 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.8.0", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1637580209;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=svSobSjKqoQmFs1ek830dxJbqfIAq3MklmwJs+7r6YE=;\n b=i/Y6MDixUjVYD3y+03/mi5pTJ28bu/qf6TTE2FuG/2M1NKP/SSHazb9gGuKnmMhsYbKRsw\n h4G6Q8Va2RmhBsrqY061API36baps68/DXXaw1YGE/asZfexD12WLZ0W+hgKr3dtiHDi9w\n GbEw6GWLFuHF/Ek7uheZVXWKoepHtRY=", "X-MC-Unique": "J3hPEHvkMo65EaCQ2xeBgQ-1", "From": "Adrian Moreno <amorenoz@redhat.com>", "To": "dev@openvswitch.org", "Date": "Mon, 22 Nov 2021 12:22:43 +0100", "Message-Id": "<20211122112256.2011194-6-amorenoz@redhat.com>", "In-Reply-To": "<20211122112256.2011194-1-amorenoz@redhat.com>", "References": "<20211122112256.2011194-1-amorenoz@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.13", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Subject": "[ovs-dev] [PATCH v1 05/18] build-aux: generate ofp field decoders", "X-BeenThere": "ovs-dev@openvswitch.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "<ovs-dev.openvswitch.org>", "List-Unsubscribe": "<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>", "List-Archive": "<http://mail.openvswitch.org/pipermail/ovs-dev/>", "List-Post": "<mailto:ovs-dev@openvswitch.org>", "List-Help": "<mailto:ovs-dev-request@openvswitch.org?subject=help>", "List-Subscribe": "<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "ovs-dev-bounces@openvswitch.org", "Sender": "\"dev\" <ovs-dev-bounces@openvswitch.org>" }, "content": "Based on meta-field information extracted by extract_ofp_fields,\nautogenerate the right decoder to be used\n\nSigned-off-by: Adrian Moreno <amorenoz@redhat.com>\n---\n build-aux/automake.mk | 3 +-\n build-aux/gen_ofp_field_decoders | 73 ++++++++++++++++++++++++++++++++\n python/.gitignore | 1 +\n python/automake.mk | 7 +++\n 4 files changed, 83 insertions(+), 1 deletion(-)\n create mode 100755 build-aux/gen_ofp_field_decoders", "diff": "diff --git a/build-aux/automake.mk b/build-aux/automake.mk\nindex 6267ccd7c..a8bb0acfd 100644\n--- a/build-aux/automake.mk\n+++ b/build-aux/automake.mk\n@@ -9,7 +9,8 @@ EXTRA_DIST += \\\n \tbuild-aux/sodepends.py \\\n \tbuild-aux/soexpand.py \\\n \tbuild-aux/text2c \\\n-\tbuild-aux/xml2nroff\n+\tbuild-aux/xml2nroff \\\n+\tbuild-aux/gen_ofp_field_decoders\n \n FLAKE8_PYFILES += \\\n $(srcdir)/build-aux/xml2nroff \\\ndiff --git a/build-aux/gen_ofp_field_decoders b/build-aux/gen_ofp_field_decoders\nnew file mode 100755\nindex 000000000..e60410af8\n--- /dev/null\n+++ b/build-aux/gen_ofp_field_decoders\n@@ -0,0 +1,73 @@\n+#!/bin/env python\n+\n+import argparse\n+import re\n+import os\n+import sys\n+import importlib\n+\n+import build.extract_ofp_fields as extract_fields\n+\n+\n+def main():\n+ parser = argparse.ArgumentParser(\n+ description=\"Tool to generate python ofproto field decoders from\"\n+ \"meta-flow information\"\n+ )\n+ parser.add_argument(\n+ \"metaflow\",\n+ metavar=\"FILE\",\n+ type=str,\n+ help=\"Read meta-flow info from file\",\n+ )\n+\n+ args = parser.parse_args()\n+\n+ fields = extract_fields.extract_ofp_fields(args.metaflow)\n+\n+ field_decoders = {}\n+ for field in fields:\n+ decoder = get_decoder(field)\n+ field_decoders[field.get(\"name\")] = decoder\n+ if field.get(\"extra_name\"):\n+ field_decoders[field.get(\"extra_name\")] = decoder\n+\n+ code = \"\"\"\n+# This file is auto-generated. Do not edit\n+\n+import functools\n+from ovs.flows import decoders\n+\n+field_decoders = {{\n+{decoders}\n+}}\n+\"\"\".format(\n+ decoders=\"\\n\".join(\n+ [\n+ \" '{name}': {decoder},\".format(name=name, decoder=decoder)\n+ for name, decoder in field_decoders.items()\n+ ]\n+ )\n+ )\n+ print(code)\n+\n+\n+def get_decoder(field):\n+ formatting = field.get(\"formatting\")\n+ if formatting in [\"decimal\", \"hexadecimal\"]:\n+ if field.get(\"mask\") == \"MFM_NONE\":\n+ return \"decoders.decode_int\"\n+ else:\n+ if field.get(\"n_bits\") in [8, 16, 32, 64, 128, 992]:\n+ return \"decoders.Mask{}\".format(field.get(\"n_bits\"))\n+ return \"decoders.decode_mask({})\".format(field.get(\"n_bits\"))\n+ elif formatting in [\"IPv4\", \"IPv6\"]:\n+ return \"decoders.IPMask\"\n+ elif formatting == \"Ethernet\":\n+ return \"decoders.EthMask\"\n+ else:\n+ return \"decoders.decode_default\"\n+\n+\n+if __name__ == \"__main__\":\n+ main()\ndiff --git a/python/.gitignore b/python/.gitignore\nindex 60ace6f05..c8ffd4574 100644\n--- a/python/.gitignore\n+++ b/python/.gitignore\n@@ -1,2 +1,3 @@\n dist/\n *.egg-info\n+ovs/flows/ofp_fields.py\ndiff --git a/python/automake.mk b/python/automake.mk\nindex b869eb355..9dfc62fce 100644\n--- a/python/automake.mk\n+++ b/python/automake.mk\n@@ -123,3 +123,10 @@ $(srcdir)/python/ovs/dirs.py: python/ovs/dirs.py.template\n \tmv $@.tmp $@\n EXTRA_DIST += python/ovs/dirs.py.template\n CLEANFILES += python/ovs/dirs.py\n+\n+$(srcdir)/python/ovs/flows/ofp_fields.py: $(srcdir)/build-aux/gen_ofp_field_decoders include/openvswitch/meta-flow.h\n+\t$(AM_V_GEN)$(run_python) $< $(srcdir)/include/openvswitch/meta-flow.h > $@.tmp\n+\t$(AM_V_at)mv $@.tmp $@\n+EXTRA_DIST += python/ovs/flows/ofp_fields.py\n+CLEANFILES += python/ovs/flows/ofp_fields.py\n+\n", "prefixes": [ "ovs-dev", "v1", "05/18" ] }