Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1548006/?format=api
{ "id": 1548006, "url": "http://patchwork.ozlabs.org/api/patches/1548006/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pwm/patch/20211029105617.210178-1-u.kleine-koenig@pengutronix.de/", "project": { "id": 38, "url": "http://patchwork.ozlabs.org/api/projects/38/?format=api", "name": "Linux PWM development", "link_name": "linux-pwm", "list_id": "linux-pwm.vger.kernel.org", "list_email": "linux-pwm@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20211029105617.210178-1-u.kleine-koenig@pengutronix.de>", "list_archive_url": null, "date": "2021-10-29T10:56:17", "name": "pwm: img: Implement .apply() callback", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "602e01f392da945a2fb2494af1df4d525372da99", "submitter": { "id": 1476, "url": "http://patchwork.ozlabs.org/api/people/1476/?format=api", "name": "Uwe Kleine-König", "email": "u.kleine-koenig@pengutronix.de" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-pwm/patch/20211029105617.210178-1-u.kleine-koenig@pengutronix.de/mbox/", "series": [ { "id": 269501, "url": "http://patchwork.ozlabs.org/api/series/269501/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pwm/list/?series=269501", "date": "2021-10-29T10:56:17", "name": "pwm: img: Implement .apply() callback", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/269501/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1548006/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1548006/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linux-pwm-owner@vger.kernel.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=23.128.96.18; helo=vger.kernel.org;\n envelope-from=linux-pwm-owner@vger.kernel.org; receiver=<UNKNOWN>)", "Received": [ "from vger.kernel.org (vger.kernel.org [23.128.96.18])\n\tby bilbo.ozlabs.org (Postfix) with ESMTP id 4HgfW43xsnz9sX3\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 29 Oct 2021 21:56:32 +1100 (AEDT)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n id S231749AbhJ2K66 (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n Fri, 29 Oct 2021 06:58:58 -0400", "from lindbergh.monkeyblade.net ([23.128.96.19]:52986 \"EHLO\n lindbergh.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n with ESMTP id S231740AbhJ2K66 (ORCPT\n <rfc822;linux-pwm@vger.kernel.org>); Fri, 29 Oct 2021 06:58:58 -0400", "from metis.ext.pengutronix.de (metis.ext.pengutronix.de\n [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33])\n by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98E20C061570\n for <linux-pwm@vger.kernel.org>; Fri, 29 Oct 2021 03:56:29 -0700 (PDT)", "from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2])\n by metis.ext.pengutronix.de with esmtps\n (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.92)\n (envelope-from <ukl@pengutronix.de>)\n id 1mgPYg-0000kl-9J; Fri, 29 Oct 2021 12:56:26 +0200", "from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de)\n by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.92)\n (envelope-from <ukl@pengutronix.de>)\n id 1mgPYd-0005PB-4Y; Fri, 29 Oct 2021 12:56:23 +0200", "from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.92)\n (envelope-from <ukl@pengutronix.de>)\n id 1mgPYd-0002Q2-3T; Fri, 29 Oct 2021 12:56:23 +0200" ], "From": "=?utf-8?q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>", "To": "Thierry Reding <thierry.reding@gmail.com>,\n Lee Jones <lee.jones@linaro.org>", "Cc": "linux-pwm@vger.kernel.org, kernel@pengutronix.de,\n Hauke Mehrtens <hauke@hauke-m.de>", "Subject": "[PATCH] pwm: img: Implement .apply() callback", "Date": "Fri, 29 Oct 2021 12:56:17 +0200", "Message-Id": "<20211029105617.210178-1-u.kleine-koenig@pengutronix.de>", "X-Mailer": "git-send-email 2.30.2", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "X-Patch-Hashes": "v=1; h=sha256; i=W6dF7RZyvVaIfn3AMXQUv3qdOGuwqeXB8fHLxYMMvtI=;\n m=TzWDfn0QgyP4Qo0s0ELgUgvslQMmfgqYACV4fnO2KFo=;\n p=sr0kis/Z3+VqcivWjoj3JOsPSJ9sFZflxj25ZzF6/Xs=;\n g=e1395e015c7c9f89466c2b08606155c6d14d8df4", "X-Patch-Sig": "m=pgp; i=u.kleine-koenig@pengutronix.de;\n s=0x0D2511F322BFAB1C1580266BE2DCDD9132669BD6;\n b=iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmF7004ACgkQwfwUeK3K7AljBwf/eGa\n ogavSsr9va2TR9ZnjxkYVH6xmSF6lQ7oIW3GJJMxePqPqL4si6J6k7pxeam8o9FN6YfqcaVfHQlsO\n PHKr7JV7QU3Q/mq0KJoD68Zsw0JEivVISCuovTDIJM+BpRKNyennVWhD8UkMfpi/ghebvh7itiCPG\n xfaQtanLO+SmqJaefGY6fCnCl3gF1slw4FmuiUVi9X6zINdLV8LZrw8Thss1QhErVuSWf7aHXwRxn\n 8HeSPt8HWDgNOgpQaMB8v9r6v1EiJe+Rqt24vgLZkJfaBdqxaigrU7X6jFN5Lz6irxX8VkqZ0qAib\n QHPxp9yPij/+AWvO7VlKV/K7yK/r/Ng==", "Content-Transfer-Encoding": "8bit", "X-SA-Exim-Connect-IP": "2a0a:edc0:0:c01:1d::a2", "X-SA-Exim-Mail-From": "ukl@pengutronix.de", "X-SA-Exim-Scanned": "No (on metis.ext.pengutronix.de);\n SAEximRunCond expanded to false", "X-PTX-Original-Recipient": "linux-pwm@vger.kernel.org", "Precedence": "bulk", "List-ID": "<linux-pwm.vger.kernel.org>", "X-Mailing-List": "linux-pwm@vger.kernel.org" }, "content": "To eventually get rid of all legacy drivers convert this driver to the\nmodern world implementing .apply(). This just pushes down a slightly\noptimized variant of how legacy drivers are handled in the core.\n\nSigned-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>\n---\n drivers/pwm/pwm-img.c | 29 ++++++++++++++++++++++++++---\n 1 file changed, 26 insertions(+), 3 deletions(-)\n\n\nbase-commit: 3906fe9bb7f1a2c8667ae54e967dc8690824f4ea", "diff": "diff --git a/drivers/pwm/pwm-img.c b/drivers/pwm/pwm-img.c\nindex f97f82548293..1f3d6346ab86 100644\n--- a/drivers/pwm/pwm-img.c\n+++ b/drivers/pwm/pwm-img.c\n@@ -184,10 +184,33 @@ static void img_pwm_disable(struct pwm_chip *chip, struct pwm_device *pwm)\n \tpm_runtime_put_autosuspend(chip->dev);\n }\n \n+static int img_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,\n+\t\t\t const struct pwm_state *state)\n+{\n+\tint err;\n+\n+\tif (state->polarity != PWM_POLARITY_NORMAL)\n+\t\treturn -EINVAL;\n+\n+\tif (!state->enabled) {\n+\t\tif (pwm->state.enabled)\n+\t\t\timg_pwm_disable(chip, pwm);\n+\n+\t\treturn 0;\n+\t}\n+\n+\terr = img_pwm_config(pwm->chip, pwm, state->duty_cycle, state->period);\n+\tif (err)\n+\t\treturn err;\n+\n+\tif (!pwm->state.enabled)\n+\t\terr = img_pwm_enable(chip, pwm);\n+\n+\treturn err;\n+}\n+\n static const struct pwm_ops img_pwm_ops = {\n-\t.config = img_pwm_config,\n-\t.enable = img_pwm_enable,\n-\t.disable = img_pwm_disable,\n+\t.apply = img_pwm_apply,\n \t.owner = THIS_MODULE,\n };\n \n", "prefixes": [] }