Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1547402/?format=api
{ "id": 1547402, "url": "http://patchwork.ozlabs.org/api/patches/1547402/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pwm/patch/20211028100942.161170-1-u.kleine-koenig@pengutronix.de/", "project": { "id": 38, "url": "http://patchwork.ozlabs.org/api/projects/38/?format=api", "name": "Linux PWM development", "link_name": "linux-pwm", "list_id": "linux-pwm.vger.kernel.org", "list_email": "linux-pwm@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20211028100942.161170-1-u.kleine-koenig@pengutronix.de>", "list_archive_url": null, "date": "2021-10-28T10:09:42", "name": "pwm: twl: Implement .apply() callback", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "839b8da9eb409621887cc1c932fa49a7d732d57a", "submitter": { "id": 1476, "url": "http://patchwork.ozlabs.org/api/people/1476/?format=api", "name": "Uwe Kleine-König", "email": "u.kleine-koenig@pengutronix.de" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-pwm/patch/20211028100942.161170-1-u.kleine-koenig@pengutronix.de/mbox/", "series": [ { "id": 269315, "url": "http://patchwork.ozlabs.org/api/series/269315/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pwm/list/?series=269315", "date": "2021-10-28T10:09:42", "name": "pwm: twl: Implement .apply() callback", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/269315/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1547402/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1547402/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linux-pwm-owner@vger.kernel.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=23.128.96.18; helo=vger.kernel.org;\n envelope-from=linux-pwm-owner@vger.kernel.org; receiver=<UNKNOWN>)", "Received": [ "from vger.kernel.org (vger.kernel.org [23.128.96.18])\n\tby bilbo.ozlabs.org (Postfix) with ESMTP id 4Hg1X30lwZz9sRK\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 28 Oct 2021 21:10:11 +1100 (AEDT)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n id S229850AbhJ1KMe (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n Thu, 28 Oct 2021 06:12:34 -0400", "from lindbergh.monkeyblade.net ([23.128.96.19]:56108 \"EHLO\n lindbergh.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n with ESMTP id S229822AbhJ1KMd (ORCPT\n <rfc822;linux-pwm@vger.kernel.org>); Thu, 28 Oct 2021 06:12:33 -0400", "from metis.ext.pengutronix.de (metis.ext.pengutronix.de\n [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33])\n by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5BA7FC061570\n for <linux-pwm@vger.kernel.org>; Thu, 28 Oct 2021 03:10:06 -0700 (PDT)", "from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2])\n by metis.ext.pengutronix.de with esmtps\n (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.92)\n (envelope-from <ukl@pengutronix.de>)\n id 1mg2MG-0006ck-AQ; Thu, 28 Oct 2021 12:10:04 +0200", "from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de)\n by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.92)\n (envelope-from <ukl@pengutronix.de>)\n id 1mg2MA-0002Mb-I3; Thu, 28 Oct 2021 12:09:58 +0200", "from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.92)\n (envelope-from <ukl@pengutronix.de>)\n id 1mg2MA-0003q9-H2; Thu, 28 Oct 2021 12:09:58 +0200" ], "From": "=?utf-8?q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>", "To": "Thierry Reding <thierry.reding@gmail.com>,\n Lee Jones <lee.jones@linaro.org>", "Cc": "linux-pwm@vger.kernel.org, kernel@pengutronix.de,\n Peter Ujfalusi <peter.ujfalusi@ti.com>,\n Paul Kocialkowski <contact@paulk.fr>", "Subject": "[PATCH] pwm: twl: Implement .apply() callback", "Date": "Thu, 28 Oct 2021 12:09:42 +0200", "Message-Id": "<20211028100942.161170-1-u.kleine-koenig@pengutronix.de>", "X-Mailer": "git-send-email 2.30.2", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "X-Patch-Hashes": "v=1; h=sha256; i=m3LAhGpwqhSAqNdCwaJ2Jom2Nqf53wuC4P6Kwp80glw=;\n m=TzWDfn0QgyP4Qo0s0ELgUgvslQMmfgqYACV4fnO2KFo=;\n p=fBu1T/SyT8wOV/p635fnQ4iElhJktOeUnbFGGePMKU8=;\n g=459fc2102d5cda4423da1a4a73a4f7cd397c03e6", "X-Patch-Sig": "m=pgp; i=u.kleine-koenig@pengutronix.de;\n s=0x0D2511F322BFAB1C1580266BE2DCDD9132669BD6;\n b=iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmF6dt0ACgkQwfwUeK3K7AnmuAgAj1n\n YP5tZQXe2oSpTe0c8SpIQFRjyHEi7yoSndSPDjugQyDGIEVeH5Er32XA6SbqGIgN9iKLvHG4u2LTS\n xTfzqCI2kxNV5WGx8sXiIMrrnkSNWzi8DCDnJjo0pOid0Cmum1icXk9L6DFAcZa+A7cAFLP48665g\n CnJCskUnk7aZUVBmWYBYD6qm8Y2vwOgL1goAWirb8Leoek17kuy9Mc7VLXPpZYI1ajJydAVVlQcNK\n u5OfFbCVFlG5fkO005SRyZUEyHAP+bfgQJhDQ01AdGFRR871wT3+JC/7CIEDjbNLR3c4hl1HxsWZL\n ok39nSm9LlOEWb2blSwIEbjsD6yEohQ==", "Content-Transfer-Encoding": "8bit", "X-SA-Exim-Connect-IP": "2a0a:edc0:0:c01:1d::a2", "X-SA-Exim-Mail-From": "ukl@pengutronix.de", "X-SA-Exim-Scanned": "No (on metis.ext.pengutronix.de);\n SAEximRunCond expanded to false", "X-PTX-Original-Recipient": "linux-pwm@vger.kernel.org", "Precedence": "bulk", "List-ID": "<linux-pwm.vger.kernel.org>", "X-Mailing-List": "linux-pwm@vger.kernel.org" }, "content": "To eventually get rid of all legacy drivers convert this driver to the\nmodern world implementing .apply(). This just pushes down a slightly\noptimized variant of how legacy drivers are handled in the core.\n\nSigned-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>\n---\n drivers/pwm/pwm-twl.c | 62 +++++++++++++++++++++++++++++++++++++------\n 1 file changed, 54 insertions(+), 8 deletions(-)\n\n\nbase-commit: 3906fe9bb7f1a2c8667ae54e967dc8690824f4ea", "diff": "diff --git a/drivers/pwm/pwm-twl.c b/drivers/pwm/pwm-twl.c\nindex 203194f2c92e..86567add79db 100644\n--- a/drivers/pwm/pwm-twl.c\n+++ b/drivers/pwm/pwm-twl.c\n@@ -58,9 +58,9 @@ static inline struct twl_pwm_chip *to_twl(struct pwm_chip *chip)\n }\n \n static int twl_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,\n-\t\t\t int duty_ns, int period_ns)\n+\t\t\t u64 duty_ns, u64 period_ns)\n {\n-\tint duty_cycle = DIV_ROUND_UP(duty_ns * TWL_PWM_MAX, period_ns) + 1;\n+\tint duty_cycle = DIV64_U64_ROUND_UP(duty_ns * TWL_PWM_MAX, period_ns) + 1;\n \tu8 pwm_config[2] = { 1, 0 };\n \tint base, ret;\n \n@@ -279,19 +279,65 @@ static void twl6030_pwm_disable(struct pwm_chip *chip, struct pwm_device *pwm)\n \tmutex_unlock(&twl->mutex);\n }\n \n+static int twl4030_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,\n+\t\t\t const struct pwm_state *state)\n+{\n+\tint err;\n+\n+\tif (state->polarity != PWM_POLARITY_NORMAL)\n+\t\treturn -EINVAL;\n+\n+\tif (!state->enabled) {\n+\t\tif (pwm->state.enabled)\n+\t\t\ttwl4030_pwm_disable(chip, pwm);\n+\n+\t\treturn 0;\n+\t}\n+\n+\terr = twl_pwm_config(pwm->chip, pwm, state->duty_cycle, state->period);\n+\tif (err)\n+\t\treturn err;\n+\n+\tif (!pwm->state.enabled)\n+\t\terr = twl4030_pwm_enable(chip, pwm);\n+\n+\treturn err;\n+}\n+\n+static int twl6030_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,\n+\t\t\t const struct pwm_state *state)\n+{\n+\tint err;\n+\n+\tif (state->polarity != PWM_POLARITY_NORMAL)\n+\t\treturn -EINVAL;\n+\n+\tif (!state->enabled) {\n+\t\tif (pwm->state.enabled)\n+\t\t\ttwl6030_pwm_disable(chip, pwm);\n+\n+\t\treturn 0;\n+\t}\n+\n+\terr = twl_pwm_config(pwm->chip, pwm, state->duty_cycle, state->period);\n+\tif (err)\n+\t\treturn err;\n+\n+\tif (!pwm->state.enabled)\n+\t\terr = twl6030_pwm_enable(chip, pwm);\n+\n+\treturn err;\n+}\n+\n static const struct pwm_ops twl4030_pwm_ops = {\n-\t.config = twl_pwm_config,\n-\t.enable = twl4030_pwm_enable,\n-\t.disable = twl4030_pwm_disable,\n+\t.apply = twl4030_pwm_apply,\n \t.request = twl4030_pwm_request,\n \t.free = twl4030_pwm_free,\n \t.owner = THIS_MODULE,\n };\n \n static const struct pwm_ops twl6030_pwm_ops = {\n-\t.config = twl_pwm_config,\n-\t.enable = twl6030_pwm_enable,\n-\t.disable = twl6030_pwm_disable,\n+\t.apply = twl6030_pwm_apply,\n \t.owner = THIS_MODULE,\n };\n \n", "prefixes": [] }