Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1528346/?format=api
{ "id": 1528346, "url": "http://patchwork.ozlabs.org/api/patches/1528346/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ovn/patch/20210915124340.1765-2-anton.ivanov@cambridgegreys.com/", "project": { "id": 68, "url": "http://patchwork.ozlabs.org/api/projects/68/?format=api", "name": "Open Virtual Network development", "link_name": "ovn", "list_id": "ovs-dev.openvswitch.org", "list_email": "ovs-dev@openvswitch.org", "web_url": "http://openvswitch.org/", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20210915124340.1765-2-anton.ivanov@cambridgegreys.com>", "list_archive_url": null, "date": "2021-09-15T12:43:39", "name": "[ovs-dev,v8,2/3] northd: Resize the hash to correct parameters after build", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "46497785116adc0c9e2ddd68741120f1f55589b5", "submitter": { "id": 71996, "url": "http://patchwork.ozlabs.org/api/people/71996/?format=api", "name": "Anton Ivanov", "email": "anton.ivanov@cambridgegreys.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/ovn/patch/20210915124340.1765-2-anton.ivanov@cambridgegreys.com/mbox/", "series": [ { "id": 262448, "url": "http://patchwork.ozlabs.org/api/series/262448/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ovn/list/?series=262448", "date": "2021-09-15T12:43:38", "name": "[ovs-dev,v8,1/3] northd: Disable parallel processing for logical_dp_groups", "version": 8, "mbox": "http://patchwork.ozlabs.org/series/262448/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1528346/comments/", "check": "fail", "checks": "http://patchwork.ozlabs.org/api/patches/1528346/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<ovs-dev-bounces@openvswitch.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "ovs-dev@openvswitch.org" ], "Delivered-To": [ "patchwork-incoming@ozlabs.org", "ovs-dev@lists.linuxfoundation.org" ], "Authentication-Results": "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=140.211.166.136; helo=smtp3.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=<UNKNOWN>)", "Received": [ "from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4H8g053ffsz9t0Y\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 15 Sep 2021 22:44:36 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id C63A4613B5;\n\tWed, 15 Sep 2021 12:44:34 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n\tby localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 0vDTTox6K920; Wed, 15 Sep 2021 12:44:34 +0000 (UTC)", "from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56])\n\tby smtp3.osuosl.org (Postfix) with ESMTPS id 06807613B1;\n\tWed, 15 Sep 2021 12:44:33 +0000 (UTC)", "from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id 5BDCDC0023;\n\tWed, 15 Sep 2021 12:44:32 +0000 (UTC)", "from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133])\n by lists.linuxfoundation.org (Postfix) with ESMTP id 69CE7C0024\n for <ovs-dev@openvswitch.org>; Wed, 15 Sep 2021 12:44:31 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id F4050405F8\n for <ovs-dev@openvswitch.org>; Wed, 15 Sep 2021 12:43:51 +0000 (UTC)", "from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id tBL6U8EYf1DM for <ovs-dev@openvswitch.org>;\n Wed, 15 Sep 2021 12:43:51 +0000 (UTC)", "from www.kot-begemot.co.uk (ivanoab7.miniserver.com [37.128.132.42])\n by smtp2.osuosl.org (Postfix) with ESMTPS id 992B240627\n for <ovs-dev@openvswitch.org>; Wed, 15 Sep 2021 12:43:49 +0000 (UTC)", "from tun252.jain.kot-begemot.co.uk ([192.168.18.6]\n helo=jain.kot-begemot.co.uk)\n by www.kot-begemot.co.uk with esmtps\n (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.92) (envelope-from <anton.ivanov@cambridgegreys.com>)\n id 1mQUGR-0000VV-5V; Wed, 15 Sep 2021 12:43:47 +0000", "from jain.kot-begemot.co.uk ([192.168.3.3])\n by jain.kot-begemot.co.uk with esmtp (Exim 4.92)\n (envelope-from <anton.ivanov@cambridgegreys.com>)\n id 1mQUGO-0000TO-9V; Wed, 15 Sep 2021 13:43:46 +0100" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.8.0", "From": "anton.ivanov@cambridgegreys.com", "To": "ovs-dev@openvswitch.org", "Date": "Wed, 15 Sep 2021 13:43:39 +0100", "Message-Id": "<20210915124340.1765-2-anton.ivanov@cambridgegreys.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20210915124340.1765-1-anton.ivanov@cambridgegreys.com>", "References": "<20210915124340.1765-1-anton.ivanov@cambridgegreys.com>", "MIME-Version": "1.0", "X-Clacks-Overhead": "GNU Terry Pratchett", "Cc": "i.maximets@ovn.org, Anton Ivanov <anton.ivanov@cambridgegreys.com>", "Subject": "[ovs-dev] [OVN Patch v8 2/3] northd: Resize the hash to correct\n\tparameters after build", "X-BeenThere": "ovs-dev@openvswitch.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "<ovs-dev.openvswitch.org>", "List-Unsubscribe": "<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>", "List-Archive": "<http://mail.openvswitch.org/pipermail/ovs-dev/>", "List-Post": "<mailto:ovs-dev@openvswitch.org>", "List-Help": "<mailto:ovs-dev-request@openvswitch.org?subject=help>", "List-Subscribe": "<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "ovs-dev-bounces@openvswitch.org", "Sender": "\"dev\" <ovs-dev-bounces@openvswitch.org>" }, "content": "From: Anton Ivanov <anton.ivanov@cambridgegreys.com>\n\nParallel builds may result in suboptimal hash bucket sizing.\nIn the absense of dp-groups this does not matter as the hash\nis purely storage and not used for lookups during the build.\n\nSuch a hash needs to be resized to a correct size at the end\nof the build to ensure that any lookups during the lflow\nreconcilliation phase are done as fast as possible.\n\nSigned-off-by: Anton Ivanov <anton.ivanov@cambridgegreys.com>\n---\n northd/ovn-northd.c | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c\nindex 3113fafc7..ed231510e 100644\n--- a/northd/ovn-northd.c\n+++ b/northd/ovn-northd.c\n@@ -13178,6 +13178,11 @@ build_lflows(struct northd_context *ctx, struct hmap *datapaths,\n igmp_groups, meter_groups, lbs,\n bfd_connections);\n \n+ /* Parallel build may result in a suboptimal hash. Resize the\n+ * hash to a correct size before doing lookups */\n+\n+ hmap_expand(&lflows);\n+\n if (hmap_count(&lflows) > max_seen_lflow_size) {\n max_seen_lflow_size = hmap_count(&lflows);\n }\n", "prefixes": [ "ovs-dev", "v8", "2/3" ] }