Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1528345/?format=api
{ "id": 1528345, "url": "http://patchwork.ozlabs.org/api/patches/1528345/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ovn/patch/20210915124340.1765-1-anton.ivanov@cambridgegreys.com/", "project": { "id": 68, "url": "http://patchwork.ozlabs.org/api/projects/68/?format=api", "name": "Open Virtual Network development", "link_name": "ovn", "list_id": "ovs-dev.openvswitch.org", "list_email": "ovs-dev@openvswitch.org", "web_url": "http://openvswitch.org/", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20210915124340.1765-1-anton.ivanov@cambridgegreys.com>", "list_archive_url": null, "date": "2021-09-15T12:43:38", "name": "[ovs-dev,v8,1/3] northd: Disable parallel processing for logical_dp_groups", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a5c4713b45e48f955631905dd1bc25aa42deb956", "submitter": { "id": 71996, "url": "http://patchwork.ozlabs.org/api/people/71996/?format=api", "name": "Anton Ivanov", "email": "anton.ivanov@cambridgegreys.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/ovn/patch/20210915124340.1765-1-anton.ivanov@cambridgegreys.com/mbox/", "series": [ { "id": 262448, "url": "http://patchwork.ozlabs.org/api/series/262448/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ovn/list/?series=262448", "date": "2021-09-15T12:43:38", "name": "[ovs-dev,v8,1/3] northd: Disable parallel processing for logical_dp_groups", "version": 8, "mbox": "http://patchwork.ozlabs.org/series/262448/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1528345/comments/", "check": "fail", "checks": "http://patchwork.ozlabs.org/api/patches/1528345/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<ovs-dev-bounces@openvswitch.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "ovs-dev@openvswitch.org" ], "Delivered-To": [ "patchwork-incoming@ozlabs.org", "ovs-dev@lists.linuxfoundation.org" ], "Authentication-Results": "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=<UNKNOWN>)", "Received": [ "from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4H8g030Mn1z9s5R\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 15 Sep 2021 22:44:34 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 799A8826D6;\n\tWed, 15 Sep 2021 12:44:32 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n\tby localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id f8hOs3Utmnta; Wed, 15 Sep 2021 12:44:31 +0000 (UTC)", "from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56])\n\tby smtp1.osuosl.org (Postfix) with ESMTPS id D4922827AA;\n\tWed, 15 Sep 2021 12:44:30 +0000 (UTC)", "from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id AE915C0011;\n\tWed, 15 Sep 2021 12:44:30 +0000 (UTC)", "from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by lists.linuxfoundation.org (Postfix) with ESMTP id 35FD3C0011\n for <ovs-dev@openvswitch.org>; Wed, 15 Sep 2021 12:44:29 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 714B282D04\n for <ovs-dev@openvswitch.org>; Wed, 15 Sep 2021 12:43:51 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id A_GmMh_TLaCS for <ovs-dev@openvswitch.org>;\n Wed, 15 Sep 2021 12:43:50 +0000 (UTC)", "from www.kot-begemot.co.uk (ivanoab7.miniserver.com [37.128.132.42])\n by smtp1.osuosl.org (Postfix) with ESMTPS id CAE4382DE6\n for <ovs-dev@openvswitch.org>; Wed, 15 Sep 2021 12:43:48 +0000 (UTC)", "from tun252.jain.kot-begemot.co.uk ([192.168.18.6]\n helo=jain.kot-begemot.co.uk)\n by www.kot-begemot.co.uk with esmtps\n (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.92) (envelope-from <anton.ivanov@cambridgegreys.com>)\n id 1mQUGP-0000VQ-Gw; Wed, 15 Sep 2021 12:43:45 +0000", "from jain.kot-begemot.co.uk ([192.168.3.3])\n by jain.kot-begemot.co.uk with esmtp (Exim 4.92)\n (envelope-from <anton.ivanov@cambridgegreys.com>)\n id 1mQUGM-0000TO-DQ; Wed, 15 Sep 2021 13:43:44 +0100" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.8.0", "From": "anton.ivanov@cambridgegreys.com", "To": "ovs-dev@openvswitch.org", "Date": "Wed, 15 Sep 2021 13:43:38 +0100", "Message-Id": "<20210915124340.1765-1-anton.ivanov@cambridgegreys.com>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "X-Clacks-Overhead": "GNU Terry Pratchett", "Cc": "i.maximets@ovn.org, Anton Ivanov <anton.ivanov@cambridgegreys.com>", "Subject": "[ovs-dev] [OVN Patch v8 1/3] northd: Disable parallel processing\n\tfor logical_dp_groups", "X-BeenThere": "ovs-dev@openvswitch.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "<ovs-dev.openvswitch.org>", "List-Unsubscribe": "<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>", "List-Archive": "<http://mail.openvswitch.org/pipermail/ovs-dev/>", "List-Post": "<mailto:ovs-dev@openvswitch.org>", "List-Help": "<mailto:ovs-dev-request@openvswitch.org?subject=help>", "List-Subscribe": "<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "ovs-dev-bounces@openvswitch.org", "Sender": "\"dev\" <ovs-dev-bounces@openvswitch.org>" }, "content": "From: Anton Ivanov <anton.ivanov@cambridgegreys.com>\n\nWork on improving processing with dp_groups enabled has\ndiscovered that the locking mechanism presently in use\nis not reliable. Disabling parallel processing if dp_groups\nare enabled until the root cause is determined and fixed.\n\nSigned-off-by: Anton Ivanov <anton.ivanov@cambridgegreys.com>\n---\n northd/ovn-northd.c | 2 +-\n ovs | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c\nindex baaddb73e..3113fafc7 100644\n--- a/northd/ovn-northd.c\n+++ b/northd/ovn-northd.c\n@@ -12974,7 +12974,7 @@ build_lswitch_and_lrouter_flows(struct hmap *datapaths, struct hmap *ports,\n }\n }\n \n- if (use_parallel_build) {\n+ if (use_parallel_build && (!use_logical_dp_groups)) {\n struct hmap *lflow_segs;\n struct lswitch_flow_build_info *lsiv;\n int index;\ndiff --git a/ovs b/ovs\nindex 748010ff3..50e5523b9 160000\n--- a/ovs\n+++ b/ovs\n@@ -1 +1 @@\n-Subproject commit 748010ff304b7cd2c43f4eb98a554433f0df07f9\n+Subproject commit 50e5523b9b2b154e5fafc5acdcdec85e9cc5a330\n", "prefixes": [ "ovs-dev", "v8", "1/3" ] }