Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1528250/?format=api
{ "id": 1528250, "url": "http://patchwork.ozlabs.org/api/patches/1528250/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ovn/patch/20210915085251.2609426-1-xsimonar@redhat.com/", "project": { "id": 68, "url": "http://patchwork.ozlabs.org/api/projects/68/?format=api", "name": "Open Virtual Network development", "link_name": "ovn", "list_id": "ovs-dev.openvswitch.org", "list_email": "ovs-dev@openvswitch.org", "web_url": "http://openvswitch.org/", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20210915085251.2609426-1-xsimonar@redhat.com>", "list_archive_url": null, "date": "2021-09-15T08:52:51", "name": "[ovs-dev] ovn.at: Fix flaky test \"controller I-P handling with monitoring disabled\".", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "70288c500fb0fd382ad3bfac054be5eb79beb629", "submitter": { "id": 82231, "url": "http://patchwork.ozlabs.org/api/people/82231/?format=api", "name": "Xavier Simonart", "email": "xsimonar@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/ovn/patch/20210915085251.2609426-1-xsimonar@redhat.com/mbox/", "series": [ { "id": 262409, "url": "http://patchwork.ozlabs.org/api/series/262409/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ovn/list/?series=262409", "date": "2021-09-15T08:52:51", "name": "[ovs-dev] ovn.at: Fix flaky test \"controller I-P handling with monitoring disabled\".", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/262409/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1528250/comments/", "check": "fail", "checks": "http://patchwork.ozlabs.org/api/patches/1528250/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<ovs-dev-bounces@openvswitch.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "dev@openvswitch.org" ], "Delivered-To": [ "patchwork-incoming@ozlabs.org", "ovs-dev@lists.linuxfoundation.org" ], "Authentication-Results": [ "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=VGlgHDYR;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=<UNKNOWN>)", "smtp4.osuosl.org (amavisd-new);\n dkim=pass (1024-bit key) header.d=redhat.com", "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=xsimonar@redhat.com" ], "Received": [ "from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4H8Ys03Nm2z9sRf\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 15 Sep 2021 18:53:08 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 6D3B060B34;\n\tWed, 15 Sep 2021 08:53:05 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n\tby localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id F_itzrS3NB_W; Wed, 15 Sep 2021 08:53:04 +0000 (UTC)", "from lists.linuxfoundation.org (lf-lists.osuosl.org\n [IPv6:2605:bc80:3010:104::8cd3:938])\n\tby smtp3.osuosl.org (Postfix) with ESMTPS id 9AB5D60708;\n\tWed, 15 Sep 2021 08:53:03 +0000 (UTC)", "from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id 6A551C0011;\n\tWed, 15 Sep 2021 08:53:03 +0000 (UTC)", "from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n by lists.linuxfoundation.org (Postfix) with ESMTP id C5A7DC000D\n for <dev@openvswitch.org>; Wed, 15 Sep 2021 08:53:01 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id B3A9640499\n for <dev@openvswitch.org>; Wed, 15 Sep 2021 08:53:01 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id DtMqr4OK94KM for <dev@openvswitch.org>;\n Wed, 15 Sep 2021 08:53:01 +0000 (UTC)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by smtp4.osuosl.org (Postfix) with ESMTPS id C6BC740498\n for <dev@openvswitch.org>; Wed, 15 Sep 2021 08:53:00 +0000 (UTC)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-222-pg7-yVH8Of-YJqi1O3jBvw-1; Wed, 15 Sep 2021 04:52:54 -0400", "from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com\n [10.5.11.12])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AF8921B18BC2\n for <dev@openvswitch.org>; Wed, 15 Sep 2021 08:52:53 +0000 (UTC)", "from wsfd-netdev90.ntdv.lab.eng.bos.redhat.com\n (wsfd-netdev90.ntdv.lab.eng.bos.redhat.com [10.19.188.196])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 69A3960C81;\n Wed, 15 Sep 2021 08:52:53 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.8.0", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1631695979;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=INA964EFZCcWnF4Ch+GGWgt+yX4OpDzmcD8uQqQ8oW0=;\n b=VGlgHDYRoCLxSw7PYr5tL0OwybBTkN3ds9uq9Gns3PZSTUje9iUG9BOETxpwHtCqF91tbB\n 6AjsLOPDxIthbYTCXgagFbozzEUe3dx9U66ERR1JMwHORLhOnGS+BBqCtqkHHABa1QrqUH\n PNwePwHleveWGbS9xIkhkluqKaQthW0=", "X-MC-Unique": "pg7-yVH8Of-YJqi1O3jBvw-1", "From": "Xavier Simonart <xsimonar@redhat.com>", "To": "xsimonar@redhat.com,\n\tdev@openvswitch.org", "Date": "Wed, 15 Sep 2021 04:52:51 -0400", "Message-Id": "<20210915085251.2609426-1-xsimonar@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.12", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Subject": "[ovs-dev] [PATCH ovn] ovn.at: Fix flaky test \"controller I-P\n\thandling with monitoring disabled\".", "X-BeenThere": "ovs-dev@openvswitch.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "<ovs-dev.openvswitch.org>", "List-Unsubscribe": "<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>", "List-Archive": "<http://mail.openvswitch.org/pipermail/ovs-dev/>", "List-Post": "<mailto:ovs-dev@openvswitch.org>", "List-Help": "<mailto:ovs-dev-request@openvswitch.org?subject=help>", "List-Subscribe": "<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "ovs-dev-bounces@openvswitch.org", "Sender": "\"dev\" <ovs-dev-bounces@openvswitch.org>" }, "content": "Test was waiting for port to be up in SBDB before checking number of flows\nin OVS. However, there is no guarantee that all flows are installed\nin OVS when port is up. Test was randomly failing as some flows were\ninstalled, but not all.\nTo fix this, we wait until the last flow (with actions=output) is\ninstalled.\nAlso fixed small typo in logging (for the same test).\n\nReported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2004390\nFixes: f8a81693b0 (\"ovn-controller: Fix the missing flows with monitor-all set to True\")\nSigned-off-by: Xavier Simonart <xsimonar@redhat.com>\n---\n tests/ovn.at | 28 ++++++++++++++++++++++++++--\n 1 file changed, 26 insertions(+), 2 deletions(-)", "diff": "diff --git a/tests/ovn.at b/tests/ovn.at\nindex 30625ec37..18aeacd02 100644\n--- a/tests/ovn.at\n+++ b/tests/ovn.at\n@@ -23448,6 +23448,12 @@ ovs-vsctl -- add-port br-int hv1-vif1 -- \\\n \n wait_for_ports_up sw0-p1\n \n+# Wait for last flow to be installed\n+OVS_WAIT_UNTIL([\n+ test $(as hv1 ovs-ofctl dump-flows br-int | \\\n+ grep \"actions=output\" -c) -eq 1\n+])\n+\n # Get the number of OF flows in hv1 and hv2\n hv1_offlows=$(as hv1 ovs-ofctl dump-flows br-int | wc -l)\n echo \"hv1 flows : $hv1_offlows\"\n@@ -23462,6 +23468,12 @@ ovs-vsctl -- add-port br-int hv2-vif1 -- \\\n \n wait_for_ports_up sw0-p2\n \n+# Wait for last flow to be installed\n+OVS_WAIT_UNTIL([\n+ test $(as hv2 ovs-ofctl dump-flows br-int | \\\n+ grep \"actions=output\" -c) -eq 1\n+])\n+\n hv2_offlows=$(as hv2 ovs-ofctl dump-flows br-int | wc -l)\n echo \"hv2 flows : $hv2_offlows\"\n AT_CHECK([test $hv2_offlows -gt 0])\n@@ -23500,9 +23512,15 @@ ovs-vsctl -- add-port br-int hv1-vif1 -- \\\n \n wait_for_ports_up sw0-p1\n \n+# Wait for last flow to be installed\n+OVS_WAIT_UNTIL([\n+ test $(as hv1 ovs-ofctl dump-flows br-int | \\\n+ grep \"actions=output\" -c) -eq 1\n+])\n+\n # Get the number of OF flows in hv1 and hv2\n hv1_offlows_mon=$(as hv1 ovs-ofctl dump-flows br-int | wc -l)\n-echo \"hv1 flows after monitor-all=true : $hv1_offlows\"\n+echo \"hv1 flows after monitor-all=true : $hv1_offlows_mon\"\n AT_CHECK([test \"$hv1_offlows\" = \"$hv1_offlows_mon\"])\n \n as hv2\n@@ -23514,8 +23532,14 @@ ovs-vsctl -- add-port br-int hv2-vif1 -- \\\n \n wait_for_ports_up sw0-p2\n \n+# Wait for last flow to be installed\n+OVS_WAIT_UNTIL([\n+ test $(as hv2 ovs-ofctl dump-flows br-int | \\\n+ grep \"actions=output\" -c) -eq 1\n+])\n+\n hv2_offlows_mon=$(as hv2 ovs-ofctl dump-flows br-int | wc -l)\n-echo \"hv2 flows after monitor-all=true : $hv2_offlows\"\n+echo \"hv2 flows after monitor-all=true : $hv2_offlows_mon\"\n AT_CHECK([test \"$hv2_offlows\" = \"$hv2_offlows_mon\"])\n \n OVN_CLEANUP([hv1], [hv2])\n", "prefixes": [ "ovs-dev" ] }