Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1527214/?format=api
{ "id": 1527214, "url": "http://patchwork.ozlabs.org/api/patches/1527214/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pwm/patch/20210913061553.21450-1-long870912@gmail.com/", "project": { "id": 38, "url": "http://patchwork.ozlabs.org/api/projects/38/?format=api", "name": "Linux PWM development", "link_name": "linux-pwm", "list_id": "linux-pwm.vger.kernel.org", "list_email": "linux-pwm@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20210913061553.21450-1-long870912@gmail.com>", "list_archive_url": null, "date": "2021-09-13T06:15:53", "name": "pwm: visconti: Simplify using devm_pwmchip_add()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "6bc4ec0a57a4a86922c08b7aec3e24fa627ec899", "submitter": { "id": 82475, "url": "http://patchwork.ozlabs.org/api/people/82475/?format=api", "name": "zhaoxiao", "email": "long870912@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-pwm/patch/20210913061553.21450-1-long870912@gmail.com/mbox/", "series": [ { "id": 262005, "url": "http://patchwork.ozlabs.org/api/series/262005/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pwm/list/?series=262005", "date": "2021-09-13T06:15:53", "name": "pwm: visconti: Simplify using devm_pwmchip_add()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/262005/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1527214/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1527214/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linux-pwm-owner@vger.kernel.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20210112 header.b=dWO6Vr1w;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=23.128.96.18; helo=vger.kernel.org;\n envelope-from=linux-pwm-owner@vger.kernel.org; receiver=<UNKNOWN>)" ], "Received": [ "from vger.kernel.org (vger.kernel.org [23.128.96.18])\n\tby ozlabs.org (Postfix) with ESMTP id 4H7GYm1KGlz9sW4\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 13 Sep 2021 16:20:28 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n id S236244AbhIMGVl (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n Mon, 13 Sep 2021 02:21:41 -0400", "from lindbergh.monkeyblade.net ([23.128.96.19]:45984 \"EHLO\n lindbergh.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n with ESMTP id S230003AbhIMGVk (ORCPT\n <rfc822;linux-pwm@vger.kernel.org>); Mon, 13 Sep 2021 02:21:40 -0400", "from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com\n [IPv6:2607:f8b0:4864:20::42b])\n by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AADEDC061574;\n Sun, 12 Sep 2021 23:20:25 -0700 (PDT)", "by mail-pf1-x42b.google.com with SMTP id y17so7799521pfl.13;\n Sun, 12 Sep 2021 23:20:25 -0700 (PDT)", "from localhost.localdomain ([111.207.172.18])\n by smtp.gmail.com with ESMTPSA id\n f6sm5701659pfa.110.2021.09.12.23.20.22\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 12 Sep 2021 23:20:24 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20210112;\n h=from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=MJZFP5k7d2O2P1gl9RWPWTU9kiXtHQ6xmLwf4B4cHAc=;\n b=dWO6Vr1w1z/Y5cyRncMP28ZhnmG8SNYRD+5cWts5t4zwKh+N3m5+jrl3Nqe6zSSis4\n KzqgKP429efnM2caaT8XS5hcH+Qo2YTKOFY37Ekz4Srvh3zR9upLXsdmuSv8Nx7X/jaF\n LPuXdbJCfMU3bZLzvRey5coKIwDIwFJ3ckoMP1tPkvWupHPJCxe0Yo2mbq7gYPpzBm39\n OQ56iT5SZmv+9r9+McdQDiBYeqQoy8dwrtCmdPofIsttfueDHztzIybGexrlfil4OY6c\n M3iyl+uXNr55VAy+KRZFUZjsvBEj/ddtMOVgibtdAXn0KXMl43nalsHDBzrNQn6CYoQp\n TiFw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=MJZFP5k7d2O2P1gl9RWPWTU9kiXtHQ6xmLwf4B4cHAc=;\n b=niEBYWDpGauQmFeHKtxuWjBrcek9WNq6q/J7Xt05RBZYdI1OW9WSWo47ZrucQK1g9B\n fBNIuizFO32DiPngeGDuwrAkWQB55Qh48HaXV8LwTAS1veWVbodY3NzSNjvRRfFQVnAs\n k/hWdM9xAZr0HgF1/ihSQ7VR1ZGDKKwg3S/2wRIIQQ+ys0mLkh0TSSZsIgkI41kxH11N\n 1XeVmgaM/POJDxt8eR6YV0CTYZX4PsrItF3IBhj2aU/l+Sa0tRFSSJz3BNmINAr/cCkx\n DcrMZwLFt7M+FRKqfxNiINBSqjUc1EJwAIahDEhjFhcaIvfgG8b+AMDsrLPvKULFyYVS\n E02A==", "X-Gm-Message-State": "AOAM532vRxzZg11e7/JS2WS0tTTcGLb6zgYVa625mjNTld2MNAweMZ0k\n qDtEdGzqsaArwDX/YOdoNGA=", "X-Google-Smtp-Source": "\n ABdhPJxydawtyrw408aHRADdQSSQtY4CoMrjVipz31NpqSnTyslm+Mek54wUlS+h5hosr6C61V6U/w==", "X-Received": "by 2002:a63:7d04:: with SMTP id y4mr9854031pgc.131.1631514025291;\n Sun, 12 Sep 2021 23:20:25 -0700 (PDT)", "From": "zhaoxiao <long870912@gmail.com>", "To": "thierry.reding@gmail.com, lee.jones@linaro.org", "Cc": "u.kleine-koenig@pengutronix.de, linux-pwm@vger.kernel.org,\n linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n zhaoxiao <long870912@gmail.com>", "Subject": "[PATCH] pwm: visconti: Simplify using devm_pwmchip_add()", "Date": "Mon, 13 Sep 2021 14:15:53 +0800", "Message-Id": "<20210913061553.21450-1-long870912@gmail.com>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Precedence": "bulk", "List-ID": "<linux-pwm.vger.kernel.org>", "X-Mailing-List": "linux-pwm@vger.kernel.org" }, "content": "This allows to drop the platform_driver's remove function. This is the\nonly user of driver data so this can go away, too.\n\nSigned-off-by: zhaoxiao <long870912@gmail.com>\n---\n drivers/pwm/pwm-visconti.c | 14 +-------------\n 1 file changed, 1 insertion(+), 13 deletions(-)", "diff": "diff --git a/drivers/pwm/pwm-visconti.c b/drivers/pwm/pwm-visconti.c\nindex af4e37d3e3a6..927c4cbb1daf 100644\n--- a/drivers/pwm/pwm-visconti.c\n+++ b/drivers/pwm/pwm-visconti.c\n@@ -144,28 +144,17 @@ static int visconti_pwm_probe(struct platform_device *pdev)\n \tif (IS_ERR(priv->base))\n \t\treturn PTR_ERR(priv->base);\n \n-\tplatform_set_drvdata(pdev, priv);\n-\n \tpriv->chip.dev = dev;\n \tpriv->chip.ops = &visconti_pwm_ops;\n \tpriv->chip.npwm = 4;\n \n-\tret = pwmchip_add(&priv->chip);\n+\tret = devm_pwmchip_add(&pdev->dev, &priv->chip);\n \tif (ret < 0)\n \t\treturn dev_err_probe(&pdev->dev, ret, \"Cannot register visconti PWM\\n\");\n \n \treturn 0;\n }\n \n-static int visconti_pwm_remove(struct platform_device *pdev)\n-{\n-\tstruct visconti_pwm_chip *priv = platform_get_drvdata(pdev);\n-\n-\tpwmchip_remove(&priv->chip);\n-\n-\treturn 0;\n-}\n-\n static const struct of_device_id visconti_pwm_of_match[] = {\n \t{ .compatible = \"toshiba,visconti-pwm\", },\n \t{ }\n@@ -178,7 +167,6 @@ static struct platform_driver visconti_pwm_driver = {\n \t\t.of_match_table = visconti_pwm_of_match,\n \t},\n \t.probe = visconti_pwm_probe,\n-\t.remove = visconti_pwm_remove,\n };\n module_platform_driver(visconti_pwm_driver);\n \n", "prefixes": [] }