Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1525727/?format=api
{ "id": 1525727, "url": "http://patchwork.ozlabs.org/api/patches/1525727/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/patch/32227465e3e15ff243439ed6a75d8f3be4ce24cd.1631094144.git.grive@u256.net/", "project": { "id": 47, "url": "http://patchwork.ozlabs.org/api/projects/47/?format=api", "name": "Open vSwitch", "link_name": "openvswitch", "list_id": "ovs-dev.openvswitch.org", "list_email": "ovs-dev@openvswitch.org", "web_url": "http://openvswitch.org/", "scm_url": "git@github.com:openvswitch/ovs.git", "webscm_url": "https://github.com/openvswitch/ovs", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<32227465e3e15ff243439ed6a75d8f3be4ce24cd.1631094144.git.grive@u256.net>", "list_archive_url": null, "date": "2021-09-08T09:47:40", "name": "[ovs-dev,v5,16/27] dpif-netdev: Postpone flow offload item freeing", "commit_ref": "528a8ab6270bcf8e5980528c4ff19fbfb86bee22", "pull_url": null, "state": "accepted", "archived": false, "hash": "aa81b81eddc5affa64bfd1ed7ea5704dd7041561", "submitter": { "id": 78795, "url": "http://patchwork.ozlabs.org/api/people/78795/?format=api", "name": "Gaetan Rivet", "email": "grive@u256.net" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/openvswitch/patch/32227465e3e15ff243439ed6a75d8f3be4ce24cd.1631094144.git.grive@u256.net/mbox/", "series": [ { "id": 261424, "url": "http://patchwork.ozlabs.org/api/series/261424/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/list/?series=261424", "date": "2021-09-08T09:47:24", "name": "dpif-netdev: Parallel offload processing", "version": 5, "mbox": "http://patchwork.ozlabs.org/series/261424/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1525727/comments/", "check": "success", "checks": "http://patchwork.ozlabs.org/api/patches/1525727/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<ovs-dev-bounces@openvswitch.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "ovs-dev@openvswitch.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "ovs-dev@lists.linuxfoundation.org" ], "Authentication-Results": [ "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=u256.net header.i=@u256.net header.a=rsa-sha256\n header.s=fm2 header.b=f1UTTu8F;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=messagingengine.com header.i=@messagingengine.com\n header.a=rsa-sha256 header.s=fm3 header.b=XsZYRbz4;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=<UNKNOWN>)", "smtp1.osuosl.org (amavisd-new);\n dkim=pass (2048-bit key) header.d=u256.net header.b=\"f1UTTu8F\";\n dkim=pass (2048-bit key) header.d=messagingengine.com\n header.b=\"XsZYRbz4\"" ], "Received": [ "from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4H4HRY48jGz9sW8\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 8 Sep 2021 19:49:45 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 0A9D6613ED;\n\tWed, 8 Sep 2021 09:49:43 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n\tby localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 7vxUrgewzJqN; Wed, 8 Sep 2021 09:49:42 +0000 (UTC)", "from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56])\n\tby smtp3.osuosl.org (Postfix) with ESMTPS id 394C6613D1;\n\tWed, 8 Sep 2021 09:49:41 +0000 (UTC)", "from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id 0F510C001D;\n\tWed, 8 Sep 2021 09:49:41 +0000 (UTC)", "from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n by lists.linuxfoundation.org (Postfix) with ESMTP id 27448C0011\n for <ovs-dev@openvswitch.org>; Wed, 8 Sep 2021 09:49:40 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 2A82A83336\n for <ovs-dev@openvswitch.org>; Wed, 8 Sep 2021 09:48:33 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id hID06uh7y-Xx for <ovs-dev@openvswitch.org>;\n Wed, 8 Sep 2021 09:48:32 +0000 (UTC)", "from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com\n [64.147.123.19])\n by smtp1.osuosl.org (Postfix) with ESMTPS id B7F6D830E3\n for <ovs-dev@openvswitch.org>; Wed, 8 Sep 2021 09:48:27 +0000 (UTC)", "from compute2.internal (compute2.nyi.internal [10.202.2.42])\n by mailout.west.internal (Postfix) with ESMTP id 1AE9732009D1;\n Wed, 8 Sep 2021 05:48:27 -0400 (EDT)", "from mailfrontend2 ([10.202.2.163])\n by compute2.internal (MEProxy); Wed, 08 Sep 2021 05:48:27 -0400", "by mail.messagingengine.com (Postfix) with ESMTPA; Wed,\n 8 Sep 2021 05:48:26 -0400 (EDT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.8.0", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=u256.net; h=from\n :to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=fm2; bh=iTsoq1vZbgwH+\n 6UZNXmS6yq+STdbeM7XqvrfKs7Xs/4=; b=f1UTTu8FuG9pNxIvhHrNr8uqChu16\n EpFzXJF6imz4ZsHpPv0pkLuW9mH+r6cBihFn7NC0v2rdSOWZGCKjM+ZH7DuEPM3P\n A5OZZpoFA10+vokuyFfA3TLbUZp+Rb5ja8B8wiaf3cYzCMjYFuILxhIelAHBvGOc\n /Cl59GosP9dQbHQ6hgPy/31tkyJR1zmEZkw7u3+sCKL0mqTapnfNjN1KH9mdtthc\n 5lOCvkxIlJGf/Y+PSOlNCEhUT/oiF9Oz5tSYOJrIdgkpPAkyYbMyJ02t/La+dp1C\n 0yqM++4g4Ks9HBmznDtDq96thRamSfM8ZHfGa/ZTL+YrNd/nRdOKegTIw==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm3; bh=iTsoq1vZbgwH+6UZNXmS6yq+STdbeM7XqvrfKs7Xs/4=; b=XsZYRbz4\n yQxeh/hG60woUPVXRvp7gZCUk9zwO3zw7dl0hvPdgX1a8+Jw2IuE6sfLsYS4X6pC\n BVHy8X7uPFvl2H+mX+luI3PeFFKP0f1TD/ABCNvTVr1Rp2TbhZs5q+r7ypEaJcrD\n Mm/X/+u0TTf/HF4r+WyIWl6j8r1bEZs7Knla5bh3G3SviizFffL9AN5NozO82pb4\n bcpVVzhYS+CU6DETlIGJpWgFOjz6zZ+QiKUCKRE5ysYSzhNLTsHn2VQ+2dcHaMHY\n GHN/Dv0hrYqLXQVCrCLE5QrKb1wdCLGJRExJrgiN2zkrYSMYGXxs1zT6rJJyleHT\n G+0yaDd/Hwpt6g==" ], "X-ME-Sender": "<xms:6oY4YXLznXzcHo12cSER-X6CUUAaKSIHQdiYy7EsqDQo1hOl75B4qQ>\n <xme:6oY4YbIvB4lLS_P33hyrzsszrTDii_ZEQNsnZpWlRraENiYjBQ5lr7vhjBLrQNfTO\n p5wk8BmjCw-br2VIXE>", "X-ME-Received": "\n <xmr:6oY4YfuSYRiLw8xh7CIHH556xEd_WZTTbJi8ZJfG6tJNoqqel1fLoPPqRvIE5qcLB0XBF8uhruXEgBOvMR-RFBlPTQ>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedvtddrudefjedgudekucetufdoteggodetrfdotf\n fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen\n uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne\n cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefirggvthgr\n nhcutfhivhgvthcuoehgrhhivhgvsehuvdehiedrnhgvtheqnecuggftrfgrthhtvghrnh\n ephefgveffkeetheetfeeifedvheelfeejfeehveduteejhfekuedtkeeiuedvteehnecu\n vehluhhsthgvrhfuihiivgepvdenucfrrghrrghmpehmrghilhhfrhhomhepghhrihhvvg\n esuhdvheeirdhnvght", "X-ME-Proxy": "<xmx:6oY4YQaD4Hm5SpbZlsBlwZ0K67LB0FM9_JVb0T1h48mJfhmtYkRtpg>\n <xmx:6oY4YebxGtTP7n3YzlgwwtVjXdtBcir28RqI1HWlMJ3e9vgKJjKuHA>\n <xmx:6oY4YUA_vHnLIk5-Tj8sIirbPsm8qkbNLf2Ps-jvTTDnMrk09JW8nA>\n <xmx:6oY4YRyphuzkj4M-QMpqCaMsXLs9OvKnu0_fSwdwb2sGfDTT0rB95g>", "From": "Gaetan Rivet <grive@u256.net>", "To": "ovs-dev@openvswitch.org", "Date": "Wed, 8 Sep 2021 11:47:40 +0200", "Message-Id": "\n <32227465e3e15ff243439ed6a75d8f3be4ce24cd.1631094144.git.grive@u256.net>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<cover.1631094144.git.grive@u256.net>", "References": "<cover.1631094144.git.grive@u256.net>", "MIME-Version": "1.0", "Cc": "Eli Britstein <elibr@nvidia.com>,\n Maxime Coquelin <maxime.coquelin@redhat.com>", "Subject": "[ovs-dev] [PATCH v5 16/27] dpif-netdev: Postpone flow offload item\n\tfreeing", "X-BeenThere": "ovs-dev@openvswitch.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "<ovs-dev.openvswitch.org>", "List-Unsubscribe": "<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>", "List-Archive": "<http://mail.openvswitch.org/pipermail/ovs-dev/>", "List-Post": "<mailto:ovs-dev@openvswitch.org>", "List-Help": "<mailto:ovs-dev-request@openvswitch.org?subject=help>", "List-Subscribe": "<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "ovs-dev-bounces@openvswitch.org", "Sender": "\"dev\" <ovs-dev-bounces@openvswitch.org>" }, "content": "Profiling the HW offload thread, the flow offload freeing takes\napproximatively 25% of the time. Most of this time is spent waiting on\nthe futex used by the libc free(), as it triggers a syscall and\nreschedule the thread.\n\nAvoid the syscall and its expensive context switch. Batch the offload\nmessages freeing using the RCU.\n\nSigned-off-by: Gaetan Rivet <grive@u256.net>\nReviewed-by: Eli Britstein <elibr@nvidia.com>\nReviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/dpif-netdev.c | 11 ++++++++---\n 1 file changed, 8 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c\nindex c4672e6e5..c3d211858 100644\n--- a/lib/dpif-netdev.c\n+++ b/lib/dpif-netdev.c\n@@ -2544,14 +2544,19 @@ dp_netdev_alloc_flow_offload(struct dp_netdev_pmd_thread *pmd,\n return offload;\n }\n \n+static void\n+dp_netdev_free_flow_offload__(struct dp_offload_thread_item *offload)\n+{\n+ free(offload->actions);\n+ free(offload);\n+}\n+\n static void\n dp_netdev_free_flow_offload(struct dp_offload_thread_item *offload)\n {\n dp_netdev_pmd_unref(offload->pmd);\n dp_netdev_flow_unref(offload->flow);\n-\n- free(offload->actions);\n- free(offload);\n+ ovsrcu_postpone(dp_netdev_free_flow_offload__, offload);\n }\n \n static void\n", "prefixes": [ "ovs-dev", "v5", "16/27" ] }