Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1525576/?format=api
{ "id": 1525576, "url": "http://patchwork.ozlabs.org/api/patches/1525576/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ovn/patch/20210907224516.489604-10-blp@ovn.org/", "project": { "id": 68, "url": "http://patchwork.ozlabs.org/api/projects/68/?format=api", "name": "Open Virtual Network development", "link_name": "ovn", "list_id": "ovs-dev.openvswitch.org", "list_email": "ovs-dev@openvswitch.org", "web_url": "http://openvswitch.org/", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20210907224516.489604-10-blp@ovn.org>", "list_archive_url": null, "date": "2021-09-07T22:45:15", "name": "[ovs-dev,v2,09/10] ovn-northd-ddlog: Avoid map(ival) for ARP flows.", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "1e7047f71be97a07c480fa764e59fec5beae48a5", "submitter": { "id": 67603, "url": "http://patchwork.ozlabs.org/api/people/67603/?format=api", "name": "Ben Pfaff", "email": "blp@ovn.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/ovn/patch/20210907224516.489604-10-blp@ovn.org/mbox/", "series": [ { "id": 261352, "url": "http://patchwork.ozlabs.org/api/series/261352/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ovn/list/?series=261352", "date": "2021-09-07T22:45:06", "name": "3x performance improvement for ddlog with load balancer benchmark", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/261352/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1525576/comments/", "check": "fail", "checks": "http://patchwork.ozlabs.org/api/patches/1525576/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<ovs-dev-bounces@openvswitch.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "dev@openvswitch.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "ovs-dev@lists.linuxfoundation.org" ], "Authentication-Results": "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=140.211.166.138; helo=smtp1.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=<UNKNOWN>)", "Received": [ "from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4H40jh1SxQz9t1Q\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 8 Sep 2021 08:46:00 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 3D8BD80CA5;\n\tTue, 7 Sep 2021 22:45:58 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n\tby localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 5qNNi6ReRxUo; Tue, 7 Sep 2021 22:45:55 +0000 (UTC)", "from lists.linuxfoundation.org (lf-lists.osuosl.org\n [IPv6:2605:bc80:3010:104::8cd3:938])\n\tby smtp1.osuosl.org (Postfix) with ESMTPS id CC28480C93;\n\tTue, 7 Sep 2021 22:45:50 +0000 (UTC)", "from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id 777E5C0020;\n\tTue, 7 Sep 2021 22:45:47 +0000 (UTC)", "from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133])\n by lists.linuxfoundation.org (Postfix) with ESMTP id 0C984C0026\n for <dev@openvswitch.org>; Tue, 7 Sep 2021 22:45:46 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id 07A89402CF\n for <dev@openvswitch.org>; Tue, 7 Sep 2021 22:45:42 +0000 (UTC)", "from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id eoNGtcqymE2y for <dev@openvswitch.org>;\n Tue, 7 Sep 2021 22:45:41 +0000 (UTC)", "from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net\n [217.70.183.201])\n by smtp2.osuosl.org (Postfix) with ESMTPS id 8431F40104\n for <dev@openvswitch.org>; Tue, 7 Sep 2021 22:45:40 +0000 (UTC)", "(Authenticated sender: blp@ovn.org)\n by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id C03421BF205;\n Tue, 7 Sep 2021 22:45:37 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.8.0", "From": "Ben Pfaff <blp@ovn.org>", "To": "dev@openvswitch.org", "Date": "Tue, 7 Sep 2021 15:45:15 -0700", "Message-Id": "<20210907224516.489604-10-blp@ovn.org>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20210907224516.489604-1-blp@ovn.org>", "References": "<20210907224516.489604-1-blp@ovn.org>", "MIME-Version": "1.0", "Cc": "Leonid Ryzhyk <lryzhyk@vmware.com>, Ben Pfaff <blp@ovn.org>", "Subject": "[ovs-dev] [PATCH ovn v2 09/10] ovn-northd-ddlog: Avoid map(ival)\n\tfor ARP flows.", "X-BeenThere": "ovs-dev@openvswitch.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "<ovs-dev.openvswitch.org>", "List-Unsubscribe": "<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>", "List-Archive": "<http://mail.openvswitch.org/pipermail/ovs-dev/>", "List-Post": "<mailto:ovs-dev@openvswitch.org>", "List-Help": "<mailto:ovs-dev-request@openvswitch.org?subject=help>", "List-Subscribe": "<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "ovs-dev-bounces@openvswitch.org", "Sender": "\"dev\" <ovs-dev-bounces@openvswitch.org>" }, "content": "It's expensive for a long list. All it buys us is sorting the list in\nalphabetical order (rather than in order of Intern hash value), which isn't\nthat valuable.\n\nThis also updates a test that depended on the sort order.\n\nSuggested-by: Leonid Ryzhyk <lryzhyk@vmware.com>\nSigned-off-by: Ben Pfaff <blp@ovn.org>\n---\n northd/ovn_northd.dl | 2 +-\n tests/ovn-northd.at | 20 ++++++++++++++------\n 2 files changed, 15 insertions(+), 7 deletions(-)", "diff": "diff --git a/northd/ovn_northd.dl b/northd/ovn_northd.dl\nindex 1bf1e5333..573c2b392 100644\n--- a/northd/ovn_northd.dl\n+++ b/northd/ovn_northd.dl\n@@ -5679,7 +5679,7 @@ var residence_check = match (is_redirect) {\n not all_ipv4s.is_empty() in\n LogicalRouterArpFlow(.lr = router,\n .lrp = Some{lrp},\n- .ip = i\"{ ${all_ipv4s.map(ival).to_vec().join(\\\", \\\")} }\",\n+ .ip = i\"{ ${all_ipv4s.to_vec().join(\\\", \\\")} }\",\n .mac = rEG_INPORT_ETH_ADDR(),\n .extra_match = residence_check,\n .drop = false,\ndiff --git a/tests/ovn-northd.at b/tests/ovn-northd.at\nindex 11886b94e..c2db8f53a 100644\n--- a/tests/ovn-northd.at\n+++ b/tests/ovn-northd.at\n@@ -1685,8 +1685,16 @@ match=(eth.mcast && inport == \"lrp-public\"), dnl\n action=(xreg0[[0..47]] = 00:00:00:00:01:00; next;)\n ])\n \n+# The order of the VIP addresses in the flow table entries doesn't\n+# matter, so just replace each of them with a generic $vip for\n+# testing. It would be better if we could ensure each one appeared\n+# exactly once, but that's hard with sed.\n+sed_vips() {\n+ sed 's/192\\.168\\.2\\.[[1456]]/$vip/g'\n+}\n+\n # Ingress router port ETH address is used for ARP reply/NA in lr_in_ip_input.\n-AT_CHECK([ovn-sbctl lflow-list | grep -E \"lr_in_ip_input.*priority=90\" | grep \"arp\\|nd\" | sort], [0], [dnl\n+AT_CHECK([ovn-sbctl lflow-list | grep -E \"lr_in_ip_input.*priority=90\" | grep \"arp\\|nd\" | sed_vips | sort], [0], [dnl\n table=3 (lr_in_ip_input ), priority=90 , dnl\n match=(arp.op == 1 && arp.tpa == 43.43.43.150), dnl\n action=(eth.dst = eth.src; eth.src = xreg0[[0..47]]; arp.op = 2; /* ARP reply */ arp.tha = arp.sha; arp.sha = xreg0[[0..47]]; arp.tpa <-> arp.spa; outport = inport; flags.loopback = 1; output;)\n@@ -1703,7 +1711,7 @@ action=(eth.dst = eth.src; eth.src = xreg0[[0..47]]; arp.op = 2; /* ARP reply */\n match=(inport == \"lrp\" && arp.op == 1 && arp.tpa == 42.42.42.1 && arp.spa == 42.42.42.0/24), dnl\n action=(eth.dst = eth.src; eth.src = xreg0[[0..47]]; arp.op = 2; /* ARP reply */ arp.tha = arp.sha; arp.sha = xreg0[[0..47]]; arp.tpa <-> arp.spa; outport = inport; flags.loopback = 1; output;)\n table=3 (lr_in_ip_input ), priority=90 , dnl\n-match=(inport == \"lrp\" && arp.op == 1 && arp.tpa == { 192.168.2.1, 192.168.2.4, 192.168.2.5, 192.168.2.6 }), dnl\n+match=(inport == \"lrp\" && arp.op == 1 && arp.tpa == { $vip, $vip, $vip, $vip }), dnl\n action=(eth.dst = eth.src; eth.src = xreg0[[0..47]]; arp.op = 2; /* ARP reply */ arp.tha = arp.sha; arp.sha = xreg0[[0..47]]; arp.tpa <-> arp.spa; outport = inport; flags.loopback = 1; output;)\n table=3 (lr_in_ip_input ), priority=90 , dnl\n match=(inport == \"lrp\" && ip6.dst == {fe80::200:ff:fe00:1, ff02::1:ff00:1} && nd_ns && nd.target == fe80::200:ff:fe00:1), dnl\n@@ -1718,7 +1726,7 @@ action=(nd_na { eth.src = xreg0[[0..47]]; ip6.src = fe80::200:ff:fe00:102:8080;\n match=(inport == \"lrp-public\" && arp.op == 1 && arp.tpa == 43.43.43.1 && arp.spa == 43.43.43.0/24), dnl\n action=(eth.dst = eth.src; eth.src = xreg0[[0..47]]; arp.op = 2; /* ARP reply */ arp.tha = arp.sha; arp.sha = xreg0[[0..47]]; arp.tpa <-> arp.spa; outport = inport; flags.loopback = 1; output;)\n table=3 (lr_in_ip_input ), priority=90 , dnl\n-match=(inport == \"lrp-public\" && arp.op == 1 && arp.tpa == { 192.168.2.1, 192.168.2.4, 192.168.2.5, 192.168.2.6 }), dnl\n+match=(inport == \"lrp-public\" && arp.op == 1 && arp.tpa == { $vip, $vip, $vip, $vip }), dnl\n action=(eth.dst = eth.src; eth.src = xreg0[[0..47]]; arp.op = 2; /* ARP reply */ arp.tha = arp.sha; arp.sha = xreg0[[0..47]]; arp.tpa <-> arp.spa; outport = inport; flags.loopback = 1; output;)\n table=3 (lr_in_ip_input ), priority=90 , dnl\n match=(inport == \"lrp-public\" && ip6.dst == {fe80::200:ff:fe00:100, ff02::1:ff00:100} && nd_ns && nd.target == fe80::200:ff:fe00:100), dnl\n@@ -1761,7 +1769,7 @@ action=(xreg0[[0..47]] = 00:00:00:00:01:00; next;)\n # Ingress router port is used for ARP reply/NA in lr_in_ip_input.\n # xxreg0[0..47] is used unless external_mac is set.\n # Priority 90 flows (per router).\n-AT_CHECK([ovn-sbctl lflow-list | grep -E \"lr_in_ip_input.*priority=90\" | grep \"arp\\|nd\" | sort], [0], [dnl\n+AT_CHECK([ovn-sbctl lflow-list | grep -E \"lr_in_ip_input.*priority=90\" | grep \"arp\\|nd\" | sed_vips | sort], [0], [dnl\n table=3 (lr_in_ip_input ), priority=90 , dnl\n match=(arp.op == 1 && arp.tpa == 43.43.43.150), dnl\n action=(eth.dst = eth.src; eth.src = xreg0[[0..47]]; arp.op = 2; /* ARP reply */ arp.tha = arp.sha; arp.sha = xreg0[[0..47]]; arp.tpa <-> arp.spa; outport = inport; flags.loopback = 1; output;)\n@@ -1778,7 +1786,7 @@ action=(eth.dst = eth.src; eth.src = xreg0[[0..47]]; arp.op = 2; /* ARP reply */\n match=(inport == \"lrp\" && arp.op == 1 && arp.tpa == 42.42.42.1 && arp.spa == 42.42.42.0/24), dnl\n action=(eth.dst = eth.src; eth.src = xreg0[[0..47]]; arp.op = 2; /* ARP reply */ arp.tha = arp.sha; arp.sha = xreg0[[0..47]]; arp.tpa <-> arp.spa; outport = inport; flags.loopback = 1; output;)\n table=3 (lr_in_ip_input ), priority=90 , dnl\n-match=(inport == \"lrp\" && arp.op == 1 && arp.tpa == { 192.168.2.1, 192.168.2.4, 192.168.2.5, 192.168.2.6 }), dnl\n+match=(inport == \"lrp\" && arp.op == 1 && arp.tpa == { $vip, $vip, $vip, $vip }), dnl\n action=(eth.dst = eth.src; eth.src = xreg0[[0..47]]; arp.op = 2; /* ARP reply */ arp.tha = arp.sha; arp.sha = xreg0[[0..47]]; arp.tpa <-> arp.spa; outport = inport; flags.loopback = 1; output;)\n table=3 (lr_in_ip_input ), priority=90 , dnl\n match=(inport == \"lrp\" && ip6.dst == {fe80::200:ff:fe00:1, ff02::1:ff00:1} && nd_ns && nd.target == fe80::200:ff:fe00:1), dnl\n@@ -1793,7 +1801,7 @@ action=(nd_na { eth.src = xreg0[[0..47]]; ip6.src = fe80::200:ff:fe00:102:8080;\n match=(inport == \"lrp-public\" && arp.op == 1 && arp.tpa == 43.43.43.1 && arp.spa == 43.43.43.0/24), dnl\n action=(eth.dst = eth.src; eth.src = xreg0[[0..47]]; arp.op = 2; /* ARP reply */ arp.tha = arp.sha; arp.sha = xreg0[[0..47]]; arp.tpa <-> arp.spa; outport = inport; flags.loopback = 1; output;)\n table=3 (lr_in_ip_input ), priority=90 , dnl\n-match=(inport == \"lrp-public\" && arp.op == 1 && arp.tpa == { 192.168.2.1, 192.168.2.4, 192.168.2.5, 192.168.2.6 } && is_chassis_resident(\"cr-lrp-public\")), dnl\n+match=(inport == \"lrp-public\" && arp.op == 1 && arp.tpa == { $vip, $vip, $vip, $vip } && is_chassis_resident(\"cr-lrp-public\")), dnl\n action=(eth.dst = eth.src; eth.src = xreg0[[0..47]]; arp.op = 2; /* ARP reply */ arp.tha = arp.sha; arp.sha = xreg0[[0..47]]; arp.tpa <-> arp.spa; outport = inport; flags.loopback = 1; output;)\n table=3 (lr_in_ip_input ), priority=90 , dnl\n match=(inport == \"lrp-public\" && ip6.dst == {fe80::200:ff:fe00:100, ff02::1:ff00:100} && nd_ns && nd.target == fe80::200:ff:fe00:100 && is_chassis_resident(\"cr-lrp-public\")), dnl\n", "prefixes": [ "ovs-dev", "v2", "09/10" ] }