Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1525575/?format=api
{ "id": 1525575, "url": "http://patchwork.ozlabs.org/api/patches/1525575/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ovn/patch/20210907224516.489604-11-blp@ovn.org/", "project": { "id": 68, "url": "http://patchwork.ozlabs.org/api/projects/68/?format=api", "name": "Open Virtual Network development", "link_name": "ovn", "list_id": "ovs-dev.openvswitch.org", "list_email": "ovs-dev@openvswitch.org", "web_url": "http://openvswitch.org/", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20210907224516.489604-11-blp@ovn.org>", "list_archive_url": null, "date": "2021-09-07T22:45:16", "name": "[ovs-dev,v2,10/10] ovn-northd-ddlog: Avoid unnecessary joins for SwitchPortARPForwards.", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "442e9be3060b0469e7ec498d45b86ba5820b2b2b", "submitter": { "id": 67603, "url": "http://patchwork.ozlabs.org/api/people/67603/?format=api", "name": "Ben Pfaff", "email": "blp@ovn.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/ovn/patch/20210907224516.489604-11-blp@ovn.org/mbox/", "series": [ { "id": 261352, "url": "http://patchwork.ozlabs.org/api/series/261352/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ovn/list/?series=261352", "date": "2021-09-07T22:45:06", "name": "3x performance improvement for ddlog with load balancer benchmark", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/261352/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1525575/comments/", "check": "fail", "checks": "http://patchwork.ozlabs.org/api/patches/1525575/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<ovs-dev-bounces@openvswitch.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "dev@openvswitch.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "ovs-dev@lists.linuxfoundation.org" ], "Authentication-Results": "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=140.211.166.133; helo=smtp2.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=<UNKNOWN>)", "Received": [ "from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4H40jg3nd9z9t10\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 8 Sep 2021 08:45:59 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby smtp2.osuosl.org (Postfix) with ESMTP id 83B24406FF;\n\tTue, 7 Sep 2021 22:45:57 +0000 (UTC)", "from smtp2.osuosl.org ([127.0.0.1])\n\tby localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id PIpz-m8me60J; Tue, 7 Sep 2021 22:45:56 +0000 (UTC)", "from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56])\n\tby smtp2.osuosl.org (Postfix) with ESMTPS id 19A78406DC;\n\tTue, 7 Sep 2021 22:45:53 +0000 (UTC)", "from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id 8EF48C001D;\n\tTue, 7 Sep 2021 22:45:49 +0000 (UTC)", "from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n by lists.linuxfoundation.org (Postfix) with ESMTP id 19C57C002C\n for <dev@openvswitch.org>; Tue, 7 Sep 2021 22:45:48 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 5686080C3F\n for <dev@openvswitch.org>; Tue, 7 Sep 2021 22:45:43 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id IX7uMoeOm3s0 for <dev@openvswitch.org>;\n Tue, 7 Sep 2021 22:45:42 +0000 (UTC)", "from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net\n [217.70.183.201])\n by smtp1.osuosl.org (Postfix) with ESMTPS id E88DF80CB0\n for <dev@openvswitch.org>; Tue, 7 Sep 2021 22:45:41 +0000 (UTC)", "(Authenticated sender: blp@ovn.org)\n by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 707FA1BF203;\n Tue, 7 Sep 2021 22:45:39 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.8.0", "From": "Ben Pfaff <blp@ovn.org>", "To": "dev@openvswitch.org", "Date": "Tue, 7 Sep 2021 15:45:16 -0700", "Message-Id": "<20210907224516.489604-11-blp@ovn.org>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20210907224516.489604-1-blp@ovn.org>", "References": "<20210907224516.489604-1-blp@ovn.org>", "MIME-Version": "1.0", "Cc": "Ben Pfaff <blp@ovn.org>", "Subject": "[ovs-dev] [PATCH ovn v2 10/10] ovn-northd-ddlog: Avoid unnecessary\n\tjoins for SwitchPortARPForwards.", "X-BeenThere": "ovs-dev@openvswitch.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "<ovs-dev.openvswitch.org>", "List-Unsubscribe": "<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>", "List-Archive": "<http://mail.openvswitch.org/pipermail/ovs-dev/>", "List-Post": "<mailto:ovs-dev@openvswitch.org>", "List-Help": "<mailto:ovs-dev-request@openvswitch.org?subject=help>", "List-Subscribe": "<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "ovs-dev-bounces@openvswitch.org", "Sender": "\"dev\" <ovs-dev-bounces@openvswitch.org>" }, "content": "SwitchPortARPForwards already has all the necessary data in it and joining\nwith SwitchPort just wastes time.\n\nSigned-off-by: Ben Pfaff <blp@ovn.org>\n---\n northd/ovn_northd.dl | 12 ++++--------\n 1 file changed, 4 insertions(+), 8 deletions(-)", "diff": "diff --git a/northd/ovn_northd.dl b/northd/ovn_northd.dl\nindex 573c2b392..201c08a24 100644\n--- a/northd/ovn_northd.dl\n+++ b/northd/ovn_northd.dl\n@@ -4612,8 +4612,7 @@ Flow(.logical_datapath = sw._uuid,\n .io_port = None,\n .controller_meter = None) :-\n var mc_flood_l2 = json_escape(mC_FLOOD_L2().0),\n- sp in &SwitchPort(.sw = sw, .peer = Some{rp@&RouterPort{.enabled = true}}),\n- &SwitchPortARPForwards(.port = sp, .reachable_ips_v4 = ips_v4),\n+ &SwitchPortARPForwards(.port = sp@&SwitchPort{.sw = sw}, .reachable_ips_v4 = ips_v4),\n var ipv4 = FlatMap(ips_v4).\n Flow(.logical_datapath = sw._uuid,\n .stage = s_SWITCH_IN_L2_LKUP(),\n@@ -4629,8 +4628,7 @@ Flow(.logical_datapath = sw._uuid,\n .io_port = None,\n .controller_meter = None) :-\n var mc_flood_l2 = json_escape(mC_FLOOD_L2().0),\n- sp in &SwitchPort(.sw = sw, .peer = Some{rp@&RouterPort{.enabled = true}}),\n- &SwitchPortARPForwards(.port = sp, .reachable_ips_v6 = ips_v6),\n+ &SwitchPortARPForwards(.port = sp@&SwitchPort{.sw = sw}, .reachable_ips_v6 = ips_v6),\n var ipv6 = FlatMap(ips_v6).\n \n Flow(.logical_datapath = sw._uuid,\n@@ -4642,8 +4640,7 @@ Flow(.logical_datapath = sw._uuid,\n .io_port = None,\n .controller_meter = None) :-\n var actions = i\"outport = ${json_escape(mC_FLOOD().0)}; output;\",\n- sp in &SwitchPort(.sw = sw, .peer = Some{rp@&RouterPort{.enabled = true}}),\n- &SwitchPortARPForwards(.port = sp, .unreachable_ips_v4 = ips_v4),\n+ &SwitchPortARPForwards(.port = sp@&SwitchPort{.sw = sw}, .unreachable_ips_v4 = ips_v4),\n var ipv4 = FlatMap(ips_v4).\n Flow(.logical_datapath = sw._uuid,\n .stage = s_SWITCH_IN_L2_LKUP(),\n@@ -4654,8 +4651,7 @@ Flow(.logical_datapath = sw._uuid,\n .io_port = None,\n .controller_meter = None) :-\n var actions = i\"outport = ${json_escape(mC_FLOOD().0)}; output;\",\n- sp in &SwitchPort(.sw = sw, .peer = Some{rp@&RouterPort{.enabled = true}}),\n- &SwitchPortARPForwards(.port = sp, .unreachable_ips_v6 = ips_v6),\n+ &SwitchPortARPForwards(.port = sp@&SwitchPort{.sw = sw}, .unreachable_ips_v6 = ips_v6),\n var ipv6 = FlatMap(ips_v6).\n \n for (SwitchPortNewDynamicAddress(.port = &SwitchPort{.lsp = lsp, .json_name = json_name, .sw = sw},\n", "prefixes": [ "ovs-dev", "v2", "10/10" ] }