Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1525568/?format=api
{ "id": 1525568, "url": "http://patchwork.ozlabs.org/api/patches/1525568/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ovn/patch/20210907224516.489604-3-blp@ovn.org/", "project": { "id": 68, "url": "http://patchwork.ozlabs.org/api/projects/68/?format=api", "name": "Open Virtual Network development", "link_name": "ovn", "list_id": "ovs-dev.openvswitch.org", "list_email": "ovs-dev@openvswitch.org", "web_url": "http://openvswitch.org/", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20210907224516.489604-3-blp@ovn.org>", "list_archive_url": null, "date": "2021-09-07T22:45:08", "name": "[ovs-dev,v2,02/10] ovn-northd-ddlog: Make joins for ARP/ND flows slightly more efficient.", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "680467b3643917640782ba2b5a71693e7c9922f0", "submitter": { "id": 67603, "url": "http://patchwork.ozlabs.org/api/people/67603/?format=api", "name": "Ben Pfaff", "email": "blp@ovn.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/ovn/patch/20210907224516.489604-3-blp@ovn.org/mbox/", "series": [ { "id": 261352, "url": "http://patchwork.ozlabs.org/api/series/261352/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ovn/list/?series=261352", "date": "2021-09-07T22:45:06", "name": "3x performance improvement for ddlog with load balancer benchmark", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/261352/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1525568/comments/", "check": "fail", "checks": "http://patchwork.ozlabs.org/api/patches/1525568/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<ovs-dev-bounces@openvswitch.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "dev@openvswitch.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "ovs-dev@lists.linuxfoundation.org" ], "Authentication-Results": "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=<UNKNOWN>)", "Received": [ "from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4H40jR1YWxz9t1Q\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 8 Sep 2021 08:45:47 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 5E6016084D;\n\tTue, 7 Sep 2021 22:45:38 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n\tby localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 5WcpNvJrlgQN; Tue, 7 Sep 2021 22:45:37 +0000 (UTC)", "from lists.linuxfoundation.org (lf-lists.osuosl.org\n [IPv6:2605:bc80:3010:104::8cd3:938])\n\tby smtp3.osuosl.org (Postfix) with ESMTPS id 88E3B607A6;\n\tTue, 7 Sep 2021 22:45:36 +0000 (UTC)", "from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id BDFDBC0020;\n\tTue, 7 Sep 2021 22:45:34 +0000 (UTC)", "from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133])\n by lists.linuxfoundation.org (Postfix) with ESMTP id 64787C000D\n for <dev@openvswitch.org>; Tue, 7 Sep 2021 22:45:33 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id 0551B40104\n for <dev@openvswitch.org>; Tue, 7 Sep 2021 22:45:32 +0000 (UTC)", "from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id nnDr-yHxSx25 for <dev@openvswitch.org>;\n Tue, 7 Sep 2021 22:45:31 +0000 (UTC)", "from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net\n [217.70.183.201])\n by smtp2.osuosl.org (Postfix) with ESMTPS id CB3FC402B5\n for <dev@openvswitch.org>; Tue, 7 Sep 2021 22:45:30 +0000 (UTC)", "(Authenticated sender: blp@ovn.org)\n by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 714501BF205;\n Tue, 7 Sep 2021 22:45:28 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.8.0", "From": "Ben Pfaff <blp@ovn.org>", "To": "dev@openvswitch.org", "Date": "Tue, 7 Sep 2021 15:45:08 -0700", "Message-Id": "<20210907224516.489604-3-blp@ovn.org>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20210907224516.489604-1-blp@ovn.org>", "References": "<20210907224516.489604-1-blp@ovn.org>", "MIME-Version": "1.0", "Cc": "Ben Pfaff <blp@ovn.org>", "Subject": "[ovs-dev] [PATCH ovn v2 02/10] ovn-northd-ddlog: Make joins for\n\tARP/ND flows slightly more efficient.", "X-BeenThere": "ovs-dev@openvswitch.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "<ovs-dev.openvswitch.org>", "List-Unsubscribe": "<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>", "List-Archive": "<http://mail.openvswitch.org/pipermail/ovs-dev/>", "List-Post": "<mailto:ovs-dev@openvswitch.org>", "List-Help": "<mailto:ovs-dev-request@openvswitch.org?subject=help>", "List-Subscribe": "<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "ovs-dev-bounces@openvswitch.org", "Sender": "\"dev\" <ovs-dev-bounces@openvswitch.org>" }, "content": "DDlog can index equality joins within a expression like this, but not\nconditional expression that follow such an expression. This doesn't\nactually matter much in this case because ordinarily the expression\nwill be true (most router ports are enabled).\n\nSigned-off-by: Ben Pfaff <blp@ovn.org>\n---\n northd/lrouter.dl | 6 ++++--\n northd/ovn_northd.dl | 16 +++++-----------\n 2 files changed, 9 insertions(+), 13 deletions(-)", "diff": "diff --git a/northd/lrouter.dl b/northd/lrouter.dl\nindex cc3dced5f..b6e752f7c 100644\n--- a/northd/lrouter.dl\n+++ b/northd/lrouter.dl\n@@ -596,7 +596,8 @@ typedef RouterPort = RouterPort {\n peer: RouterPeer,\n mcast_cfg: Intern<McastPortCfg>,\n sb_options: Map<istring,istring>,\n- has_bfd: bool\n+ has_bfd: bool,\n+ enabled: bool\n }\n \n relation RouterPort[Intern<RouterPort>]\n@@ -610,7 +611,8 @@ RouterPort[RouterPort{\n .peer = peer,\n .mcast_cfg = mcast_cfg,\n .sb_options = sb_options,\n- .has_bfd = has_bfd\n+ .has_bfd = has_bfd,\n+ .enabled = lrp.is_enabled()\n }.intern()] :-\n lrp in &nb::Logical_Router_Port(),\n Some{var networks} = extract_lrp_networks(lrp.mac.ival(), lrp.networks.map(ival)),\ndiff --git a/northd/ovn_northd.dl b/northd/ovn_northd.dl\nindex 4402b17d2..c41a79b84 100644\n--- a/northd/ovn_northd.dl\n+++ b/northd/ovn_northd.dl\n@@ -4609,8 +4609,7 @@ relation &SwitchPortARPForwards(\n .reachable_ips_v6 = reachable_ips_v6,\n .unreachable_ips_v4 = unreachable_ips_v4,\n .unreachable_ips_v6 = unreachable_ips_v6) :-\n- port in &SwitchPort(.peer = Some{rp}),\n- rp.is_enabled(),\n+ port in &SwitchPort(.peer = Some{rp@&RouterPort{.enabled = true}}),\n (var reachable_ips_v4, var reachable_ips_v6, var unreachable_ips_v4, var unreachable_ips_v6) = get_arp_forward_ips(rp).\n \n /* Packets received from VXLAN tunnels have already been through the\n@@ -4632,8 +4631,7 @@ Flow(.logical_datapath = sw._uuid,\n .stage_hint = stage_hint(sp.lsp._uuid),\n .io_port = None,\n .controller_meter = None) :-\n- sp in &SwitchPort(.sw = sw, .peer = Some{rp}),\n- rp.is_enabled(),\n+ sp in &SwitchPort(.sw = sw, .peer = Some{rp@&RouterPort{.enabled = true}}),\n &SwitchPortARPForwards(.port = sp, .reachable_ips_v4 = ips_v4),\n var ipv4 = FlatMap(ips_v4),\n var mc_flood_l2 = json_escape(mC_FLOOD_L2().0).\n@@ -4650,8 +4648,7 @@ Flow(.logical_datapath = sw._uuid,\n .stage_hint = stage_hint(sp.lsp._uuid),\n .io_port = None,\n .controller_meter = None) :-\n- sp in &SwitchPort(.sw = sw, .peer = Some{rp}),\n- rp.is_enabled(),\n+ sp in &SwitchPort(.sw = sw, .peer = Some{rp@&RouterPort{.enabled = true}}),\n &SwitchPortARPForwards(.port = sp, .reachable_ips_v6 = ips_v6),\n var ipv6 = FlatMap(ips_v6),\n var mc_flood_l2 = json_escape(mC_FLOOD_L2().0).\n@@ -4664,12 +4661,10 @@ Flow(.logical_datapath = sw._uuid,\n .stage_hint = 0,\n .io_port = None,\n .controller_meter = None) :-\n- sp in &SwitchPort(.sw = sw, .peer = Some{rp}),\n- rp.is_enabled(),\n+ sp in &SwitchPort(.sw = sw, .peer = Some{rp@&RouterPort{.enabled = true}}),\n &SwitchPortARPForwards(.port = sp, .unreachable_ips_v4 = ips_v4),\n var ipv4 = FlatMap(ips_v4),\n var flood = json_escape(mC_FLOOD().0).\n-\n Flow(.logical_datapath = sw._uuid,\n .stage = s_SWITCH_IN_L2_LKUP(),\n .priority = 90,\n@@ -4678,8 +4673,7 @@ Flow(.logical_datapath = sw._uuid,\n .stage_hint = stage_hint(sp.lsp._uuid),\n .io_port = None,\n .controller_meter = None) :-\n- sp in &SwitchPort(.sw = sw, .peer = Some{rp}),\n- rp.is_enabled(),\n+ sp in &SwitchPort(.sw = sw, .peer = Some{rp@&RouterPort{.enabled = true}}),\n &SwitchPortARPForwards(.port = sp, .unreachable_ips_v6 = ips_v6),\n var ipv6 = FlatMap(ips_v6),\n var flood = json_escape(mC_FLOOD().0).\n", "prefixes": [ "ovs-dev", "v2", "02/10" ] }