Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1524284/?format=api
{ "id": 1524284, "url": "http://patchwork.ozlabs.org/api/patches/1524284/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ovn/patch/20210903122148.826196-4-mark.d.gray@redhat.com/", "project": { "id": 68, "url": "http://patchwork.ozlabs.org/api/projects/68/?format=api", "name": "Open Virtual Network development", "link_name": "ovn", "list_id": "ovs-dev.openvswitch.org", "list_email": "ovs-dev@openvswitch.org", "web_url": "http://openvswitch.org/", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20210903122148.826196-4-mark.d.gray@redhat.com>", "list_archive_url": null, "date": "2021-09-03T12:21:44", "name": "[ovs-dev,v4,3/7] inc-proc-eng: Allow definition of engine_node with global scope", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "4f80b8ac3f119a729768378169c651908a36e64d", "submitter": { "id": 79963, "url": "http://patchwork.ozlabs.org/api/people/79963/?format=api", "name": "Mark Gray", "email": "mark.d.gray@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/ovn/patch/20210903122148.826196-4-mark.d.gray@redhat.com/mbox/", "series": [ { "id": 260884, "url": "http://patchwork.ozlabs.org/api/series/260884/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ovn/list/?series=260884", "date": "2021-09-03T12:21:41", "name": "northd: Split northd and northd incremental processing framework", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/260884/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1524284/comments/", "check": "fail", "checks": "http://patchwork.ozlabs.org/api/patches/1524284/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<ovs-dev-bounces@openvswitch.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "dev@openvswitch.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "ovs-dev@lists.linuxfoundation.org" ], "Authentication-Results": [ "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=BrbX0zQr;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=<UNKNOWN>)", "smtp4.osuosl.org (amavisd-new);\n dkim=pass (1024-bit key) header.d=redhat.com", "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mark.d.gray@redhat.com" ], "Received": [ "from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4H1H3f3QKlz9sPf\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 3 Sep 2021 22:22:05 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id ED40283E53;\n\tFri, 3 Sep 2021 12:22:02 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n\tby localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id tjPOkDG6Wm2p; Fri, 3 Sep 2021 12:22:02 +0000 (UTC)", "from lists.linuxfoundation.org (lf-lists.osuosl.org\n [IPv6:2605:bc80:3010:104::8cd3:938])\n\tby smtp1.osuosl.org (Postfix) with ESMTPS id 30A1D83E58;\n\tFri, 3 Sep 2021 12:22:01 +0000 (UTC)", "from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id F38FAC0010;\n\tFri, 3 Sep 2021 12:22:00 +0000 (UTC)", "from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n by lists.linuxfoundation.org (Postfix) with ESMTP id 572BCC0010\n for <dev@openvswitch.org>; Fri, 3 Sep 2021 12:21:59 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 3794F42682\n for <dev@openvswitch.org>; Fri, 3 Sep 2021 12:21:59 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id HxTCFdqnMCql for <dev@openvswitch.org>;\n Fri, 3 Sep 2021 12:21:58 +0000 (UTC)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [216.205.24.124])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 89D864267C\n for <dev@openvswitch.org>; Fri, 3 Sep 2021 12:21:58 +0000 (UTC)", "from mail-wm1-f70.google.com (mail-wm1-f70.google.com\n [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-597-106gZ6AZNkCkY-reygF4cg-1; Fri, 03 Sep 2021 08:21:56 -0400", "by mail-wm1-f70.google.com with SMTP id\n u1-20020a05600c210100b002e74fc5af71so1824456wml.1\n for <dev@openvswitch.org>; Fri, 03 Sep 2021 05:21:56 -0700 (PDT)", "from wsfd-netdev91.ntdv.lab.eng.bos.redhat.com\n (nat-pool-bos-t.redhat.com. [66.187.233.206])\n by smtp.gmail.com with ESMTPSA id a6sm4836612wrh.97.2021.09.03.05.21.53\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 03 Sep 2021 05:21:54 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.8.0", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1630671717;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=ohdpBT4O5YRZy8kOBlvAIzvbE+byDA+xhmxiOfBgH3E=;\n b=BrbX0zQrBjJbZ+FjyiF5I5F4TTjZmH2FIUF5jOTbz5AdEVi8vWIlCwoP2cMaDDEyyfOArQ\n Ane/B5m5y5h0l7J8MoCVVwE9mYliAAB1A5L5YSreEnPPfdNcGkAu+wbmQK6ZQlmmd1UhT0\n xNLe0BShZguvmpcKlmGqAMkDkve/H/8=", "X-MC-Unique": "106gZ6AZNkCkY-reygF4cg-1", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=ohdpBT4O5YRZy8kOBlvAIzvbE+byDA+xhmxiOfBgH3E=;\n b=IeRSEDOe7mRr47SB6xpAH0SYMD+ac7XIN8fiTlAAwM3ia/bkGxn0idIITFKIfCxBbr\n D2+AmCYvObx1Nejsrdn4ilQYapLVAY3YSlBZ8caFkKu7gZDlA3lIWjzFrSmWCOt5iYOH\n 2ABwynIbGKdK4c29yC9/bxZB9MDpmU2fFXHuydw9CiRA00IR54toYEXz/syIjPMGSDmB\n 7eX98VXyW4fJIZxh9JucQuvzQ6Ugg/+vOEo+oH3lEu88czZi46tCRweY5L//MWX3lYD4\n LSZxGzwlW/u4cNNXGaMDVGo9LwjogAE/BVmVpDLxL/ExlApDea68YdIsVQr3E76JoWNp\n JChw==", "X-Gm-Message-State": "AOAM533nYoNC7h1gU8kBl20/XI47FVhbQRY5Ez1sER6SiJ1xAX8bVUYN\n fKfb+fR4/pe/JHpcwKiBkrjm6pAcqnln5LYq/19OYXq4V42z8fyERVbG/8EwRr6P+pWC7PF6Oso\n XZLz05ftlo0aUf4AAULH/ouuFskm3JVpTbSpfGRUxtEt5FEPJfn7I9kJAq3DJXf/LyNwO", "X-Received": [ "by 2002:adf:8170:: with SMTP id 103mr3773231wrm.167.1630671715364;\n Fri, 03 Sep 2021 05:21:55 -0700 (PDT)", "by 2002:adf:8170:: with SMTP id 103mr3773207wrm.167.1630671715123;\n Fri, 03 Sep 2021 05:21:55 -0700 (PDT)" ], "X-Google-Smtp-Source": "\n ABdhPJwLh+xjMX3JPZVNGPFrjAyox6UlIMRU+uLuYqm0x4NNeGdTBlwaHhzRhkRl/hfR+Ahemrt8vQ==", "From": "Mark Gray <mark.d.gray@redhat.com>", "To": "dev@openvswitch.org", "Date": "Fri, 3 Sep 2021 08:21:44 -0400", "Message-Id": "<20210903122148.826196-4-mark.d.gray@redhat.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210903122148.826196-1-mark.d.gray@redhat.com>", "References": "<20210903122148.826196-1-mark.d.gray@redhat.com>", "MIME-Version": "1.0", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Cc": "numans@redhat.com", "Subject": "[ovs-dev] [PATCH ovn v4 3/7] inc-proc-eng: Allow definition of\n\tengine_node with global scope", "X-BeenThere": "ovs-dev@openvswitch.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "<ovs-dev.openvswitch.org>", "List-Unsubscribe": "<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>", "List-Archive": "<http://mail.openvswitch.org/pipermail/ovs-dev/>", "List-Post": "<mailto:ovs-dev@openvswitch.org>", "List-Help": "<mailto:ovs-dev-request@openvswitch.org?subject=help>", "List-Subscribe": "<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "ovs-dev-bounces@openvswitch.org", "Sender": "\"dev\" <ovs-dev-bounces@openvswitch.org>" }, "content": "Refactor ENGINE_NODE() macro to not assign function pointers. This\nallows ENGINE_NODE() to be used outside functions, creating an\nengine_node with global scope (but can be statically defined within a file).\nThis allows more flexibility in how the I-P engine can be used.\n\nAdditional function pointers (e.g. is_valid(), clear_tracked_data()),\nmay be assigned later, if required.\n\nSigned-off-by: Mark Gray <mark.d.gray@redhat.com>\n---\n controller/ovn-controller.c | 2 +-\n lib/inc-proc-eng.h | 8 ++++----\n 2 files changed, 5 insertions(+), 5 deletions(-)", "diff": "diff --git a/controller/ovn-controller.c b/controller/ovn-controller.c\nindex 0031a103566a..c79b6c32158b 100644\n--- a/controller/ovn-controller.c\n+++ b/controller/ovn-controller.c\n@@ -3213,7 +3213,7 @@ main(int argc, char *argv[])\n stopwatch_create(BFD_RUN_STOPWATCH_NAME, SW_MS);\n \n /* Define inc-proc-engine nodes. */\n- ENGINE_NODE_CUSTOM_WITH_CLEAR_TRACK_DATA(ct_zones, \"ct_zones\");\n+ ENGINE_NODE_CUSTOM_WITH_CLEAR_TRACK_DATA_IS_VALID(ct_zones, \"ct_zones\");\n ENGINE_NODE_WITH_CLEAR_TRACK_DATA(runtime_data, \"runtime_data\");\n ENGINE_NODE(non_vif_data, \"non_vif_data\");\n ENGINE_NODE(mff_ovn_geneve, \"mff_ovn_geneve\");\ndiff --git a/lib/inc-proc-eng.h b/lib/inc-proc-eng.h\nindex 859b30a71c86..1ccae559dff6 100644\n--- a/lib/inc-proc-eng.h\n+++ b/lib/inc-proc-eng.h\n@@ -295,19 +295,19 @@ void engine_ovsdb_node_add_index(struct engine_node *, const char *name,\n .init = en_##NAME##_init, \\\n .run = en_##NAME##_run, \\\n .cleanup = en_##NAME##_cleanup, \\\n- .is_valid = en_##NAME##_is_valid, \\\n+ .is_valid = NULL, \\\n .clear_tracked_data = NULL, \\\n };\n \n #define ENGINE_NODE_CUSTOM_DATA(NAME, NAME_STR) \\\n ENGINE_NODE_DEF(NAME, NAME_STR)\n \n-#define ENGINE_NODE_CUSTOM_WITH_CLEAR_TRACK_DATA(NAME, NAME_STR) \\\n+#define ENGINE_NODE_CUSTOM_WITH_CLEAR_TRACK_DATA_IS_VALID(NAME, NAME_STR) \\\n ENGINE_NODE_CUSTOM_DATA(NAME, NAME_STR) \\\n- en_##NAME.clear_tracked_data = en_##NAME##_clear_tracked_data;\n+ en_##NAME.clear_tracked_data = en_##NAME##_clear_tracked_data; \\\n+ en_##NAME.is_valid = en_##NAME##_is_valid;\n \n #define ENGINE_NODE(NAME, NAME_STR) \\\n- static bool (*en_##NAME##_is_valid)(struct engine_node *node) = NULL; \\\n ENGINE_NODE_DEF(NAME, NAME_STR)\n \n #define ENGINE_NODE_WITH_CLEAR_TRACK_DATA(NAME, NAME_STR) \\\n", "prefixes": [ "ovs-dev", "v4", "3/7" ] }