Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1523753/?format=api
{ "id": 1523753, "url": "http://patchwork.ozlabs.org/api/patches/1523753/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20210902130928.528803-8-clg@kaod.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20210902130928.528803-8-clg@kaod.org>", "list_archive_url": null, "date": "2021-09-02T13:09:15", "name": "[v2,07/20] ppc/pnv: Add POWER10 quads", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "9a7ccddb68846ef456b2eacd1ad015ce2a66db7a", "submitter": { "id": 68548, "url": "http://patchwork.ozlabs.org/api/people/68548/?format=api", "name": "Cédric Le Goater", "email": "clg@kaod.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20210902130928.528803-8-clg@kaod.org/mbox/", "series": [ { "id": 260743, "url": "http://patchwork.ozlabs.org/api/series/260743/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=260743", "date": "2021-09-02T13:09:11", "name": "ppc/pnv: Extend the powernv10 machine", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/260743/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1523753/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1523753/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=<UNKNOWN>)", "garm.ovh; auth=pass\n (GARM-101G004d942538e-08bd-42be-aab0-46f35bbe3e08,\n 0F69C8711EE098B745CC44F7BEC1CAFBB1DDDEDC) smtp.auth=clg@kaod.org" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4H0hTN0DhNz9tD5\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 2 Sep 2021 23:23:51 +1000 (AEST)", "from localhost ([::1]:33498 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1mLmh3-0005oE-A3\n\tfor incoming@patchwork.ozlabs.org; Thu, 02 Sep 2021 09:23:49 -0400", "from eggs.gnu.org ([2001:470:142:3::10]:42858)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <clg@kaod.org>) id 1mLmTd-0006iP-CH\n for qemu-devel@nongnu.org; Thu, 02 Sep 2021 09:09:57 -0400", "from 9.mo52.mail-out.ovh.net ([87.98.180.222]:53767)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <clg@kaod.org>) id 1mLmTR-0001vv-Bn\n for qemu-devel@nongnu.org; Thu, 02 Sep 2021 09:09:57 -0400", "from mxplan5.mail.ovh.net (unknown [10.109.156.48])\n by mo52.mail-out.ovh.net (Postfix) with ESMTPS id 77F23295EFF;\n Thu, 2 Sep 2021 15:09:35 +0200 (CEST)", "from kaod.org (37.59.142.101) by DAG4EX1.mxp5.local (172.16.2.31)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Thu, 2 Sep\n 2021 15:09:33 +0200" ], "X-OVh-ClientIp": "82.64.250.170", "From": "=?utf-8?q?C=C3=A9dric_Le_Goater?= <clg@kaod.org>", "To": "David Gibson <david@gibson.dropbear.id.au>, Greg Kurz <groug@kaod.org>", "Subject": "[PATCH v2 07/20] ppc/pnv: Add POWER10 quads", "Date": "Thu, 2 Sep 2021 15:09:15 +0200", "Message-ID": "<20210902130928.528803-8-clg@kaod.org>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20210902130928.528803-1-clg@kaod.org>", "References": "<20210902130928.528803-1-clg@kaod.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"UTF-8\"", "Content-Transfer-Encoding": "8bit", "X-Originating-IP": "[37.59.142.101]", "X-ClientProxiedBy": "DAG5EX1.mxp5.local (172.16.2.41) To DAG4EX1.mxp5.local\n (172.16.2.31)", "X-Ovh-Tracer-GUID": "efb2f6b4-27bb-40de-a557-eca6093dcc5e", "X-Ovh-Tracer-Id": "14775747428112436131", "X-VR-SPAMSTATE": "OK", "X-VR-SPAMSCORE": "-100", "X-VR-SPAMCAUSE": "\n gggruggvucftvghtrhhoucdtuddrgedvtddruddvhedgiedtucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufffkffojghfgggtgfhisehtkeertdertdejnecuhfhrohhmpeevrogurhhitgcunfgvucfiohgrthgvrhcuoegtlhhgsehkrghougdrohhrgheqnecuggftrfgrthhtvghrnhepheehfeegjeeitdfffeetjeduveejueefuefgtdefueelueetveeliefhhffgtdelnecukfhppedtrddtrddtrddtpdefjedrheelrddugedvrddutddunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpqdhouhhtpdhhvghlohepmhigphhlrghnhedrmhgrihhlrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpegtlhhgsehkrghougdrohhrghdprhgtphhtthhopegtlhhgsehkrghougdrohhrgh", "Received-SPF": "pass client-ip=87.98.180.222; envelope-from=clg@kaod.org;\n helo=9.mo52.mail-out.ovh.net", "X-Spam_score_int": "-18", "X-Spam_score": "-1.9", "X-Spam_bar": "-", "X-Spam_report": "(-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "qemu-ppc@nongnu.org, qemu-devel@nongnu.org, =?utf-8?q?C=C3=A9dric_Le_Goa?=\n\t=?utf-8?q?ter?= <clg@kaod.org>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "and use a pnv_chip_power10_quad_realize() helper to avoid code\nduplication with P9. This still needs some refinements on the XSCOM\nregisters handling in PnvQuad.\n\nSigned-off-by: Cédric Le Goater <clg@kaod.org>\n---\n\n v2: rebased on previous changes adding 'quad-id'\n \n include/hw/ppc/pnv.h | 3 +++\n hw/ppc/pnv.c | 50 +++++++++++++++++++++++++++++++++++---------\n 2 files changed, 43 insertions(+), 10 deletions(-)", "diff": "diff --git a/include/hw/ppc/pnv.h b/include/hw/ppc/pnv.h\nindex a299fbc7f25c..13495423283a 100644\n--- a/include/hw/ppc/pnv.h\n+++ b/include/hw/ppc/pnv.h\n@@ -128,6 +128,9 @@ struct Pnv10Chip {\n Pnv9Psi psi;\n PnvLpcController lpc;\n PnvOCC occ;\n+\n+ uint32_t nr_quads;\n+ PnvQuad *quads;\n };\n \n #define PNV10_PIR2FUSEDCORE(pir) (((pir) >> 3) & 0xf)\ndiff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c\nindex a186df3fee41..5c342e313329 100644\n--- a/hw/ppc/pnv.c\n+++ b/hw/ppc/pnv.c\n@@ -1370,6 +1370,21 @@ static void pnv_chip_power9_instance_init(Object *obj)\n chip->num_phbs = pcc->num_phbs;\n }\n \n+static void pnv_chip_quad_realize_one(PnvChip *chip, PnvQuad *eq,\n+ PnvCore *pnv_core)\n+{\n+ char eq_name[32];\n+ int core_id = CPU_CORE(pnv_core)->core_id;\n+\n+ snprintf(eq_name, sizeof(eq_name), \"eq[%d]\", core_id);\n+ object_initialize_child_with_props(OBJECT(chip), eq_name, eq,\n+ sizeof(*eq), TYPE_PNV_QUAD,\n+ &error_fatal, NULL);\n+\n+ object_property_set_int(OBJECT(eq), \"quad-id\", core_id, &error_fatal);\n+ qdev_realize(DEVICE(eq), NULL, &error_fatal);\n+}\n+\n static void pnv_chip_quad_realize(Pnv9Chip *chip9, Error **errp)\n {\n PnvChip *chip = PNV_CHIP(chip9);\n@@ -1379,18 +1394,9 @@ static void pnv_chip_quad_realize(Pnv9Chip *chip9, Error **errp)\n chip9->quads = g_new0(PnvQuad, chip9->nr_quads);\n \n for (i = 0; i < chip9->nr_quads; i++) {\n- char eq_name[32];\n PnvQuad *eq = &chip9->quads[i];\n- PnvCore *pnv_core = chip->cores[i * 4];\n- int core_id = CPU_CORE(pnv_core)->core_id;\n-\n- snprintf(eq_name, sizeof(eq_name), \"eq[%d]\", core_id);\n- object_initialize_child_with_props(OBJECT(chip), eq_name, eq,\n- sizeof(*eq), TYPE_PNV_QUAD,\n- &error_fatal, NULL);\n \n- object_property_set_int(OBJECT(eq), \"quad-id\", core_id, &error_fatal);\n- qdev_realize(DEVICE(eq), NULL, &error_fatal);\n+ pnv_chip_quad_realize_one(chip, eq, chip->cores[i * 4]);\n \n pnv_xscom_add_subregion(chip, PNV9_XSCOM_EQ_BASE(eq->quad_id),\n &eq->xscom_regs);\n@@ -1606,6 +1612,24 @@ static void pnv_chip_power10_instance_init(Object *obj)\n object_initialize_child(obj, \"occ\", &chip10->occ, TYPE_PNV10_OCC);\n }\n \n+static void pnv_chip_power10_quad_realize(Pnv10Chip *chip10, Error **errp)\n+{\n+ PnvChip *chip = PNV_CHIP(chip10);\n+ int i;\n+\n+ chip10->nr_quads = DIV_ROUND_UP(chip->nr_cores, 4);\n+ chip10->quads = g_new0(PnvQuad, chip10->nr_quads);\n+\n+ for (i = 0; i < chip10->nr_quads; i++) {\n+ PnvQuad *eq = &chip10->quads[i];\n+\n+ pnv_chip_quad_realize_one(chip, eq, chip->cores[i * 4]);\n+\n+ pnv_xscom_add_subregion(chip, PNV10_XSCOM_EQ_BASE(eq->quad_id),\n+ &eq->xscom_regs);\n+ }\n+}\n+\n static void pnv_chip_power10_realize(DeviceState *dev, Error **errp)\n {\n PnvChipClass *pcc = PNV_CHIP_GET_CLASS(dev);\n@@ -1627,6 +1651,12 @@ static void pnv_chip_power10_realize(DeviceState *dev, Error **errp)\n return;\n }\n \n+ pnv_chip_power10_quad_realize(chip10, &local_err);\n+ if (local_err) {\n+ error_propagate(errp, local_err);\n+ return;\n+ }\n+\n /* XIVE2 interrupt controller (POWER10) */\n object_property_set_int(OBJECT(&chip10->xive), \"ic-bar\",\n PNV10_XIVE2_IC_BASE(chip), &error_fatal);\n", "prefixes": [ "v2", "07/20" ] }