Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1523618/?format=api
{ "id": 1523618, "url": "http://patchwork.ozlabs.org/api/patches/1523618/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/patch/1630579661-34824-1-git-send-email-wangyunjian@huawei.com/", "project": { "id": 47, "url": "http://patchwork.ozlabs.org/api/projects/47/?format=api", "name": "Open vSwitch", "link_name": "openvswitch", "list_id": "ovs-dev.openvswitch.org", "list_email": "ovs-dev@openvswitch.org", "web_url": "http://openvswitch.org/", "scm_url": "git@github.com:openvswitch/ovs.git", "webscm_url": "https://github.com/openvswitch/ovs", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1630579661-34824-1-git-send-email-wangyunjian@huawei.com>", "list_archive_url": null, "date": "2021-09-02T10:47:41", "name": "[ovs-dev,v2] bond: Check for NULL member in bond_member_set_enable()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f4d1f7b54d1a720bc91f79b7da6c68c27b7b44b0", "submitter": { "id": 69073, "url": "http://patchwork.ozlabs.org/api/people/69073/?format=api", "name": "wangyunjian", "email": "wangyunjian@huawei.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/openvswitch/patch/1630579661-34824-1-git-send-email-wangyunjian@huawei.com/mbox/", "series": [ { "id": 260714, "url": "http://patchwork.ozlabs.org/api/series/260714/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/list/?series=260714", "date": "2021-09-02T10:47:41", "name": "[ovs-dev,v2] bond: Check for NULL member in bond_member_set_enable()", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/260714/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1523618/comments/", "check": "success", "checks": "http://patchwork.ozlabs.org/api/patches/1523618/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<ovs-dev-bounces@openvswitch.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "dev@openvswitch.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "ovs-dev@lists.linuxfoundation.org" ], "Authentication-Results": "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=140.211.166.138; helo=smtp1.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=<UNKNOWN>)", "Received": [ "from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4H0d1W1T4sz9sCD\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 2 Sep 2021 20:47:59 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 6BE2780C62;\n\tThu, 2 Sep 2021 10:47:57 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n\tby localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id pgLa41ijhQ3S; Thu, 2 Sep 2021 10:47:53 +0000 (UTC)", "from lists.linuxfoundation.org (lf-lists.osuosl.org\n [IPv6:2605:bc80:3010:104::8cd3:938])\n\tby smtp1.osuosl.org (Postfix) with ESMTPS id C697180BE8;\n\tThu, 2 Sep 2021 10:47:52 +0000 (UTC)", "from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id 7DD00C001A;\n\tThu, 2 Sep 2021 10:47:52 +0000 (UTC)", "from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n by lists.linuxfoundation.org (Postfix) with ESMTP id 17AADC000E\n for <dev@openvswitch.org>; Thu, 2 Sep 2021 10:47:51 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id EA73642537\n for <dev@openvswitch.org>; Thu, 2 Sep 2021 10:47:50 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id C34XdTLCA80H for <dev@openvswitch.org>;\n Thu, 2 Sep 2021 10:47:47 +0000 (UTC)", "from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189])\n by smtp4.osuosl.org (Postfix) with ESMTPS id D7EB040436\n for <dev@openvswitch.org>; Thu, 2 Sep 2021 10:47:46 +0000 (UTC)", "from dggemv711-chm.china.huawei.com (unknown [172.30.72.54])\n by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4H0d0l2XB9z8DT4;\n Thu, 2 Sep 2021 18:47:19 +0800 (CST)", "from dggpemm500008.china.huawei.com (7.185.36.136) by\n dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2176.2; Thu, 2 Sep 2021 18:47:42 +0800", "from localhost (10.174.242.157) by dggpemm500008.china.huawei.com\n (7.185.36.136) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Thu, 2 Sep 2021\n 18:47:42 +0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.8.0", "From": "Yunjian Wang <wangyunjian@huawei.com>", "To": "<dev@openvswitch.org>, <i.maximets@ovn.org>", "Date": "Thu, 2 Sep 2021 18:47:41 +0800", "Message-ID": "<1630579661-34824-1-git-send-email-wangyunjian@huawei.com>", "X-Mailer": "git-send-email 1.9.5.msysgit.1", "MIME-Version": "1.0", "X-Originating-IP": "[10.174.242.157]", "X-ClientProxiedBy": "dggems703-chm.china.huawei.com (10.3.19.180) To\n dggpemm500008.china.huawei.com (7.185.36.136)", "X-CFilter-Loop": "Reflected", "Cc": "dingxiaoxiong@huawei.com", "Subject": "[ovs-dev] [PATCH v2] bond: Check for NULL member in\n\tbond_member_set_enable()", "X-BeenThere": "ovs-dev@openvswitch.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "<ovs-dev.openvswitch.org>", "List-Unsubscribe": "<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>", "List-Archive": "<http://mail.openvswitch.org/pipermail/ovs-dev/>", "List-Post": "<mailto:ovs-dev@openvswitch.org>", "List-Help": "<mailto:ovs-dev-request@openvswitch.org?subject=help>", "List-Subscribe": "<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n <mailto:ovs-dev-request@openvswitch.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "ovs-dev-bounces@openvswitch.org", "Sender": "\"dev\" <ovs-dev-bounces@openvswitch.org>" }, "content": "The function bond_member_lookup() could return NULL, the return value\nneed to be checked.\n\nFound by Coverity.\n\nReported-at: https://scan8.coverity.com/reports.htm#v48222/p12487/fileInstanceId=29689046&defectInstanceId=10109012&mergedDefectId=279245\nSigned-off-by: Yunjian Wang <wangyunjian@huawei.com>\nAcked-by: Kevin Traynor <ktraynor@redhat.com>\n---\nv2:\n * Update commit msg suggested by Kevin Traynor\n---\n ofproto/bond.c | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)", "diff": "diff --git a/ofproto/bond.c b/ofproto/bond.c\nindex a4116588f..2dcfeda71 100644\n--- a/ofproto/bond.c\n+++ b/ofproto/bond.c\n@@ -672,8 +672,13 @@ out:\n void\n bond_member_set_may_enable(struct bond *bond, void *member_, bool may_enable)\n {\n+ struct bond_member *member;\n+\n ovs_rwlock_wrlock(&rwlock);\n- bond_member_lookup(bond, member_)->may_enable = may_enable;\n+ member = bond_member_lookup(bond, member_);\n+ if (member) {\n+ member->may_enable = may_enable;\n+ }\n ovs_rwlock_unlock(&rwlock);\n }\n \n", "prefixes": [ "ovs-dev", "v2" ] }