Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1523322/?format=api
{ "id": 1523322, "url": "http://patchwork.ozlabs.org/api/patches/1523322/?format=api", "web_url": "http://patchwork.ozlabs.org/project/patchwork/patch/20210901165756.181192-3-stephen@that.guru/", "project": { "id": 16, "url": "http://patchwork.ozlabs.org/api/projects/16/?format=api", "name": "Patchwork", "link_name": "patchwork", "list_id": "patchwork.lists.ozlabs.org", "list_email": "patchwork@lists.ozlabs.org", "web_url": "http://jk.ozlabs.org/projects/patchwork/", "scm_url": "git://github.com/getpatchwork/patchwork", "webscm_url": "https://github.com/getpatchwork/patchwork", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20210901165756.181192-3-stephen@that.guru>", "list_archive_url": null, "date": "2021-09-01T16:57:39", "name": "[RFC,v2,02/19] templatetags: Trivial cleanup", "commit_ref": null, "pull_url": null, "state": "rfc", "archived": false, "hash": "4e659455f9035b1f0934e2543ff9e54423cc39f2", "submitter": { "id": 69991, "url": "http://patchwork.ozlabs.org/api/people/69991/?format=api", "name": "Stephen Finucane", "email": "stephen@that.guru" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/patchwork/patch/20210901165756.181192-3-stephen@that.guru/mbox/", "series": [ { "id": 260605, "url": "http://patchwork.ozlabs.org/api/series/260605/?format=api", "web_url": "http://patchwork.ozlabs.org/project/patchwork/list/?series=260605", "date": "2021-09-01T16:57:37", "name": "Integrate Bulma", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/260605/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1523322/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1523322/checks/", "tags": {}, "related": [ { "id": 1516035, "url": "http://patchwork.ozlabs.org/api/patches/1516035/?format=api", "web_url": "http://patchwork.ozlabs.org/project/patchwork/patch/20210811213705.36293-3-stephen@that.guru/", "msgid": "<20210811213705.36293-3-stephen@that.guru>", "list_archive_url": null, "date": "2021-08-11T21:36:48", "name": "[RFC,02/19] templatetags: Trivial cleanup", "mbox": "http://patchwork.ozlabs.org/project/patchwork/patch/20210811213705.36293-3-stephen@that.guru/mbox/" } ], "headers": { "Return-Path": "\n <patchwork-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "patchwork@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "patchwork@lists.ozlabs.org" ], "Authentication-Results": [ "ozlabs.org;\n\tdkim=fail reason=\"key not found in DNS\" header.d=that.guru\n header.i=@that.guru header.a=rsa-sha256 header.s=x header.b=aNYds15h;\n\tdkim-atps=neutral", "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=patchwork-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=<UNKNOWN>)", "lists.ozlabs.org;\n\tdkim=fail reason=\"key not found in DNS\" header.d=that.guru\n header.i=@that.guru header.a=rsa-sha256 header.s=x header.b=aNYds15h;\n\tdkim-atps=neutral", "lists.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=that.guru\n (client-ip=136.175.108.142; helo=mail-108-mta142.mxroute.com;\n envelope-from=stephen@that.guru; receiver=<UNKNOWN>)", "lists.ozlabs.org;\n dkim=fail reason=\"key not found in DNS\" header.d=that.guru\n header.i=@that.guru\n header.a=rsa-sha256 header.s=x header.b=aNYds15h;\n dkim-atps=neutral" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4H09HL2Lwqz9sW8\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 2 Sep 2021 02:58:22 +1000 (AEST)", "from boromir.ozlabs.org (localhost [IPv6:::1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4H09HL1HT5z2yQ8\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 2 Sep 2021 02:58:22 +1000 (AEST)", "from mail-108-mta142.mxroute.com (mail-108-mta142.mxroute.com\n [136.175.108.142])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by lists.ozlabs.org (Postfix) with ESMTPS id 4H09H966c8z2xWg\n for <patchwork@lists.ozlabs.org>; Thu, 2 Sep 2021 02:58:13 +1000 (AEST)", "from filter004.mxroute.com ([149.28.56.236] filter004.mxroute.com)\n (Authenticated sender: mN4UYu2MZsgR)\n by mail-108-mta142.mxroute.com (ZoneMTA) with ESMTPSA id\n 17ba24be41300074ba.001 for <patchwork@lists.ozlabs.org>\n (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256);\n Wed, 01 Sep 2021 16:58:07 +0000" ], "X-Zone-Loop": "23fbf2c458cef3de55e3c37ea44b26c8749b5bfc2ecc", "X-Originating-IP": "[149.28.56.236]", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=that.guru;\n s=x;\n h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:\n Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:\n Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n List-Post:List-Owner:List-Archive;\n bh=L9Igfxz0uxUVGr/K+7SlxNilCwUZrSnLzWJwPbKoc3M=; b=aNYds15h3xyDd68ysb8DqkNtOv\n 6OTn3kCMRODEn79Bb7zAKhT2Qw96UgXo9uSCXVmPMeOXc2do4YKbE8h26Af0rN8FBs3OnRtsBoyce\n OUx27MGJOot/+0/yXF+tBZsF0oGN9ObHiHAPQXuS+yekNZIHsINgCGZPif3Ohsbo3DCmwiaHI8IL2\n ez/Oe2yEzoxVWPuEGGxoRRdWaqzPRqndIPHQgqe1E8CFIMErAZJ2+Kf1NNnfz+qV3Th0+1H0MpW+1\n rAUsXz1ZE49AGV5k4U/91c9UYjEH3XPt7CqV4OngYtEORcq2oZIJFRq2cwWtRjQHwlui/sEMyBmh/\n tzW0aUPw==;", "From": "Stephen Finucane <stephen@that.guru>", "To": "patchwork@lists.ozlabs.org", "Subject": "[RFC PATCH v2 02/19] templatetags: Trivial cleanup", "Date": "Wed, 1 Sep 2021 17:57:39 +0100", "Message-Id": "<20210901165756.181192-3-stephen@that.guru>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20210901165756.181192-1-stephen@that.guru>", "References": "<20210901165756.181192-1-stephen@that.guru>", "MIME-Version": "1.0", "X-AuthUser": "stephen@that.guru", "X-BeenThere": "patchwork@lists.ozlabs.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Patchwork development <patchwork.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/patchwork>,\n <mailto:patchwork-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/patchwork/>", "List-Post": "<mailto:patchwork@lists.ozlabs.org>", "List-Help": "<mailto:patchwork-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/patchwork>,\n <mailto:patchwork-request@lists.ozlabs.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "patchwork-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org", "Sender": "\"Patchwork\"\n <patchwork-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>" }, "content": "Make this a little nicer to read.\n\nSigned-off-by: Stephen Finucane <stephen@that.guru>\n---\n patchwork/templatetags/listurl.py | 22 ++++++++-----\n patchwork/templatetags/patch.py | 24 ++++++++------\n patchwork/templatetags/person.py | 9 +++--\n patchwork/templatetags/project.py | 11 +++++--\n patchwork/templatetags/syntax.py | 55 ++++++++++++++++++-------------\n 5 files changed, 75 insertions(+), 46 deletions(-)", "diff": "diff --git patchwork/templatetags/listurl.py patchwork/templatetags/listurl.py\nindex 3d5388d2..ad920de2 100644\n--- patchwork/templatetags/listurl.py\n+++ patchwork/templatetags/listurl.py\n@@ -5,8 +5,8 @@\n \n from django.conf import settings\n from django import template\n-from django.urls import reverse\n from django.urls import NoReverseMatch\n+from django.urls import reverse\n from django.utils.encoding import smart_str\n from django.utils.html import escape\n \n@@ -20,7 +20,6 @@ list_params = [c.param for c in FILTERS] + ['order', 'page']\n \n \n class ListURLNode(template.defaulttags.URLNode):\n-\n def __init__(self, kwargs):\n super(ListURLNode, self).__init__(None, [], {}, False)\n self.params = {}\n@@ -38,8 +37,9 @@ class ListURLNode(template.defaulttags.URLNode):\n except NoReverseMatch:\n try:\n project_name = settings.SETTINGS_MODULE.split('.')[0]\n- path = reverse(project_name + '.' + view_name,\n- args=[], kwargs=kwargs)\n+ path = reverse(\n+ project_name + '.' + view_name, args=[], kwargs=kwargs\n+ )\n except NoReverseMatch:\n raise\n \n@@ -59,8 +59,12 @@ class ListURLNode(template.defaulttags.URLNode):\n if not params:\n return path\n \n- return path + '?' + '&'.join(\n- ['%s=%s' % (k, escape(v)) for (k, v) in list(params.items())])\n+ return '?'.join(\n+ [\n+ path,\n+ '&'.join('%s=%s' % (k, escape(v)) for k, v in params.items()),\n+ ]\n+ )\n \n \n @register.tag\n@@ -68,7 +72,8 @@ def listurl(parser, token):\n bits = token.contents.split(' ', 1)\n if not bits:\n raise template.TemplateSyntaxError(\n- \"'%s' takes at least one argument (path to a view)\" % bits[0])\n+ \"'%s' takes at least one argument (path to a view)\" % bits[0]\n+ )\n kwargs = {}\n if len(bits) > 1:\n for arg in bits[1].split(','):\n@@ -78,5 +83,6 @@ def listurl(parser, token):\n kwargs[k] = parser.compile_filter(v)\n else:\n raise template.TemplateSyntaxError(\n- \"'%s' requires name=value params\" % bits[0])\n+ \"'%s' requires name=value params\" % bits[0]\n+ )\n return ListURLNode(kwargs)\ndiff --git patchwork/templatetags/patch.py patchwork/templatetags/patch.py\nindex 3837798d..cf22f251 100644\n--- patchwork/templatetags/patch.py\n+++ patchwork/templatetags/patch.py\n@@ -18,6 +18,7 @@ register = template.Library()\n def patch_tags(patch):\n counts = []\n titles = []\n+\n for tag in [t for t in patch.project.tags if t.show_column]:\n count = getattr(patch, tag.attr_name)\n titles.append('%d %s' % (count, tag.name))\n@@ -25,9 +26,10 @@ def patch_tags(patch):\n counts.append(\"-\")\n else:\n counts.append(str(count))\n- return mark_safe('<span title=\"%s\">%s</span>' % (\n- ' / '.join(titles),\n- ' '.join(counts)))\n+\n+ return mark_safe(\n+ '<span title=\"%s\">%s</span>' % (' / '.join(titles), ' '.join(counts))\n+ )\n \n \n @register.filter(name='patch_checks')\n@@ -51,14 +53,15 @@ def patch_checks(patch):\n count = '-'\n \n check_elements.append(\n- '<span class=\"patchlistchecks {}\">{}</span>'.format(\n- color, count))\n+ f'<span class=\"patchlistchecks {color}\">{count}</span>'\n+ )\n \n check_elements.reverse()\n \n- return mark_safe('<span title=\"%s\">%s</span>' % (\n- ' / '.join(titles),\n- ''.join(check_elements)))\n+ return mark_safe(\n+ '<span title=\"%s\">%s</span>'\n+ % (' / '.join(titles), ''.join(check_elements))\n+ )\n \n \n @register.filter(name='patch_commit_display')\n@@ -69,5 +72,6 @@ def patch_commit_display(patch):\n if not fmt:\n return escape(commit)\n \n- return mark_safe('<a href=\"%s\">%s</a>' % (escape(fmt.format(commit)),\n- escape(commit)))\n+ return mark_safe(\n+ '<a href=\"%s\">%s</a>' % (escape(fmt.format(commit)), escape(commit))\n+ )\ndiff --git patchwork/templatetags/person.py patchwork/templatetags/person.py\nindex 61937d94..f49444ae 100644\n--- patchwork/templatetags/person.py\n+++ patchwork/templatetags/person.py\n@@ -22,9 +22,12 @@ def personify(person, project):\n else:\n linktext = escape(person.email)\n \n- url = reverse('patch-list',\n- kwargs={'project_id': project.linkname})\n+ url = reverse('patch-list', kwargs={'project_id': project.linkname})\n out = '<a href=\"%s?%s=%s\">%s</a>' % (\n- url, SubmitterFilter.param, escape(person.id), linktext)\n+ url,\n+ SubmitterFilter.param,\n+ escape(person.id),\n+ linktext,\n+ )\n \n return mark_safe(out)\ndiff --git patchwork/templatetags/project.py patchwork/templatetags/project.py\nindex 0fad8eb2..ca108f7c 100644\n--- patchwork/templatetags/project.py\n+++ patchwork/templatetags/project.py\n@@ -13,6 +13,11 @@ register = template.Library()\n @register.simple_tag(takes_context=True)\n def project_tags(context):\n tags = [t for t in context['project'].tags if t.show_column]\n- return mark_safe('<span title=\"%s\">%s</span>' % (\n- ' / '.join([tag.name for tag in tags]),\n- '/'.join([tag.abbrev for tag in tags])))\n+\n+ return mark_safe(\n+ '<span title=\"%s\">%s</span>'\n+ % (\n+ ' / '.join([tag.name for tag in tags]),\n+ '/'.join([tag.abbrev for tag in tags]),\n+ )\n+ )\ndiff --git patchwork/templatetags/syntax.py patchwork/templatetags/syntax.py\nindex 69830866..0132d17b 100644\n--- patchwork/templatetags/syntax.py\n+++ patchwork/templatetags/syntax.py\n@@ -18,25 +18,32 @@ def _compile(value):\n return re.compile(regex, re.M | re.I), cls\n \n \n-_patch_span_res = [_compile(x) for x in [\n- (r'^(Index:?|diff|\\-\\-\\-|\\+\\+\\+|\\*\\*\\*) .*$', 'p_header'),\n- (r'^\\+.*$', 'p_add'),\n- (r'^-.*$', 'p_del'),\n- (r'^!.*$', 'p_mod'),\n-]]\n+_patch_span_res = [\n+ _compile(x)\n+ for x in [\n+ (r'^(Index:?|diff|\\-\\-\\-|\\+\\+\\+|\\*\\*\\*) .*$', 'p_header'),\n+ (r'^\\+.*$', 'p_add'),\n+ (r'^-.*$', 'p_del'),\n+ (r'^!.*$', 'p_mod'),\n+ ]\n+]\n \n _patch_chunk_re = re.compile(\n- r'^(@@ \\-\\d+(?:,\\d+)? \\+\\d+(?:,\\d+)? @@)(.*)$', re.M | re.I)\n-\n-_comment_span_res = [_compile(x) for x in [\n- (r'^\\s*Signed-off-by: .*$', 'signed-off-by'),\n- (r'^\\s*Acked-by: .*$', 'acked-by'),\n- (r'^\\s*Nacked-by: .*$', 'nacked-by'),\n- (r'^\\s*Tested-by: .*$', 'tested-by'),\n- (r'^\\s*Reviewed-by: .*$', 'reviewed-by'),\n- (r'^\\s*From: .*$', 'from'),\n- (r'^\\s*>.*$', 'quote'),\n-]]\n+ r'^(@@ \\-\\d+(?:,\\d+)? \\+\\d+(?:,\\d+)? @@)(.*)$', re.M | re.I\n+)\n+\n+_comment_span_res = [\n+ _compile(x)\n+ for x in [\n+ (r'^\\s*Signed-off-by: .*$', 'signed-off-by'),\n+ (r'^\\s*Acked-by: .*$', 'acked-by'),\n+ (r'^\\s*Nacked-by: .*$', 'nacked-by'),\n+ (r'^\\s*Tested-by: .*$', 'tested-by'),\n+ (r'^\\s*Reviewed-by: .*$', 'reviewed-by'),\n+ (r'^\\s*From: .*$', 'from'),\n+ (r'^\\s*>.*$', 'quote'),\n+ ]\n+]\n \n _span = '<span class=\"%s\">%s</span>'\n \n@@ -45,14 +52,18 @@ _span = '<span class=\"%s\">%s</span>'\n def patchsyntax(patch):\n diff = escape(patch.diff).replace('\\r\\n', '\\n')\n \n- for (regex, cls) in _patch_span_res:\n+ for regex, cls in _patch_span_res:\n diff = regex.sub(lambda x: _span % (cls, x.group(0)), diff)\n \n diff = _patch_chunk_re.sub(\n- lambda x:\n- _span % ('p_chunk', x.group(1)) + ' ' +\n- _span % ('p_context', x.group(2)),\n- diff)\n+ lambda x: ' '.join(\n+ [\n+ _span % ('p_chunk', x.group(1)),\n+ _span % ('p_context', x.group(2)),\n+ ],\n+ ),\n+ diff,\n+ )\n \n return mark_safe(diff)\n \n", "prefixes": [ "RFC", "v2", "02/19" ] }