Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1475777/?format=api
{ "id": 1475777, "url": "http://patchwork.ozlabs.org/api/patches/1475777/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20210508014802.892561-71-richard.henderson@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20210508014802.892561-71-richard.henderson@linaro.org>", "list_archive_url": null, "date": "2021-05-08T01:48:00", "name": "[70/72] softfloat: Convert float32_exp2 to FloatParts", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "ef980db8cf35fd71a14cbd612c89de5f3be123e4", "submitter": { "id": 72104, "url": "http://patchwork.ozlabs.org/api/people/72104/?format=api", "name": "Richard Henderson", "email": "richard.henderson@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20210508014802.892561-71-richard.henderson@linaro.org/mbox/", "series": [ { "id": 242770, "url": "http://patchwork.ozlabs.org/api/series/242770/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=242770", "date": "2021-05-08T01:46:53", "name": "Convert floatx80 and float128 to FloatParts", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/242770/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1475777/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1475777/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=kNopF2bh;\n\tdkim-atps=neutral" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4FcWrT42BPz9sTD\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 8 May 2021 12:45:13 +1000 (AEST)", "from localhost ([::1]:60632 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1lfCxr-0001Ah-He\n\tfor incoming@patchwork.ozlabs.org; Fri, 07 May 2021 22:45:11 -0400", "from eggs.gnu.org ([2001:470:142:3::10]:41842)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1lfC8Q-0003Xd-Ap\n for qemu-devel@nongnu.org; Fri, 07 May 2021 21:52:02 -0400", "from mail-pj1-x1033.google.com ([2607:f8b0:4864:20::1033]:44956)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1lfC8E-0005bK-Lv\n for qemu-devel@nongnu.org; Fri, 07 May 2021 21:52:02 -0400", "by mail-pj1-x1033.google.com with SMTP id\n lj11-20020a17090b344bb029015bc3073608so6553355pjb.3\n for <qemu-devel@nongnu.org>; Fri, 07 May 2021 18:51:49 -0700 (PDT)", "from localhost.localdomain ([71.212.144.24])\n by smtp.gmail.com with ESMTPSA id 204sm5861396pfw.158.2021.05.07.18.51.48\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 07 May 2021 18:51:48 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=3Z3suMoiq2NOsSh1nb+Y+UBUwnjAhv5Rkm1TF46BgbU=;\n b=kNopF2bhrMPhCTXvG8jdj/L6NeKzgJe+RsOgZzqLna85kWRBjsZK8vG1y3e+MuxuDQ\n il2YYJUtim8HSngmV9JcxX68zQ4TYLixpQ4JQyNxuQIqOieoSLQY5xLjw7DYWZsAyJ++\n UU09I4133v9taIG5dbm3yZSS8g2OnNRow7FwVCvVIGIWvd+Dxd2MEZgB3vQ4Dv6hZ8rq\n hXjp6DTkzaB5TDIypxC4SYK2Ku9fqX3MZdp6rC/peQvzGpCy0u/anfuMfRDB7EkhWeqc\n rZwrifV8DxVS3Mfdf6LTGNk/jUFmYI1gp9j/FxB1pPKztL1yuvYfJKvhtv1NZ6MPvFrA\n RiZA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=3Z3suMoiq2NOsSh1nb+Y+UBUwnjAhv5Rkm1TF46BgbU=;\n b=j9nCRxwcWskoh0M//seAgmhHajT1/Zx71hIwHLQ3FdUeVpoyzhu7KJP5tWKrt3rLHQ\n B0ihMA2GYIc9z7jweeaE5HcOjGk0urCHOQg4X7EJvRtsGgWqwgv41lqEje+D3MMc8TV+\n /Y41n1w6WAPWP9MnwLI9s0Eqa6YnBKjpk/Ogut3pcE6/6ErUJod0gFtBS1aXSBwryMxC\n +I/mqcRbwBzqLumTqGWoCP0Tvl51GKKw+K0of1ujdaBc9ZU0GfBwEGrJaAJoAZmmhz4P\n 3E1XlNxzzv2lxW0cEYspCi0SYLq5PE7cU/c5szUAD+wJVocFCsom6LfitzT4PPKbTwEe\n NYkg==", "X-Gm-Message-State": "AOAM533DlKUJzYUOV8jFvGWxgY053C85nqItePHrINrKExSeBzUZ7L7A\n eOTLhQuIPc1NR4xF11t1rjf7uwMmjnWjMg==", "X-Google-Smtp-Source": "\n ABdhPJw34LBuio8V9ocFwQZ0/e1j6tjS3O6oTopCS6gML7NdqnfBXOOV0J6NZNzid6vfOsxW8C+72w==", "X-Received": "by 2002:a17:90a:410e:: with SMTP id\n u14mr27089522pjf.45.1620438709023;\n Fri, 07 May 2021 18:51:49 -0700 (PDT)", "From": "Richard Henderson <richard.henderson@linaro.org>", "To": "qemu-devel@nongnu.org", "Subject": "[PATCH 70/72] softfloat: Convert float32_exp2 to FloatParts", "Date": "Fri, 7 May 2021 18:48:00 -0700", "Message-Id": "<20210508014802.892561-71-richard.henderson@linaro.org>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210508014802.892561-1-richard.henderson@linaro.org>", "References": "<20210508014802.892561-1-richard.henderson@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::1033;\n envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1033.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "alex.bennee@linaro.org, david@redhat.com", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "Keep the intermediate results in FloatParts instead of\nconverting back and forth between float64. Use muladd\ninstead of separate mul+add.\n\nSigned-off-by: Richard Henderson <richard.henderson@linaro.org>\n---\n fpu/softfloat.c | 53 +++++++++++++++++++++----------------------------\n 1 file changed, 23 insertions(+), 30 deletions(-)", "diff": "diff --git a/fpu/softfloat.c b/fpu/softfloat.c\nindex b89ec4b832..906bb427ae 100644\n--- a/fpu/softfloat.c\n+++ b/fpu/softfloat.c\n@@ -5212,47 +5212,40 @@ static const float64 float32_exp2_coefficients[15] =\n \n float32 float32_exp2(float32 a, float_status *status)\n {\n- bool aSign;\n- int aExp;\n- uint32_t aSig;\n- float64 r, x, xn;\n+ FloatParts64 xp, xnp, tp, rp;\n int i;\n- a = float32_squash_input_denormal(a, status);\n \n- aSig = extractFloat32Frac( a );\n- aExp = extractFloat32Exp( a );\n- aSign = extractFloat32Sign( a );\n-\n- if ( aExp == 0xFF) {\n- if (aSig) {\n- return propagateFloat32NaN(a, float32_zero, status);\n+ float32_unpack_canonical(&xp, a, status);\n+ if (unlikely(xp.cls != float_class_normal)) {\n+ switch (xp.cls) {\n+ case float_class_snan:\n+ case float_class_qnan:\n+ parts_return_nan(&xp, status);\n+ return float32_round_pack_canonical(&xp, status);\n+ case float_class_inf:\n+ return xp.sign ? float32_zero : a;\n+ case float_class_zero:\n+ return float32_one;\n+ default:\n+ break;\n }\n- return (aSign) ? float32_zero : a;\n- }\n- if (aExp == 0) {\n- if (aSig == 0) return float32_one;\n+ g_assert_not_reached();\n }\n \n float_raise(float_flag_inexact, status);\n \n- /* ******************************* */\n- /* using float64 for approximation */\n- /* ******************************* */\n- x = float32_to_float64(a, status);\n- x = float64_mul(x, float64_ln2, status);\n+ float64_unpack_canonical(&xnp, float64_ln2, status);\n+ xp = *parts_mul(&xp, &tp, status);\n+ xnp = xp;\n \n- xn = x;\n- r = float64_one;\n+ float64_unpack_canonical(&rp, float64_one, status);\n for (i = 0 ; i < 15 ; i++) {\n- float64 f;\n-\n- f = float64_mul(xn, float32_exp2_coefficients[i], status);\n- r = float64_add(r, f, status);\n-\n- xn = float64_mul(xn, x, status);\n+ float64_unpack_canonical(&tp, float32_exp2_coefficients[i], status);\n+ rp = *parts_muladd(&tp, &xp, &rp, 0, status);\n+ xnp = *parts_mul(&xnp, &xp, status);\n }\n \n- return float64_to_float32(r, status);\n+ return float32_round_pack_canonical(&rp, status);\n }\n \n /*----------------------------------------------------------------------------\n", "prefixes": [ "70/72" ] }