Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1475772/?format=api
{ "id": 1475772, "url": "http://patchwork.ozlabs.org/api/patches/1475772/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20210508014802.892561-58-richard.henderson@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20210508014802.892561-58-richard.henderson@linaro.org>", "list_archive_url": null, "date": "2021-05-08T01:47:47", "name": "[57/72] softfloat: Adjust parts_uncanon_normal for floatx80", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "0d070a5768dde3df27f83d3635c9125eb6f5e248", "submitter": { "id": 72104, "url": "http://patchwork.ozlabs.org/api/people/72104/?format=api", "name": "Richard Henderson", "email": "richard.henderson@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20210508014802.892561-58-richard.henderson@linaro.org/mbox/", "series": [ { "id": 242770, "url": "http://patchwork.ozlabs.org/api/series/242770/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=242770", "date": "2021-05-08T01:46:53", "name": "Convert floatx80 and float128 to FloatParts", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/242770/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1475772/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1475772/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=MLzGjO4a;\n\tdkim-atps=neutral" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4FcWkb2kkKz9sTD\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 8 May 2021 12:40:07 +1000 (AEST)", "from localhost ([::1]:46060 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1lfCsu-0008Gr-Ul\n\tfor incoming@patchwork.ozlabs.org; Fri, 07 May 2021 22:40:04 -0400", "from eggs.gnu.org ([2001:470:142:3::10]:41752)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1lfC8F-0003U6-N6\n for qemu-devel@nongnu.org; Fri, 07 May 2021 21:51:52 -0400", "from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]:37557)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1lfC86-0005WB-Bp\n for qemu-devel@nongnu.org; Fri, 07 May 2021 21:51:51 -0400", "by mail-pf1-x431.google.com with SMTP id b15so9156311pfl.4\n for <qemu-devel@nongnu.org>; Fri, 07 May 2021 18:51:41 -0700 (PDT)", "from localhost.localdomain ([71.212.144.24])\n by smtp.gmail.com with ESMTPSA id 204sm5861396pfw.158.2021.05.07.18.51.40\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 07 May 2021 18:51:40 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=LZ3EVpA+stFdeEBoSATKDS13Onp/VeKXwMPd01vcHvM=;\n b=MLzGjO4a0NXTWKyzbgVeKknWmmPhCJ5AnX4t979Rdmtlf74ekRu8shyfCi9IGu2wqK\n 9coqGBUCa9/fpwBV1yvbbNaFdNhqskGsMR6fmgyLMvMpEvb/ic/j2JXsAvN2rhvAd+2/\n +UlIbNzJwbuMbJB3c7haMLAiBGQB2qD9olF8lH2dIBq4/Mjc8gghK4jG0/bL/f3LuElb\n jRj/QyGJlvoHAcNHSOmi/9aV6bbpWGyzn2/3xd7bav2l0nBg9WnNVOclNn4ii2eOspoX\n N8OwoTklzK4ZL5f9EO3FMazQh0mjC2H9dTOeaaQjF480nQHpkq3bwvLYnyAUP+usGfxg\n /qBQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=LZ3EVpA+stFdeEBoSATKDS13Onp/VeKXwMPd01vcHvM=;\n b=jvLGCpPYY0LQgF4nl+H5NCYEC0jNzMne0OCGry3oEbkAa1zzV8Q6yALr4daf2H9VCs\n mJYvVDQniYR13MYXl9hPuTrEvJjqSIdiXZEcsRra+nj96Jg6C3JKwtYbZy7dmAmrObzy\n twyV7kgQKfMMPLcerCm/3dJLDescb5ikjwpAW00IygyCkdF5IxJF1D5vrf7vuvshAb+u\n f9iIMjs8qov4siZQGcTbvzRZ5CNYhnBO6lP/Q20/m8qEB8WxjvmPnSoY7kVQTwhtxVrJ\n RMyjD8W/YPYJT3WFOPDsUHE+DicgCBRDcrMZmi/ed55Kwi0jgnVhhYQyaGeesT2zSzx2\n OC4A==", "X-Gm-Message-State": "AOAM531fUptlNiHJ4RLZ76UB3OKaUYXZtwlGCsVMh6ai5in9/KoirycF\n nRs17D/hwxjYxyR0w3M1OzUBv8zZCvI32A==", "X-Google-Smtp-Source": "\n ABdhPJyC6bkzxb3nVPG6p5WVgVNQhj+UGZ4ZQUlVz7j1hCyf0eK23d0jQGx9KEAPj4DuiwSg0GGt5A==", "X-Received": "by 2002:a63:2115:: with SMTP id\n h21mr13288716pgh.191.1620438701044;\n Fri, 07 May 2021 18:51:41 -0700 (PDT)", "From": "Richard Henderson <richard.henderson@linaro.org>", "To": "qemu-devel@nongnu.org", "Subject": "[PATCH 57/72] softfloat: Adjust parts_uncanon_normal for floatx80", "Date": "Fri, 7 May 2021 18:47:47 -0700", "Message-Id": "<20210508014802.892561-58-richard.henderson@linaro.org>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210508014802.892561-1-richard.henderson@linaro.org>", "References": "<20210508014802.892561-1-richard.henderson@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::431;\n envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x431.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "alex.bennee@linaro.org, david@redhat.com", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "With floatx80_precision_x, the rounding happens across\nthe break between words. Notice this case with\n\n frac_lsb = round_mask + 1 -> 0\n\nand check the bits in frac_hi as needed.\n\nIn addition, since frac_shift == 0, we won't implicitly clear\nround_mask via the right-shift, so explicitly clear those bits.\nThis fixes rounding for floatx80_precision_[sd].\n\nSigned-off-by: Richard Henderson <richard.henderson@linaro.org>\n---\n fpu/softfloat-parts.c.inc | 36 ++++++++++++++++++++++++++++++------\n 1 file changed, 30 insertions(+), 6 deletions(-)", "diff": "diff --git a/fpu/softfloat-parts.c.inc b/fpu/softfloat-parts.c.inc\nindex 3ee6552d5a..c18f77f2cf 100644\n--- a/fpu/softfloat-parts.c.inc\n+++ b/fpu/softfloat-parts.c.inc\n@@ -156,7 +156,13 @@ static void partsN(uncanon_normal)(FloatPartsN *p, float_status *s,\n switch (s->float_rounding_mode) {\n case float_round_nearest_even:\n overflow_norm = false;\n- inc = ((p->frac_lo & roundeven_mask) != frac_lsbm1 ? frac_lsbm1 : 0);\n+ if (N > 64 && frac_lsb == 0) {\n+ inc = ((p->frac_hi & 1) || (p->frac_lo & round_mask) != frac_lsbm1\n+ ? frac_lsbm1 : 0);\n+ } else {\n+ inc = ((p->frac_lo & roundeven_mask) != frac_lsbm1\n+ ? frac_lsbm1 : 0);\n+ }\n break;\n case float_round_ties_away:\n overflow_norm = false;\n@@ -176,7 +182,11 @@ static void partsN(uncanon_normal)(FloatPartsN *p, float_status *s,\n break;\n case float_round_to_odd:\n overflow_norm = true;\n- inc = p->frac_lo & frac_lsb ? 0 : round_mask;\n+ if (N > 64 && frac_lsb == 0) {\n+ inc = p->frac_hi & 1 ? 0 : round_mask;\n+ } else {\n+ inc = p->frac_lo & frac_lsb ? 0 : round_mask;\n+ }\n break;\n default:\n g_assert_not_reached();\n@@ -191,8 +201,8 @@ static void partsN(uncanon_normal)(FloatPartsN *p, float_status *s,\n p->frac_hi |= DECOMPOSED_IMPLICIT_BIT;\n exp++;\n }\n+ p->frac_lo &= ~round_mask;\n }\n- frac_shr(p, frac_shift);\n \n if (fmt->arm_althp) {\n /* ARM Alt HP eschews Inf and NaN for a wider exponent. */\n@@ -201,18 +211,21 @@ static void partsN(uncanon_normal)(FloatPartsN *p, float_status *s,\n flags = float_flag_invalid;\n exp = exp_max;\n frac_allones(p);\n+ p->frac_lo &= ~round_mask;\n }\n } else if (unlikely(exp >= exp_max)) {\n flags |= float_flag_overflow | float_flag_inexact;\n if (overflow_norm) {\n exp = exp_max - 1;\n frac_allones(p);\n+ p->frac_lo &= ~round_mask;\n } else {\n p->cls = float_class_inf;\n exp = exp_max;\n frac_clear(p);\n }\n }\n+ frac_shr(p, frac_shift);\n } else if (s->flush_to_zero) {\n flags |= float_flag_output_denormal;\n p->cls = float_class_zero;\n@@ -232,17 +245,28 @@ static void partsN(uncanon_normal)(FloatPartsN *p, float_status *s,\n /* Need to recompute round-to-even/round-to-odd. */\n switch (s->float_rounding_mode) {\n case float_round_nearest_even:\n- inc = ((p->frac_lo & roundeven_mask) != frac_lsbm1\n- ? frac_lsbm1 : 0);\n+ if (N > 64 && frac_lsb == 0) {\n+ inc = ((p->frac_hi & 1) ||\n+ (p->frac_lo & round_mask) != frac_lsbm1\n+ ? frac_lsbm1 : 0);\n+ } else {\n+ inc = ((p->frac_lo & roundeven_mask) != frac_lsbm1\n+ ? frac_lsbm1 : 0);\n+ }\n break;\n case float_round_to_odd:\n- inc = p->frac_lo & frac_lsb ? 0 : round_mask;\n+ if (N > 64 && frac_lsb == 0) {\n+ inc = p->frac_hi & 1 ? 0 : round_mask;\n+ } else {\n+ inc = p->frac_lo & frac_lsb ? 0 : round_mask;\n+ }\n break;\n default:\n break;\n }\n flags |= float_flag_inexact;\n frac_addi(p, p, inc);\n+ p->frac_lo &= ~round_mask;\n }\n \n exp = (p->frac_hi & DECOMPOSED_IMPLICIT_BIT) != 0;\n", "prefixes": [ "57/72" ] }