Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1475770/?format=api
{ "id": 1475770, "url": "http://patchwork.ozlabs.org/api/patches/1475770/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20210508014802.892561-55-richard.henderson@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20210508014802.892561-55-richard.henderson@linaro.org>", "list_archive_url": null, "date": "2021-05-08T01:47:44", "name": "[54/72] softfloat: Split out parts_uncanon_normal", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "3bb0988c4e4b8e4ffa09fa264b4cba1ce7859139", "submitter": { "id": 72104, "url": "http://patchwork.ozlabs.org/api/people/72104/?format=api", "name": "Richard Henderson", "email": "richard.henderson@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20210508014802.892561-55-richard.henderson@linaro.org/mbox/", "series": [ { "id": 242770, "url": "http://patchwork.ozlabs.org/api/series/242770/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=242770", "date": "2021-05-08T01:46:53", "name": "Convert floatx80 and float128 to FloatParts", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/242770/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1475770/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1475770/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=Xey1+YXB;\n\tdkim-atps=neutral" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4FcWh65DjDz9sCD\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 8 May 2021 12:37:58 +1000 (AEST)", "from localhost ([::1]:39614 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1lfCqq-00040s-Ng\n\tfor incoming@patchwork.ozlabs.org; Fri, 07 May 2021 22:37:56 -0400", "from eggs.gnu.org ([2001:470:142:3::10]:41592)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1lfC86-00039V-70\n for qemu-devel@nongnu.org; Fri, 07 May 2021 21:51:42 -0400", "from mail-pg1-x535.google.com ([2607:f8b0:4864:20::535]:44903)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1lfC84-0005VH-D5\n for qemu-devel@nongnu.org; Fri, 07 May 2021 21:51:41 -0400", "by mail-pg1-x535.google.com with SMTP id y32so8617369pga.11\n for <qemu-devel@nongnu.org>; Fri, 07 May 2021 18:51:39 -0700 (PDT)", "from localhost.localdomain ([71.212.144.24])\n by smtp.gmail.com with ESMTPSA id 204sm5861396pfw.158.2021.05.07.18.51.38\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 07 May 2021 18:51:38 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=zL439EHx3BPOhexd35s+Xkdi6C28utf2wKmRbPR2CBI=;\n b=Xey1+YXBlzvQ+XRKDOTSi4J19G9eWajaJyQTd4PukhpSnIX9gaxXRNme2bKqp7za1o\n CAEcAZ5ihkqzT/CwcSjMNGMM2STzyNwO2cuUsrk3ln+peKvBum3Mx7xt0yNEC2uIgRYw\n 49cptIz+sBVEcVj5nGjTV4+4EItUWu5qhRmVCxPAJDd931TmowV5OA8CYEcD90vjbAGZ\n pdWu+56H44gIspc0AMnkkc9HC2NEFB+Fabv/wloG42kDTJh/u4f2gy04q2M0mgdEqurU\n Sla3L64Boa/gdK9YgNpwo1yNjYVpe6G11ge20RA42/EG/x3iork8waEeNDqah3O9lINq\n B+aw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=zL439EHx3BPOhexd35s+Xkdi6C28utf2wKmRbPR2CBI=;\n b=qOVgiHUfxbNQabcHBxFG5JEZlkGtQ017CmfM/3rNYMk5pc14U/gCa23ZKw2F61jF0n\n qYIQRwKPJalxyIiAXW2rgQ/TnGrm6CkRoc3BzSyl6T0/U9Mo27QPnVeKbm1Y+HyadG4H\n 6pGV5mg9dpNrIfC44AxXdl/gnVDISVzRQHrHytSxMKWlil8dHaQuWS1p5rRn+doKrMJq\n tDMHGv7z822y2zOPURhM9lbKdW+cPlp4Af15JaAEpysv3kru8OSdvUNBiUvB7N6yFzbX\n 5R77UutSViOOZ60dNhLqEStLjMoNIFp9rOdolUMbfqUCo34P3yGHWY6HLmwjDR//vsXJ\n ylhw==", "X-Gm-Message-State": "AOAM533SWh6a6iL2/xYG/j7o3Hko+EUdy7j+t54mGaelGtSW0vrN5lx8\n Ho0ZhDlR1uWdyasMWK3zrbTa49oXle37EQ==", "X-Google-Smtp-Source": "\n ABdhPJy6eFTQk6dZCxYbHk+K9MFVStlFjNbfvpm8xKXyA3T3i4stSovRrSpCxvq3fLKCyC7vEFGK6Q==", "X-Received": "by 2002:aa7:9104:0:b029:279:e897:2825 with SMTP id\n 4-20020aa791040000b0290279e8972825mr13447797pfh.51.1620438699041;\n Fri, 07 May 2021 18:51:39 -0700 (PDT)", "From": "Richard Henderson <richard.henderson@linaro.org>", "To": "qemu-devel@nongnu.org", "Subject": "[PATCH 54/72] softfloat: Split out parts_uncanon_normal", "Date": "Fri, 7 May 2021 18:47:44 -0700", "Message-Id": "<20210508014802.892561-55-richard.henderson@linaro.org>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210508014802.892561-1-richard.henderson@linaro.org>", "References": "<20210508014802.892561-1-richard.henderson@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::535;\n envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x535.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "alex.bennee@linaro.org, david@redhat.com", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "We will need to treat the non-normal cases of floatx80 specially,\nso split out the normal case that we can reuse.\n\nSigned-off-by: Richard Henderson <richard.henderson@linaro.org>\n---\n fpu/softfloat.c | 8 ++++++\n fpu/softfloat-parts.c.inc | 56 ++++++++++++++++++++++-----------------\n 2 files changed, 39 insertions(+), 25 deletions(-)", "diff": "diff --git a/fpu/softfloat.c b/fpu/softfloat.c\nindex 75a3bb881d..4df69029ec 100644\n--- a/fpu/softfloat.c\n+++ b/fpu/softfloat.c\n@@ -763,6 +763,14 @@ static void parts128_canonicalize(FloatParts128 *p, float_status *status,\n #define parts_canonicalize(A, S, F) \\\n PARTS_GENERIC_64_128(canonicalize, A)(A, S, F)\n \n+static void parts64_uncanon_normal(FloatParts64 *p, float_status *status,\n+ const FloatFmt *fmt);\n+static void parts128_uncanon_normal(FloatParts128 *p, float_status *status,\n+ const FloatFmt *fmt);\n+\n+#define parts_uncanon_normal(A, S, F) \\\n+ PARTS_GENERIC_64_128(uncanon_normal, A)(A, S, F)\n+\n static void parts64_uncanon(FloatParts64 *p, float_status *status,\n const FloatFmt *fmt);\n static void parts128_uncanon(FloatParts128 *p, float_status *status,\ndiff --git a/fpu/softfloat-parts.c.inc b/fpu/softfloat-parts.c.inc\nindex 293029711c..65462bf6cb 100644\n--- a/fpu/softfloat-parts.c.inc\n+++ b/fpu/softfloat-parts.c.inc\n@@ -140,8 +140,8 @@ static void partsN(canonicalize)(FloatPartsN *p, float_status *status,\n * fraction; these bits will be removed. The exponent will be biased\n * by EXP_BIAS and must be bounded by [EXP_MAX-1, 0].\n */\n-static void partsN(uncanon)(FloatPartsN *p, float_status *s,\n- const FloatFmt *fmt)\n+static void partsN(uncanon_normal)(FloatPartsN *p, float_status *s,\n+ const FloatFmt *fmt)\n {\n const int exp_max = fmt->exp_max;\n const int frac_shift = fmt->frac_shift;\n@@ -153,29 +153,6 @@ static void partsN(uncanon)(FloatPartsN *p, float_status *s,\n bool overflow_norm;\n int exp, flags = 0;\n \n- if (unlikely(p->cls != float_class_normal)) {\n- switch (p->cls) {\n- case float_class_zero:\n- p->exp = 0;\n- frac_clear(p);\n- return;\n- case float_class_inf:\n- g_assert(!fmt->arm_althp);\n- p->exp = fmt->exp_max;\n- frac_clear(p);\n- return;\n- case float_class_qnan:\n- case float_class_snan:\n- g_assert(!fmt->arm_althp);\n- p->exp = fmt->exp_max;\n- frac_shr(p, fmt->frac_shift);\n- return;\n- default:\n- break;\n- }\n- g_assert_not_reached();\n- }\n-\n switch (s->float_rounding_mode) {\n case float_round_nearest_even:\n overflow_norm = false;\n@@ -282,6 +259,35 @@ static void partsN(uncanon)(FloatPartsN *p, float_status *s,\n float_raise(flags, s);\n }\n \n+static void partsN(uncanon)(FloatPartsN *p, float_status *s,\n+ const FloatFmt *fmt)\n+{\n+ if (likely(p->cls == float_class_normal)) {\n+ parts_uncanon_normal(p, s, fmt);\n+ } else {\n+ switch (p->cls) {\n+ case float_class_zero:\n+ p->exp = 0;\n+ frac_clear(p);\n+ return;\n+ case float_class_inf:\n+ g_assert(!fmt->arm_althp);\n+ p->exp = fmt->exp_max;\n+ frac_clear(p);\n+ return;\n+ case float_class_qnan:\n+ case float_class_snan:\n+ g_assert(!fmt->arm_althp);\n+ p->exp = fmt->exp_max;\n+ frac_shr(p, fmt->frac_shift);\n+ return;\n+ default:\n+ break;\n+ }\n+ g_assert_not_reached();\n+ }\n+}\n+\n /*\n * Returns the result of adding or subtracting the values of the\n * floating-point values `a' and `b'. The operation is performed\n", "prefixes": [ "54/72" ] }