Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1475758/?format=api
{ "id": 1475758, "url": "http://patchwork.ozlabs.org/api/patches/1475758/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20210508014802.892561-53-richard.henderson@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20210508014802.892561-53-richard.henderson@linaro.org>", "list_archive_url": null, "date": "2021-05-08T01:47:42", "name": "[52/72] softfloat: Move scalbn_decomposed to softfloat-parts.c.inc", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "f1ee9fcb9317857a65009d22ad12237be0e2ea23", "submitter": { "id": 72104, "url": "http://patchwork.ozlabs.org/api/people/72104/?format=api", "name": "Richard Henderson", "email": "richard.henderson@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20210508014802.892561-53-richard.henderson@linaro.org/mbox/", "series": [ { "id": 242770, "url": "http://patchwork.ozlabs.org/api/series/242770/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=242770", "date": "2021-05-08T01:46:53", "name": "Convert floatx80 and float128 to FloatParts", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/242770/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1475758/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1475758/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=WB2XNQ1y;\n\tdkim-atps=neutral" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4FcWY42DMQz9sTD\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 8 May 2021 12:31:52 +1000 (AEST)", "from localhost ([::1]:45360 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1lfCkw-0005yY-85\n\tfor incoming@patchwork.ozlabs.org; Fri, 07 May 2021 22:31:50 -0400", "from eggs.gnu.org ([2001:470:142:3::10]:41598)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1lfC86-0003Bl-Pu\n for qemu-devel@nongnu.org; Fri, 07 May 2021 21:51:42 -0400", "from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]:45657)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1lfC82-0005UC-V7\n for qemu-devel@nongnu.org; Fri, 07 May 2021 21:51:42 -0400", "by mail-pf1-x42c.google.com with SMTP id i190so9084664pfc.12\n for <qemu-devel@nongnu.org>; Fri, 07 May 2021 18:51:38 -0700 (PDT)", "from localhost.localdomain ([71.212.144.24])\n by smtp.gmail.com with ESMTPSA id 204sm5861396pfw.158.2021.05.07.18.51.37\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 07 May 2021 18:51:37 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=eMIJGqBzed5Gqno92wb2fBBiT03MKVRcpl3Hpjjr9sA=;\n b=WB2XNQ1yGN4oLJb3r3tnLj+wjaa/nwWP8mPVhL+0H2oONQ722gMg4ATft46RjusWdl\n A34AN/izQw1MtDrY4oeITQLY56A1Zgw8XeIb8BcSoGIWxCry7pJQO+QnrOfz9TfOP57L\n CqpNwpo6u+MkELA2Mk4iwvv3jRMcn05OTjIYuPpa6Y8g5EvjkuQQQxyNfsHddsHQozwA\n GCvH1D02moeuVnWt5l8ew0shbMwh4JN8fCK7Qf6VZSPqNJsBKI5xnWKYprf7yUkUHM/9\n W3WU/KcfQAPB8l7qx0JJoZo9rgsF1FF/dcm5zDR44nLcPw2MfjVUHt0zEbUmHorV30RC\n Gb5A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=eMIJGqBzed5Gqno92wb2fBBiT03MKVRcpl3Hpjjr9sA=;\n b=QPXYZsbRLyjkAAKkPb0FOaV+OXx1ON0h1etmF2AtXGWYA2DHqlJ3DuJHbsLLwwO5J6\n FKNSH2xi9Wg3OPiJviocgS1Hk0agVdVHeuxUkotwJkfMuO2nuc9QdyPEnyiC5wGf+Esf\n 12zSUJQF84T/V5hhPUAkRFP4a9Vt8BOQ5Na3dl5upPL76jS/Cisf5/vRZW1q184OFhKz\n 2DiqY4ZCvmIETbn/LjeMwQ+Dj4chl1tpPqJi7neeVIap80atVR4caXcOA4u9U8xFf6sY\n 9wy13MUEFT2sX6v+aZfb3c/N3A0kN08EeVzifLK4M//X4130YtOGxSYr7U0kMyLVi7PQ\n 9V1A==", "X-Gm-Message-State": "AOAM533i04Jay2J1sriMuWI0IBL7R5Dh/6WsZ/2czPTkGPMm3wo7UaHC\n OCRVfZRRr/Jbm87FaAWYb7SylAhtQD1uIg==", "X-Google-Smtp-Source": "\n ABdhPJwxWMW7kM/Gvg8ugzCZBSE1BsooiXy6Hpl3/xPpxSREUQhrf8MutnZpnka+56nzOQuwu/Zaag==", "X-Received": "by 2002:aa7:87d9:0:b029:28e:af66:d71d with SMTP id\n i25-20020aa787d90000b029028eaf66d71dmr13658492pfo.28.1620438697557;\n Fri, 07 May 2021 18:51:37 -0700 (PDT)", "From": "Richard Henderson <richard.henderson@linaro.org>", "To": "qemu-devel@nongnu.org", "Subject": "[PATCH 52/72] softfloat: Move scalbn_decomposed to\n softfloat-parts.c.inc", "Date": "Fri, 7 May 2021 18:47:42 -0700", "Message-Id": "<20210508014802.892561-53-richard.henderson@linaro.org>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210508014802.892561-1-richard.henderson@linaro.org>", "References": "<20210508014802.892561-1-richard.henderson@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::42c;\n envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42c.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "alex.bennee@linaro.org, david@redhat.com", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "Rename to parts$N_scalbn.\nReimplement float128_scalbn with FloatParts128.\n\nSigned-off-by: Richard Henderson <richard.henderson@linaro.org>\n---\n fpu/softfloat.c | 103 +++++++++++++-------------------------\n fpu/softfloat-parts.c.inc | 21 ++++++++\n 2 files changed, 55 insertions(+), 69 deletions(-)", "diff": "diff --git a/fpu/softfloat.c b/fpu/softfloat.c\nindex 2faceadf8b..f83ca20000 100644\n--- a/fpu/softfloat.c\n+++ b/fpu/softfloat.c\n@@ -889,6 +889,12 @@ static int parts128_compare(FloatParts128 *a, FloatParts128 *b,\n #define parts_compare(A, B, S, Q) \\\n PARTS_GENERIC_64_128(compare, A)(A, B, S, Q)\n \n+static void parts64_scalbn(FloatParts64 *a, int n, float_status *s);\n+static void parts128_scalbn(FloatParts128 *a, int n, float_status *s);\n+\n+#define parts_scalbn(A, N, S) \\\n+ PARTS_GENERIC_64_128(scalbn, A)(A, N, S)\n+\n /*\n * Helper functions for softfloat-parts.c.inc, per-size operations.\n */\n@@ -3531,58 +3537,53 @@ FloatRelation float128_compare_quiet(float128 a, float128 b, float_status *s)\n return float128_do_compare(a, b, s, true);\n }\n \n-/* Multiply A by 2 raised to the power N. */\n-static FloatParts64 scalbn_decomposed(FloatParts64 a, int n, float_status *s)\n-{\n- if (unlikely(is_nan(a.cls))) {\n- parts_return_nan(&a, s);\n- }\n- if (a.cls == float_class_normal) {\n- /* The largest float type (even though not supported by FloatParts64)\n- * is float128, which has a 15 bit exponent. Bounding N to 16 bits\n- * still allows rounding to infinity, without allowing overflow\n- * within the int32_t that backs FloatParts64.exp.\n- */\n- n = MIN(MAX(n, -0x10000), 0x10000);\n- a.exp += n;\n- }\n- return a;\n-}\n+/*\n+ * Scale by 2**N\n+ */\n \n float16 float16_scalbn(float16 a, int n, float_status *status)\n {\n- FloatParts64 pa, pr;\n+ FloatParts64 p;\n \n- float16_unpack_canonical(&pa, a, status);\n- pr = scalbn_decomposed(pa, n, status);\n- return float16_round_pack_canonical(&pr, status);\n+ float16_unpack_canonical(&p, a, status);\n+ parts_scalbn(&p, n, status);\n+ return float16_round_pack_canonical(&p, status);\n }\n \n float32 float32_scalbn(float32 a, int n, float_status *status)\n {\n- FloatParts64 pa, pr;\n+ FloatParts64 p;\n \n- float32_unpack_canonical(&pa, a, status);\n- pr = scalbn_decomposed(pa, n, status);\n- return float32_round_pack_canonical(&pr, status);\n+ float32_unpack_canonical(&p, a, status);\n+ parts_scalbn(&p, n, status);\n+ return float32_round_pack_canonical(&p, status);\n }\n \n float64 float64_scalbn(float64 a, int n, float_status *status)\n {\n- FloatParts64 pa, pr;\n+ FloatParts64 p;\n \n- float64_unpack_canonical(&pa, a, status);\n- pr = scalbn_decomposed(pa, n, status);\n- return float64_round_pack_canonical(&pr, status);\n+ float64_unpack_canonical(&p, a, status);\n+ parts_scalbn(&p, n, status);\n+ return float64_round_pack_canonical(&p, status);\n }\n \n bfloat16 bfloat16_scalbn(bfloat16 a, int n, float_status *status)\n {\n- FloatParts64 pa, pr;\n+ FloatParts64 p;\n \n- bfloat16_unpack_canonical(&pa, a, status);\n- pr = scalbn_decomposed(pa, n, status);\n- return bfloat16_round_pack_canonical(&pr, status);\n+ bfloat16_unpack_canonical(&p, a, status);\n+ parts_scalbn(&p, n, status);\n+ return bfloat16_round_pack_canonical(&p, status);\n+}\n+\n+float128 float128_scalbn(float128 a, int n, float_status *status)\n+{\n+ FloatParts128 p;\n+\n+ float128_unpack_canonical(&p, a, status);\n+ parts_scalbn(&p, n, status);\n+ return float128_round_pack_canonical(&p, status);\n }\n \n /*\n@@ -6640,42 +6641,6 @@ floatx80 floatx80_scalbn(floatx80 a, int n, float_status *status)\n aSign, aExp, aSig, 0, status);\n }\n \n-float128 float128_scalbn(float128 a, int n, float_status *status)\n-{\n- bool aSign;\n- int32_t aExp;\n- uint64_t aSig0, aSig1;\n-\n- aSig1 = extractFloat128Frac1( a );\n- aSig0 = extractFloat128Frac0( a );\n- aExp = extractFloat128Exp( a );\n- aSign = extractFloat128Sign( a );\n- if ( aExp == 0x7FFF ) {\n- if ( aSig0 | aSig1 ) {\n- return propagateFloat128NaN(a, a, status);\n- }\n- return a;\n- }\n- if (aExp != 0) {\n- aSig0 |= UINT64_C(0x0001000000000000);\n- } else if (aSig0 == 0 && aSig1 == 0) {\n- return a;\n- } else {\n- aExp++;\n- }\n-\n- if (n > 0x10000) {\n- n = 0x10000;\n- } else if (n < -0x10000) {\n- n = -0x10000;\n- }\n-\n- aExp += n - 1;\n- return normalizeRoundAndPackFloat128( aSign, aExp, aSig0, aSig1\n- , status);\n-\n-}\n-\n static void __attribute__((constructor)) softfloat_init(void)\n {\n union_float64 ua, ub, uc, ur;\ndiff --git a/fpu/softfloat-parts.c.inc b/fpu/softfloat-parts.c.inc\nindex 4e11aa8b3b..9749c11a6b 100644\n--- a/fpu/softfloat-parts.c.inc\n+++ b/fpu/softfloat-parts.c.inc\n@@ -1062,3 +1062,24 @@ static FloatRelation partsN(compare)(FloatPartsN *a, FloatPartsN *b,\n b_sign:\n return b->sign ? float_relation_greater : float_relation_less;\n }\n+\n+/*\n+ * Multiply A by 2 raised to the power N.\n+ */\n+static void partsN(scalbn)(FloatPartsN *a, int n, float_status *s)\n+{\n+ switch (a->cls) {\n+ case float_class_snan:\n+ case float_class_qnan:\n+ parts_return_nan(a, s);\n+ break;\n+ case float_class_zero:\n+ case float_class_inf:\n+ break;\n+ case float_class_normal:\n+ a->exp += MIN(MAX(n, -0x10000), 0x10000);\n+ break;\n+ default:\n+ g_assert_not_reached();\n+ }\n+}\n", "prefixes": [ "52/72" ] }