Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1475754/?format=api
{ "id": 1475754, "url": "http://patchwork.ozlabs.org/api/patches/1475754/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20210508014802.892561-49-richard.henderson@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20210508014802.892561-49-richard.henderson@linaro.org>", "list_archive_url": null, "date": "2021-05-08T01:47:38", "name": "[48/72] softfloat: Move int_to_float to softfloat-parts.c.inc", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "ea17c28ef563cfd99e9dc4039e9c46e87de5367c", "submitter": { "id": 72104, "url": "http://patchwork.ozlabs.org/api/people/72104/?format=api", "name": "Richard Henderson", "email": "richard.henderson@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20210508014802.892561-49-richard.henderson@linaro.org/mbox/", "series": [ { "id": 242770, "url": "http://patchwork.ozlabs.org/api/series/242770/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=242770", "date": "2021-05-08T01:46:53", "name": "Convert floatx80 and float128 to FloatParts", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/242770/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1475754/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1475754/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=IF7kVHgR;\n\tdkim-atps=neutral" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4FcWVt3clWz9sX3\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 8 May 2021 12:29:58 +1000 (AEST)", "from localhost ([::1]:36726 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1lfCj6-0000DV-HU\n\tfor incoming@patchwork.ozlabs.org; Fri, 07 May 2021 22:29:56 -0400", "from eggs.gnu.org ([2001:470:142:3::10]:41510)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1lfC82-0002vM-N0\n for qemu-devel@nongnu.org; Fri, 07 May 2021 21:51:38 -0400", "from mail-pg1-x52f.google.com ([2607:f8b0:4864:20::52f]:46767)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1lfC80-0005Rp-Ep\n for qemu-devel@nongnu.org; Fri, 07 May 2021 21:51:38 -0400", "by mail-pg1-x52f.google.com with SMTP id m124so8603148pgm.13\n for <qemu-devel@nongnu.org>; Fri, 07 May 2021 18:51:36 -0700 (PDT)", "from localhost.localdomain ([71.212.144.24])\n by smtp.gmail.com with ESMTPSA id 204sm5861396pfw.158.2021.05.07.18.51.34\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 07 May 2021 18:51:34 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=1Od39KgKMdYhwkyR5c/sGxfaCPXmuk0Ca5kCuFG8rqg=;\n b=IF7kVHgRdpduJYwf3ykC3rP1wJOb9RxNKG7me5v76JPWL3/rZrKtwg5S9e+7mrrcgx\n Zaiocmb6pnHrk3mcgttwIrDk4El8Jcm397Wl37Ie3ipU3RXcKeD7NDRUwuYMeS0bO0lB\n dflQQ3ZoFRmgg/tpxw+L2pje3eAgMyVmdOwB4M0KUYSVkYXvVQbyxjrVMTOWWxJvT9Vo\n B4jy/nxcsWg87CCg/p/wYkODgiORHRMEE2Nw6KA82PdsxHo8gfE4W9euU0Qj02lAKyWT\n YW5b2dsHZ36H5ISROCL0b5fdtDmkR1GsMDTY0e3vBFFiCwzo+WXjKrGi9NpynpZutOqM\n p5kQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=1Od39KgKMdYhwkyR5c/sGxfaCPXmuk0Ca5kCuFG8rqg=;\n b=Y7l2Pj/SfTf59RAuMbvoljeQOrsQEd0vgqEnunZAu/p+KaTRsxhX+dCi2IOzlOyDZ2\n 1wF283506/Zj+UKqz+Vfgejt/jolpAQbmertGnbka+dCwcRzj4czqA89+LCVt7bnQL8v\n 2sK1xKkbHhZ5P+72q8BopS3AkcYSVQC1qpHjTEb57JPfc66jRAtj5mm8JTlRdtPNjYJH\n jD4Oj4Kvlo3RGhEYaRYRrPPq1aeqdIHhDOA/sfRsguffMPYP1hJ9W82ERnYZW56NPp6h\n QpsxdcT3QgzXaI7u8xszd8InoyK7lL65UERubAsOwZBBh4gughkJ9mSuHLbDixxMVOe7\n 8kww==", "X-Gm-Message-State": "AOAM532MC1f3jjuXKt8lF2TcM5Gr5frBza86fegntJI/0tdw3WudP83G\n ypEGheS0jWw849oWp8+l/dyVYF5XymzoJA==", "X-Google-Smtp-Source": "\n ABdhPJwmk15h4bFF5YpiHFBshL0rrA77oOC+D42wOxVJbVo1Pqx7x3oYMEZmG8WfUj8cLBYybNO0ww==", "X-Received": "by 2002:a62:8fd2:0:b029:28e:8c64:52a4 with SMTP id\n n201-20020a628fd20000b029028e8c6452a4mr13447910pfd.3.1620438695142;\n Fri, 07 May 2021 18:51:35 -0700 (PDT)", "From": "Richard Henderson <richard.henderson@linaro.org>", "To": "qemu-devel@nongnu.org", "Subject": "[PATCH 48/72] softfloat: Move int_to_float to softfloat-parts.c.inc", "Date": "Fri, 7 May 2021 18:47:38 -0700", "Message-Id": "<20210508014802.892561-49-richard.henderson@linaro.org>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210508014802.892561-1-richard.henderson@linaro.org>", "References": "<20210508014802.892561-1-richard.henderson@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::52f;\n envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52f.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "alex.bennee@linaro.org, david@redhat.com", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "Rename to parts$N_sint_to_float.\nReimplement int{32,64}_to_float128 with FloatParts128.\n\nSigned-off-by: Richard Henderson <richard.henderson@linaro.org>\n---\n fpu/softfloat.c | 136 +++++++++++---------------------------\n fpu/softfloat-parts.c.inc | 32 +++++++++\n 2 files changed, 70 insertions(+), 98 deletions(-)", "diff": "diff --git a/fpu/softfloat.c b/fpu/softfloat.c\nindex 235ddda7a0..d843ea67c4 100644\n--- a/fpu/softfloat.c\n+++ b/fpu/softfloat.c\n@@ -848,6 +848,14 @@ static uint64_t parts128_float_to_uint(FloatParts128 *p, FloatRoundMode rmode,\n #define parts_float_to_uint(P, R, Z, M, S) \\\n PARTS_GENERIC_64_128(float_to_uint, P)(P, R, Z, M, S)\n \n+static void parts64_sint_to_float(FloatParts64 *p, int64_t a,\n+ int scale, float_status *s);\n+static void parts128_sint_to_float(FloatParts128 *p, int64_t a,\n+ int scale, float_status *s);\n+\n+#define parts_sint_to_float(P, I, Z, S) \\\n+ PARTS_GENERIC_64_128(sint_to_float, P)(P, I, Z, S)\n+\n /*\n * Helper functions for softfloat-parts.c.inc, per-size operations.\n */\n@@ -2939,42 +2947,15 @@ uint64_t bfloat16_to_uint64_round_to_zero(bfloat16 a, float_status *s)\n }\n \n /*\n- * Integer to float conversions\n- *\n- * Returns the result of converting the two's complement integer `a'\n- * to the floating-point format. The conversion is performed according\n- * to the IEC/IEEE Standard for Binary Floating-Point Arithmetic.\n+ * Signed integer to floating-point conversions\n */\n \n-static FloatParts64 int_to_float(int64_t a, int scale, float_status *status)\n-{\n- FloatParts64 r = { .sign = false };\n-\n- if (a == 0) {\n- r.cls = float_class_zero;\n- } else {\n- uint64_t f = a;\n- int shift;\n-\n- r.cls = float_class_normal;\n- if (a < 0) {\n- f = -f;\n- r.sign = true;\n- }\n- shift = clz64(f);\n- scale = MIN(MAX(scale, -0x10000), 0x10000);\n-\n- r.exp = DECOMPOSED_BINARY_POINT - shift + scale;\n- r.frac = f << shift;\n- }\n-\n- return r;\n-}\n-\n float16 int64_to_float16_scalbn(int64_t a, int scale, float_status *status)\n {\n- FloatParts64 pa = int_to_float(a, scale, status);\n- return float16_round_pack_canonical(&pa, status);\n+ FloatParts64 p;\n+\n+ parts_sint_to_float(&p, a, scale, status);\n+ return float16_round_pack_canonical(&p, status);\n }\n \n float16 int32_to_float16_scalbn(int32_t a, int scale, float_status *status)\n@@ -3009,8 +2990,10 @@ float16 int8_to_float16(int8_t a, float_status *status)\n \n float32 int64_to_float32_scalbn(int64_t a, int scale, float_status *status)\n {\n- FloatParts64 pa = int_to_float(a, scale, status);\n- return float32_round_pack_canonical(&pa, status);\n+ FloatParts64 p;\n+\n+ parts64_sint_to_float(&p, a, scale, status);\n+ return float32_round_pack_canonical(&p, status);\n }\n \n float32 int32_to_float32_scalbn(int32_t a, int scale, float_status *status)\n@@ -3040,8 +3023,10 @@ float32 int16_to_float32(int16_t a, float_status *status)\n \n float64 int64_to_float64_scalbn(int64_t a, int scale, float_status *status)\n {\n- FloatParts64 pa = int_to_float(a, scale, status);\n- return float64_round_pack_canonical(&pa, status);\n+ FloatParts64 p;\n+\n+ parts_sint_to_float(&p, a, scale, status);\n+ return float64_round_pack_canonical(&p, status);\n }\n \n float64 int32_to_float64_scalbn(int32_t a, int scale, float_status *status)\n@@ -3069,15 +3054,12 @@ float64 int16_to_float64(int16_t a, float_status *status)\n return int64_to_float64_scalbn(a, 0, status);\n }\n \n-/*\n- * Returns the result of converting the two's complement integer `a'\n- * to the bfloat16 format.\n- */\n-\n bfloat16 int64_to_bfloat16_scalbn(int64_t a, int scale, float_status *status)\n {\n- FloatParts64 pa = int_to_float(a, scale, status);\n- return bfloat16_round_pack_canonical(&pa, status);\n+ FloatParts64 p;\n+\n+ parts_sint_to_float(&p, a, scale, status);\n+ return bfloat16_round_pack_canonical(&p, status);\n }\n \n bfloat16 int32_to_bfloat16_scalbn(int32_t a, int scale, float_status *status)\n@@ -3105,6 +3087,19 @@ bfloat16 int16_to_bfloat16(int16_t a, float_status *status)\n return int64_to_bfloat16_scalbn(a, 0, status);\n }\n \n+float128 int64_to_float128(int64_t a, float_status *status)\n+{\n+ FloatParts128 p;\n+\n+ parts_sint_to_float(&p, a, 0, status);\n+ return float128_round_pack_canonical(&p, status);\n+}\n+\n+float128 int32_to_float128(int32_t a, float_status *status)\n+{\n+ return int64_to_float128(a, status);\n+}\n+\n /*\n * Unsigned Integer to float conversions\n *\n@@ -4955,28 +4950,6 @@ floatx80 int32_to_floatx80(int32_t a, float_status *status)\n \n }\n \n-/*----------------------------------------------------------------------------\n-| Returns the result of converting the 32-bit two's complement integer `a' to\n-| the quadruple-precision floating-point format. The conversion is performed\n-| according to the IEC/IEEE Standard for Binary Floating-Point Arithmetic.\n-*----------------------------------------------------------------------------*/\n-\n-float128 int32_to_float128(int32_t a, float_status *status)\n-{\n- bool zSign;\n- uint32_t absA;\n- int8_t shiftCount;\n- uint64_t zSig0;\n-\n- if ( a == 0 ) return packFloat128( 0, 0, 0, 0 );\n- zSign = ( a < 0 );\n- absA = zSign ? - a : a;\n- shiftCount = clz32(absA) + 17;\n- zSig0 = absA;\n- return packFloat128( zSign, 0x402E - shiftCount, zSig0<<shiftCount, 0 );\n-\n-}\n-\n /*----------------------------------------------------------------------------\n | Returns the result of converting the 64-bit two's complement integer `a'\n | to the extended double-precision floating-point format. The conversion\n@@ -4998,39 +4971,6 @@ floatx80 int64_to_floatx80(int64_t a, float_status *status)\n \n }\n \n-/*----------------------------------------------------------------------------\n-| Returns the result of converting the 64-bit two's complement integer `a' to\n-| the quadruple-precision floating-point format. The conversion is performed\n-| according to the IEC/IEEE Standard for Binary Floating-Point Arithmetic.\n-*----------------------------------------------------------------------------*/\n-\n-float128 int64_to_float128(int64_t a, float_status *status)\n-{\n- bool zSign;\n- uint64_t absA;\n- int8_t shiftCount;\n- int32_t zExp;\n- uint64_t zSig0, zSig1;\n-\n- if ( a == 0 ) return packFloat128( 0, 0, 0, 0 );\n- zSign = ( a < 0 );\n- absA = zSign ? - a : a;\n- shiftCount = clz64(absA) + 49;\n- zExp = 0x406E - shiftCount;\n- if ( 64 <= shiftCount ) {\n- zSig1 = 0;\n- zSig0 = absA;\n- shiftCount -= 64;\n- }\n- else {\n- zSig1 = absA;\n- zSig0 = 0;\n- }\n- shortShift128Left( zSig0, zSig1, shiftCount, &zSig0, &zSig1 );\n- return packFloat128( zSign, zExp, zSig0, zSig1 );\n-\n-}\n-\n /*----------------------------------------------------------------------------\n | Returns the result of converting the 64-bit unsigned integer `a'\n | to the quadruple-precision floating-point format. The conversion is performed\ndiff --git a/fpu/softfloat-parts.c.inc b/fpu/softfloat-parts.c.inc\nindex c6e327547f..8102de1307 100644\n--- a/fpu/softfloat-parts.c.inc\n+++ b/fpu/softfloat-parts.c.inc\n@@ -881,3 +881,35 @@ static uint64_t partsN(float_to_uint)(FloatPartsN *p, FloatRoundMode rmode,\n float_raise(flags, s);\n return r;\n }\n+\n+/*\n+ * Integer to float conversions\n+ *\n+ * Returns the result of converting the two's complement integer `a'\n+ * to the floating-point format. The conversion is performed according\n+ * to the IEC/IEEE Standard for Binary Floating-Point Arithmetic.\n+ */\n+static void partsN(sint_to_float)(FloatPartsN *p, int64_t a,\n+ int scale, float_status *s)\n+{\n+ uint64_t f = a;\n+ int shift;\n+\n+ memset(p, 0, sizeof(*p));\n+\n+ if (a == 0) {\n+ p->cls = float_class_zero;\n+ return;\n+ }\n+\n+ p->cls = float_class_normal;\n+ if (a < 0) {\n+ f = -f;\n+ p->sign = true;\n+ }\n+ shift = clz64(f);\n+ scale = MIN(MAX(scale, -0x10000), 0x10000);\n+\n+ p->exp = DECOMPOSED_BINARY_POINT - shift + scale;\n+ p->frac_hi = f << shift;\n+}\n", "prefixes": [ "48/72" ] }