Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1475736/?format=api
{ "id": 1475736, "url": "http://patchwork.ozlabs.org/api/patches/1475736/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20210508014802.892561-29-richard.henderson@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20210508014802.892561-29-richard.henderson@linaro.org>", "list_archive_url": null, "date": "2021-05-08T01:47:18", "name": "[28/72] softfloat: Move return_nan to softfloat-parts.c.inc", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "57a397a03e9a577b4572e171dc5614fbfb662094", "submitter": { "id": 72104, "url": "http://patchwork.ozlabs.org/api/people/72104/?format=api", "name": "Richard Henderson", "email": "richard.henderson@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20210508014802.892561-29-richard.henderson@linaro.org/mbox/", "series": [ { "id": 242770, "url": "http://patchwork.ozlabs.org/api/series/242770/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=242770", "date": "2021-05-08T01:46:53", "name": "Convert floatx80 and float128 to FloatParts", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/242770/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1475736/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1475736/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=b+2D+jy4;\n\tdkim-atps=neutral" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4FcW8v35xrz9sRK\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 8 May 2021 12:14:23 +1000 (AEST)", "from localhost ([::1]:55180 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1lfCU1-0008Df-88\n\tfor incoming@patchwork.ozlabs.org; Fri, 07 May 2021 22:14:21 -0400", "from eggs.gnu.org ([2001:470:142:3::10]:40888)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1lfC58-0004Tv-Nj\n for qemu-devel@nongnu.org; Fri, 07 May 2021 21:48:38 -0400", "from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]:40947)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1lfC4t-0003e8-EE\n for qemu-devel@nongnu.org; Fri, 07 May 2021 21:48:38 -0400", "by mail-pl1-x634.google.com with SMTP id n16so6142830plf.7\n for <qemu-devel@nongnu.org>; Fri, 07 May 2021 18:48:22 -0700 (PDT)", "from localhost.localdomain ([71.212.144.24])\n by smtp.gmail.com with ESMTPSA id t4sm5819681pfq.165.2021.05.07.18.48.21\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 07 May 2021 18:48:21 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=wdvnl/BT8EpxSM2u6kGkXFgWaAcTOrO0eZtHA1yV7g8=;\n b=b+2D+jy47RtHzEaXEdKXxMlpv4MRONgMNHezoqY4AQqlpdHZ5NkJQqbpksVk2+S6e2\n hIQaBQP7qqf9Dsz/akYSa9A++AJCie471KE8pFZjGNJ8pvM0MRvHasgZRjjintPWCGKl\n oa0hsz5QRudTmR3+Xcd1y5hw8ybHjjllGFwv8bZeVbLO3Apr8yej0UpvAbYtJJcapysT\n o6XwM5gtpCt64m1jxCsW+prlM1Eif2RqyQX7HXVorU1lLVKAb7GEC9AmFqAQbsZ+zTuh\n gJ0N0jzakBTKXX57gdFC+rcE+bG1fehX4BwQHJrboLrxMAtARkpIKjy44l7riC3X8i+n\n cmXg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=wdvnl/BT8EpxSM2u6kGkXFgWaAcTOrO0eZtHA1yV7g8=;\n b=fRN/jfiSUW7ARG7agnJrBClyLrALEz1i2b5FgAENF//0DGsCz1oD9Rsu4MFa1rbskI\n cWHzyltYGVkBaJLSEz+GgMiKjGdfgPsZCMRXkZOLxkjFJYmHdc2HBOK8AcPYkL+HFl1w\n EpCqPf1mq4R+L7kZaGtoShrtygZebWvl6/nqYAKwX39FpyKak0vOG/pSYa04sd6n8zHz\n dwxTgiRqfT+XdGIvOt4Z+/IpEjgWURwswb/zgPwuxtaFuRQmlcZXqmQ6u2XgaGbTTUDh\n d51RS/2iwwtgtvyNaTv7lK5cwl0irT8Rc08JL0iQXaeW6/bfF/hGAmuFZYJO9V+2Exj5\n VyQg==", "X-Gm-Message-State": "AOAM531k390MdhUizjnd0RGXPFaz2A6k8SGTcydioSTJVJEY7HFFwRMu\n TPtpn/GDJUsK8j/Gd79bQOTf25XA7p5JBQ==", "X-Google-Smtp-Source": "\n ABdhPJziAuEvGXdVRHgUbu6FA9zMlTIAxutUe436CB/ZaeMCgpxTGhGQl8v7cyNav3/RTtmHRIEbng==", "X-Received": "by 2002:a17:90a:73c4:: with SMTP id\n n4mr25581579pjk.201.1620438501965;\n Fri, 07 May 2021 18:48:21 -0700 (PDT)", "From": "Richard Henderson <richard.henderson@linaro.org>", "To": "qemu-devel@nongnu.org", "Subject": "[PATCH 28/72] softfloat: Move return_nan to softfloat-parts.c.inc", "Date": "Fri, 7 May 2021 18:47:18 -0700", "Message-Id": "<20210508014802.892561-29-richard.henderson@linaro.org>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210508014802.892561-1-richard.henderson@linaro.org>", "References": "<20210508014802.892561-1-richard.henderson@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::634;\n envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x634.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "alex.bennee@linaro.org, david@redhat.com", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "At the same time, convert to pointers, rename to return_nan$N\nand define a macro for return_nan using QEMU_GENERIC.\n\nSigned-off-by: Richard Henderson <richard.henderson@linaro.org>\n---\n fpu/softfloat.c | 45 ++++++++++++++++++++++-----------------\n fpu/softfloat-parts.c.inc | 37 ++++++++++++++++++++++++++++++++\n 2 files changed, 62 insertions(+), 20 deletions(-)\n create mode 100644 fpu/softfloat-parts.c.inc", "diff": "diff --git a/fpu/softfloat.c b/fpu/softfloat.c\nindex 6d5392aeab..5b26696078 100644\n--- a/fpu/softfloat.c\n+++ b/fpu/softfloat.c\n@@ -708,6 +708,10 @@ static float128 float128_pack_raw(const FloatParts128 *p)\n #define parts_default_nan(P, S) PARTS_GENERIC_64_128(default_nan, P)(P, S)\n #define parts_silence_nan(P, S) PARTS_GENERIC_64_128(silence_nan, P)(P, S)\n \n+static void parts64_return_nan(FloatParts64 *a, float_status *s);\n+static void parts128_return_nan(FloatParts128 *a, float_status *s);\n+\n+#define parts_return_nan(P, S) PARTS_GENERIC_64_128(return_nan, P)(P, S)\n \n /*\n * Helper functions for softfloat-parts.c.inc, per-size operations.\n@@ -914,22 +918,6 @@ static FloatParts64 round_canonical(FloatParts64 p, float_status *s,\n return p;\n }\n \n-static FloatParts64 return_nan(FloatParts64 a, float_status *s)\n-{\n- g_assert(is_nan(a.cls));\n- if (is_snan(a.cls)) {\n- float_raise(float_flag_invalid, s);\n- if (!s->default_nan_mode) {\n- parts_silence_nan(&a, s);\n- return a;\n- }\n- } else if (!s->default_nan_mode) {\n- return a;\n- }\n- parts_default_nan(&a, s);\n- return a;\n-}\n-\n static FloatParts64 pick_nan(FloatParts64 a, FloatParts64 b, float_status *s)\n {\n if (is_snan(a.cls) || is_snan(b.cls)) {\n@@ -991,6 +979,21 @@ static FloatParts64 pick_nan_muladd(FloatParts64 a, FloatParts64 b, FloatParts64\n return a;\n }\n \n+#define partsN(NAME) parts64_##NAME\n+#define FloatPartsN FloatParts64\n+\n+#include \"softfloat-parts.c.inc\"\n+\n+#undef partsN\n+#undef FloatPartsN\n+#define partsN(NAME) parts128_##NAME\n+#define FloatPartsN FloatParts128\n+\n+#include \"softfloat-parts.c.inc\"\n+\n+#undef partsN\n+#undef FloatPartsN\n+\n /*\n * Pack/unpack routines with a specific FloatFmt.\n */\n@@ -2065,7 +2068,7 @@ static FloatParts64 float_to_float(FloatParts64 a, const FloatFmt *dstf,\n break;\n }\n } else if (is_nan(a.cls)) {\n- return return_nan(a, s);\n+ parts_return_nan(&a, s);\n }\n return a;\n }\n@@ -2194,7 +2197,8 @@ static FloatParts64 round_to_int(FloatParts64 a, FloatRoundMode rmode,\n switch (a.cls) {\n case float_class_qnan:\n case float_class_snan:\n- return return_nan(a, s);\n+ parts_return_nan(&a, s);\n+ break;\n \n case float_class_zero:\n case float_class_inf:\n@@ -3590,7 +3594,7 @@ FloatRelation bfloat16_compare_quiet(bfloat16 a, bfloat16 b, float_status *s)\n static FloatParts64 scalbn_decomposed(FloatParts64 a, int n, float_status *s)\n {\n if (unlikely(is_nan(a.cls))) {\n- return return_nan(a, s);\n+ parts_return_nan(&a, s);\n }\n if (a.cls == float_class_normal) {\n /* The largest float type (even though not supported by FloatParts64)\n@@ -3658,7 +3662,8 @@ static FloatParts64 sqrt_float(FloatParts64 a, float_status *s, const FloatFmt *\n int bit, last_bit;\n \n if (is_nan(a.cls)) {\n- return return_nan(a, s);\n+ parts_return_nan(&a, s);\n+ return a;\n }\n if (a.cls == float_class_zero) {\n return a; /* sqrt(+-0) = +-0 */\ndiff --git a/fpu/softfloat-parts.c.inc b/fpu/softfloat-parts.c.inc\nnew file mode 100644\nindex 0000000000..2a3075d6fe\n--- /dev/null\n+++ b/fpu/softfloat-parts.c.inc\n@@ -0,0 +1,37 @@\n+/*\n+ * QEMU float support\n+ *\n+ * The code in this source file is derived from release 2a of the SoftFloat\n+ * IEC/IEEE Floating-point Arithmetic Package. Those parts of the code (and\n+ * some later contributions) are provided under that license, as detailed below.\n+ * It has subsequently been modified by contributors to the QEMU Project,\n+ * so some portions are provided under:\n+ * the SoftFloat-2a license\n+ * the BSD license\n+ * GPL-v2-or-later\n+ *\n+ * Any future contributions to this file after December 1st 2014 will be\n+ * taken to be licensed under the Softfloat-2a license unless specifically\n+ * indicated otherwise.\n+ */\n+\n+static void partsN(return_nan)(FloatPartsN *a, float_status *s)\n+{\n+ switch (a->cls) {\n+ case float_class_snan:\n+ float_raise(float_flag_invalid, s);\n+ if (s->default_nan_mode) {\n+ parts_default_nan(a, s);\n+ } else {\n+ parts_silence_nan(a, s);\n+ }\n+ break;\n+ case float_class_qnan:\n+ if (s->default_nan_mode) {\n+ parts_default_nan(a, s);\n+ }\n+ break;\n+ default:\n+ g_assert_not_reached();\n+ }\n+}\n", "prefixes": [ "28/72" ] }