Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1475729/?format=api
{ "id": 1475729, "url": "http://patchwork.ozlabs.org/api/patches/1475729/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20210508014802.892561-25-richard.henderson@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20210508014802.892561-25-richard.henderson@linaro.org>", "list_archive_url": null, "date": "2021-05-08T01:47:14", "name": "[24/72] softfloat: Use pointers with parts_silence_nan", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "e770d48be8f3dfff2acc0427ac0dcad939137e93", "submitter": { "id": 72104, "url": "http://patchwork.ozlabs.org/api/people/72104/?format=api", "name": "Richard Henderson", "email": "richard.henderson@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20210508014802.892561-25-richard.henderson@linaro.org/mbox/", "series": [ { "id": 242770, "url": "http://patchwork.ozlabs.org/api/series/242770/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=242770", "date": "2021-05-08T01:46:53", "name": "Convert floatx80 and float128 to FloatParts", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/242770/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1475729/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1475729/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=ZEzQ62fu;\n\tdkim-atps=neutral" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4FcW2120Btz9sWl\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 8 May 2021 12:08:25 +1000 (AEST)", "from localhost ([::1]:38744 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1lfCOF-0005Zk-Af\n\tfor incoming@patchwork.ozlabs.org; Fri, 07 May 2021 22:08:23 -0400", "from eggs.gnu.org ([2001:470:142:3::10]:40820)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1lfC53-0004GW-6r\n for qemu-devel@nongnu.org; Fri, 07 May 2021 21:48:35 -0400", "from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]:41898)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1lfC4r-0003dA-I6\n for qemu-devel@nongnu.org; Fri, 07 May 2021 21:48:32 -0400", "by mail-pl1-x635.google.com with SMTP id z18so2556712plg.8\n for <qemu-devel@nongnu.org>; Fri, 07 May 2021 18:48:20 -0700 (PDT)", "from localhost.localdomain ([71.212.144.24])\n by smtp.gmail.com with ESMTPSA id t4sm5819681pfq.165.2021.05.07.18.48.19\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 07 May 2021 18:48:19 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=7MJgtQMBS2ngXY709lmeRGrslyeOuJRTB/k5dCBY0b0=;\n b=ZEzQ62fuZL23i3KzUSjzVnFtRoMPgOLRz60W8vDr/iS/hpaEKguU9nNJbtqx7fos+j\n UakYvqmu3lgKRABCV3KAi8ie9klJvm0KW6lekdVZ97b+w+gFKDB/w2ztwMVbsty0Y1o1\n kapRnJcqpxNGUrHEY7IUYScIqtbrH1Bq4fM7KWMg4hCdISa8I7AFeyMxUdvg1TUE7Jej\n T2hZyhKHrQlf6NngHDQG+tZ+qmMO7f1WTntO50v1J4hwXR6N9GEGNHp58CcZ4PMtDP4Q\n /pvWJpVelHzh25NIcy+etZRJHOlm4DCwnRMLFhDfwSWGqUiDtKJNGhogQKSxVxO+KK20\n Pzrg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=7MJgtQMBS2ngXY709lmeRGrslyeOuJRTB/k5dCBY0b0=;\n b=BMQRvuV7VvUp4R9aaOmK6azY+5R+gBc0VZqCY+dqHe+DYWvFhgJ6KDYTOodan0K8FP\n v5wZPDogmfcB5Z38bKGeWRwan/Vut0FQ5d/ckhdgtMCW+VcWYg24d5Nc0fY8lDExuPj1\n Em1GNFtcDZgRqvi0plZr1pH/McCFnBXSqqEBhEVyXL1H1XSdx/wL8EP5sf+5ROPmg/+K\n +QHPdUM+1gR3rXfR8WV82AZ5eAN6iboH1oPVK/wN6ED6xZQeR5EQwl/EoQftMLZVZnJF\n AxbKDasdWD+I9aBNt47mjnThpP81EHTNU/k0VhBmPXdrp6U+jC1jYR+QMywUR/Tj15q7\n h2Kw==", "X-Gm-Message-State": "AOAM530tVDyHr+BvmDNumAyxfL6fMGq/TVrC14o8WOG/iUUFtBhEpzQf\n 1JMngnKJKW3zoccw3gfq4/7Uz9WKA6+pnQ==", "X-Google-Smtp-Source": "\n ABdhPJwEMXsPs+bVzMlQGYffoOm4wFYKsfeIBRI1e4BRHa/PWn6zRX8yQ1wd5sU5GUkZVhSLg4tzQA==", "X-Received": "by 2002:a17:90a:6289:: with SMTP id\n d9mr13725072pjj.84.1620438499617;\n Fri, 07 May 2021 18:48:19 -0700 (PDT)", "From": "Richard Henderson <richard.henderson@linaro.org>", "To": "qemu-devel@nongnu.org", "Subject": "[PATCH 24/72] softfloat: Use pointers with parts_silence_nan", "Date": "Fri, 7 May 2021 18:47:14 -0700", "Message-Id": "<20210508014802.892561-25-richard.henderson@linaro.org>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210508014802.892561-1-richard.henderson@linaro.org>", "References": "<20210508014802.892561-1-richard.henderson@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::635;\n envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x635.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "alex.bennee@linaro.org, david@redhat.com", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "At the same time, rename to parts64_silence_nan, split out\nparts_silence_nan_frac, and define a macro for parts_silence_nan.\n\nSigned-off-by: Richard Henderson <richard.henderson@linaro.org>\n---\n fpu/softfloat.c | 16 +++++++++-------\n fpu/softfloat-specialize.c.inc | 17 +++++++++++------\n 2 files changed, 20 insertions(+), 13 deletions(-)", "diff": "diff --git a/fpu/softfloat.c b/fpu/softfloat.c\nindex b0cbd5941c..2123453d40 100644\n--- a/fpu/softfloat.c\n+++ b/fpu/softfloat.c\n@@ -657,6 +657,7 @@ static inline float64 float64_pack_raw(const FloatParts64 *p)\n #include \"softfloat-specialize.c.inc\"\n \n #define parts_default_nan parts64_default_nan\n+#define parts_silence_nan parts64_silence_nan\n \n /* Canonicalize EXP and FRAC, setting CLS. */\n static FloatParts64 sf_canonicalize(FloatParts64 part, const FloatFmt *parm,\n@@ -851,7 +852,8 @@ static FloatParts64 return_nan(FloatParts64 a, float_status *s)\n if (is_snan(a.cls)) {\n float_raise(float_flag_invalid, s);\n if (!s->default_nan_mode) {\n- return parts_silence_nan(a, s);\n+ parts_silence_nan(&a, s);\n+ return a;\n }\n } else if (!s->default_nan_mode) {\n return a;\n@@ -875,7 +877,7 @@ static FloatParts64 pick_nan(FloatParts64 a, FloatParts64 b, float_status *s)\n a = b;\n }\n if (is_snan(a.cls)) {\n- return parts_silence_nan(a, s);\n+ parts_silence_nan(&a, s);\n }\n }\n return a;\n@@ -916,7 +918,7 @@ static FloatParts64 pick_nan_muladd(FloatParts64 a, FloatParts64 b, FloatParts64\n }\n \n if (is_snan(a.cls)) {\n- return parts_silence_nan(a, s);\n+ parts_silence_nan(&a, s);\n }\n return a;\n }\n@@ -3801,7 +3803,7 @@ float16 float16_silence_nan(float16 a, float_status *status)\n \n float16_unpack_raw(&p, a);\n p.frac <<= float16_params.frac_shift;\n- p = parts_silence_nan(p, status);\n+ parts_silence_nan(&p, status);\n p.frac >>= float16_params.frac_shift;\n return float16_pack_raw(&p);\n }\n@@ -3812,7 +3814,7 @@ float32 float32_silence_nan(float32 a, float_status *status)\n \n float32_unpack_raw(&p, a);\n p.frac <<= float32_params.frac_shift;\n- p = parts_silence_nan(p, status);\n+ parts_silence_nan(&p, status);\n p.frac >>= float32_params.frac_shift;\n return float32_pack_raw(&p);\n }\n@@ -3823,7 +3825,7 @@ float64 float64_silence_nan(float64 a, float_status *status)\n \n float64_unpack_raw(&p, a);\n p.frac <<= float64_params.frac_shift;\n- p = parts_silence_nan(p, status);\n+ parts_silence_nan(&p, status);\n p.frac >>= float64_params.frac_shift;\n return float64_pack_raw(&p);\n }\n@@ -3834,7 +3836,7 @@ bfloat16 bfloat16_silence_nan(bfloat16 a, float_status *status)\n \n bfloat16_unpack_raw(&p, a);\n p.frac <<= bfloat16_params.frac_shift;\n- p = parts_silence_nan(p, status);\n+ parts_silence_nan(&p, status);\n p.frac >>= bfloat16_params.frac_shift;\n return bfloat16_pack_raw(&p);\n }\ndiff --git a/fpu/softfloat-specialize.c.inc b/fpu/softfloat-specialize.c.inc\nindex 085ddea62b..2a1bc66633 100644\n--- a/fpu/softfloat-specialize.c.inc\n+++ b/fpu/softfloat-specialize.c.inc\n@@ -177,20 +177,25 @@ static void parts64_default_nan(FloatParts64 *p, float_status *status)\n | floating-point parts.\n *----------------------------------------------------------------------------*/\n \n-static FloatParts64 parts_silence_nan(FloatParts64 a, float_status *status)\n+static uint64_t parts_silence_nan_frac(uint64_t frac, float_status *status)\n {\n g_assert(!no_signaling_nans(status));\n g_assert(!status->default_nan_mode);\n \n /* The only snan_bit_is_one target without default_nan_mode is HPPA. */\n if (snan_bit_is_one(status)) {\n- a.frac &= ~(1ULL << (DECOMPOSED_BINARY_POINT - 1));\n- a.frac |= 1ULL << (DECOMPOSED_BINARY_POINT - 2);\n+ frac &= ~(1ULL << (DECOMPOSED_BINARY_POINT - 1));\n+ frac |= 1ULL << (DECOMPOSED_BINARY_POINT - 2);\n } else {\n- a.frac |= 1ULL << (DECOMPOSED_BINARY_POINT - 1);\n+ frac |= 1ULL << (DECOMPOSED_BINARY_POINT - 1);\n }\n- a.cls = float_class_qnan;\n- return a;\n+ return frac;\n+}\n+\n+static void parts64_silence_nan(FloatParts64 *p, float_status *status)\n+{\n+ p->frac = parts_silence_nan_frac(p->frac, status);\n+ p->cls = float_class_qnan;\n }\n \n /*----------------------------------------------------------------------------\n", "prefixes": [ "24/72" ] }