Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1475725/?format=api
{ "id": 1475725, "url": "http://patchwork.ozlabs.org/api/patches/1475725/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20210508014802.892561-20-richard.henderson@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20210508014802.892561-20-richard.henderson@linaro.org>", "list_archive_url": null, "date": "2021-05-08T01:47:09", "name": "[19/72] softfloat: Use pointers with ftype_unpack_raw", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "5825e52d7407eeb78e55c1e59c6bd82cb17342bb", "submitter": { "id": 72104, "url": "http://patchwork.ozlabs.org/api/people/72104/?format=api", "name": "Richard Henderson", "email": "richard.henderson@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20210508014802.892561-20-richard.henderson@linaro.org/mbox/", "series": [ { "id": 242770, "url": "http://patchwork.ozlabs.org/api/series/242770/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=242770", "date": "2021-05-08T01:46:53", "name": "Convert floatx80 and float128 to FloatParts", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/242770/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1475725/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1475725/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=Hn97pC6a;\n\tdkim-atps=neutral" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4FcVyj2vMrz9sWl\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 8 May 2021 12:05:33 +1000 (AEST)", "from localhost ([::1]:58072 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1lfCLN-000817-Kp\n\tfor incoming@patchwork.ozlabs.org; Fri, 07 May 2021 22:05:29 -0400", "from eggs.gnu.org ([2001:470:142:3::10]:40812)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1lfC52-0004GV-Jz\n for qemu-devel@nongnu.org; Fri, 07 May 2021 21:48:35 -0400", "from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]:40747)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1lfC4n-0003cY-Ft\n for qemu-devel@nongnu.org; Fri, 07 May 2021 21:48:32 -0400", "by mail-pf1-x435.google.com with SMTP id x188so9131405pfd.7\n for <qemu-devel@nongnu.org>; Fri, 07 May 2021 18:48:17 -0700 (PDT)", "from localhost.localdomain ([71.212.144.24])\n by smtp.gmail.com with ESMTPSA id t4sm5819681pfq.165.2021.05.07.18.48.15\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 07 May 2021 18:48:15 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=haSDSlpUM8p9DuI0N+XPpsqo4opBjSRscJfYOaISZlo=;\n b=Hn97pC6az92QTeC7SIiYnEaAq/kWBpSpfH4zW2HFs5JY/eZYzffvqp3t4mTVdhuWB3\n kG91RvByJhB8X1Aw7sola4oPanHqJAOGUjNaLd0wIwsgfKhIM50cY/wqj4Hk/Cr6lIlL\n xAKkHFByWo+W1Gsof1lUtLl1iEqlAtut5HKYvv2qfBhbh/jph+T++khh0Y+0FuEraWUH\n yUVen934zJAcgQMm4aVqtvGcE9gnFaLN3AJjAWARm/GyZU+S/Q2Zp8iXN7lq3cU5B0Mh\n 3Rpb35w15VzLvNAhIuhsbLdC3Fo3qKeS8lE76+BTlWxHwIHxR146nS8rXBlX9wHOUCOH\n LHUQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=haSDSlpUM8p9DuI0N+XPpsqo4opBjSRscJfYOaISZlo=;\n b=kGU+cWtvlzcGNH8BEOwzw6I1rcU/U6oV41Cj8DB53Fr7mcJmURpl7C88Z9MkE6HhuG\n /Y707SV6XVnIDURFf4R4SapgikETtxeUm6dFkMB/ESrtRPP5lKmkhWEwBESSmTA9tKOh\n /lE78HMvDH7bUV4SDnqmTUsJ/laI9Yo0g0jwCWpaRsi37jK63t1ZacA4Oue1cMoXGqQK\n 296TevAQOsM3wadyPtFKAcZGj9sCT5KJrao9yKTWe8wxdE6BGV8J+tMBSduEVqscXIif\n mVmvJotVILn5n6twRKGRdTFdIZjKLXgqM27cyw8QZ7glcZEE2NYdM2FGUTQjM3qqQTZa\n ph1w==", "X-Gm-Message-State": "AOAM5322KFya7dmQqAemKcYarm56e3Bv258B1qabr4K5AtAblD1a7LX4\n 9zDKvdJQW7FE3RiiaKsbe979O0jLzb1iZg==", "X-Google-Smtp-Source": "\n ABdhPJz6np9NSAlkX9KuQy+lqmKQ/YCdZeEX9VWovy5R0f2RO88OQ3jfXXri30jwS6lE2TeTuYg4wg==", "X-Received": "by 2002:a63:4e5c:: with SMTP id\n o28mr13298797pgl.380.1620438496132;\n Fri, 07 May 2021 18:48:16 -0700 (PDT)", "From": "Richard Henderson <richard.henderson@linaro.org>", "To": "qemu-devel@nongnu.org", "Subject": "[PATCH 19/72] softfloat: Use pointers with ftype_unpack_raw", "Date": "Fri, 7 May 2021 18:47:09 -0700", "Message-Id": "<20210508014802.892561-20-richard.henderson@linaro.org>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210508014802.892561-1-richard.henderson@linaro.org>", "References": "<20210508014802.892561-1-richard.henderson@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::435;\n envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x435.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "alex.bennee@linaro.org, david@redhat.com", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "Signed-off-by: Richard Henderson <richard.henderson@linaro.org>\n---\n fpu/softfloat.c | 76 +++++++++++++++++++++++++++++++------------------\n 1 file changed, 48 insertions(+), 28 deletions(-)", "diff": "diff --git a/fpu/softfloat.c b/fpu/softfloat.c\nindex 5ff9368012..5a736a46cf 100644\n--- a/fpu/softfloat.c\n+++ b/fpu/softfloat.c\n@@ -593,32 +593,24 @@ static void unpack_raw64(FloatParts64 *r, const FloatFmt *fmt, uint64_t raw)\n };\n }\n \n-static inline FloatParts64 float16_unpack_raw(float16 f)\n+static inline void float16_unpack_raw(FloatParts64 *p, float16 f)\n {\n- FloatParts64 p;\n- unpack_raw64(&p, &float16_params, f);\n- return p;\n+ unpack_raw64(p, &float16_params, f);\n }\n \n-static inline FloatParts64 bfloat16_unpack_raw(bfloat16 f)\n+static inline void bfloat16_unpack_raw(FloatParts64 *p, bfloat16 f)\n {\n- FloatParts64 p;\n- unpack_raw64(&p, &bfloat16_params, f);\n- return p;\n+ unpack_raw64(p, &bfloat16_params, f);\n }\n \n-static inline FloatParts64 float32_unpack_raw(float32 f)\n+static inline void float32_unpack_raw(FloatParts64 *p, float32 f)\n {\n- FloatParts64 p;\n- unpack_raw64(&p, &float32_params, f);\n- return p;\n+ unpack_raw64(p, &float32_params, f);\n }\n \n-static inline FloatParts64 float64_unpack_raw(float64 f)\n+static inline void float64_unpack_raw(FloatParts64 *p, float64 f)\n {\n- FloatParts64 p;\n- unpack_raw64(&p, &float64_params, f);\n- return p;\n+ unpack_raw64(p, &float64_params, f);\n }\n \n /* Pack a float from parts, but do not canonicalize. */\n@@ -931,7 +923,10 @@ static FloatParts64 pick_nan_muladd(FloatParts64 a, FloatParts64 b, FloatParts64\n static FloatParts64 float16a_unpack_canonical(float16 f, float_status *s,\n const FloatFmt *params)\n {\n- return sf_canonicalize(float16_unpack_raw(f), params, s);\n+ FloatParts64 p;\n+\n+ float16_unpack_raw(&p, f);\n+ return sf_canonicalize(p, params, s);\n }\n \n static FloatParts64 float16_unpack_canonical(float16 f, float_status *s)\n@@ -941,7 +936,10 @@ static FloatParts64 float16_unpack_canonical(float16 f, float_status *s)\n \n static FloatParts64 bfloat16_unpack_canonical(bfloat16 f, float_status *s)\n {\n- return sf_canonicalize(bfloat16_unpack_raw(f), &bfloat16_params, s);\n+ FloatParts64 p;\n+\n+ bfloat16_unpack_raw(&p, f);\n+ return sf_canonicalize(p, &bfloat16_params, s);\n }\n \n static float16 float16a_round_pack_canonical(FloatParts64 p, float_status *s,\n@@ -962,7 +960,10 @@ static bfloat16 bfloat16_round_pack_canonical(FloatParts64 p, float_status *s)\n \n static FloatParts64 float32_unpack_canonical(float32 f, float_status *s)\n {\n- return sf_canonicalize(float32_unpack_raw(f), &float32_params, s);\n+ FloatParts64 p;\n+\n+ float32_unpack_raw(&p, f);\n+ return sf_canonicalize(p, &float32_params, s);\n }\n \n static float32 float32_round_pack_canonical(FloatParts64 p, float_status *s)\n@@ -972,7 +973,10 @@ static float32 float32_round_pack_canonical(FloatParts64 p, float_status *s)\n \n static FloatParts64 float64_unpack_canonical(float64 f, float_status *s)\n {\n- return sf_canonicalize(float64_unpack_raw(f), &float64_params, s);\n+ FloatParts64 p;\n+\n+ float64_unpack_raw(&p, f);\n+ return sf_canonicalize(p, &float64_params, s);\n }\n \n static float64 float64_round_pack_canonical(FloatParts64 p, float_status *s)\n@@ -3648,7 +3652,9 @@ bfloat16 bfloat16_default_nan(float_status *status)\n \n float16 float16_silence_nan(float16 a, float_status *status)\n {\n- FloatParts64 p = float16_unpack_raw(a);\n+ FloatParts64 p;\n+\n+ float16_unpack_raw(&p, a);\n p.frac <<= float16_params.frac_shift;\n p = parts_silence_nan(p, status);\n p.frac >>= float16_params.frac_shift;\n@@ -3657,7 +3663,9 @@ float16 float16_silence_nan(float16 a, float_status *status)\n \n float32 float32_silence_nan(float32 a, float_status *status)\n {\n- FloatParts64 p = float32_unpack_raw(a);\n+ FloatParts64 p;\n+\n+ float32_unpack_raw(&p, a);\n p.frac <<= float32_params.frac_shift;\n p = parts_silence_nan(p, status);\n p.frac >>= float32_params.frac_shift;\n@@ -3666,7 +3674,9 @@ float32 float32_silence_nan(float32 a, float_status *status)\n \n float64 float64_silence_nan(float64 a, float_status *status)\n {\n- FloatParts64 p = float64_unpack_raw(a);\n+ FloatParts64 p;\n+\n+ float64_unpack_raw(&p, a);\n p.frac <<= float64_params.frac_shift;\n p = parts_silence_nan(p, status);\n p.frac >>= float64_params.frac_shift;\n@@ -3675,7 +3685,9 @@ float64 float64_silence_nan(float64 a, float_status *status)\n \n bfloat16 bfloat16_silence_nan(bfloat16 a, float_status *status)\n {\n- FloatParts64 p = bfloat16_unpack_raw(a);\n+ FloatParts64 p;\n+\n+ bfloat16_unpack_raw(&p, a);\n p.frac <<= bfloat16_params.frac_shift;\n p = parts_silence_nan(p, status);\n p.frac >>= bfloat16_params.frac_shift;\n@@ -3700,7 +3712,9 @@ static bool parts_squash_denormal(FloatParts64 p, float_status *status)\n float16 float16_squash_input_denormal(float16 a, float_status *status)\n {\n if (status->flush_inputs_to_zero) {\n- FloatParts64 p = float16_unpack_raw(a);\n+ FloatParts64 p;\n+\n+ float16_unpack_raw(&p, a);\n if (parts_squash_denormal(p, status)) {\n return float16_set_sign(float16_zero, p.sign);\n }\n@@ -3711,7 +3725,9 @@ float16 float16_squash_input_denormal(float16 a, float_status *status)\n float32 float32_squash_input_denormal(float32 a, float_status *status)\n {\n if (status->flush_inputs_to_zero) {\n- FloatParts64 p = float32_unpack_raw(a);\n+ FloatParts64 p;\n+\n+ float32_unpack_raw(&p, a);\n if (parts_squash_denormal(p, status)) {\n return float32_set_sign(float32_zero, p.sign);\n }\n@@ -3722,7 +3738,9 @@ float32 float32_squash_input_denormal(float32 a, float_status *status)\n float64 float64_squash_input_denormal(float64 a, float_status *status)\n {\n if (status->flush_inputs_to_zero) {\n- FloatParts64 p = float64_unpack_raw(a);\n+ FloatParts64 p;\n+\n+ float64_unpack_raw(&p, a);\n if (parts_squash_denormal(p, status)) {\n return float64_set_sign(float64_zero, p.sign);\n }\n@@ -3733,7 +3751,9 @@ float64 float64_squash_input_denormal(float64 a, float_status *status)\n bfloat16 bfloat16_squash_input_denormal(bfloat16 a, float_status *status)\n {\n if (status->flush_inputs_to_zero) {\n- FloatParts64 p = bfloat16_unpack_raw(a);\n+ FloatParts64 p;\n+\n+ bfloat16_unpack_raw(&p, a);\n if (parts_squash_denormal(p, status)) {\n return bfloat16_set_sign(bfloat16_zero, p.sign);\n }\n", "prefixes": [ "19/72" ] }