Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1475719/?format=api
{ "id": 1475719, "url": "http://patchwork.ozlabs.org/api/patches/1475719/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20210508014802.892561-13-richard.henderson@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20210508014802.892561-13-richard.henderson@linaro.org>", "list_archive_url": null, "date": "2021-05-08T01:47:02", "name": "[12/72] softfloat: fix return_nan vs default_nan_mode", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "9f488e38102bd550d96f9258c243079c934148d8", "submitter": { "id": 72104, "url": "http://patchwork.ozlabs.org/api/people/72104/?format=api", "name": "Richard Henderson", "email": "richard.henderson@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20210508014802.892561-13-richard.henderson@linaro.org/mbox/", "series": [ { "id": 242770, "url": "http://patchwork.ozlabs.org/api/series/242770/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=242770", "date": "2021-05-08T01:46:53", "name": "Convert floatx80 and float128 to FloatParts", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/242770/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1475719/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1475719/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=b73ETn1l;\n\tdkim-atps=neutral" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4FcVvr0qRQz9sWl\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 8 May 2021 12:03:04 +1000 (AEST)", "from localhost ([::1]:49316 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1lfCJ4-00021t-45\n\tfor incoming@patchwork.ozlabs.org; Fri, 07 May 2021 22:03:02 -0400", "from eggs.gnu.org ([2001:470:142:3::10]:40636)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1lfC4o-0004BJ-WC\n for qemu-devel@nongnu.org; Fri, 07 May 2021 21:48:22 -0400", "from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]:54055)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1lfC4i-0003Yq-Oa\n for qemu-devel@nongnu.org; Fri, 07 May 2021 21:48:18 -0400", "by mail-pj1-x102f.google.com with SMTP id p17so6206406pjz.3\n for <qemu-devel@nongnu.org>; Fri, 07 May 2021 18:48:12 -0700 (PDT)", "from localhost.localdomain ([71.212.144.24])\n by smtp.gmail.com with ESMTPSA id t4sm5819681pfq.165.2021.05.07.18.48.11\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 07 May 2021 18:48:11 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=ZkAPsJpFKYLwHKnqQJYxgfiNUgUoOxofSZa6fTNKj+E=;\n b=b73ETn1ljStaXoeH3oWYISHItx2sRYf/rAzjBU7RxjwJsWFc3O4g+GInCiFUHSdXFX\n zbEo6aO1xr7kzVmDp/1DSH56L0cIT2DKE1GbDzjk5Hq3LWizAc0XdrL9+lxzS/pZYG8w\n reuhKe5o8Z9NGj1XL4GVaEClMeaYcVOG5LLYQFQ1Gc+gjJ92eqNjkDtnEmB9dAFRUqaE\n EL2ZGieARAS5O4EdMqXVvVzQSjhQHo6IjZTfIRiHQgFecL2IMQcZR4vKphCBzy4qAB3r\n DkpbbHi+pn18A2uM+3dnMQB1GBvl0IirtWHyWBWyxGKe0PgWqCkEUCCqDoZATWrRTBFR\n nC8Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=ZkAPsJpFKYLwHKnqQJYxgfiNUgUoOxofSZa6fTNKj+E=;\n b=rFR+MGd8Ik9mPfIl7GYXmKL5WGN1R7wx5GTAkDNzB+5rARJytBwZODINH0nfwiizUc\n vEMLaBLtP9ZV/+hqXLCYgZ9PxgvmpPcsJIQYwQt5ANutc4BaZi0k85ebEuBUGzJHqxoI\n ds5VqUqsQQQDo/GIgwcscPphMZ6N17N+XxY68vO6JCT4lnkjKKpsfHVWCrDQ1YVPtCyH\n 7Km2amcYukrsJLFsrPAvhkMHdNENEVmIpb7PczgGqwRecHBuF0RFqCZ/tYfPRJKZDR3g\n dFv55GXG1FOWlIjJvPPEvVkOtAHFj5O6hWvqUBGjRiniG3lY8c62T8PW2ZxF/nAaLZ5f\n zLyw==", "X-Gm-Message-State": "AOAM530ZBry6/WwuX91fugxGG245yDzD/nXKeMD7xR80/19p3OkbNLjM\n vnDb8ZGD6V0MSDjoyZk4m6+X3RAurguB7w==", "X-Google-Smtp-Source": "\n ABdhPJzCGVz0PADwhRdlH3Yf+DOTCfeug1HfeZ2W9VKabxZ/x9XqBjTdRM6zzIb78M3YXtVfMQ+VpQ==", "X-Received": "by 2002:a17:90a:1c02:: with SMTP id\n s2mr13256859pjs.17.1620438491557;\n Fri, 07 May 2021 18:48:11 -0700 (PDT)", "From": "Richard Henderson <richard.henderson@linaro.org>", "To": "qemu-devel@nongnu.org", "Subject": "[PATCH 12/72] softfloat: fix return_nan vs default_nan_mode", "Date": "Fri, 7 May 2021 18:47:02 -0700", "Message-Id": "<20210508014802.892561-13-richard.henderson@linaro.org>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210508014802.892561-1-richard.henderson@linaro.org>", "References": "<20210508014802.892561-1-richard.henderson@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::102f;\n envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102f.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "alex.bennee@linaro.org, david@redhat.com", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "Do not call parts_silence_nan when default_nan_mode is in\neffect. This will avoid an assert in a later patch.\n\nSigned-off-by: Richard Henderson <richard.henderson@linaro.org>\n---\n fpu/softfloat.c | 19 +++++++------------\n 1 file changed, 7 insertions(+), 12 deletions(-)", "diff": "diff --git a/fpu/softfloat.c b/fpu/softfloat.c\nindex b694e38522..6589f00b23 100644\n--- a/fpu/softfloat.c\n+++ b/fpu/softfloat.c\n@@ -892,21 +892,16 @@ static float64 float64_round_pack_canonical(FloatParts p, float_status *s)\n \n static FloatParts return_nan(FloatParts a, float_status *s)\n {\n- switch (a.cls) {\n- case float_class_snan:\n+ g_assert(is_nan(a.cls));\n+ if (is_snan(a.cls)) {\n float_raise(float_flag_invalid, s);\n- a = parts_silence_nan(a, s);\n- /* fall through */\n- case float_class_qnan:\n- if (s->default_nan_mode) {\n- return parts_default_nan(s);\n+ if (!s->default_nan_mode) {\n+ return parts_silence_nan(a, s);\n }\n- break;\n-\n- default:\n- g_assert_not_reached();\n+ } else if (!s->default_nan_mode) {\n+ return a;\n }\n- return a;\n+ return parts_default_nan(s);\n }\n \n static FloatParts pick_nan(FloatParts a, FloatParts b, float_status *s)\n", "prefixes": [ "12/72" ] }