Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1475718/?format=api
{ "id": 1475718, "url": "http://patchwork.ozlabs.org/api/patches/1475718/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20210508014802.892561-31-richard.henderson@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20210508014802.892561-31-richard.henderson@linaro.org>", "list_archive_url": null, "date": "2021-05-08T01:47:20", "name": "[30/72] softfloat: Move pick_nan_muladd to softfloat-parts.c.inc", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "5696af87486a825947bb0c5633b4774074d4e5ff", "submitter": { "id": 72104, "url": "http://patchwork.ozlabs.org/api/people/72104/?format=api", "name": "Richard Henderson", "email": "richard.henderson@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20210508014802.892561-31-richard.henderson@linaro.org/mbox/", "series": [ { "id": 242770, "url": "http://patchwork.ozlabs.org/api/series/242770/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=242770", "date": "2021-05-08T01:46:53", "name": "Convert floatx80 and float128 to FloatParts", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/242770/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1475718/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1475718/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=W0aWBJ6h;\n\tdkim-atps=neutral" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4FcVrF6FZlz9sWp\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 8 May 2021 11:59:57 +1000 (AEST)", "from localhost ([::1]:44406 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1lfCG3-00076B-Pu\n\tfor incoming@patchwork.ozlabs.org; Fri, 07 May 2021 21:59:55 -0400", "from eggs.gnu.org ([2001:470:142:3::10]:40872)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1lfC57-0004Oo-80\n for qemu-devel@nongnu.org; Fri, 07 May 2021 21:48:37 -0400", "from mail-pg1-x52e.google.com ([2607:f8b0:4864:20::52e]:40851)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1lfC4u-0003eN-OR\n for qemu-devel@nongnu.org; Fri, 07 May 2021 21:48:36 -0400", "by mail-pg1-x52e.google.com with SMTP id j12so2566629pgh.7\n for <qemu-devel@nongnu.org>; Fri, 07 May 2021 18:48:24 -0700 (PDT)", "from localhost.localdomain ([71.212.144.24])\n by smtp.gmail.com with ESMTPSA id t4sm5819681pfq.165.2021.05.07.18.48.22\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 07 May 2021 18:48:22 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=ki4FuXvK7BJh92SU9AyENZ1CnGAywIA26sz/52XFR5g=;\n b=W0aWBJ6hx1o6EpJVP6o5BKN0s1DWl46OWhP+JKf74OoOtDFZJVAgJ8Kui630YRx04X\n w5saoQwqa8Gj/UqvgqfEmH4+xOxx2NKoiSNMxszk/z1T5MTt6B/irhZ30RNApvyrAPsO\n zbwQFP/DVlsc4Wu+kYBdL3SFgFg/D2e3a9/VxgvqIouDC9088hsiasq85SPKKbaUOmCB\n 86wpnIS9+FeK/eOGBeMtziW0PmyqPPetwWNDaGs1QZNOSF+KrKkqp7NiDVpTVDhnCqYN\n g+c/B32nulApwc1RpcD4kOxOHduBDpnNK2pMeXbSPvdIRC2wVdv9m6/nFFR5JjLGaVMM\n Z9Jw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=ki4FuXvK7BJh92SU9AyENZ1CnGAywIA26sz/52XFR5g=;\n b=cZ1wqxNM5SIigyyTiw9fotGuxLQzoflVRP5oE5Qm2wnqr2tEmxARaVDy86BjJiTaX9\n YwU47Eg8uGbT5apswu3hpoUfj5jwgrsopQq0Kj7StHk02Uqrd2S1kmuxOPOeMEcEbTOI\n 4HOhpWzpHGrDB7qMo8I1Xr0HK4wAOLBVXevl6BF0HTvauHR4Es8oelPlhflvZcyOyS33\n 47V04sqRz85a4j5r/WRllAWGuPOg5tsj3KWa/bJDb9R17oTwtAe6WqXfvFm5HHA+XBH1\n ijJzoNmC/aMVuHhlPdtjwe/G+faRPkr1l/hokXpse1Drt1gYjmm2M6JI6zBlosGFSXmh\n qSKw==", "X-Gm-Message-State": "AOAM5303SeCMEQgOl/yYODtGWNVpB2dhaQsj57BGxQysMg7EPUCtxW+u\n EnNrUqItpbC05GOkN7nPWbSrZrheWJ2VbA==", "X-Google-Smtp-Source": "\n ABdhPJx/KcRzMwVo/L9fRhfEqIfdKCc0JMcj1gacDegdUDJ76cYrCCFThMZDWlYjNH8r9zyZGEZJBw==", "X-Received": "by 2002:aa7:8d5a:0:b029:227:7b07:7d8b with SMTP id\n s26-20020aa78d5a0000b02902277b077d8bmr12918248pfe.26.1620438503234;\n Fri, 07 May 2021 18:48:23 -0700 (PDT)", "From": "Richard Henderson <richard.henderson@linaro.org>", "To": "qemu-devel@nongnu.org", "Subject": "[PATCH 30/72] softfloat: Move pick_nan_muladd to\n softfloat-parts.c.inc", "Date": "Fri, 7 May 2021 18:47:20 -0700", "Message-Id": "<20210508014802.892561-31-richard.henderson@linaro.org>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210508014802.892561-1-richard.henderson@linaro.org>", "References": "<20210508014802.892561-1-richard.henderson@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::52e;\n envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52e.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "alex.bennee@linaro.org, david@redhat.com", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "At the same time, convert to pointers, rename to pick_nan_muladd$N\nand define a macro for pick_nan_muladd using QEMU_GENERIC.\n\nSigned-off-by: Richard Henderson <richard.henderson@linaro.org>\n---\n fpu/softfloat.c | 53 ++++++++++-----------------------------\n fpu/softfloat-parts.c.inc | 40 +++++++++++++++++++++++++++++\n 2 files changed, 53 insertions(+), 40 deletions(-)", "diff": "diff --git a/fpu/softfloat.c b/fpu/softfloat.c\nindex 77efaedeaa..40ee294e35 100644\n--- a/fpu/softfloat.c\n+++ b/fpu/softfloat.c\n@@ -720,6 +720,18 @@ static FloatParts128 *parts128_pick_nan(FloatParts128 *a, FloatParts128 *b,\n \n #define parts_pick_nan(A, B, S) PARTS_GENERIC_64_128(pick_nan, A)(A, B, S)\n \n+static FloatParts64 *parts64_pick_nan_muladd(FloatParts64 *a, FloatParts64 *b,\n+ FloatParts64 *c, float_status *s,\n+ int ab_mask, int abc_mask);\n+static FloatParts128 *parts128_pick_nan_muladd(FloatParts128 *a,\n+ FloatParts128 *b,\n+ FloatParts128 *c,\n+ float_status *s,\n+ int ab_mask, int abc_mask);\n+\n+#define parts_pick_nan_muladd(A, B, C, S, ABM, ABCM) \\\n+ PARTS_GENERIC_64_128(pick_nan_muladd, A)(A, B, C, S, ABM, ABCM)\n+\n /*\n * Helper functions for softfloat-parts.c.inc, per-size operations.\n */\n@@ -947,45 +959,6 @@ static FloatParts64 round_canonical(FloatParts64 p, float_status *s,\n return p;\n }\n \n-static FloatParts64 pick_nan_muladd(FloatParts64 a, FloatParts64 b, FloatParts64 c,\n- bool inf_zero, float_status *s)\n-{\n- int which;\n-\n- if (is_snan(a.cls) || is_snan(b.cls) || is_snan(c.cls)) {\n- float_raise(float_flag_invalid, s);\n- }\n-\n- which = pickNaNMulAdd(a.cls, b.cls, c.cls, inf_zero, s);\n-\n- if (s->default_nan_mode) {\n- /* Note that this check is after pickNaNMulAdd so that function\n- * has an opportunity to set the Invalid flag.\n- */\n- which = 3;\n- }\n-\n- switch (which) {\n- case 0:\n- break;\n- case 1:\n- a = b;\n- break;\n- case 2:\n- a = c;\n- break;\n- case 3:\n- parts_default_nan(&a, s);\n- break;\n- default:\n- g_assert_not_reached();\n- }\n-\n- if (is_snan(a.cls)) {\n- parts_silence_nan(&a, s);\n- }\n- return a;\n-}\n \n #define partsN(NAME) parts64_##NAME\n #define FloatPartsN FloatParts64\n@@ -1496,7 +1469,7 @@ static FloatParts64 muladd_floats(FloatParts64 a, FloatParts64 b, FloatParts64 c\n * off to the target-specific pick-a-NaN routine.\n */\n if (unlikely(abc_mask & float_cmask_anynan)) {\n- return pick_nan_muladd(a, b, c, inf_zero, s);\n+ return *parts_pick_nan_muladd(&a, &b, &c, s, ab_mask, abc_mask);\n }\n \n if (inf_zero) {\ndiff --git a/fpu/softfloat-parts.c.inc b/fpu/softfloat-parts.c.inc\nindex 11a71650f7..a78d61ea07 100644\n--- a/fpu/softfloat-parts.c.inc\n+++ b/fpu/softfloat-parts.c.inc\n@@ -60,3 +60,43 @@ static FloatPartsN *partsN(pick_nan)(FloatPartsN *a, FloatPartsN *b,\n }\n return a;\n }\n+\n+static FloatPartsN *partsN(pick_nan_muladd)(FloatPartsN *a, FloatPartsN *b,\n+ FloatPartsN *c, float_status *s,\n+ int ab_mask, int abc_mask)\n+{\n+ int which;\n+\n+ if (unlikely(abc_mask & float_cmask_snan)) {\n+ float_raise(float_flag_invalid, s);\n+ }\n+\n+ which = pickNaNMulAdd(a->cls, b->cls, c->cls,\n+ ab_mask == float_cmask_infzero, s);\n+\n+ if (s->default_nan_mode || which == 3) {\n+ /*\n+ * Note that this check is after pickNaNMulAdd so that function\n+ * has an opportunity to set the Invalid flag for infzero.\n+ */\n+ parts_default_nan(a, s);\n+ return a;\n+ }\n+\n+ switch (which) {\n+ case 0:\n+ break;\n+ case 1:\n+ a = b;\n+ break;\n+ case 2:\n+ a = c;\n+ break;\n+ default:\n+ g_assert_not_reached();\n+ }\n+ if (is_snan(a->cls)) {\n+ parts_silence_nan(a, s);\n+ }\n+ return a;\n+}\n", "prefixes": [ "30/72" ] }