Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1475705/?format=api
{ "id": 1475705, "url": "http://patchwork.ozlabs.org/api/patches/1475705/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20210508014802.892561-11-richard.henderson@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20210508014802.892561-11-richard.henderson@linaro.org>", "list_archive_url": null, "date": "2021-05-08T01:47:00", "name": "[10/72] softfloat: Add float_cmask and constants", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "90be920a96892189fe8f5199b53c4eafbcac36eb", "submitter": { "id": 72104, "url": "http://patchwork.ozlabs.org/api/people/72104/?format=api", "name": "Richard Henderson", "email": "richard.henderson@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20210508014802.892561-11-richard.henderson@linaro.org/mbox/", "series": [ { "id": 242770, "url": "http://patchwork.ozlabs.org/api/series/242770/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=242770", "date": "2021-05-08T01:46:53", "name": "Convert floatx80 and float128 to FloatParts", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/242770/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1475705/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1475705/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=gshKE4ND;\n\tdkim-atps=neutral" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4FcVfp0WP8z9sV5\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 8 May 2021 11:51:46 +1000 (AEST)", "from localhost ([::1]:52142 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1lfC88-0001fJ-1l\n\tfor incoming@patchwork.ozlabs.org; Fri, 07 May 2021 21:51:44 -0400", "from eggs.gnu.org ([2001:470:142:3::10]:40582)\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1lfC4l-0004A5-Ff\n for qemu-devel@nongnu.org; Fri, 07 May 2021 21:48:15 -0400", "from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]:47063)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1lfC4h-0003YO-Lw\n for qemu-devel@nongnu.org; Fri, 07 May 2021 21:48:15 -0400", "by mail-pf1-x42b.google.com with SMTP id q2so9076801pfh.13\n for <qemu-devel@nongnu.org>; Fri, 07 May 2021 18:48:11 -0700 (PDT)", "from localhost.localdomain ([71.212.144.24])\n by smtp.gmail.com with ESMTPSA id t4sm5819681pfq.165.2021.05.07.18.48.09\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 07 May 2021 18:48:10 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=J2jECUv0KB/VRaKbNWjXBjsVAbH6ZqCf4a3f43XZat8=;\n b=gshKE4ND++11vkoO3VO4AgFOqNGFofzNHQ+eBPT5aS0Tly5wzIwj/xtgl218eHWG3w\n iCPH2HlwiE6pf2TRAmxJEZB6V01CkGtcbHrbACRt3dAyLVDPYkkIrcomLox08xtvgKZ9\n UNJ8k97EzzGJvCpR2LEk2fK7QTix/PB/mWTXkrGwOG8FV4BPXSGKNwOuMrgJwqeucEO7\n C10n33fv6kdrkt6UsvedUXGv1iREIOL8EeVSBrjbpWFF0ivoXCvY2aZtqCqhaUbn4GTc\n Z4m5hz17LEmaGg5QDRBYQt6W4xPJV8C1/aix2PAOxV5UCOA3d8m4MJ0gP6u1ZerJ2sD7\n 9TiA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=J2jECUv0KB/VRaKbNWjXBjsVAbH6ZqCf4a3f43XZat8=;\n b=pbu0/+miB81BzzOGdTEQmSBJCBDZTEoR5dHIxx3sW8Phcz2Zk7Hfki6FzuKQLBNlV3\n ipnn7TWqAx9eJIOXlUSYjkSz9aqK38CloXUuCBHYPdoSgEnnOWIvSmi8lycHQOg6Vp75\n yKynBjewhB3OlskHseoOIBC5rOW9mUnJLNVf2494AzocwGUl/B9baCr3bJ9KEaaL9Jab\n 1UTdXRbccMsxgs9tRdBZ6/cnNjmCZiDBGy3qMY1uzjUUN4TiXZfwdy4OuH4uKp3FSNIN\n 2W9CQdy/MkXK8tbDDnJ6S1wtf4SyqeLxjPXEerRLzSaxe1QK+jIi6UksDsnwI5Zo0hpz\n VDjQ==", "X-Gm-Message-State": "AOAM532Lm3Gi1qV+yFiWBedQ6Akm3ryZ9s8p33hxy/uvWM403fMvmSJ9\n 5PWEG7T2QpOW+PNmxYxmufwVfN4L+tPioA==", "X-Google-Smtp-Source": "\n ABdhPJzrtcUcTeDdVU2ejVDXo1x4ElrLBXC0xPgwebmBJovskIlprBBOEzS0UALaJXYY8RbhamTYFg==", "X-Received": "by 2002:a63:4c26:: with SMTP id\n z38mr13542949pga.415.1620438490406;\n Fri, 07 May 2021 18:48:10 -0700 (PDT)", "From": "Richard Henderson <richard.henderson@linaro.org>", "To": "qemu-devel@nongnu.org", "Subject": "[PATCH 10/72] softfloat: Add float_cmask and constants", "Date": "Fri, 7 May 2021 18:47:00 -0700", "Message-Id": "<20210508014802.892561-11-richard.henderson@linaro.org>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210508014802.892561-1-richard.henderson@linaro.org>", "References": "<20210508014802.892561-1-richard.henderson@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::42b;\n envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42b.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "alex.bennee@linaro.org, david@redhat.com", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "Testing more than one class at a time is better done with masks.\nThis reduces the static branch count.\n\nReviewed-by: Alex Bennée <alex.bennee@linaro.org>\nReviewed-by: David Hildenbrand <david@redhat.com>\nSigned-off-by: Richard Henderson <richard.henderson@linaro.org>\n---\n fpu/softfloat.c | 30 +++++++++++++++++++++++-------\n 1 file changed, 23 insertions(+), 7 deletions(-)", "diff": "diff --git a/fpu/softfloat.c b/fpu/softfloat.c\nindex ee4b5073b6..64edb23793 100644\n--- a/fpu/softfloat.c\n+++ b/fpu/softfloat.c\n@@ -469,6 +469,20 @@ typedef enum __attribute__ ((__packed__)) {\n float_class_snan,\n } FloatClass;\n \n+#define float_cmask(bit) (1u << (bit))\n+\n+enum {\n+ float_cmask_zero = float_cmask(float_class_zero),\n+ float_cmask_normal = float_cmask(float_class_normal),\n+ float_cmask_inf = float_cmask(float_class_inf),\n+ float_cmask_qnan = float_cmask(float_class_qnan),\n+ float_cmask_snan = float_cmask(float_class_snan),\n+\n+ float_cmask_infzero = float_cmask_zero | float_cmask_inf,\n+ float_cmask_anynan = float_cmask_qnan | float_cmask_snan,\n+};\n+\n+\n /* Simple helpers for checking if, or what kind of, NaN we have */\n static inline __attribute__((unused)) bool is_nan(FloatClass c)\n {\n@@ -1338,26 +1352,28 @@ bfloat16 QEMU_FLATTEN bfloat16_mul(bfloat16 a, bfloat16 b, float_status *status)\n static FloatParts muladd_floats(FloatParts a, FloatParts b, FloatParts c,\n int flags, float_status *s)\n {\n- bool inf_zero = ((1 << a.cls) | (1 << b.cls)) ==\n- ((1 << float_class_inf) | (1 << float_class_zero));\n- bool p_sign;\n+ bool inf_zero, p_sign;\n bool sign_flip = flags & float_muladd_negate_result;\n FloatClass p_class;\n uint64_t hi, lo;\n int p_exp;\n+ int ab_mask, abc_mask;\n+\n+ ab_mask = float_cmask(a.cls) | float_cmask(b.cls);\n+ abc_mask = float_cmask(c.cls) | ab_mask;\n+ inf_zero = ab_mask == float_cmask_infzero;\n \n /* It is implementation-defined whether the cases of (0,inf,qnan)\n * and (inf,0,qnan) raise InvalidOperation or not (and what QNaN\n * they return if they do), so we have to hand this information\n * off to the target-specific pick-a-NaN routine.\n */\n- if (is_nan(a.cls) || is_nan(b.cls) || is_nan(c.cls)) {\n+ if (unlikely(abc_mask & float_cmask_anynan)) {\n return pick_nan_muladd(a, b, c, inf_zero, s);\n }\n \n if (inf_zero) {\n float_raise(float_flag_invalid, s);\n- s->float_exception_flags |= float_flag_invalid;\n return parts_default_nan(s);\n }\n \n@@ -1371,9 +1387,9 @@ static FloatParts muladd_floats(FloatParts a, FloatParts b, FloatParts c,\n p_sign ^= 1;\n }\n \n- if (a.cls == float_class_inf || b.cls == float_class_inf) {\n+ if (ab_mask & float_cmask_inf) {\n p_class = float_class_inf;\n- } else if (a.cls == float_class_zero || b.cls == float_class_zero) {\n+ } else if (ab_mask & float_cmask_zero) {\n p_class = float_class_zero;\n } else {\n p_class = float_class_normal;\n", "prefixes": [ "10/72" ] }