Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1466842/?format=api
{ "id": 1466842, "url": "http://patchwork.ozlabs.org/api/patches/1466842/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20210416040924.2882771-9-danielwa@cisco.com/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<20210416040924.2882771-9-danielwa@cisco.com>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/20210416040924.2882771-9-danielwa@cisco.com/", "date": "2021-04-16T04:09:19", "name": "[8/8] CMDLINE: arm64: convert to generic builtin command line", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "ba81162fb11c17817d8e13b306a42dc2a597746d", "submitter": { "id": 67374, "url": "http://patchwork.ozlabs.org/api/people/67374/?format=api", "name": "Daniel Walker (danielwa)", "email": "danielwa@cisco.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20210416040924.2882771-9-danielwa@cisco.com/mbox/", "series": [ { "id": 239425, "url": "http://patchwork.ozlabs.org/api/series/239425/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=239425", "date": "2021-04-16T04:09:11", "name": "generic command line v4", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/239425/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1466842/comments/", "check": "warning", "checks": "http://patchwork.ozlabs.org/api/patches/1466842/checks/", "tags": {}, "related": [ { "id": 1460189, "url": "http://patchwork.ozlabs.org/api/patches/1460189/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/be8847438abbfa4972dd792eb616973816af9290.1617126961.git.danielwa@cisco.com/", "msgid": "<be8847438abbfa4972dd792eb616973816af9290.1617126961.git.danielwa@cisco.com>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/be8847438abbfa4972dd792eb616973816af9290.1617126961.git.danielwa@cisco.com/", "date": "2021-03-30T17:57:03", "name": "[8/8] CMDLINE: arm64: convert to generic builtin command line", "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/be8847438abbfa4972dd792eb616973816af9290.1617126961.git.danielwa@cisco.com/mbox/" } ], "headers": { "Return-Path": "\n <linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org;\n receiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=cisco.com header.i=@cisco.com header.a=rsa-sha256\n header.s=iport header.b=Ed7SYlCI;\n\tdkim-atps=neutral", "lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=cisco.com header.i=@cisco.com header.a=rsa-sha256\n header.s=iport header.b=Ed7SYlCI;\n\tdkim-atps=neutral", "lists.ozlabs.org; spf=pass (sender SPF authorized)\n smtp.mailfrom=cisco.com (client-ip=173.37.86.75; helo=rcdn-iport-4.cisco.com;\n envelope-from=danielwa@cisco.com; receiver=<UNKNOWN>)", "lists.ozlabs.org; dkim=pass (1024-bit key;\n unprotected) header.d=cisco.com header.i=@cisco.com header.a=rsa-sha256\n header.s=iport header.b=Ed7SYlCI; dkim-atps=neutral" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4FM2rZ6pYhz9sVv\n\tfor <patchwork-incoming@ozlabs.org>; Fri, 16 Apr 2021 14:13:34 +1000 (AEST)", "from boromir.ozlabs.org (localhost [IPv6:::1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4FM2rZ54jbz3dXt\n\tfor <patchwork-incoming@ozlabs.org>; Fri, 16 Apr 2021 14:13:34 +1000 (AEST)", "from rcdn-iport-4.cisco.com (rcdn-iport-4.cisco.com [173.37.86.75])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n bits)) (No client certificate requested)\n by lists.ozlabs.org (Postfix) with ESMTPS id 4FM2mC1RR2z3btV\n for <linuxppc-dev@lists.ozlabs.org>; Fri, 16 Apr 2021 14:09:46 +1000 (AEST)", "from alln-core-6.cisco.com ([173.36.13.139])\n by rcdn-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA;\n 16 Apr 2021 04:09:41 +0000", "from zorba.cisco.com ([10.24.7.67])\n by alln-core-6.cisco.com (8.15.2/8.15.2) with ESMTP id 13G49OHn016753;\n Fri, 16 Apr 2021 04:09:40 GMT" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=cisco.com; i=@cisco.com; l=3563; q=dns/txt; s=iport;\n t=1618546187; x=1619755787;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=GO4wmk8aV0OUxVhW9VMyBb9l4wFj18+YTePQSCcYNiM=;\n b=Ed7SYlCIalp8fHnSDtzO7GLNpGxKpF7ENpDQWO0vPsCNpoeUpghQnSJm\n aoMMjqpSb5nLQXpKaiM5a8+J63We3k3HwawUl3G4te7OKrn95EojRV5LI\n wfvZdjTaWNq95HV8rQ5vigM24Dmr2j2rX1HCenpesp5PWqB8J1yMPoyj8 I=;", "IronPort-HdrOrdr": "\n A9a23:IILAOaPeW6nIHMBcT5z155DYdL4zR+YMi2QD/UoZc3BoW+afkN2jm+le6AT9jywfVGpltdeLPqSBRn20z+8Q3aA9NaqvNTOJhEKGN4dnhLGJ/xTBHGnE+vdZxeNcdcFFeb7NJHxbqeq/3wWiCdYnx7C8gcWVrMPT1W1kQw0vS6wI1WZEIz2WGEF3WwVKbKBRfPGhz/FKqDa6dXMcYt7TPAhmY8H4u9bJmJj6CCRoOzcb7mC14A+A2frTDwWfmiwTSSpIxq0vtVLYihXj6r+42svLrSP05iv255RSlMCJ8Lt+Lf3JrNQJITPxjQvtQ4JtV9S5zUkIidDqzko2m9/RpBplBeBP0jf6e2G4pgaF4XiH7AoT", "X-IronPort-Anti-Spam-Filtered": "true", "X-IronPort-Anti-Spam-Result": "\n A0BMAAAiDXlg/4sNJK1aHAEBAQEBAQcBARIBAQQEAQGBfgcBAQsBAYIpgU0BOTGMZ6Q7gXwLAQEBDzQEAQGEUAKBcwIlNAkOAgMBAQwBAQUBAQECAQYEcROFXUMWAYVrBjIBRhBRVwYBEoJxgwisCIIrgQGIM4FEFIElAYhrdIN1JxyBSUKEc4o5BIJGAYEPggRskQQEjVOcLYMWgSabUQ8jpHyVGJ5YhQqBVDqBWTMaCBsVgyRQGQ6OKxaNawFbIQMvOAIGCgEBAwmJToNAAQE", "X-IronPort-AV": "E=Sophos;i=\"5.82,226,1613433600\"; d=\"scan'208\";a=\"861122364\"", "From": "Daniel Walker <danielwa@cisco.com>", "To": "Will Deacon <will@kernel.org>,\n Christophe Leroy <christophe.leroy@csgroup.eu>,\n Rob Herring <robh@kernel.org>,\n Daniel Gimpelevich <daniel@gimpelevich.san-francisco.ca.us>,\n Andrew Morton <akpm@linux-foundation.org>, x86@kernel.org,\n linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,\n Catalin Marinas <catalin.marinas@arm.com>", "Subject": "[PATCH 8/8] CMDLINE: arm64: convert to generic builtin command line", "Date": "Thu, 15 Apr 2021 21:09:19 -0700", "Message-Id": "<20210416040924.2882771-9-danielwa@cisco.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210416040924.2882771-1-danielwa@cisco.com>", "References": "<20210416040924.2882771-1-danielwa@cisco.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Auto-Response-Suppress": "DR, OOF, AutoReply", "X-Outbound-SMTP-Client": "10.24.7.67, [10.24.7.67]", "X-Outbound-Node": "alln-core-6.cisco.com", "X-BeenThere": "linuxppc-dev@lists.ozlabs.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Linux on PowerPC Developers Mail List <linuxppc-dev.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/linuxppc-dev>,\n <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>", "Cc": "linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n xe-linux-external@cisco.com", "Errors-To": "linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org", "Sender": "\"Linuxppc-dev\"\n <linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>" }, "content": "This removes arm64 from the device tree handling of the\ncommand line arguments.\n\nThe boot_command_line variable is populated inside the earliest\nuser of the command line, which is in idreg-override.c.\n\nThe device tree should not be needed to do any further handling\nof the boot command line options.\n\nCc: xe-linux-external@cisco.com\nSigned-off-by: Daniel Walker <danielwa@cisco.com>\n---\n arch/arm64/Kconfig | 33 +-----------------------------\n arch/arm64/include/asm/setup.h | 2 ++\n arch/arm64/kernel/idreg-override.c | 9 ++++----\n 3 files changed, 8 insertions(+), 36 deletions(-)", "diff": "diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig\nindex e4e1b6550115..9781ba3758b1 100644\n--- a/arch/arm64/Kconfig\n+++ b/arch/arm64/Kconfig\n@@ -105,6 +105,7 @@ config ARM64\n \tselect GENERIC_ALLOCATOR\n \tselect GENERIC_ARCH_TOPOLOGY\n \tselect GENERIC_CLOCKEVENTS_BROADCAST\n+\tselect GENERIC_CMDLINE\n \tselect GENERIC_CPU_AUTOPROBE\n \tselect GENERIC_CPU_VULNERABILITIES\n \tselect GENERIC_EARLY_IOREMAP\n@@ -1841,38 +1842,6 @@ config ARM64_ACPI_PARKING_PROTOCOL\n \t protocol even if the corresponding data is present in the ACPI\n \t MADT table.\n \n-config CMDLINE\n-\tstring \"Default kernel command string\"\n-\tdefault \"\"\n-\thelp\n-\t Provide a set of default command-line options at build time by\n-\t entering them here. As a minimum, you should specify the the\n-\t root device (e.g. root=/dev/nfs).\n-\n-choice\n-\tprompt \"Kernel command line type\" if CMDLINE != \"\"\n-\tdefault CMDLINE_FROM_BOOTLOADER\n-\thelp\n-\t Choose how the kernel will handle the provided default kernel\n-\t command line string.\n-\n-config CMDLINE_FROM_BOOTLOADER\n-\tbool \"Use bootloader kernel arguments if available\"\n-\thelp\n-\t Uses the command-line options passed by the boot loader. If\n-\t the boot loader doesn't provide any, the default kernel command\n-\t string provided in CMDLINE will be used.\n-\n-config CMDLINE_FORCE\n-\tbool \"Always use the default kernel command string\"\n-\thelp\n-\t Always use the default kernel command string, even if the boot\n-\t loader passes other arguments to the kernel.\n-\t This is useful if you cannot or don't want to change the\n-\t command-line options your boot loader passes to the kernel.\n-\n-endchoice\n-\n config EFI_STUB\n \tbool\n \ndiff --git a/arch/arm64/include/asm/setup.h b/arch/arm64/include/asm/setup.h\nindex d3320618ed14..1f5b6d8f2433 100644\n--- a/arch/arm64/include/asm/setup.h\n+++ b/arch/arm64/include/asm/setup.h\n@@ -5,7 +5,9 @@\n \n #include <uapi/asm/setup.h>\n \n+#ifndef __ASSEMBLY__\n void *get_early_fdt_ptr(void);\n void early_fdt_map(u64 dt_phys);\n+#endif /* __ASSEMBLY__ */\n \n #endif\ndiff --git a/arch/arm64/kernel/idreg-override.c b/arch/arm64/kernel/idreg-override.c\nindex 83f1c4b92095..0a3fcae13043 100644\n--- a/arch/arm64/kernel/idreg-override.c\n+++ b/arch/arm64/kernel/idreg-override.c\n@@ -9,6 +9,7 @@\n #include <linux/ctype.h>\n #include <linux/kernel.h>\n #include <linux/libfdt.h>\n+#include <linux/cmdline.h>\n \n #include <asm/cacheflush.h>\n #include <asm/cpufeature.h>\n@@ -188,11 +189,11 @@ static __init void parse_cmdline(void)\n {\n \tconst u8 *prop = get_bootargs_cmdline();\n \n-\tif (IS_ENABLED(CONFIG_CMDLINE_FORCE) || !prop)\n-\t\t__parse_cmdline(CONFIG_CMDLINE, true);\n+\tstrscpy(boot_command_line, prop, COMMAND_LINE_SIZE);\n+\tcmdline_add_builtin(boot_command_line);\n+\n+\t__parse_cmdline(boot_command_line, true);\n \n-\tif (!IS_ENABLED(CONFIG_CMDLINE_FORCE) && prop)\n-\t\t__parse_cmdline(prop, true);\n }\n \n /* Keep checkers quiet */\n", "prefixes": [ "8/8" ] }