Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1461758/?format=api
{ "id": 1461758, "url": "http://patchwork.ozlabs.org/api/patches/1461758/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/68db4e57bb88c523f76dcae12feafbb0cae1a85d.1617375802.git.christophe.leroy@csgroup.eu/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<68db4e57bb88c523f76dcae12feafbb0cae1a85d.1617375802.git.christophe.leroy@csgroup.eu>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/68db4e57bb88c523f76dcae12feafbb0cae1a85d.1617375802.git.christophe.leroy@csgroup.eu/", "date": "2021-04-02T15:18:02", "name": "[v4,01/20] cmdline: Add generic function to build command line.", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "65e54b06d7768901632b2252932883dec4ded411", "submitter": { "id": 79086, "url": "http://patchwork.ozlabs.org/api/people/79086/?format=api", "name": "Christophe Leroy", "email": "christophe.leroy@csgroup.eu" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/68db4e57bb88c523f76dcae12feafbb0cae1a85d.1617375802.git.christophe.leroy@csgroup.eu/mbox/", "series": [ { "id": 237158, "url": "http://patchwork.ozlabs.org/api/series/237158/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=237158", "date": "2021-04-02T15:18:03", "name": "Implement GENERIC_CMDLINE", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/237158/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1461758/comments/", "check": "success", "checks": "http://patchwork.ozlabs.org/api/patches/1461758/checks/", "tags": {}, "related": [ { "id": 1458780, "url": "http://patchwork.ozlabs.org/api/patches/1458780/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/878228ad88df38f8914c7aa25dede3ed05c50f48.1616765869.git.christophe.leroy@csgroup.eu/", "msgid": "<878228ad88df38f8914c7aa25dede3ed05c50f48.1616765869.git.christophe.leroy@csgroup.eu>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/878228ad88df38f8914c7aa25dede3ed05c50f48.1616765869.git.christophe.leroy@csgroup.eu/", "date": "2021-03-26T13:44:48", "name": "[v3,01/17] cmdline: Add generic function to build command line.", "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/878228ad88df38f8914c7aa25dede3ed05c50f48.1616765869.git.christophe.leroy@csgroup.eu/mbox/" } ], "headers": { "Return-Path": "\n <linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org;\n receiver=<UNKNOWN>)", "lists.ozlabs.org; spf=pass (sender SPF authorized)\n smtp.mailfrom=csgroup.eu (client-ip=93.17.236.30; helo=pegase1.c-s.fr;\n envelope-from=christophe.leroy@csgroup.eu; receiver=<UNKNOWN>)" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4FBkHg4M60z9sXL\n\tfor <patchwork-incoming@ozlabs.org>; Sat, 3 Apr 2021 02:19:43 +1100 (AEDT)", "from boromir.ozlabs.org (localhost [IPv6:::1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4FBkHg3GSBz3cmw\n\tfor <patchwork-incoming@ozlabs.org>; Sat, 3 Apr 2021 02:19:43 +1100 (AEDT)", "from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by lists.ozlabs.org (Postfix) with ESMTPS id 4FBkFv064gz3brb\n for <linuxppc-dev@lists.ozlabs.org>; Sat, 3 Apr 2021 02:18:08 +1100 (AEDT)", "from localhost (mailhub1-int [192.168.12.234])\n by localhost (Postfix) with ESMTP id 4FBkFj2vNPz9v2lt;\n Fri, 2 Apr 2021 17:18:01 +0200 (CEST)", "from pegase1.c-s.fr ([192.168.12.234])\n by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024)\n with ESMTP id NJ34BehnDmHj; Fri, 2 Apr 2021 17:18:01 +0200 (CEST)", "from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192])\n by pegase1.c-s.fr (Postfix) with ESMTP id 4FBkFj1ndyz9v2ls;\n Fri, 2 Apr 2021 17:18:01 +0200 (CEST)", "from localhost (localhost [127.0.0.1])\n by messagerie.si.c-s.fr (Postfix) with ESMTP id 2774B8BB7C;\n Fri, 2 Apr 2021 17:18:03 +0200 (CEST)", "from messagerie.si.c-s.fr ([127.0.0.1])\n by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023)\n with ESMTP id wc8EW3tptikR; Fri, 2 Apr 2021 17:18:03 +0200 (CEST)", "from po16121vm.idsi0.si.c-s.fr (unknown [192.168.4.90])\n by messagerie.si.c-s.fr (Postfix) with ESMTP id 99C3C8BB7B;\n Fri, 2 Apr 2021 17:18:02 +0200 (CEST)", "by po16121vm.idsi0.si.c-s.fr (Postfix, from userid 0)\n id 701DA67989; Fri, 2 Apr 2021 15:18:02 +0000 (UTC)" ], "X-Virus-Scanned": [ "Debian amavisd-new at c-s.fr", "amavisd-new at c-s.fr" ], "Message-Id": "\n <68db4e57bb88c523f76dcae12feafbb0cae1a85d.1617375802.git.christophe.leroy@csgroup.eu>", "In-Reply-To": "<cover.1617375802.git.christophe.leroy@csgroup.eu>", "References": "<cover.1617375802.git.christophe.leroy@csgroup.eu>", "From": "Christophe Leroy <christophe.leroy@csgroup.eu>", "Subject": "[PATCH v4 01/20] cmdline: Add generic function to build command line.", "To": "will@kernel.org, danielwa@cisco.com, robh@kernel.org,\n daniel@gimpelevich.san-francisco.ca.us, arnd@kernel.org,\n akpm@linux-foundation.org", "Date": "Fri, 2 Apr 2021 15:18:02 +0000 (UTC)", "X-BeenThere": "linuxppc-dev@lists.ozlabs.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Linux on PowerPC Developers Mail List <linuxppc-dev.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/linuxppc-dev>,\n <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>", "Cc": "linux-arch@vger.kernel.org, devicetree@vger.kernel.org,\n microblaze <monstr@monstr.eu>, linux-xtensa@linux-xtensa.org,\n linux-sh@vger.kernel.org, linux-hexagon@vger.kernel.org, x86@kernel.org,\n linux-kernel@vger.kernel.org, nios2 <ley.foon.tan@intel.com>,\n linux-mips@vger.kernel.org, linux-mm@kvack.org,\n openrisc@lists.librecores.org,\n sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org,\n linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org", "Errors-To": "linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org", "Sender": "\"Linuxppc-dev\"\n <linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>" }, "content": "This code provides architectures with a way to build command line\nbased on what is built in the kernel and what is handed over by the\nbootloader, based on selected compile-time options.\n\nSigned-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>\n---\nv3:\n- Addressed comments from Will\n- Added capability to have src == dst\nv4:\n- Add cmdline_strlcpy()\n- Removed cmdline_build() macro, __cmdline_build() becomes cmdline_build()\n- Fixed the destination length to COMMAND_LINE_SIZE\n- Truncate at a space not in a quote when too long\n- Added a message when forcing the command line\n---\n include/linux/cmdline.h | 79 +++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 79 insertions(+)\n create mode 100644 include/linux/cmdline.h", "diff": "diff --git a/include/linux/cmdline.h b/include/linux/cmdline.h\nnew file mode 100644\nindex 000000000000..a0773dc365c7\n--- /dev/null\n+++ b/include/linux/cmdline.h\n@@ -0,0 +1,79 @@\n+/* SPDX-License-Identifier: GPL-2.0 */\n+#ifndef _LINUX_CMDLINE_H\n+#define _LINUX_CMDLINE_H\n+\n+#include <linux/string.h>\n+#include <linux/printk.h>\n+#include <asm/setup.h>\n+\n+/* Allow users to override strlcat/strlcpy, powerpc can't use strings so early*/\n+#ifndef cmdline_strlcat\n+#define cmdline_strlcat strlcat\n+#define cmdline_strlcpy strlcpy\n+#endif\n+\n+/*\n+ * This function will append or prepend a builtin command line to the command\n+ * line provided by the bootloader. Kconfig options can be used to alter\n+ * the behavior of this builtin command line.\n+ * @dst: The destination of the final command line (Min. size COMMAND_LINE_SIZE)\n+ * @src: The starting string or NULL if there isn't one. Must not equal dst.\n+ * Returns: false if the string was truncated, true otherwise\n+ */\n+static __always_inline bool __cmdline_build(char *dst, const char *src)\n+{\n+\tint len;\n+\tchar *ptr, *last_space;\n+\tbool in_quote = false;\n+\n+\tif (IS_ENABLED(CONFIG_CMDLINE_FORCE))\n+\t\tsrc = NULL;\n+\n+\tdst[0] = 0;\n+\n+\tif (IS_ENABLED(CONFIG_CMDLINE_PREPEND))\n+\t\tlen = cmdline_strlcat(dst, CONFIG_CMDLINE \" \", COMMAND_LINE_SIZE);\n+\n+\tlen = cmdline_strlcat(dst, src, COMMAND_LINE_SIZE);\n+\n+\tif (IS_ENABLED(CONFIG_CMDLINE_EXTEND))\n+\t\tlen = cmdline_strlcat(dst, \" \" CONFIG_CMDLINE, COMMAND_LINE_SIZE);\n+\n+\tif (len < COMMAND_LINE_SIZE - 1)\n+\t\treturn true;\n+\n+\tfor (ptr = dst; *ptr; ptr++) {\n+\t\tif (*ptr == '\"')\n+\t\t\tin_quote = !in_quote;\n+\t\tif (*ptr == ' ' && !in_quote)\n+\t\t\tlast_space = ptr;\n+\t}\n+\tif (last_space)\n+\t\t*last_space = 0;\n+\n+\treturn false;\n+}\n+\n+/*\n+ * This function will append or prepend a builtin command line to the command\n+ * line provided by the bootloader. Kconfig options can be used to alter\n+ * the behavior of this builtin command line.\n+ * @dst: The destination of the final command line (Min. size COMMAND_LINE_SIZE)\n+ * @src: The starting string or NULL if there isn't one.\n+ */\n+static __always_inline void cmdline_build(char *dst, const char *src)\n+{\n+\tstatic char tmp[COMMAND_LINE_SIZE] __initdata;\n+\n+\tif (src == dst) {\n+\t\tcmdline_strlcpy(tmp, src, COMMAND_LINE_SIZE);\n+\t\tsrc = tmp;\n+\t}\n+\tif (!__cmdline_build(dst, src))\n+\t\tpr_warn(\"Command line is too long, it has been truncated\\n\");\n+\n+\tif (IS_ENABLED(CONFIG_CMDLINE_FORCE))\n+\t\tpr_info(\"Forcing kernel command line to: %s\\n\", dst);\n+}\n+\n+#endif /* _LINUX_CMDLINE_H */\n", "prefixes": [ "v4", "01/20" ] }