Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1453610/?format=api
{ "id": 1453610, "url": "http://patchwork.ozlabs.org/api/patches/1453610/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-um/patch/20210315234731.2e03184a344b.I04f1816296f04c5aa7d7d88b33bd4a14dd458da8@changeid/", "project": { "id": 60, "url": "http://patchwork.ozlabs.org/api/projects/60/?format=api", "name": "User-mode Linux Development", "link_name": "linux-um", "list_id": "linux-um.lists.infradead.org", "list_email": "linux-um@lists.infradead.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20210315234731.2e03184a344b.I04f1816296f04c5aa7d7d88b33bd4a14dd458da8@changeid>", "list_archive_url": null, "date": "2021-03-15T22:47:31", "name": "um: disable CONFIG_GCOV with MODULES", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "83d8e422880332172c87dff8cc79087456a070d9", "submitter": { "id": 265, "url": "http://patchwork.ozlabs.org/api/people/265/?format=api", "name": "Johannes Berg", "email": "johannes@sipsolutions.net" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-um/patch/20210315234731.2e03184a344b.I04f1816296f04c5aa7d7d88b33bd4a14dd458da8@changeid/mbox/", "series": [ { "id": 234180, "url": "http://patchwork.ozlabs.org/api/series/234180/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-um/list/?series=234180", "date": "2021-03-15T22:47:31", "name": "um: disable CONFIG_GCOV with MODULES", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/234180/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1453610/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1453610/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2001:8b0:10b:1:d65d:64ff:fe57:4e05; helo=desiato.infradead.org;\n envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=desiato.20200630 header.b=MXskyxgI;\n\tdkim-atps=neutral" ], "Received": [ "from desiato.infradead.org (desiato.infradead.org\n [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4Dzs5B4l7Mz9sRR\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 16 Mar 2021 09:47:58 +1100 (AEDT)", "from localhost ([::1] helo=desiato.infradead.org)\n\tby desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux))\n\tid 1lLw02-00H3DG-WA; Mon, 15 Mar 2021 22:47:47 +0000", "from s3.sipsolutions.net ([2a01:4f8:191:4433::2]\n helo=sipsolutions.net)\n by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux))\n id 1lLvzs-00H3Bn-E0\n for linux-um@lists.infradead.org; Mon, 15 Mar 2021 22:47:39 +0000", "by sipsolutions.net with esmtpsa\n (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)\n (Exim 4.94) (envelope-from <johannes@sipsolutions.net>)\n id 1lLvzq-00Gf0W-Df; Mon, 15 Mar 2021 23:47:34 +0100" ], "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding\n\t:Content-Type:List-Subscribe:List-Help:List-Post:List-Archive:\n\tList-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc:To:From:\n\tReply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender\n\t:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner;\n\tbh=i6EOaxvdagqNKl6564Gue22U7+I2uxLhVwd17bVmXp0=; b=MXskyxgIdVLbjDEJMT37fh4PLP\n\tagLoaCYCiWg+O16CiWX39GmKBkFh5HZ7HPZ9qqBdX9p43HRxWTHOVUnNljqZl9KkPyA2BxQoTJXjy\n\t4wTQ69y6jfRzQWBrmybf5STjFGXPvuXKv1V6/GrmlBkHvGPMhZWcJS8f9gJKBO2/ZV8N5zp3bPSDU\n\tiWeR5eyF2RZmj8otjd6t2ZqqNtdY+e8gl4SPySBeoVxh8xPl0UN/A5QW3mqXdDPBKlWWMl+BQy92v\n\tFAs3MNDfWH3erkry86Y+mA69VYKXDhijhe52E2BVVlL7Ktk+PK0BjnRj1/ObarkIb4MxeFzgKabi4\n\tRoDJmwoA==;", "From": "Johannes Berg <johannes@sipsolutions.net>", "To": "linux-um@lists.infradead.org", "Cc": "Johannes Berg <johannes.berg@intel.com>", "Subject": "[PATCH] um: disable CONFIG_GCOV with MODULES", "Date": "Mon, 15 Mar 2021 23:47:31 +0100", "Message-Id": "\n <20210315234731.2e03184a344b.I04f1816296f04c5aa7d7d88b33bd4a14dd458da8@changeid>", "X-Mailer": "git-send-email 2.30.2", "MIME-Version": "1.0", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20210315_224736_537037_8F0CA49B ", "X-CRM114-Status": "GOOD ( 10.49 )", "X-Spam-Score": "0.4 (/)", "X-Spam-Report": "Spam detection software,\n running on the system \"desiato.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: From: Johannes Berg <johannes.berg@intel.com> CONFIG_GCOV\n doesn't work with modules, and for various reasons it cannot work, see also\n https://lore.kernel.org/r/d36ea54d8c0a8dd706826ba844a6f27691f45d55.camel@sipsolutions.net\n Content analysis details: (0.4 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n 0.0 SPF_NONE SPF: sender does not publish an SPF Record\n 0.4 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS", "X-BeenThere": "linux-um@lists.infradead.org", "X-Mailman-Version": "2.1.34", "Precedence": "list", "List-Id": "<linux-um.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/linux-um>,\n <mailto:linux-um-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-um/>", "List-Post": "<mailto:linux-um@lists.infradead.org>", "List-Help": "<mailto:linux-um-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-um>,\n <mailto:linux-um-request@lists.infradead.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"linux-um\" <linux-um-bounces@lists.infradead.org>", "Errors-To": "linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "From: Johannes Berg <johannes.berg@intel.com>\n\nCONFIG_GCOV doesn't work with modules, and for various reasons\nit cannot work, see also\nhttps://lore.kernel.org/r/d36ea54d8c0a8dd706826ba844a6f27691f45d55.camel@sipsolutions.net\n\nMake CONFIG_GCOV depend on !MODULES to avoid anyone\nrunning into issues there. This also means we need\nnot export the gcov symbols.\n\nSigned-off-by: Johannes Berg <johannes.berg@intel.com>\n---\n arch/um/Kconfig.debug | 1 +\n arch/um/kernel/Makefile | 1 -\n arch/um/kernel/gmon_syms.c | 16 ----------------\n 3 files changed, 1 insertion(+), 17 deletions(-)\n delete mode 100644 arch/um/kernel/gmon_syms.c", "diff": "diff --git a/arch/um/Kconfig.debug b/arch/um/Kconfig.debug\nindex 315d368e63ad..1dfb2959c73b 100644\n--- a/arch/um/Kconfig.debug\n+++ b/arch/um/Kconfig.debug\n@@ -17,6 +17,7 @@ config GCOV\n \tbool \"Enable gcov support\"\n \tdepends on DEBUG_INFO\n \tdepends on !KCOV\n+\tdepends on !MODULES\n \thelp\n \t This option allows developers to retrieve coverage data from a UML\n \t session.\ndiff --git a/arch/um/kernel/Makefile b/arch/um/kernel/Makefile\nindex c1205f9ec17e..2fdd00de5a72 100644\n--- a/arch/um/kernel/Makefile\n+++ b/arch/um/kernel/Makefile\n@@ -21,7 +21,6 @@ obj-y = config.o exec.o exitcode.o irq.o ksyms.o mem.o \\\n \n obj-$(CONFIG_BLK_DEV_INITRD) += initrd.o\n obj-$(CONFIG_GPROF)\t+= gprof_syms.o\n-obj-$(CONFIG_GCOV)\t+= gmon_syms.o\n obj-$(CONFIG_EARLY_PRINTK) += early_printk.o\n obj-$(CONFIG_STACKTRACE) += stacktrace.o\n obj-$(CONFIG_GENERIC_PCI_IOMAP) += ioport.o\ndiff --git a/arch/um/kernel/gmon_syms.c b/arch/um/kernel/gmon_syms.c\ndeleted file mode 100644\nindex 9361a8eb9bf1..000000000000\n--- a/arch/um/kernel/gmon_syms.c\n+++ /dev/null\n@@ -1,16 +0,0 @@\n-// SPDX-License-Identifier: GPL-2.0\n-/*\n- * Copyright (C) 2001 - 2007 Jeff Dike (jdike@{addtoit,linux.intel}.com)\n- */\n-\n-#include <linux/module.h>\n-\n-extern void __bb_init_func(void *) __attribute__((weak));\n-EXPORT_SYMBOL(__bb_init_func);\n-\n-extern void __gcov_init(void *) __attribute__((weak));\n-EXPORT_SYMBOL(__gcov_init);\n-extern void __gcov_merge_add(void *, unsigned int) __attribute__((weak));\n-EXPORT_SYMBOL(__gcov_merge_add);\n-extern void __gcov_exit(void) __attribute__((weak));\n-EXPORT_SYMBOL(__gcov_exit);\n", "prefixes": [] }