Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1407820/?format=api
{ "id": 1407820, "url": "http://patchwork.ozlabs.org/api/patches/1407820/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20201129125407.1391557-4-idosch@idosch.org/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20201129125407.1391557-4-idosch@idosch.org>", "list_archive_url": null, "date": "2020-11-29T12:54:01", "name": "[net-next,3/9] mlxsw: spectrum: Only treat 802.1q packets as tagged packets", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "2c36680b351f95b455d0cb94234d18951d730ac6", "submitter": { "id": 69679, "url": "http://patchwork.ozlabs.org/api/people/69679/?format=api", "name": "Ido Schimmel", "email": "idosch@idosch.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20201129125407.1391557-4-idosch@idosch.org/mbox/", "series": [ { "id": 217375, "url": "http://patchwork.ozlabs.org/api/series/217375/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=217375", "date": "2020-11-29T12:54:00", "name": "mlxsw: Add support for 802.1ad bridging", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/217375/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1407820/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1407820/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming-netdev@ozlabs.org", "Delivered-To": "patchwork-incoming-netdev@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=23.128.96.18; helo=vger.kernel.org;\n envelope-from=netdev-owner@vger.kernel.org; receiver=<UNKNOWN>)", "ozlabs.org;\n dmarc=none (p=none dis=none) header.from=idosch.org", "ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=messagingengine.com header.i=@messagingengine.com\n header.a=rsa-sha256 header.s=fm1 header.b=X109YinQ;\n\tdkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [23.128.96.18])\n\tby ozlabs.org (Postfix) with ESMTP id 4CkSzH5lhnz9sRR\n\tfor <patchwork-incoming-netdev@ozlabs.org>;\n Sun, 29 Nov 2020 23:56:11 +1100 (AEDT)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n id S1727709AbgK2Mzd (ORCPT\n <rfc822;patchwork-incoming-netdev@ozlabs.org>);\n Sun, 29 Nov 2020 07:55:33 -0500", "from new1-smtp.messagingengine.com ([66.111.4.221]:46193 \"EHLO\n new1-smtp.messagingengine.com\" rhost-flags-OK-OK-OK-OK)\n by vger.kernel.org with ESMTP id S1727210AbgK2Mzd (ORCPT\n <rfc822;netdev@vger.kernel.org>); Sun, 29 Nov 2020 07:55:33 -0500", "from compute3.internal (compute3.nyi.internal [10.202.2.43])\n by mailnew.nyi.internal (Postfix) with ESMTP id D32BF5806B7;\n Sun, 29 Nov 2020 07:54:46 -0500 (EST)", "from mailfrontend2 ([10.202.2.163])\n by compute3.internal (MEProxy); Sun, 29 Nov 2020 07:54:46 -0500", "from shredder.lan (igld-84-229-154-147.inter.net.il\n [84.229.154.147])\n by mail.messagingengine.com (Postfix) with ESMTPA id B77033064AAE;\n Sun, 29 Nov 2020 07:54:44 -0500 (EST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm1; bh=A4TCvot9x2vVuOlxx97oS3i6vnCWoeACnkRn1Gnvyuo=; b=X109YinQ\n ir3pNNcTE6YsHdNVGHzQiiRY/4QsDxLdt6NItTJ0xkqei6HNX1bdafm32Itco7P8\n ULD4Jaiqkf185w8QgbPK1j2ef96haoADHnssE0KPALBUTn1NObWkdPplnpjLZubR\n VIDZW1y9QCKTcpgfseK/xYZjPUd4Kht0gy7vKoqEnNDONN6hnwFMw9Tb7ZQrAcyz\n 9fPw4bYApQnMnpdAEKxyPyWK5+gnK4AmtpNs8F6s2K9Nh8pgpC34mAH1pGplFC+A\n YPPXom1eydh91Co/Brv47uhEY+zRGOXy80G+YWM7KUBSNdPrZvjwmRo45iLz6vIA\n qICj5xu3cYxCcw==", "X-ME-Sender": "<xms:FprDX8QvihcpE1mpCmfsEjDrq74qibgaOsmuW_i9NFl6iYAUgIlf2A>\n <xme:FprDX5yKZnV1WndQwMIKZRLTYOwV_cWHGFefnd9ayoCmGRjxRpycVmYjN0ONl2r7z\n Qhhvd2DH0ojOX8>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedujedrudehkedggeeiucetufdoteggodetrfdotf\n fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen\n uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgjfhgggfestdekre\n dtredttdenucfhrhhomhepkfguohcuufgthhhimhhmvghluceoihguohhstghhsehiugho\n shgthhdrohhrgheqnecuggftrfgrthhtvghrnhepudetieevffffveelkeeljeffkefhke\n ehgfdtffethfelvdejgffghefgveejkefhnecukfhppeekgedrvddvledrudehgedrudeg\n jeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehiug\n hoshgthhesihguohhstghhrdhorhhg", "X-ME-Proxy": "<xmx:FprDX52EYSSxBeYP215HBeJHGPB0MdhDM0bwtQr1HT9WRnVvSy6iRA>\n <xmx:FprDXwDxScYnqRctmGgggM9SkNPGkT3DTMHL6EewJgKRiWPYBYozzg>\n <xmx:FprDX1hhRUTFznbED55n9GXzxROFiwviYRqFYExXGPrdwLKNDmmiDw>\n <xmx:FprDX8NRvT0QLpASIgTMxmhkl3A5q4131kyPup5K8-j81eD4OnZ53A>", "From": "Ido Schimmel <idosch@idosch.org>", "To": "netdev@vger.kernel.org, bridge@lists.linux-foundation.org", "Cc": "davem@davemloft.net, kuba@kernel.org, jiri@nvidia.com,\n ivecera@redhat.com, roopa@nvidia.com, nikolay@nvidia.com,\n amcohen@nvidia.com, danieller@nvidia.com, petrm@nvidia.com,\n mlxsw@nvidia.com, Ido Schimmel <idosch@nvidia.com>", "Subject": "[PATCH net-next 3/9] mlxsw: spectrum: Only treat 802.1q packets as\n tagged packets", "Date": "Sun, 29 Nov 2020 14:54:01 +0200", "Message-Id": "<20201129125407.1391557-4-idosch@idosch.org>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20201129125407.1391557-1-idosch@idosch.org>", "References": "<20201129125407.1391557-1-idosch@idosch.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "From: Amit Cohen <amcohen@nvidia.com>\n\nBy default, the device considers both 802.1ad and 802.1q packets as tagged,\nbut this is not supported by the driver. It only supports VLAN and bridge\ndevices that use 802.1q protocol.\n\nInstead, configure the device to only treat 802.1q packets as tagged\npackets.\n\nSigned-off-by: Amit Cohen <amcohen@nvidia.com>\nReviewed-by: Petr Machata <petrm@nvidia.com>\nSigned-off-by: Ido Schimmel <idosch@nvidia.com>\n---\n .../net/ethernet/mellanox/mlxsw/spectrum.c | 26 +++++++++++++++++++\n 1 file changed, 26 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c\nindex b08853f71b2b..ee0c4d098c78 100644\n--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c\n+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c\n@@ -1386,6 +1386,19 @@ static int mlxsw_sp_port_overheat_init_val_set(struct mlxsw_sp_port *mlxsw_sp_po\n \treturn 0;\n }\n \n+static int\n+mlxsw_sp_port_vlan_classification_set(struct mlxsw_sp_port *mlxsw_sp_port,\n+\t\t\t\t bool is_8021ad_tagged,\n+\t\t\t\t bool is_8021q_tagged)\n+{\n+\tstruct mlxsw_sp *mlxsw_sp = mlxsw_sp_port->mlxsw_sp;\n+\tchar spvc_pl[MLXSW_REG_SPVC_LEN];\n+\n+\tmlxsw_reg_spvc_pack(spvc_pl, mlxsw_sp_port->local_port,\n+\t\t\t is_8021ad_tagged, is_8021q_tagged);\n+\treturn mlxsw_reg_write(mlxsw_sp->core, MLXSW_REG(spvc), spvc_pl);\n+}\n+\n static int mlxsw_sp_port_create(struct mlxsw_sp *mlxsw_sp, u8 local_port,\n \t\t\t\tu8 split_base_local_port,\n \t\t\t\tstruct mlxsw_sp_port_mapping *port_mapping)\n@@ -1592,6 +1605,16 @@ static int mlxsw_sp_port_create(struct mlxsw_sp *mlxsw_sp, u8 local_port,\n \t}\n \tmlxsw_sp_port->default_vlan = mlxsw_sp_port_vlan;\n \n+\t/* Set SPVC.et0=true and SPVC.et1=false to make the local port to treat\n+\t * only packets with 802.1q header as tagged packets.\n+\t */\n+\terr = mlxsw_sp_port_vlan_classification_set(mlxsw_sp_port, false, true);\n+\tif (err) {\n+\t\tdev_err(mlxsw_sp->bus_info->dev, \"Port %d: Failed to set default VLAN classification\\n\",\n+\t\t\tlocal_port);\n+\t\tgoto err_port_vlan_classification_set;\n+\t}\n+\n \tINIT_DELAYED_WORK(&mlxsw_sp_port->ptp.shaper_dw,\n \t\t\t mlxsw_sp->ptp_ops->shaper_work);\n \n@@ -1618,6 +1641,8 @@ static int mlxsw_sp_port_create(struct mlxsw_sp *mlxsw_sp, u8 local_port,\n \n err_register_netdev:\n err_port_overheat_init_val_set:\n+\tmlxsw_sp_port_vlan_classification_set(mlxsw_sp_port, true, true);\n+err_port_vlan_classification_set:\n \tmlxsw_sp->ports[local_port] = NULL;\n \tmlxsw_sp_port_vlan_destroy(mlxsw_sp_port_vlan);\n err_port_vlan_create:\n@@ -1664,6 +1689,7 @@ static void mlxsw_sp_port_remove(struct mlxsw_sp *mlxsw_sp, u8 local_port)\n \tmlxsw_sp_port_ptp_clear(mlxsw_sp_port);\n \tmlxsw_core_port_clear(mlxsw_sp->core, local_port, mlxsw_sp);\n \tunregister_netdev(mlxsw_sp_port->dev); /* This calls ndo_stop */\n+\tmlxsw_sp_port_vlan_classification_set(mlxsw_sp_port, true, true);\n \tmlxsw_sp->ports[local_port] = NULL;\n \tmlxsw_sp_port_vlan_flush(mlxsw_sp_port, true);\n \tmlxsw_sp_port_nve_fini(mlxsw_sp_port);\n", "prefixes": [ "net-next", "3/9" ] }